René's URL Explorer Experiment


Title: test: add new.target add-on regression test by bnoordhuis · Pull Request #9689 · nodejs/node · GitHub

Open Graph Title: test: add new.target add-on regression test by bnoordhuis · Pull Request #9689 · nodejs/node

X Title: test: add new.target add-on regression test by bnoordhuis · Pull Request #9689 · nodejs/node

Description: Add a test that checks that new.target inheritance works when inheriting from a constructor defined in C++. Refs: #9288 Refs: #9293 CI: https://ci.nodejs.org/job/node-test-pull-request/4900/

Open Graph Description: Add a test that checks that new.target inheritance works when inheriting from a constructor defined in C++. Refs: #9288 Refs: #9293 CI: https://ci.nodejs.org/job/node-test-pull-request/4900/

X Description: Add a test that checks that new.target inheritance works when inheriting from a constructor defined in C++. Refs: #9288 Refs: #9293 CI: https://ci.nodejs.org/job/node-test-pull-request/4900/

Opengraph URL: https://github.com/nodejs/node/pull/9689

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:50eb35c7-a1d2-8b3f-0583-5e31f834836f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2A8:279B15:FC6707:15AE8EE:6969F38B
html-safe-nonceb3642199f853c77444eedffd791ed57fce0f1c37c56d37585b980a929c15948e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkE4OjI3OUIxNTpGQzY3MDc6MTVBRThFRTo2OTY5RjM4QiIsInZpc2l0b3JfaWQiOiI0NTQ0ODEwMjM5Nzc2MTI1ODM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac07c6aacc47e92457407b74777814d78c4ffaaa3078b554ef3cf52b49c46d6e7a
hovercard-subject-tagpull_request:94445251
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9689/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/17d2ce0d65c72c0400b324eab7f9b23973386bceed273b67a626fc67d951d238/nodejs/node/pull/9689
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/17d2ce0d65c72c0400b324eab7f9b23973386bceed273b67a626fc67d951d238/nodejs/node/pull/9689
og:image:altAdd a test that checks that new.target inheritance works when inheriting from a constructor defined in C++. Refs: #9288 Refs: #9293 CI: https://ci.nodejs.org/job/node-test-pull-request/4900/
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/9689#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9689
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9689
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/9689
Reloadhttps://github.com/nodejs/node/pull/9689
Reloadhttps://github.com/nodejs/node/pull/9689
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/9689
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/9689
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/9689#issue-comment-box
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:new-target-addon-testhttps://github.com/bnoordhuis/io.js/tree/new-target-addon-test
test: add new.target add-on regression test https://github.com/nodejs/node/pull/9689#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:new-target-addon-testhttps://github.com/bnoordhuis/io.js/tree/new-target-addon-test
Conversation 6 https://github.com/nodejs/node/pull/9689
Commits 1 https://github.com/nodejs/node/pull/9689/commits
Checks 0 https://github.com/nodejs/node/pull/9689/checks
Files changed https://github.com/nodejs/node/pull/9689/files
Please reload this pagehttps://github.com/nodejs/node/pull/9689
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 18, 2016https://github.com/nodejs/node/pull/9689#issue-190432994
Please reload this pagehttps://github.com/nodejs/node/pull/9689
#9288https://github.com/nodejs/node/issues/9288
#9293https://github.com/nodejs/node/pull/9293
https://ci.nodejs.org/job/node-test-pull-request/4900/https://ci.nodejs.org/job/node-test-pull-request/4900/
Please reload this pagehttps://github.com/nodejs/node/pull/9689
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 18, 2016https://github.com/nodejs/node/pull/9689#event-865037981
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
Nov 18, 2016https://github.com/nodejs/node/pull/9689#event-865040294
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2016 https://github.com/nodejs/node/pull/9689#pullrequestreview-9316580
View reviewed changes https://github.com/nodejs/node/pull/9689/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/9689#pullrequestreview-9316580
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9689
test/addons/new-target/test.jshttps://github.com/nodejs/node/pull/9689/files#diff-8b03c027bd3bfe636c773ba1d7718acf504bb16759a3e7d883d611d9eb2a51e7
addaleaxhttps://github.com/addaleax
Nov 18, 2016https://github.com/nodejs/node/pull/9689#discussion_r88749075
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9689
bnoordhuishttps://github.com/bnoordhuis
Nov 18, 2016https://github.com/nodejs/node/pull/9689#discussion_r88749810
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9689
test/addons/new-target/binding.cchttps://github.com/nodejs/node/pull/9689/files#diff-ca190cb8cd590cd64fcda8bd7186630481d68b98fe8eef78e363bafeb6f624b1
addaleaxhttps://github.com/addaleax
Nov 18, 2016https://github.com/nodejs/node/pull/9689#discussion_r88749174
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9689
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 18, 2016 https://github.com/nodejs/node/pull/9689#ref-pullrequest-185374185
v8: fix new.target inheritance from c++ #9293 https://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
test: add new.target add-on regression testhttps://github.com/nodejs/node/pull/9689/commits/13c4f44e974534951564c110b0e718fb5c642464
13c4f44https://github.com/nodejs/node/pull/9689/commits/13c4f44e974534951564c110b0e718fb5c642464
nodejs#9689https://github.com/nodejs/node/pull/9689
nodejs#9288https://github.com/nodejs/node/issues/9288
nodejs#9293https://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/2614eca98c3e18959d1a4a83bac21c42f655033c..13c4f44e974534951564c110b0e718fb5c642464
2614ecahttps://github.com/nodejs/node/commit/2614eca98c3e18959d1a4a83bac21c42f655033c
13c4f44https://github.com/nodejs/node/commit/13c4f44e974534951564c110b0e718fb5c642464
Compare https://github.com/nodejs/node/compare/2614eca98c3e18959d1a4a83bac21c42f655033c..13c4f44e974534951564c110b0e718fb5c642464
November 21, 2016 13:37https://github.com/nodejs/node/pull/9689#event-866509993
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 21, 2016https://github.com/nodejs/node/pull/9689#event-866510117
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
November 21, 2016 13:37https://github.com/nodejs/node/pull/9689#event-866510121
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
13c4f44https://github.com/nodejs/node/commit/13c4f44e974534951564c110b0e718fb5c642464
Nov 21, 2016https://github.com/nodejs/node/pull/9689#event-866511169
addaleaxhttps://github.com/addaleax
Nov 22, 2016 https://github.com/nodejs/node/pull/9689#ref-commit-7c1a2f5
https://github.com/bnoordhuis
https://github.com/addaleax
test: add new.target add-on regression testhttps://github.com/nodejs/node/commit/7c1a2f56fccdf2df2aefbf72533e9e6a307dcf22
7c1a2f5https://github.com/nodejs/node/commit/7c1a2f56fccdf2df2aefbf72533e9e6a307dcf22
#9689https://github.com/nodejs/node/pull/9689
#9288https://github.com/nodejs/node/issues/9288
#9293https://github.com/nodejs/node/pull/9293
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Dec 20, 2016https://github.com/nodejs/node/pull/9689#event-900600191
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 20, 2016https://github.com/nodejs/node/pull/9689#issuecomment-268332618
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/9689
MylesBorinshttps://github.com/MylesBorins
Dec 20, 2016 https://github.com/nodejs/node/pull/9689#ref-commit-550393d
https://github.com/bnoordhuis
https://github.com/MylesBorins
test: add new.target add-on regression testhttps://github.com/nodejs/node/commit/550393dc785208524ece55492a5a854038d1338e
550393dhttps://github.com/nodejs/node/commit/550393dc785208524ece55492a5a854038d1338e
#9689https://github.com/nodejs/node/pull/9689
#9288https://github.com/nodejs/node/issues/9288
#9293https://github.com/nodejs/node/pull/9293
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 21, 2016https://github.com/nodejs/node/pull/9689#issuecomment-268436684
@thealphanerdhttps://github.com/thealphanerd
#9293https://github.com/nodejs/node/pull/9293
Please reload this pagehttps://github.com/nodejs/node/pull/9689
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 21, 2016https://github.com/nodejs/node/pull/9689#event-901120812
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Dec 21, 2016https://github.com/nodejs/node/pull/9689#event-902119737
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2016 https://github.com/nodejs/node/pull/9689#ref-commit-350ed47
https://github.com/bnoordhuis
https://github.com/MylesBorins
test: add new.target add-on regression testhttps://github.com/nodejs/node/commit/350ed47d59eea04ada9447ee92bc619ff45699bf
350ed47https://github.com/nodejs/node/commit/350ed47d59eea04ada9447ee92bc619ff45699bf
#9689https://github.com/nodejs/node/pull/9689
#9288https://github.com/nodejs/node/issues/9288
#9293https://github.com/nodejs/node/pull/9293
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2016 https://github.com/nodejs/node/pull/9689#ref-pullrequest-197028755
V4.7.1 proposal #10395 https://github.com/nodejs/node/pull/10395
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Jan 23, 2017https://github.com/nodejs/node/pull/9689#event-932192537
bnoordhuishttps://github.com/bnoordhuis
Mar 2, 2017 https://github.com/nodejs/node/pull/9689#ref-commit-2ebceed
https://github.com/bnoordhuis
test: add new.target add-on regression testhttps://github.com/bnoordhuis/io.js/commit/2ebceed790641ee73026cf3c81785a7e957f161e
2ebceedhttps://github.com/bnoordhuis/io.js/commit/2ebceed790641ee73026cf3c81785a7e957f161e
nodejs#9689https://github.com/nodejs/node/pull/9689
nodejs#9288https://github.com/nodejs/node/issues/9288
nodejs#9293https://github.com/nodejs/node/pull/9293
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/9689#ref-commit-87760cc
https://github.com/bnoordhuis
https://github.com/MylesBorins
test: add new.target add-on regression testhttps://github.com/nodejs/node/commit/87760cc346920105467bd2e58c8145f32579fac1
87760cchttps://github.com/nodejs/node/commit/87760cc346920105467bd2e58c8145f32579fac1
#9689https://github.com/nodejs/node/pull/9689
#9288https://github.com/nodejs/node/issues/9288
#9293https://github.com/nodejs/node/pull/9293
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/9689#ref-pullrequest-212909365
v6.10.1 proposal #11759 https://github.com/nodejs/node/pull/11759
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9689
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/9689/files/391cf780ae5f631d5469c503deacec730f9c89ad
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/9689
https://github.com/bnoordhuis
https://github.com/MylesBorins
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.