| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:716e8055-be0e-866a-d1dd-90193ec6887a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A436:9F9DA:20282ED:2C2C6C3:696AB8EF |
| html-safe-nonce | a3d70fc13d22a28830fbe39f5f0bb0fd0be7bee60723e4dad39a61a9d69eca7d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDM2OjlGOURBOjIwMjgyRUQ6MkMyQzZDMzo2OTZBQjhFRiIsInZpc2l0b3JfaWQiOiI5MTM5NDA3NDY4MDk2MDQzMjQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 453f090194eb50d99a28e0040adf1a68cf82aa20ed72bd03de0db70fb8c7956b |
| hovercard-subject-tag | pull_request:94434960 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9685/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ebfab3cf47c5266b66298caca55a4980292efc3088f29c38ca8649da34381214/nodejs/node/pull/9685 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ebfab3cf47c5266b66298caca55a4980292efc3088f29c38ca8649da34381214/nodejs/node/pull/9685 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines
Affected core subsystem(s)
timers
Descri... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Fishrock123 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9685#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9685 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9685 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9685 |
| Reload | https://github.com/nodejs/node/pull/9685 |
| Reload | https://github.com/nodejs/node/pull/9685 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9685#issue-comment-box |
| Fishrock123 | https://github.com/Fishrock123 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Fishrock123:fix-timers-cancel-in-interval | https://github.com/Fishrock123/node/tree/fix-timers-cancel-in-interval |
|
timers: use consistent checks for canceled timers
| https://github.com/nodejs/node/pull/9685#top |
| Fishrock123 | https://github.com/Fishrock123 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Fishrock123:fix-timers-cancel-in-interval | https://github.com/Fishrock123/node/tree/fix-timers-cancel-in-interval |
|
Conversation
22
| https://github.com/nodejs/node/pull/9685 |
|
Commits
1
| https://github.com/nodejs/node/pull/9685/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9685/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9685/files |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9685#issue-190419318 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| #9606 | https://github.com/nodejs/node/pull/9606 |
| #9561 | https://github.com/nodejs/node/issues/9561 |
| c8c2544 | https://github.com/nodejs/node/commit/c8c2544cd9c339cdde881fc9a7f0851971b94d72 |
| https://ci.nodejs.org/job/node-test-pull-request/4898/ | https://ci.nodejs.org/job/node-test-pull-request/4898/ |
| @cjihrig | https://github.com/cjihrig |
| @misterdjules | https://github.com/misterdjules |
| @watson | https://github.com/watson |
| https://www.twitch.tv/nodesource/v/101846332 | https://www.twitch.tv/nodesource/v/101846332 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9685#event-864956045 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9685#event-864956102 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 19, 2016
| https://github.com/nodejs/node/pull/9685#pullrequestreview-9347932 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9685/files |
| test/parallel/test-timers-unenroll-unref-interval.js | https://github.com/nodejs/node/pull/9685/files#diff-c637a8ed2f8d3d02e58270d9deb60028f33f4d608b40a7ac4fe1511cc4338736 |
| Trott | https://github.com/Trott |
| Nov 19, 2016 | https://github.com/nodejs/node/pull/9685#discussion_r88782267 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| below | https://github.com/nodejs/node/pull/9685#discussion_r88937746 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Fishrock123 | https://github.com/Fishrock123 |
| Nov 19, 2016 | https://github.com/nodejs/node/pull/9685#discussion_r88784325 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Trott | https://github.com/Trott |
| Nov 19, 2016 | https://github.com/nodejs/node/pull/9685#discussion_r88785767 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Trott | https://github.com/Trott |
| Nov 20, 2016 | https://github.com/nodejs/node/pull/9685#discussion_r88805214 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Trott | https://github.com/Trott |
| Nov 20, 2016 | https://github.com/nodejs/node/pull/9685#discussion_r88805518 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Trott | https://github.com/Trott |
| Nov 21, 2016 | https://github.com/nodejs/node/pull/9685#discussion_r88828082 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Trott | https://github.com/Trott |
| Nov 21, 2016 | https://github.com/nodejs/node/pull/9685#discussion_r88920304 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Trott | https://github.com/Trott |
| Nov 21, 2016 | https://github.com/nodejs/node/pull/9685#discussion_r88921897 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Fishrock123 | https://github.com/Fishrock123 |
| Nov 21, 2016 | https://github.com/nodejs/node/pull/9685#discussion_r88923472 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Trott | https://github.com/Trott |
| Nov 21, 2016 | https://github.com/nodejs/node/pull/9685#discussion_r88937746 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| https://github.com/watson |
| watson | https://github.com/watson |
| Nov 19, 2016 | https://github.com/nodejs/node/pull/9685#issuecomment-261724565 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/c11e465253bbd34c2eee872311fc60c05ce0887f..11bb6f2313432a2dc849c83d6ac4c4f30438a8f5 |
| c11e465 | https://github.com/nodejs/node/commit/c11e465253bbd34c2eee872311fc60c05ce0887f |
| 11bb6f2 | https://github.com/nodejs/node/commit/11bb6f2313432a2dc849c83d6ac4c4f30438a8f5 |
|
Compare
| https://github.com/nodejs/node/compare/c11e465253bbd34c2eee872311fc60c05ce0887f..11bb6f2313432a2dc849c83d6ac4c4f30438a8f5 |
| November 21, 2016 21:36 | https://github.com/nodejs/node/pull/9685#event-867272701 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Nov 21, 2016 | https://github.com/nodejs/node/pull/9685#issuecomment-262075259 |
| https://ci.nodejs.org/job/node-test-pull-request/4926/console | https://ci.nodejs.org/job/node-test-pull-request/4926/console |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/11bb6f2313432a2dc849c83d6ac4c4f30438a8f5..a89a08fbd0b5d1e407e79d1813d05ee87319b084 |
| 11bb6f2 | https://github.com/nodejs/node/commit/11bb6f2313432a2dc849c83d6ac4c4f30438a8f5 |
| a89a08f | https://github.com/nodejs/node/commit/a89a08fbd0b5d1e407e79d1813d05ee87319b084 |
|
Compare
| https://github.com/nodejs/node/compare/11bb6f2313432a2dc849c83d6ac4c4f30438a8f5..a89a08fbd0b5d1e407e79d1813d05ee87319b084 |
| November 21, 2016 21:40 | https://github.com/nodejs/node/pull/9685#event-867277281 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Nov 21, 2016 | https://github.com/nodejs/node/pull/9685#issuecomment-262075880 |
| https://ci.nodejs.org/job/node-test-pull-request/4927/ | https://ci.nodejs.org/job/node-test-pull-request/4927/ |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 21, 2016 | https://github.com/nodejs/node/pull/9685#issuecomment-262078956 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 21, 2016
| https://github.com/nodejs/node/pull/9685#pullrequestreview-9554065 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9685/files |
| test/parallel/test-timers-unenroll-unref-interval.js | https://github.com/nodejs/node/pull/9685/files#diff-c637a8ed2f8d3d02e58270d9deb60028f33f4d608b40a7ac4fe1511cc4338736 |
| Trott | https://github.com/Trott |
| Nov 21, 2016 | https://github.com/nodejs/node/pull/9685#discussion_r88999979 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/a89a08fbd0b5d1e407e79d1813d05ee87319b084..55efbfec62719db63483e4ef4aad1e15b25ccec0 |
| a89a08f | https://github.com/nodejs/node/commit/a89a08fbd0b5d1e407e79d1813d05ee87319b084 |
| 55efbfe | https://github.com/nodejs/node/commit/55efbfec62719db63483e4ef4aad1e15b25ccec0 |
|
Compare
| https://github.com/nodejs/node/compare/a89a08fbd0b5d1e407e79d1813d05ee87319b084..55efbfec62719db63483e4ef4aad1e15b25ccec0 |
| November 22, 2016 17:24 | https://github.com/nodejs/node/pull/9685#event-868554149 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/55efbfec62719db63483e4ef4aad1e15b25ccec0..98fea5bbf987a95a406fc67730c043a881471d31 |
| 55efbfe | https://github.com/nodejs/node/commit/55efbfec62719db63483e4ef4aad1e15b25ccec0 |
| 98fea5b | https://github.com/nodejs/node/commit/98fea5bbf987a95a406fc67730c043a881471d31 |
|
Compare
| https://github.com/nodejs/node/compare/55efbfec62719db63483e4ef4aad1e15b25ccec0..98fea5bbf987a95a406fc67730c043a881471d31 |
| November 22, 2016 17:24 | https://github.com/nodejs/node/pull/9685#event-868555503 |
|
| https://github.com/Fishrock123 |
| timers: use consistent checks for canceled timers | https://github.com/nodejs/node/pull/9685/commits/3f1e38c847fad83315dd8fb61efa1ae1498a3e7e |
| 3f1e38c | https://github.com/nodejs/node/pull/9685/commits/3f1e38c847fad83315dd8fb61efa1ae1498a3e7e |
| nodejs#9606 | https://github.com/nodejs/node/pull/9606 |
| nodejs#9561 | https://github.com/nodejs/node/issues/9561 |
| nodejs#9685 | https://github.com/nodejs/node/pull/9685 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/98fea5bbf987a95a406fc67730c043a881471d31..3f1e38c847fad83315dd8fb61efa1ae1498a3e7e |
| 98fea5b | https://github.com/nodejs/node/commit/98fea5bbf987a95a406fc67730c043a881471d31 |
| 3f1e38c | https://github.com/nodejs/node/commit/3f1e38c847fad83315dd8fb61efa1ae1498a3e7e |
|
Compare
| https://github.com/nodejs/node/compare/98fea5bbf987a95a406fc67730c043a881471d31..3f1e38c847fad83315dd8fb61efa1ae1498a3e7e |
| November 22, 2016 17:28 | https://github.com/nodejs/node/pull/9685#event-868561382 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| 3f1e38c | https://github.com/nodejs/node/commit/3f1e38c847fad83315dd8fb61efa1ae1498a3e7e |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9685#event-868562719 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/9685#ref-commit-02c2bf7 |
|
| https://github.com/Fishrock123 |
| timers: use consistent checks for canceled timers | https://github.com/nodejs/node/commit/02c2bf7d34141ddb903e215580ee79551790ac48 |
| 02c2bf7 | https://github.com/nodejs/node/commit/02c2bf7d34141ddb903e215580ee79551790ac48 |
| #9606 | https://github.com/nodejs/node/pull/9606 |
| #9561 | https://github.com/nodejs/node/issues/9561 |
| #9685 | https://github.com/nodejs/node/pull/9685 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/9685#event-900604151 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/9685#issuecomment-268333488 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/9685#event-900889188 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/9685#event-900889327 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/9685#issuecomment-268388659 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/9685#issuecomment-268390276 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9685#ref-commit-9c9277b |
|
| https://github.com/Fishrock123 |
| timers: use consistent checks for canceled timers | https://github.com/Fishrock123/node/commit/9c9277b819770be5faf038914734b7c0b87a69d5 |
| 9c9277b | https://github.com/Fishrock123/node/commit/9c9277b819770be5faf038914734b7c0b87a69d5 |
| nodejs#9606 | https://github.com/nodejs/node/pull/9606 |
| nodejs#9561 | https://github.com/nodejs/node/issues/9561 |
| nodejs#9685 | https://github.com/nodejs/node/pull/9685 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9685#ref-pullrequest-196813296 |
|
Fix timers cancel in interval v4.x
#10365
| https://github.com/nodejs/node/pull/10365 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 21, 2016 | https://github.com/nodejs/node/pull/9685#issuecomment-268396203 |
| @thealphanerd | https://github.com/thealphanerd |
| #10365 | https://github.com/nodejs/node/pull/10365 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Dec 21, 2016 | https://github.com/nodejs/node/pull/9685#issuecomment-268459372 |
| #4303 | https://github.com/nodejs/node/pull/4303 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9685#ref-commit-553d95d |
|
| https://github.com/Fishrock123 |
|
| https://github.com/MylesBorins |
| timers: use consistent checks for canceled timers | https://github.com/nodejs/node/commit/553d95da15a0e06a0ce33c8cc9fbeb54647cf171 |
| 553d95d | https://github.com/nodejs/node/commit/553d95da15a0e06a0ce33c8cc9fbeb54647cf171 |
| #9606 | https://github.com/nodejs/node/pull/9606 |
| #9561 | https://github.com/nodejs/node/issues/9561 |
| #9685 | https://github.com/nodejs/node/pull/9685 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9685#ref-commit-8bb66cd |
|
| https://github.com/Fishrock123 |
|
| https://github.com/MylesBorins |
| timers: use consistent checks for canceled timers | https://github.com/nodejs/node/commit/8bb66cd920ab5d02678cfe5c3425940f04017357 |
| 8bb66cd | https://github.com/nodejs/node/commit/8bb66cd920ab5d02678cfe5c3425940f04017357 |
| #9606 | https://github.com/nodejs/node/pull/9606 |
| #9561 | https://github.com/nodejs/node/issues/9561 |
| #9685 | https://github.com/nodejs/node/pull/9685 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9685#ref-commit-759e8fd |
|
| https://github.com/Fishrock123 |
|
| https://github.com/MylesBorins |
| timers: bail from intervals if _repeat is bad | https://github.com/nodejs/node/commit/759e8fdd183c949cd429a23e0baa28f1cff1f66b |
| 759e8fd | https://github.com/nodejs/node/commit/759e8fdd183c949cd429a23e0baa28f1cff1f66b |
| #10365 | https://github.com/nodejs/node/pull/10365 |
| #9685 | https://github.com/nodejs/node/pull/9685 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Dec 21, 2016 | https://github.com/nodejs/node/pull/9685#event-902075718 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9685#ref-commit-c349fb3 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/MylesBorins |
| timers: use consistent checks for canceled timers | https://github.com/nodejs/node/commit/c349fb3b0e669154c55e3a5ad58f41cd4086706a |
| c349fb3 | https://github.com/nodejs/node/commit/c349fb3b0e669154c55e3a5ad58f41cd4086706a |
| #9606 | https://github.com/nodejs/node/pull/9606 |
| #9561 | https://github.com/nodejs/node/issues/9561 |
| #9685 | https://github.com/nodejs/node/pull/9685 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9685#ref-commit-d98d089 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/MylesBorins |
| timers: use consistent checks for canceled timers | https://github.com/nodejs/node/commit/d98d089270263ea96e34ce4eb9f3cc3ba7c06b2e |
| d98d089 | https://github.com/nodejs/node/commit/d98d089270263ea96e34ce4eb9f3cc3ba7c06b2e |
| #9606 | https://github.com/nodejs/node/pull/9606 |
| #9561 | https://github.com/nodejs/node/issues/9561 |
| #9685 | https://github.com/nodejs/node/pull/9685 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9685#ref-commit-0be437a |
|
| https://github.com/Fishrock123 |
|
| https://github.com/MylesBorins |
| timers: bail from intervals if _repeat is bad | https://github.com/nodejs/node/commit/0be437aff0d766fa95a6e562ff327abd67471cde |
| 0be437a | https://github.com/nodejs/node/commit/0be437aff0d766fa95a6e562ff327abd67471cde |
| #10365 | https://github.com/nodejs/node/pull/10365 |
| #9685 | https://github.com/nodejs/node/pull/9685 |
|
V6.9.3 proposal
#10394
| https://github.com/nodejs/node/pull/10394 |
|
V4.7.1 proposal
#10395
| https://github.com/nodejs/node/pull/10395 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/9685#ref-commit-1035318 |
|
| https://github.com/MylesBorins |
| 2017-01-03, Version 4.7.1 'Argon' (LTS) | https://github.com/nodejs/node/commit/1035318070c3c302289325d961c82966b2a9e64a |
| 1035318 | https://github.com/nodejs/node/commit/1035318070c3c302289325d961c82966b2a9e64a |
| #9675 | https://github.com/nodejs/node/pull/9675 |
| #7826 | https://github.com/nodejs/node/pull/7826 |
| #9685 | https://github.com/nodejs/node/pull/9685 |
| #10395 | https://github.com/nodejs/node/pull/10395 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/9685#ref-commit-42149d7 |
|
| https://github.com/MylesBorins |
| 2017-01-03, Version 6.9.3 'Boron' (LTS) Release | https://github.com/nodejs/node/commit/42149d73468c0f844c693b2eead8d24f078fa1bb |
| 42149d7 | https://github.com/nodejs/node/commit/42149d73468c0f844c693b2eead8d24f078fa1bb |
| #9675 | https://github.com/nodejs/node/pull/9675 |
| #9847 | https://github.com/nodejs/node/pull/9847 |
| #10386 | https://github.com/nodejs/node/pull/10386 |
| #9762 | https://github.com/nodejs/node/pull/9762 |
| #8876 | https://github.com/nodejs/node/pull/8876 |
| #8932 | https://github.com/nodejs/node/pull/8932 |
| #10103 | https://github.com/nodejs/node/pull/10103 |
| #9852 | https://github.com/nodejs/node/pull/9852 |
| #9685 | https://github.com/nodejs/node/pull/9685 |
| #10394 | https://github.com/nodejs/node/pull/10394 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/9685#ref-commit-2bf1c24 |
|
| https://github.com/MylesBorins |
| 2017-01-03, Version 6.9.3 'Boron' (LTS) Release | https://github.com/nodejs/node/commit/2bf1c24f6a8b88ed02dadb2c6de4f3761abe8406 |
| 2bf1c24 | https://github.com/nodejs/node/commit/2bf1c24f6a8b88ed02dadb2c6de4f3761abe8406 |
| #9675 | https://github.com/nodejs/node/pull/9675 |
| #9847 | https://github.com/nodejs/node/pull/9847 |
| #10386 | https://github.com/nodejs/node/pull/10386 |
| #9762 | https://github.com/nodejs/node/pull/9762 |
| #8876 | https://github.com/nodejs/node/pull/8876 |
| #8932 | https://github.com/nodejs/node/pull/8932 |
| #10103 | https://github.com/nodejs/node/pull/10103 |
| #9852 | https://github.com/nodejs/node/pull/9852 |
| #9685 | https://github.com/nodejs/node/pull/9685 |
| #10394 | https://github.com/nodejs/node/pull/10394 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 4, 2017
| https://github.com/nodejs/node/pull/9685#ref-commit-b26a469 |
|
| https://github.com/MylesBorins |
| 2017-01-03, Version 4.7.1 'Argon' (LTS) | https://github.com/nodejs/node/commit/b26a469211d126b95115583cc780dcfcc115ed98 |
| b26a469 | https://github.com/nodejs/node/commit/b26a469211d126b95115583cc780dcfcc115ed98 |
| #9675 | https://github.com/nodejs/node/pull/9675 |
| #7826 | https://github.com/nodejs/node/pull/7826 |
| #9685 | https://github.com/nodejs/node/pull/9685 |
| #10395 | https://github.com/nodejs/node/pull/10395 |
| imyller | https://github.com/imyller |
|
Mar 2, 2017
| https://github.com/nodejs/node/pull/9685#ref-commit-774acef |
|
| https://github.com/imyller |
| 2017-01-03, Version 4.7.1 'Argon' (LTS) | https://github.com/imyller/meta-nodejs/commit/774acef96415b8f747935fcae94c7360e7070239 |
| 774acef | https://github.com/imyller/meta-nodejs/commit/774acef96415b8f747935fcae94c7360e7070239 |
| nodejs/node#9675 | https://github.com/nodejs/node/pull/9675 |
| nodejs/node#7826 | https://github.com/nodejs/node/pull/7826 |
| nodejs/node#9685 | https://github.com/nodejs/node/pull/9685 |
| nodejs/node#10395 | https://github.com/nodejs/node/pull/10395 |
| imyller | https://github.com/imyller |
|
Mar 2, 2017
| https://github.com/nodejs/node/pull/9685#ref-commit-96fa035 |
|
| https://github.com/imyller |
| 2017-01-03, Version 6.9.3 'Boron' (LTS) Release | https://github.com/imyller/meta-nodejs/commit/96fa035e2e8a140a3bf092ab0e6aaab8aee0cfd1 |
| 96fa035 | https://github.com/imyller/meta-nodejs/commit/96fa035e2e8a140a3bf092ab0e6aaab8aee0cfd1 |
| nodejs/node#9675 | https://github.com/nodejs/node/pull/9675 |
| nodejs/node#9847 | https://github.com/nodejs/node/pull/9847 |
| nodejs/node#10386 | https://github.com/nodejs/node/pull/10386 |
| nodejs/node#9762 | https://github.com/nodejs/node/pull/9762 |
| nodejs/node#8876 | https://github.com/nodejs/node/pull/8876 |
| nodejs/node#8932 | https://github.com/nodejs/node/pull/8932 |
| nodejs/node#10103 | https://github.com/nodejs/node/pull/10103 |
| nodejs/node#9852 | https://github.com/nodejs/node/pull/9852 |
| nodejs/node#9685 | https://github.com/nodejs/node/pull/9685 |
| nodejs/node#10394 | https://github.com/nodejs/node/pull/10394 |
| imyller | https://github.com/imyller |
|
Mar 2, 2017
| https://github.com/nodejs/node/pull/9685#ref-commit-13f539e |
|
| https://github.com/imyller |
| 2017-01-03, Version 4.7.1 'Argon' (LTS) | https://github.com/imyller/meta-nodejs/commit/13f539ec668cd0113d3cf4e3e6ada3b915c0d104 |
| 13f539e | https://github.com/imyller/meta-nodejs/commit/13f539ec668cd0113d3cf4e3e6ada3b915c0d104 |
| nodejs/node#9675 | https://github.com/nodejs/node/pull/9675 |
| nodejs/node#7826 | https://github.com/nodejs/node/pull/7826 |
| nodejs/node#9685 | https://github.com/nodejs/node/pull/9685 |
| nodejs/node#10395 | https://github.com/nodejs/node/pull/10395 |
| imyller | https://github.com/imyller |
|
Mar 2, 2017
| https://github.com/nodejs/node/pull/9685#ref-commit-0a82bea |
|
| https://github.com/imyller |
| 2017-01-03, Version 6.9.3 'Boron' (LTS) Release | https://github.com/imyller/meta-nodejs/commit/0a82bea52706c945ccf978a91013a51fb754057c |
| 0a82bea | https://github.com/imyller/meta-nodejs/commit/0a82bea52706c945ccf978a91013a51fb754057c |
| nodejs/node#9675 | https://github.com/nodejs/node/pull/9675 |
| nodejs/node#9847 | https://github.com/nodejs/node/pull/9847 |
| nodejs/node#10386 | https://github.com/nodejs/node/pull/10386 |
| nodejs/node#9762 | https://github.com/nodejs/node/pull/9762 |
| nodejs/node#8876 | https://github.com/nodejs/node/pull/8876 |
| nodejs/node#8932 | https://github.com/nodejs/node/pull/8932 |
| nodejs/node#10103 | https://github.com/nodejs/node/pull/10103 |
| nodejs/node#9852 | https://github.com/nodejs/node/pull/9852 |
| nodejs/node#9685 | https://github.com/nodejs/node/pull/9685 |
| nodejs/node#10394 | https://github.com/nodejs/node/pull/10394 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9685 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/9685/files/a89a08fbd0b5d1e407e79d1813d05ee87319b084 |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
|
segfault if clearTimeout(interval)
| https://github.com/nodejs/node/issues/9561 |
| Please reload this page | https://github.com/nodejs/node/pull/9685 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/watson |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |