| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8b6595d6-f0fb-9a2e-2278-55e107df7ace |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CF2C:3037EB:BC0C11:105F61C:696A6462 |
| html-safe-nonce | 18f2fbf394bed3efac5a88c872025a0ed662ff836f86d0e2c60333d248840b84 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjJDOjMwMzdFQjpCQzBDMTE6MTA1RjYxQzo2OTZBNjQ2MiIsInZpc2l0b3JfaWQiOiIzNTkzOTE4Mjk3MzUxNTQ1OTU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | be0375ae38ebfdb5130193b8d2fa2cf344f98257edfae74a06b14d761988373c |
| hovercard-subject-tag | pull_request:94433267 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9682/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c519d77430e6c4600fc7e8e5e39dcd3521983a94ae6104a344ef0c21faf23430/nodejs/node/pull/9682 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c519d77430e6c4600fc7e8e5e39dcd3521983a94ae6104a344ef0c21faf23430/nodejs/node/pull/9682 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
test
Description of change
This is a backport of:
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mscdex |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9682#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9682 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9682 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9682 |
| Reload | https://github.com/nodejs/node/pull/9682 |
| Reload | https://github.com/nodejs/node/pull/9682 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9682#issue-comment-box |
| mscdex | https://github.com/mscdex |
| nodejs:v4.x-staging | https://github.com/nodejs/node/tree/v4.x-staging |
| mscdex:backport-v4-pr-8034-8948-9262 | https://github.com/mscdex/io.js/tree/backport-v4-pr-8034-8948-9262 |
|
backport: cctest TAP output changes
| https://github.com/nodejs/node/pull/9682#top |
| mscdex | https://github.com/mscdex |
| nodejs:v4.x-staging | https://github.com/nodejs/node/tree/v4.x-staging |
| mscdex:backport-v4-pr-8034-8948-9262 | https://github.com/mscdex/io.js/tree/backport-v4-pr-8034-8948-9262 |
|
Conversation
10
| https://github.com/nodejs/node/pull/9682 |
|
Commits
6
| https://github.com/nodejs/node/pull/9682/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9682/checks |
|
Files changed
6
| https://github.com/nodejs/node/pull/9682/files |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9682#issue-190417115 |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| build: run cctests as part of test-ci target #8034 | https://github.com/nodejs/node/pull/8034 |
| deps: revert default gtest reporter change #8948 | https://github.com/nodejs/node/pull/8948 |
| test.py tap13 output #9262 | https://github.com/nodejs/node/pull/9262 |
| @bnoordhuis | https://github.com/bnoordhuis |
| @jbergstroem | https://github.com/jbergstroem |
| https://ci.nodejs.org/job/node-test-pull-request/4897/ | https://ci.nodejs.org/job/node-test-pull-request/4897/ |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| bnoordhuis | https://github.com/bnoordhuis |
| November 18, 2016 15:27 | https://github.com/nodejs/node/pull/9682#commits-pushed-f72f02f |
|
| https://github.com/bnoordhuis |
|
| https://github.com/mscdex |
| deps: make gtest output tap | https://github.com/nodejs/node/pull/9682/commits/f72f02faa9897e87215a304aca481351fb3b8a7e |
| f72f02f | https://github.com/nodejs/node/pull/9682/commits/f72f02faa9897e87215a304aca481351fb3b8a7e |
| nodejs#8034 | https://github.com/nodejs/node/pull/8034 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/mscdex |
| build: run cctests as part of test-ci target | https://github.com/nodejs/node/pull/9682/commits/938e67a0b658ead48807612548b448a6e38ca6e9 |
| 938e67a | https://github.com/nodejs/node/pull/9682/commits/938e67a0b658ead48807612548b448a6e38ca6e9 |
| nodejs#8034 | https://github.com/nodejs/node/pull/8034 |
|
| https://github.com/mscdex |
| deps: revert default gtest reporter change | https://github.com/nodejs/node/pull/9682/commits/7f819198b50a96937a663d8719a554e878c442b0 |
| 7f81919 | https://github.com/nodejs/node/pull/9682/commits/7f819198b50a96937a663d8719a554e878c442b0 |
| nodejs#8948 | https://github.com/nodejs/node/pull/8948 |
|
| https://github.com/jbergstroem |
|
| https://github.com/mscdex |
| test: output tap13 instead of almost-tap | https://github.com/nodejs/node/pull/9682/commits/d2693b16bdb9250efa1f4957999f3fb33dacf6c0 |
| d2693b1 | https://github.com/nodejs/node/pull/9682/commits/d2693b16bdb9250efa1f4957999f3fb33dacf6c0 |
| nodejs#9262 | https://github.com/nodejs/node/pull/9262 |
|
| https://github.com/jbergstroem |
|
| https://github.com/mscdex |
| gtest: output tap comments as yamlish | https://github.com/nodejs/node/pull/9682/commits/a7d90df8032f0f363461edf9d5a05a030c796a32 |
| a7d90df | https://github.com/nodejs/node/pull/9682/commits/a7d90df8032f0f363461edf9d5a05a030c796a32 |
| nodejs#9262 | https://github.com/nodejs/node/pull/9262 |
|
| https://github.com/jbergstroem |
|
| https://github.com/mscdex |
| gitignore: ignore all tap files | https://github.com/nodejs/node/pull/9682/commits/0b8be2a11302907375f2b0d4c7604537a5d30142 |
| 0b8be2a | https://github.com/nodejs/node/pull/9682/commits/0b8be2a11302907375f2b0d4c7604537a5d30142 |
| nodejs#9262 | https://github.com/nodejs/node/pull/9262 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av4.x |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9682#event-864942436 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av4.x |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9682#event-864942550 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9682#event-864942918 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/9682#ref-pullrequest-170195793 |
|
build: run cctests as part of test-ci target
#8034
| https://github.com/nodejs/node/pull/8034 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/9682#pullrequestreview-9305213 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9682/files/0b8be2a11302907375f2b0d4c7604537a5d30142 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9682#issuecomment-261643055 |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9682#issuecomment-261643573 |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9682#issuecomment-261643934 |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| https://ci.nodejs.org/job/node-test-commit-windows-fanned/5329/ | https://ci.nodejs.org/job/node-test-commit-windows-fanned/5329/ |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9682#issuecomment-261665506 |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9682#issuecomment-262149300 |
| https://ci.nodejs.org/job/node-test-pull-request/4932/ | https://ci.nodejs.org/job/node-test-pull-request/4932/ |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9682#issuecomment-262151036 |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9682#issuecomment-262151731 |
| @mscdex | https://github.com/mscdex |
| @jbergstroem | https://github.com/jbergstroem |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9682#issuecomment-262154766 |
| #9695 | https://github.com/nodejs/node/pull/9695 |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9682#issuecomment-262155879 |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9682#issuecomment-262155975 |
| 66e26cd...02e6c84 | https://github.com/nodejs/node/compare/66e26cd253a1b65d243aa67d95e415ae392e4858...02e6c84de23e833033163c64bf0a5c9fab7829e4 |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9682#event-867690838 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| November 22, 2016 06:18 | https://github.com/nodejs/node/pull/9682#event-867698366 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9682 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/9682/files/0b8be2a11302907375f2b0d4c7604537a5d30142 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/9682 |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/jbergstroem |
|
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |