René's URL Explorer Experiment


Title: fs: do not pass Buffer when toString() fails by mscdex · Pull Request #9670 · nodejs/node · GitHub

Open Graph Title: fs: do not pass Buffer when toString() fails by mscdex · Pull Request #9670 · nodejs/node

X Title: fs: do not pass Buffer when toString() fails by mscdex · Pull Request #9670 · nodejs/node

Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) fs Descriptio...

Open Graph Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) fs Descriptio...

X Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) fs Descriptio...

Opengraph URL: https://github.com/nodejs/node/pull/9670

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:30ef51b3-23ba-0ba5-19b6-91470987d1b7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA6A:30F550:1FDF160:2CA4838:696A5C27
html-safe-nonce2c6bfaf34e1418f68f75653cfa3a4d5e98c256b97b4296261d8d54736fc013c7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTZBOjMwRjU1MDoxRkRGMTYwOjJDQTQ4Mzg6Njk2QTVDMjciLCJ2aXNpdG9yX2lkIjoiNTY2OTgxNzc5NDE0ODU4ODU4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac14976207b727fde2c058f667e0cff7519f4c367a5dd3d66de0eee889f97db1fe
hovercard-subject-tagpull_request:94297029
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9670/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5033819e06a56d4a5baec54e03d3e67ae11e6c00b9a51590c4b9d664acf7a895/nodejs/node/pull/9670
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5033819e06a56d4a5baec54e03d3e67ae11e6c00b9a51590c4b9d664acf7a895/nodejs/node/pull/9670
og:image:altChecklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) fs Descriptio...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemscdex
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/9670#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9670
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9670
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/9670
Reloadhttps://github.com/nodejs/node/pull/9670
Reloadhttps://github.com/nodejs/node/pull/9670
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/9670
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/9670
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/9670#issue-comment-box
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:fs-tostring-failure-callbackhttps://github.com/mscdex/io.js/tree/fs-tostring-failure-callback
fs: do not pass Buffer when toString() fails https://github.com/nodejs/node/pull/9670#top
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:fs-tostring-failure-callbackhttps://github.com/mscdex/io.js/tree/fs-tostring-failure-callback
Conversation 7 https://github.com/nodejs/node/pull/9670
Commits 1 https://github.com/nodejs/node/pull/9670/commits
Checks 0 https://github.com/nodejs/node/pull/9670/checks
Files changed https://github.com/nodejs/node/pull/9670/files
Please reload this pagehttps://github.com/nodejs/node/pull/9670
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Nov 18, 2016https://github.com/nodejs/node/pull/9670#issue-190227870
Please reload this pagehttps://github.com/nodejs/node/pull/9670
https://ci.nodejs.org/job/node-test-pull-request/4877/https://ci.nodejs.org/job/node-test-pull-request/4877/
Please reload this pagehttps://github.com/nodejs/node/pull/9670
https://github.com/mscdex
mscdexhttps://github.com/mscdex
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Nov 18, 2016https://github.com/nodejs/node/pull/9670#event-863832907
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Nov 18, 2016https://github.com/nodejs/node/pull/9670#event-863832945
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 18, 2016 https://github.com/nodejs/node/pull/9670#pullrequestreview-9164540
View reviewed changes https://github.com/nodejs/node/pull/9670/files
https://github.com/targos
targoshttps://github.com/targos
Nov 18, 2016 https://github.com/nodejs/node/pull/9670#pullrequestreview-9171473
View reviewed changes https://github.com/nodejs/node/pull/9670/files
targoshttps://github.com/targos
https://github.com/nodejs/node/pull/9670#pullrequestreview-9171473
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9670
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Nov 18, 2016 https://github.com/nodejs/node/pull/9670#pullrequestreview-9179579
View reviewed changes https://github.com/nodejs/node/pull/9670/files
https://github.com/princejwesley
princejwesleyhttps://github.com/princejwesley
Nov 18, 2016 https://github.com/nodejs/node/pull/9670#pullrequestreview-9181077
View reviewed changes https://github.com/nodejs/node/pull/9670/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 18, 2016 https://github.com/nodejs/node/pull/9670#pullrequestreview-9182982
View reviewed changes https://github.com/nodejs/node/pull/9670/files
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Nov 18, 2016 https://github.com/nodejs/node/pull/9670#pullrequestreview-9234321
View reviewed changes https://github.com/nodejs/node/pull/9670/files
sam-githubhttps://github.com/sam-github
https://github.com/nodejs/node/pull/9670#pullrequestreview-9234321
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9670
lib/fs.jshttps://github.com/nodejs/node/pull/9670/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
sam-githubhttps://github.com/sam-github
Nov 18, 2016https://github.com/nodejs/node/pull/9670#discussion_r88666722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9670
mscdexhttps://github.com/mscdex
Nov 18, 2016https://github.com/nodejs/node/pull/9670#discussion_r88727209
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9670
https://github.com/mscdex
mscdexhttps://github.com/mscdex
force-pushedhttps://github.com/nodejs/node/compare/733e8e6f9822abdf2ae6a46fe8e5bcdc805a1d2c..7b181060e62959fcfb5599c479861846ec1f143b
733e8e6https://github.com/nodejs/node/commit/733e8e6f9822abdf2ae6a46fe8e5bcdc805a1d2c
7b18106https://github.com/nodejs/node/commit/7b181060e62959fcfb5599c479861846ec1f143b
Compare https://github.com/nodejs/node/compare/733e8e6f9822abdf2ae6a46fe8e5bcdc805a1d2c..7b181060e62959fcfb5599c479861846ec1f143b
November 18, 2016 19:51https://github.com/nodejs/node/pull/9670#event-864879981
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Nov 18, 2016https://github.com/nodejs/node/pull/9670#issuecomment-261625936
Please reload this pagehttps://github.com/nodejs/node/pull/9670
@sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/9670
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Nov 18, 2016https://github.com/nodejs/node/pull/9670#issuecomment-261626339
https://ci.nodejs.org/job/node-test-pull-request/4893/https://ci.nodejs.org/job/node-test-pull-request/4893/
Please reload this pagehttps://github.com/nodejs/node/pull/9670
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 14, 2016https://github.com/nodejs/node/pull/9670#issuecomment-266959921
Please reload this pagehttps://github.com/nodejs/node/pull/9670
https://ci.nodejs.org/job/node-test-pull-request/5399/https://ci.nodejs.org/job/node-test-pull-request/5399/
https://ci.nodejs.org/job/node-test-pull-request/5400/https://ci.nodejs.org/job/node-test-pull-request/5400/
Please reload this pagehttps://github.com/nodejs/node/pull/9670
https://github.com/mscdex
mscdexhttps://github.com/mscdex
force-pushedhttps://github.com/nodejs/node/compare/7b181060e62959fcfb5599c479861846ec1f143b..dc918d7d301027b994407abf56d4866e8bb66705
7b18106https://github.com/nodejs/node/commit/7b181060e62959fcfb5599c479861846ec1f143b
dc918d7https://github.com/nodejs/node/commit/dc918d7d301027b994407abf56d4866e8bb66705
Compare https://github.com/nodejs/node/compare/7b181060e62959fcfb5599c479861846ec1f143b..dc918d7d301027b994407abf56d4866e8bb66705
December 14, 2016 08:01https://github.com/nodejs/node/pull/9670#event-893232716
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 14, 2016https://github.com/nodejs/node/pull/9670#event-893232841
https://github.com/mscdex
mscdexhttps://github.com/mscdex
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 14, 2016https://github.com/nodejs/node/pull/9670#event-893233051
https://github.com/mscdex
fs: do not pass Buffer when toString() failshttps://github.com/nodejs/node/pull/9670/commits/f3cf8e98081b52003bfe3c10f27f29c1c49e800a
f3cf8e9https://github.com/nodejs/node/pull/9670/commits/f3cf8e98081b52003bfe3c10f27f29c1c49e800a
nodejs#9670https://github.com/nodejs/node/pull/9670
https://github.com/mscdex
mscdexhttps://github.com/mscdex
force-pushedhttps://github.com/nodejs/node/compare/dc918d7d301027b994407abf56d4866e8bb66705..f3cf8e98081b52003bfe3c10f27f29c1c49e800a
dc918d7https://github.com/nodejs/node/commit/dc918d7d301027b994407abf56d4866e8bb66705
f3cf8e9https://github.com/nodejs/node/commit/f3cf8e98081b52003bfe3c10f27f29c1c49e800a
Compare https://github.com/nodejs/node/compare/dc918d7d301027b994407abf56d4866e8bb66705..f3cf8e98081b52003bfe3c10f27f29c1c49e800a
December 14, 2016 08:31https://github.com/nodejs/node/pull/9670#event-893261141
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 14, 2016https://github.com/nodejs/node/pull/9670#event-893261204
https://github.com/mscdex
mscdexhttps://github.com/mscdex
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 14, 2016https://github.com/nodejs/node/pull/9670#event-893261459
https://github.com/mscdex
mscdexhttps://github.com/mscdex
f3cf8e9https://github.com/nodejs/node/commit/f3cf8e98081b52003bfe3c10f27f29c1c49e800a
Dec 14, 2016https://github.com/nodejs/node/pull/9670#event-893262501
https://github.com/mscdex
mscdexhttps://github.com/mscdex
December 14, 2016 08:34https://github.com/nodejs/node/pull/9670#event-893263878
italoacasashttps://github.com/italoacasas
Jan 18, 2017 https://github.com/nodejs/node/pull/9670#ref-commit-df5acf7
https://github.com/mscdex
fs: do not pass Buffer when toString() failshttps://github.com/italoacasas/node/commit/df5acf7baffaf63b5fd1c97940c6e8d73f9806a1
df5acf7https://github.com/italoacasas/node/commit/df5acf7baffaf63b5fd1c97940c6e8d73f9806a1
nodejs#9670https://github.com/nodejs/node/pull/9670
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 4, 2017 https://github.com/nodejs/node/pull/9670#ref-pullrequest-219383958
8.0.0 Release Proposal #12220 https://github.com/nodejs/node/pull/12220
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9670
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/9670/files/733e8e6f9822abdf2ae6a46fe8e5bcdc805a1d2c
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/9670/files/733e8e6f9822abdf2ae6a46fe8e5bcdc805a1d2c
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/9670/files/733e8e6f9822abdf2ae6a46fe8e5bcdc805a1d2c
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/9670/files/733e8e6f9822abdf2ae6a46fe8e5bcdc805a1d2c
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/9670/files/733e8e6f9822abdf2ae6a46fe8e5bcdc805a1d2c
https://github.com/princejwesley
princejwesley https://github.com/princejwesley
https://github.com/nodejs/node/pull/9670/files/733e8e6f9822abdf2ae6a46fe8e5bcdc805a1d2c
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/9670
https://github.com/mscdex
https://github.com/sam-github
https://github.com/jasnell
https://github.com/thefourtheye
https://github.com/princejwesley
https://github.com/targos
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.