| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:25cc1004-bca3-d853-5194-98e2473856c7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EE1C:144C84:137638F:1B3F1B0:696A3E70 |
| html-safe-nonce | e64f75aa6e0d63e24566dff78f60b416aeaab1a6c2007f3746a489a0f1cae6d9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRTFDOjE0NEM4NDoxMzc2MzhGOjFCM0YxQjA6Njk2QTNFNzAiLCJ2aXNpdG9yX2lkIjoiMTIxNDkxMDQ2ODcxMDg3NDczNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 80e61f710fb2b58c95e3a42ae1eec6c6f14ab27f90e423e09cdfc9958a254d8f |
| hovercard-subject-tag | pull_request:94085362 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9651/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/974e62bef84ee6015e079c3176bb89850911ef1b7d27156f7af2dc126e08a687/nodejs/node/pull/9651 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/974e62bef84ee6015e079c3176bb89850911ef1b7d27156f7af2dc126e08a687/nodejs/node/pull/9651 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines
Affect... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gerrard00 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 13581a31d51edf4a3aca179e10890a4d4f9b6d76 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9651#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9651 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9651 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9651 |
| Reload | https://github.com/nodejs/node/pull/9651 |
| Reload | https://github.com/nodejs/node/pull/9651 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9651#issue-comment-box |
| gerrard00 | https://github.com/gerrard00 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gerrard00:support_numeric_kill | https://github.com/gerrard00/node/tree/support_numeric_kill |
|
child_process: support numeric signal argument to kill.
| https://github.com/nodejs/node/pull/9651#top |
| gerrard00 | https://github.com/gerrard00 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gerrard00:support_numeric_kill | https://github.com/gerrard00/node/tree/support_numeric_kill |
|
Conversation
57
| https://github.com/nodejs/node/pull/9651 |
|
Commits
1
| https://github.com/nodejs/node/pull/9651/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9651/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9651/files |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issue-189906383 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| #9519 | https://github.com/nodejs/node/issues/9519 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#event-862090208 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
|
Nov 17, 2016
| https://github.com/nodejs/node/pull/9651#ref-issue-188100418 |
|
n.kill(19) throws error
#9519
| https://github.com/nodejs/node/issues/9519 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#event-862092783 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261127689 |
| https://github.com/nodejs/node/blob/master/doc/guides/writing_tests.md | https://github.com/nodejs/node/blob/master/doc/guides/writing_tests.md |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261129617 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| force-pushed | https://github.com/nodejs/node/compare/ae7c0d4b51c205c852ab0a59a24ae213b8a062c9..29198d41b7948f37f1ba3a9c383c33972400dfc2 |
| ae7c0d4 | https://github.com/nodejs/node/commit/ae7c0d4b51c205c852ab0a59a24ae213b8a062c9 |
| 29198d4 | https://github.com/nodejs/node/commit/29198d41b7948f37f1ba3a9c383c33972400dfc2 |
|
Compare
| https://github.com/nodejs/node/compare/ae7c0d4b51c205c852ab0a59a24ae213b8a062c9..29198d41b7948f37f1ba3a9c383c33972400dfc2 |
| November 17, 2016 01:43 | https://github.com/nodejs/node/pull/9651#event-862105205 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261130425 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| force-pushed | https://github.com/nodejs/node/compare/29198d41b7948f37f1ba3a9c383c33972400dfc2..410c5897338d23da241bdb1bd6e4387846967e7d |
| 29198d4 | https://github.com/nodejs/node/commit/29198d41b7948f37f1ba3a9c383c33972400dfc2 |
| 410c589 | https://github.com/nodejs/node/commit/410c5897338d23da241bdb1bd6e4387846967e7d |
|
Compare
| https://github.com/nodejs/node/compare/29198d41b7948f37f1ba3a9c383c33972400dfc2..410c5897338d23da241bdb1bd6e4387846967e7d |
| November 17, 2016 01:55 | https://github.com/nodejs/node/pull/9651#event-862115075 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261132024 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 17, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9047899 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/9651/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| cjihrig | https://github.com/cjihrig |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88475063 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88483965 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 17, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9048034 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files |
| test/parallel/test-child-process-kill-numeric.js | https://github.com/nodejs/node/pull/9651/files#diff-45ed0d5ba349677c7f28b63b5adc6606778af75238b5a58cfc0f30057fa81809 |
| cjihrig | https://github.com/cjihrig |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88475205 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| test/parallel/test-child-process-kill-numeric.js | https://github.com/nodejs/node/pull/9651/files#diff-45ed0d5ba349677c7f28b63b5adc6606778af75238b5a58cfc0f30057fa81809 |
| cjihrig | https://github.com/cjihrig |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88475524 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| test/parallel/test-child-process-kill-numeric.js | https://github.com/nodejs/node/pull/9651/files#diff-45ed0d5ba349677c7f28b63b5adc6606778af75238b5a58cfc0f30057fa81809 |
| cjihrig | https://github.com/cjihrig |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88475762 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| test/parallel/test-child-process-kill-numeric.js | https://github.com/nodejs/node/pull/9651/files#diff-45ed0d5ba349677c7f28b63b5adc6606778af75238b5a58cfc0f30057fa81809 |
| cjihrig | https://github.com/cjihrig |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88475818 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| test/parallel/test-child-process-kill-numeric.js | https://github.com/nodejs/node/pull/9651/files#diff-45ed0d5ba349677c7f28b63b5adc6606778af75238b5a58cfc0f30057fa81809 |
| cjihrig | https://github.com/cjihrig |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88475922 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| test/parallel/test-child-process-kill-numeric.js | https://github.com/nodejs/node/pull/9651/files#diff-45ed0d5ba349677c7f28b63b5adc6606778af75238b5a58cfc0f30057fa81809 |
| cjihrig | https://github.com/cjihrig |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88476106 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| test/parallel/test-child-process-kill-numeric.js | https://github.com/nodejs/node/pull/9651/files#diff-45ed0d5ba349677c7f28b63b5adc6606778af75238b5a58cfc0f30057fa81809 |
| cjihrig | https://github.com/cjihrig |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88476155 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| test/parallel/test-child-process-kill-numeric.js | https://github.com/nodejs/node/pull/9651/files#diff-45ed0d5ba349677c7f28b63b5adc6606778af75238b5a58cfc0f30057fa81809 |
| cjihrig | https://github.com/cjihrig |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88476235 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| test/parallel/test-child-process-kill-numeric.js | https://github.com/nodejs/node/pull/9651/files#diff-45ed0d5ba349677c7f28b63b5adc6606778af75238b5a58cfc0f30057fa81809 |
| cjihrig | https://github.com/cjihrig |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88476321 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261288026 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261288937 |
| https://github.com/nodejs/node/blob/master/doc/guides/writing_tests.md | https://github.com/nodejs/node/blob/master/doc/guides/writing_tests.md |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| force-pushed | https://github.com/nodejs/node/compare/044fdecd6124a92d214ef7bbcf9d14a2a137bd04..7c08ce9dce9a6b61f6095905a9010500a66cd8b0 |
| 044fdec | https://github.com/nodejs/node/commit/044fdecd6124a92d214ef7bbcf9d14a2a137bd04 |
| 7c08ce9 | https://github.com/nodejs/node/commit/7c08ce9dce9a6b61f6095905a9010500a66cd8b0 |
|
Compare
| https://github.com/nodejs/node/compare/044fdecd6124a92d214ef7bbcf9d14a2a137bd04..7c08ce9dce9a6b61f6095905a9010500a66cd8b0 |
| November 17, 2016 17:46 | https://github.com/nodejs/node/pull/9651#event-863195391 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261317436 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261334110 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261336203 |
| @sam-github | https://github.com/sam-github |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Nov 17, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9091982 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files |
| sam-github | https://github.com/sam-github |
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9091982 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/9651/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| sam-github | https://github.com/sam-github |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88520056 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| cjihrig | https://github.com/cjihrig |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88598762 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/9651/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| sam-github | https://github.com/sam-github |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88520520 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88522960 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| test/parallel/test-child-process-kill-numeric.js | https://github.com/nodejs/node/pull/9651/files#diff-45ed0d5ba349677c7f28b63b5adc6606778af75238b5a58cfc0f30057fa81809 |
| sam-github | https://github.com/sam-github |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88521414 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88526763 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Nov 17, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9093881 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files |
| sam-github | https://github.com/sam-github |
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9093881 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 17, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9093484 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/9651/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| targos | https://github.com/targos |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88521576 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88527795 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261336987 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261337610 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| force-pushed | https://github.com/nodejs/node/compare/9ba36200fec45801463cfaa555936912f5eb5091..798fe20ed7d1ac7ce5dec9ec5e03a7f6548e923d |
| 9ba3620 | https://github.com/nodejs/node/commit/9ba36200fec45801463cfaa555936912f5eb5091 |
| 798fe20 | https://github.com/nodejs/node/commit/798fe20ed7d1ac7ce5dec9ec5e03a7f6548e923d |
|
Compare
| https://github.com/nodejs/node/compare/9ba36200fec45801463cfaa555936912f5eb5091..798fe20ed7d1ac7ce5dec9ec5e03a7f6548e923d |
| November 17, 2016 19:24 | https://github.com/nodejs/node/pull/9651#event-863334268 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261344837 |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 17, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9102050 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9102050 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| force-pushed | https://github.com/nodejs/node/compare/798fe20ed7d1ac7ce5dec9ec5e03a7f6548e923d..5e8cdf9bdc596b34fdf27370a6008c552984fc31 |
| 798fe20 | https://github.com/nodejs/node/commit/798fe20ed7d1ac7ce5dec9ec5e03a7f6548e923d |
| 5e8cdf9 | https://github.com/nodejs/node/commit/5e8cdf9bdc596b34fdf27370a6008c552984fc31 |
|
Compare
| https://github.com/nodejs/node/compare/798fe20ed7d1ac7ce5dec9ec5e03a7f6548e923d..5e8cdf9bdc596b34fdf27370a6008c552984fc31 |
| November 17, 2016 23:55 | https://github.com/nodejs/node/pull/9651#event-863675580 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261407937 |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9168195 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files |
| doc/api/child_process.md | https://github.com/nodejs/node/pull/9651/files#diff-fb4d08d898bf0f72e95ea3627f5838fdf1c4b5adc303cd7c8f526da13e57faf5 |
| cjihrig | https://github.com/cjihrig |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88598816 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88604052 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261447636 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| force-pushed | https://github.com/nodejs/node/compare/5e8cdf9bdc596b34fdf27370a6008c552984fc31..7c45e721a6ecda340564cf90e6195929ff918a03 |
| 5e8cdf9 | https://github.com/nodejs/node/commit/5e8cdf9bdc596b34fdf27370a6008c552984fc31 |
| 7c45e72 | https://github.com/nodejs/node/commit/7c45e721a6ecda340564cf90e6195929ff918a03 |
|
Compare
| https://github.com/nodejs/node/compare/5e8cdf9bdc596b34fdf27370a6008c552984fc31..7c45e721a6ecda340564cf90e6195929ff918a03 |
| November 18, 2016 06:07 | https://github.com/nodejs/node/pull/9651#event-863913961 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261456544 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-261549725 |
| https://github.com/nodejs/node/blob/master/lib/internal/process.js#L152-L178 | https://github.com/nodejs/node/blob/master/lib/internal/process.js#L152-L178 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9265881 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/9651/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| jasnell | https://github.com/jasnell |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88697826 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| cjihrig | https://github.com/cjihrig |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88699141 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 21, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r88949602 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| force-pushed | https://github.com/nodejs/node/compare/76e52b8dd87e9eaa27d804814b7409462eda0cf1..04a8e743d8b962515c33984ab70ee233cdbb6b33 |
| 76e52b8 | https://github.com/nodejs/node/commit/76e52b8dd87e9eaa27d804814b7409462eda0cf1 |
| 04a8e74 | https://github.com/nodejs/node/commit/04a8e743d8b962515c33984ab70ee233cdbb6b33 |
|
Compare
| https://github.com/nodejs/node/compare/76e52b8dd87e9eaa27d804814b7409462eda0cf1..04a8e743d8b962515c33984ab70ee233cdbb6b33 |
| November 21, 2016 17:47 | https://github.com/nodejs/node/pull/9651#event-866946854 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Nov 21, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-262014437 |
| @cjihrig | https://github.com/cjihrig |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 21, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9507296 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/9651#pullrequestreview-9507296 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
|
| https://github.com/gerrard00 |
| child_process: support numeric signal arg to kill | https://github.com/nodejs/node/pull/9651/commits/fd7a620146f9e0d033dfefaeae6bf67d74f01b73 |
| fd7a620 | https://github.com/nodejs/node/pull/9651/commits/fd7a620146f9e0d033dfefaeae6bf67d74f01b73 |
| nodejs#9519 | https://github.com/nodejs/node/issues/9519 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| force-pushed | https://github.com/nodejs/node/compare/04a8e743d8b962515c33984ab70ee233cdbb6b33..fd7a620146f9e0d033dfefaeae6bf67d74f01b73 |
| 04a8e74 | https://github.com/nodejs/node/commit/04a8e743d8b962515c33984ab70ee233cdbb6b33 |
| fd7a620 | https://github.com/nodejs/node/commit/fd7a620146f9e0d033dfefaeae6bf67d74f01b73 |
|
Compare
| https://github.com/nodejs/node/compare/04a8e743d8b962515c33984ab70ee233cdbb6b33..fd7a620146f9e0d033dfefaeae6bf67d74f01b73 |
| November 22, 2016 02:02 | https://github.com/nodejs/node/pull/9651#event-867541354 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 16, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-267612989 |
| @sam-github | https://github.com/sam-github |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 16, 2016 | https://github.com/nodejs/node/pull/9651#event-896799305 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Dec 16, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-13349038 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files/fd7a620146f9e0d033dfefaeae6bf67d74f01b73 |
| doc/api/child_process.md | https://github.com/nodejs/node/pull/9651/files/fd7a620146f9e0d033dfefaeae6bf67d74f01b73#diff-fb4d08d898bf0f72e95ea3627f5838fdf1c4b5adc303cd7c8f526da13e57faf5 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 16, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r92826463 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gerrard00 | https://github.com/gerrard00 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 16, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-267613966 |
| https://ci.nodejs.org/job/node-test-pull-request/5440/ | https://ci.nodejs.org/job/node-test-pull-request/5440/ |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Dec 16, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-13352399 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files/fd7a620146f9e0d033dfefaeae6bf67d74f01b73 |
| doc/api/child_process.md | https://github.com/nodejs/node/pull/9651/files/fd7a620146f9e0d033dfefaeae6bf67d74f01b73#diff-fb4d08d898bf0f72e95ea3627f5838fdf1c4b5adc303cd7c8f526da13e57faf5 |
| targos | https://github.com/targos |
| Dec 16, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r92829700 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| sam-github | https://github.com/sam-github |
| Dec 19, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r93087099 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| test/parallel/test-child-process-kill.js | https://github.com/nodejs/node/pull/9651/files/fd7a620146f9e0d033dfefaeae6bf67d74f01b73#diff-9a298da372068e402b0e72668db3ebc688c5fdc347552c725e48565b8a72f99c |
| targos | https://github.com/targos |
| Dec 16, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r92829952 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Dec 16, 2016
| https://github.com/nodejs/node/pull/9651#pullrequestreview-13353052 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9651/files/fd7a620146f9e0d033dfefaeae6bf67d74f01b73 |
| test/parallel/test-child-process-kill.js | https://github.com/nodejs/node/pull/9651/files/fd7a620146f9e0d033dfefaeae6bf67d74f01b73#diff-9a298da372068e402b0e72668db3ebc688c5fdc347552c725e48565b8a72f99c |
| targos | https://github.com/targos |
| Dec 16, 2016 | https://github.com/nodejs/node/pull/9651#discussion_r92830325 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Dec 19, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-268036933 |
| #9651 (comment) | https://github.com/nodejs/node/pull/9651#issuecomment-261549725 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 21, 2016 | https://github.com/nodejs/node/pull/9651#issuecomment-268674447 |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 19, 2017 | https://github.com/nodejs/node/pull/9651#issuecomment-287651578 |
| @gerrard00 | https://github.com/gerrard00 |
| @gerrard00 | https://github.com/gerrard00 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Mar 19, 2017 | https://github.com/nodejs/node/pull/9651#event-1006008938 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Mar 21, 2017 | https://github.com/nodejs/node/pull/9651#issuecomment-288117863 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| https://github.com/gerrard00 |
| gerrard00 | https://github.com/gerrard00 |
| Mar 21, 2017 | https://github.com/nodejs/node/pull/9651#event-1008802218 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Mar 21, 2017 | https://github.com/nodejs/node/pull/9651#issuecomment-288130398 |
| #10423 | https://github.com/nodejs/node/pull/10423 |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9651 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/9651/files/7c45e721a6ecda340564cf90e6195929ff918a03 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/9651/files/fd7a620146f9e0d033dfefaeae6bf67d74f01b73 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/9651/files/798fe20ed7d1ac7ce5dec9ec5e03a7f6548e923d |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/9651/files/04a8e743d8b962515c33984ab70ee233cdbb6b33 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/9651/files/fd7a620146f9e0d033dfefaeae6bf67d74f01b73 |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs/node/pull/9651/files/fd7a620146f9e0d033dfefaeae6bf67d74f01b73 |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Please reload this page | https://github.com/nodejs/node/pull/9651 |
|
| https://github.com/gerrard00 |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/sam-github |
|
| https://github.com/Fishrock123 |
|
| https://github.com/Trott |
|
| https://github.com/thefourtheye |
|
| https://github.com/jasnell |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |