René's URL Explorer Experiment


Title: Fix V8 patch by MylesBorins · Pull Request #9610 · nodejs/node · GitHub

Open Graph Title: Fix V8 patch by MylesBorins · Pull Request #9610 · nodejs/node

X Title: Fix V8 patch by MylesBorins · Pull Request #9610 · nodejs/node

Description: This is a particularly weird fix and I ask that @nodejs/lts @nodejs/ctc @nodejs/v8 all take a look and make sure that I'm not off here. While auditing a backport we were digging into a V8 change th...

Open Graph Description: This is a particularly weird fix and I ask that @nodejs/lts @nodejs/ctc @nodejs/v8 all take a look and make sure that I'm not off here. While auditing a backport we were digging into a V8 chang...

X Description: This is a particularly weird fix and I ask that @nodejs/lts @nodejs/ctc @nodejs/v8 all take a look and make sure that I'm not off here. While auditing a backport we were digging into a V8 c...

Opengraph URL: https://github.com/nodejs/node/pull/9610

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:00cdb5fe-b581-7ccd-b4c0-9dd2bf8232b5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98FC:301463:387F5C:49CE21:696B3C8A
html-safe-nonce62953ea2ec003d60eb3bc959740c83e66a246cffbc018eb094bdc9c58fb78893
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEZDOjMwMTQ2MzozODdGNUM6NDlDRTIxOjY5NkIzQzhBIiwidmlzaXRvcl9pZCI6IjQ2NTYyNDI1MjYzMjA4MDI5NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb51a4a5ac9d5e9154d66215e89146fd30328d4118ea1fc0fbeb859c99835ac66
hovercard-subject-tagpull_request:93677359
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9610/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/903fec5eb1fc1c373885a8eedc59a3bb1bf33ee5cd7b131375ac9ddc4ab84a2f/nodejs/node/pull/9610
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/903fec5eb1fc1c373885a8eedc59a3bb1bf33ee5cd7b131375ac9ddc4ab84a2f/nodejs/node/pull/9610
og:image:altThis is a particularly weird fix and I ask that @nodejs/lts @nodejs/ctc @nodejs/v8 all take a look and make sure that I'm not off here. While auditing a backport we were digging into a V8 chang...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMylesBorins
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/9610#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9610
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9610
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/9610
Reloadhttps://github.com/nodejs/node/pull/9610
Reloadhttps://github.com/nodejs/node/pull/9610
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/9610
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/9610
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/9610#issue-comment-box
MylesBorinshttps://github.com/MylesBorins
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
MylesBorins:fix-v8-patchhttps://github.com/MylesBorins/node/tree/fix-v8-patch
Fix V8 patch https://github.com/nodejs/node/pull/9610#top
MylesBorinshttps://github.com/MylesBorins
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
MylesBorins:fix-v8-patchhttps://github.com/MylesBorins/node/tree/fix-v8-patch
Conversation 6 https://github.com/nodejs/node/pull/9610
Commits 2 https://github.com/nodejs/node/pull/9610/commits
Checks 0 https://github.com/nodejs/node/pull/9610/checks
Files changed https://github.com/nodejs/node/pull/9610/files
Please reload this pagehttps://github.com/nodejs/node/pull/9610
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 15, 2016https://github.com/nodejs/node/pull/9610#issue-189266086
backporthttps://github.com/nodejs/node/pull/9385
during the upgrade to V8 5.1https://github.com/nodejs/node/pull/8054
cd77ca3https://github.com/nodejs/node/commit/cd77ca397a808ca12286819400c9fea5c37b940a
ofrobots@33c9578https://github.com/ofrobots/node/commit/33c957890db04f4f379b8da99a7a4c0150ae1d96
92ecbc4https://github.com/nodejs/node/commit/92ecbc4edcfe38d22fda5fabf422ca505c7423fa
exact changeset from the V8 trackerhttps://chromium.googlesource.com/v8/v8/+/9cf88c1c364cf76c1e745aa63196768435e8ef5d
ofrobots@33c9578https://github.com/ofrobots/node/commit/33c957890db04f4f379b8da99a7a4c0150ae1d96
Please reload this pagehttps://github.com/nodejs/node/pull/9610
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x
Nov 15, 2016https://github.com/nodejs/node/pull/9610#event-858692261
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 15, 2016 https://github.com/nodejs/node/pull/9610#ref-pullrequest-186362822
Backport --shared to V4.x codebase to allow building as a shared library / DLL #9385 https://github.com/nodejs/node/pull/9385
https://github.com/mscdex
mscdexhttps://github.com/mscdex
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Nov 15, 2016https://github.com/nodejs/node/pull/9610#event-858788377
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 15, 2016 https://github.com/nodejs/node/pull/9610#pullrequestreview-8550858
View reviewed changes https://github.com/nodejs/node/pull/9610/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/9610#pullrequestreview-8550858
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9610
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Nov 15, 2016 https://github.com/nodejs/node/pull/9610#pullrequestreview-8653029
View reviewed changes https://github.com/nodejs/node/pull/9610/files
ofrobotshttps://github.com/ofrobots
Please reload this pagehttps://github.com/nodejs/node/pull/9610
https://github.com/nodejs/node/pull/9610#pullrequestreview-8653029
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9610
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 15, 2016https://github.com/nodejs/node/pull/9610#issuecomment-260714243
https://ci.nodejs.org/job/node-test-commit-v8-linux/420/https://ci.nodejs.org/job/node-test-commit-v8-linux/420/
Please reload this pagehttps://github.com/nodejs/node/pull/9610
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 17, 2016 https://github.com/nodejs/node/pull/9610#pullrequestreview-9103513
View reviewed changes https://github.com/nodejs/node/pull/9610/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/9610#pullrequestreview-9103513
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9610
November 17, 2016 14:49https://github.com/nodejs/node/pull/9610#commits-pushed-e893986
deps: revert botched V8 backporthttps://github.com/nodejs/node/pull/9610/commits/e8939860687c4d4107dc899986eba3f4ec136fc7
e893986https://github.com/nodejs/node/pull/9610/commits/e8939860687c4d4107dc899986eba3f4ec136fc7
92ecbc4https://github.com/MylesBorins/node/commit/92ecbc4edcfe38d22fda5fabf422ca505c7423fa
https://github.com/stefanmb
deps: cherry-pickhttps://github.com/nodejs/node/pull/9610/commits/fb635f615b10b7d793c93bd9fb66910af190ffcd
6f68f30https://github.com/MylesBorins/node/commit/6f68f30b655c86538b43f90621163e8f62b7fcd5
from v8 upstreamhttps://github.com/nodejs/node/pull/9610/commits/fb635f615b10b7d793c93bd9fb66910af190ffcd
fb635f6https://github.com/nodejs/node/pull/9610/commits/fb635f615b10b7d793c93bd9fb66910af190ffcd
nodejs#7487https://github.com/nodejs/node/pull/7487
https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5dhttps://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d
https://codereview.chromium.org/2149963002https://codereview.chromium.org/2149963002
nodejs#37814https://github.com/nodejs/node/pull/37814
nodejs#37856https://github.com/nodejs/node/issues/37856
nodejs#7802https://github.com/nodejs/node/pull/7802
nodejs#8084https://github.com/nodejs/node/pull/8084
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/f940c005cd805a475f6c42f3f5335abfc2a55aef..fb635f615b10b7d793c93bd9fb66910af190ffcd
f940c00https://github.com/nodejs/node/commit/f940c005cd805a475f6c42f3f5335abfc2a55aef
fb635f6https://github.com/nodejs/node/commit/fb635f615b10b7d793c93bd9fb66910af190ffcd
Compare https://github.com/nodejs/node/compare/f940c005cd805a475f6c42f3f5335abfc2a55aef..fb635f615b10b7d793c93bd9fb66910af190ffcd
November 17, 2016 19:50https://github.com/nodejs/node/pull/9610#event-863372337
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
fb635f6https://github.com/nodejs/node/commit/fb635f615b10b7d793c93bd9fb66910af190ffcd
Nov 17, 2016https://github.com/nodejs/node/pull/9610#event-863372733
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2016 https://github.com/nodejs/node/pull/9610#ref-commit-804b398
deps: revert botched V8 backporthttps://github.com/nodejs/node/commit/804b39823969006e7767cca9f7ede84d97c8ec51
804b398https://github.com/nodejs/node/commit/804b39823969006e7767cca9f7ede84d97c8ec51
92ecbc4https://github.com/nodejs/node/commit/92ecbc4edcfe38d22fda5fabf422ca505c7423fa
#9610https://github.com/nodejs/node/pull/9610
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2016 https://github.com/nodejs/node/pull/9610#ref-commit-96e8e86
https://github.com/stefanmb
deps: cherry-pickhttps://github.com/nodejs/node/commit/96e8e869c00a7764bf6ab50a3c37595228e9a1c7
6f68f30https://github.com/nodejs/node/commit/6f68f30b655c86538b43f90621163e8f62b7fcd5
from v8 upstreamhttps://github.com/nodejs/node/commit/96e8e869c00a7764bf6ab50a3c37595228e9a1c7
96e8e86https://github.com/nodejs/node/commit/96e8e869c00a7764bf6ab50a3c37595228e9a1c7
#7487https://github.com/nodejs/node/pull/7487
https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5dhttps://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d
https://codereview.chromium.org/2149963002https://codereview.chromium.org/2149963002
#37814https://github.com/nodejs/node/pull/37814
#37856https://github.com/nodejs/node/issues/37856
#7802https://github.com/nodejs/node/pull/7802
#8084https://github.com/nodejs/node/pull/8084
#9610https://github.com/nodejs/node/pull/9610
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2016https://github.com/nodejs/node/pull/9610#issuecomment-261351555
Please reload this pagehttps://github.com/nodejs/node/pull/9610
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2016https://github.com/nodejs/node/pull/9610#issuecomment-261397301
Please reload this pagehttps://github.com/nodejs/node/pull/9610
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 22, 2016 https://github.com/nodejs/node/pull/9610#ref-pullrequest-190942302
v6.9.2 proposal #9735 https://github.com/nodejs/node/pull/9735
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
November 14, 2017 17:45https://github.com/nodejs/node/pull/9610#event-1341398214
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9610
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/9610/files/f940c005cd805a475f6c42f3f5335abfc2a55aef
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/9610/files/f940c005cd805a475f6c42f3f5335abfc2a55aef
https://github.com/ofrobots
ofrobots https://github.com/ofrobots
https://github.com/nodejs/node/pull/9610/files/f940c005cd805a475f6c42f3f5335abfc2a55aef
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/9610
https://github.com/MylesBorins
https://github.com/ofrobots
https://github.com/bnoordhuis
https://github.com/mhdawson
https://github.com/mscdex
https://github.com/nodejs-github-bot
https://github.com/stefanmb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.