| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0b81b5fd-b5ea-3bb6-0e40-042efe7025d0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9528:3F4FF7:7BE16B:A13E80:696B4D77 |
| html-safe-nonce | e4fb7e36ac1b604c0b7b623eb00f6e9a9982dd0a2b62eb922273463360aeac59 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTI4OjNGNEZGNzo3QkUxNkI6QTEzRTgwOjY5NkI0RDc3IiwidmlzaXRvcl9pZCI6Ijg2NDg5MTY1MjQ5NDYxMTU5NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 074fb7d6bf96018bf60063a996009cb74df19985c5486a2988dc23f9832640e9 |
| hovercard-subject-tag | pull_request:92592576 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9502/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4bdec50b499a1d961f1fb3b88fe4af952177df0b64f341a129201210b386b37c/nodejs/node/pull/9502 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4bdec50b499a1d961f1fb3b88fe4af952177df0b64f341a129201210b386b37c/nodejs/node/pull/9502 |
| og:image:alt | Checklist
documentation is changed or added
commit message follows commit guidelines
Affected core subsystem(s)
doc
Description of change
I don't feel like it as clear on this before.
Al... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Fishrock123 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9502#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9502 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9502 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9502 |
| Reload | https://github.com/nodejs/node/pull/9502 |
| Reload | https://github.com/nodejs/node/pull/9502 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9502 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9502 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9502#issue-comment-box |
| Fishrock123 | https://github.com/Fishrock123 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Fishrock123:tests-guide | https://github.com/Fishrock123/node/tree/tests-guide |
|
doc: clarify the exit code part of writing_tests.md
| https://github.com/nodejs/node/pull/9502#top |
| Fishrock123 | https://github.com/Fishrock123 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Fishrock123:tests-guide | https://github.com/Fishrock123/node/tree/tests-guide |
|
Conversation
3
| https://github.com/nodejs/node/pull/9502 |
|
Commits
1
| https://github.com/nodejs/node/pull/9502/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9502/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9502/files |
| Please reload this page | https://github.com/nodejs/node/pull/9502 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/9502#issue-187725202 |
| Please reload this page | https://github.com/nodejs/node/pull/9502 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/9502#event-849954375 |
| https://github.com/santigimeno |
| santigimeno | https://github.com/santigimeno |
|
Nov 7, 2016
| https://github.com/nodejs/node/pull/9502#pullrequestreview-7426688 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9502/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 7, 2016
| https://github.com/nodejs/node/pull/9502#pullrequestreview-7436819 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9502/files |
| doc/guides/writing_tests.md | https://github.com/nodejs/node/pull/9502/files#diff-de3129ca410c78d26233859def078ed7527967470b03f336263b847972402064 |
| jasnell | https://github.com/jasnell |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/9502#discussion_r86798035 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9502 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 7, 2016
| https://github.com/nodejs/node/pull/9502#pullrequestreview-7436980 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9502/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/9502#pullrequestreview-7436980 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9502 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 7, 2016
| https://github.com/nodejs/node/pull/9502#pullrequestreview-7443437 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9502/files |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Nov 8, 2016
| https://github.com/nodejs/node/pull/9502#pullrequestreview-7563234 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9502/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Nov 8, 2016
| https://github.com/nodejs/node/pull/9502#pullrequestreview-7572486 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9502/files |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/2a5cfcf3877f2e3638fcdcc523fb23b234ee2c6f..31d66efd998e59aab70660c14439d0abd81bdcaf |
| 2a5cfcf | https://github.com/nodejs/node/commit/2a5cfcf3877f2e3638fcdcc523fb23b234ee2c6f |
| 31d66ef | https://github.com/nodejs/node/commit/31d66efd998e59aab70660c14439d0abd81bdcaf |
|
Compare
| https://github.com/nodejs/node/compare/2a5cfcf3877f2e3638fcdcc523fb23b234ee2c6f..31d66efd998e59aab70660c14439d0abd81bdcaf |
| November 8, 2016 14:42 | https://github.com/nodejs/node/pull/9502#event-851580927 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/9502#issuecomment-259154242 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/9502 |
|
| https://github.com/Fishrock123 |
| doc: clarify the exit code part of writing_tests | https://github.com/nodejs/node/pull/9502/commits/4affb8929f70a8022d153a3a7e031fe20db5bb64 |
| 4affb89 | https://github.com/nodejs/node/pull/9502/commits/4affb8929f70a8022d153a3a7e031fe20db5bb64 |
| nodejs#9502 | https://github.com/nodejs/node/pull/9502 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/31d66efd998e59aab70660c14439d0abd81bdcaf..4affb8929f70a8022d153a3a7e031fe20db5bb64 |
| 31d66ef | https://github.com/nodejs/node/commit/31d66efd998e59aab70660c14439d0abd81bdcaf |
| 4affb89 | https://github.com/nodejs/node/commit/4affb8929f70a8022d153a3a7e031fe20db5bb64 |
|
Compare
| https://github.com/nodejs/node/compare/31d66efd998e59aab70660c14439d0abd81bdcaf..4affb8929f70a8022d153a3a7e031fe20db5bb64 |
| November 11, 2016 15:23 | https://github.com/nodejs/node/pull/9502#event-856033498 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| 4affb89 | https://github.com/nodejs/node/commit/4affb8929f70a8022d153a3a7e031fe20db5bb64 |
| Nov 11, 2016 | https://github.com/nodejs/node/pull/9502#event-856035252 |
| addaleax | https://github.com/addaleax |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/9502#ref-commit-92f163e |
|
| https://github.com/Fishrock123 |
|
| https://github.com/addaleax |
| doc: clarify the exit code part of writing_tests | https://github.com/nodejs/node/commit/92f163e4655b738370c781edc72bdd1b6bbfe8dd |
| 92f163e | https://github.com/nodejs/node/commit/92f163e4655b738370c781edc72bdd1b6bbfe8dd |
| #9502 | https://github.com/nodejs/node/pull/9502 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 13, 2016
| https://github.com/nodejs/node/pull/9502#ref-commit-6f850f4 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/MylesBorins |
| doc: clarify the exit code part of writing_tests | https://github.com/nodejs/node/commit/6f850f4037df96ff10c557ef8ecec41032867155 |
| 6f850f4 | https://github.com/nodejs/node/commit/6f850f4037df96ff10c557ef8ecec41032867155 |
| #9502 | https://github.com/nodejs/node/pull/9502 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 13, 2016
| https://github.com/nodejs/node/pull/9502#ref-commit-1e06ed7 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/MylesBorins |
| doc: clarify the exit code part of writing_tests | https://github.com/nodejs/node/commit/1e06ed7e9d1546879b9be0d725d229f606c68d97 |
| 1e06ed7 | https://github.com/nodejs/node/commit/1e06ed7e9d1546879b9be0d725d229f606c68d97 |
| #9502 | https://github.com/nodejs/node/pull/9502 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Dec 13, 2016 | https://github.com/nodejs/node/pull/9502#event-892628239 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9502#ref-commit-136b42b |
|
| https://github.com/Fishrock123 |
|
| https://github.com/MylesBorins |
| doc: clarify the exit code part of writing_tests | https://github.com/nodejs/node/commit/136b42ba0eb34a7f4a6a9c3e425a785afb04f0d6 |
| 136b42b | https://github.com/nodejs/node/commit/136b42ba0eb34a7f4a6a9c3e425a785afb04f0d6 |
| #9502 | https://github.com/nodejs/node/pull/9502 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9502#ref-commit-f86b094 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/MylesBorins |
| doc: clarify the exit code part of writing_tests | https://github.com/nodejs/node/commit/f86b094daac1cc3a2951ae659b3f757352c8290f |
| f86b094 | https://github.com/nodejs/node/commit/f86b094daac1cc3a2951ae659b3f757352c8290f |
| #9502 | https://github.com/nodejs/node/pull/9502 |
|
V6.9.3 proposal
#10394
| https://github.com/nodejs/node/pull/10394 |
|
V4.7.1 proposal
#10395
| https://github.com/nodejs/node/pull/10395 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9502 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/9502/files/2a5cfcf3877f2e3638fcdcc523fb23b234ee2c6f |
|
| https://github.com/santigimeno |
|
santigimeno
| https://github.com/santigimeno |
|
| https://github.com/nodejs/node/pull/9502/files/2a5cfcf3877f2e3638fcdcc523fb23b234ee2c6f |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/9502/files/2a5cfcf3877f2e3638fcdcc523fb23b234ee2c6f |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/9502/files/2a5cfcf3877f2e3638fcdcc523fb23b234ee2c6f |
|
| https://github.com/danbev |
|
danbev
| https://github.com/danbev |
|
| https://github.com/nodejs/node/pull/9502/files/2a5cfcf3877f2e3638fcdcc523fb23b234ee2c6f |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/9502 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/danbev |
|
| https://github.com/jasnell |
|
| https://github.com/santigimeno |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |