| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a14277ac-8bb8-00ef-9706-5b882abe83d0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC60:305A31:369C8A:46D7CF:696B3D19 |
| html-safe-nonce | 3d53e0d36339b08406b70fe480cb7d1914a94234051d7cfc0b5c05feb724caa5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzYwOjMwNUEzMTozNjlDOEE6NDZEN0NGOjY5NkIzRDE5IiwidmlzaXRvcl9pZCI6IjcwMTUzNzQwMDY1MjQ3ODc5OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6610a107cca86254b200e2ad377a03610a4699f49a8592f7eca702696cc8a1d9 |
| hovercard-subject-tag | pull_request:92521163 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9498/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/57375b67c746e15a367e1137de1a380f49af35f10ce4575e157ed4ce267c95f5/nodejs/node/pull/9498 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/57375b67c746e15a367e1137de1a380f49af35f10ce4575e157ed4ce267c95f5/nodejs/node/pull/9498 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
test timers addons
Description of change
Move copy... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9498#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9498 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9498 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9498 |
| Reload | https://github.com/nodejs/node/pull/9498 |
| Reload | https://github.com/nodejs/node/pull/9498 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9498 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9498 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9498#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:make-callback-recurse | https://github.com/Trott/io.js/tree/make-callback-recurse |
|
test: refactor make-callback-recurse test
| https://github.com/nodejs/node/pull/9498#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:make-callback-recurse | https://github.com/Trott/io.js/tree/make-callback-recurse |
|
Conversation
4
| https://github.com/nodejs/node/pull/9498 |
|
Commits
2
| https://github.com/nodejs/node/pull/9498/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9498/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9498/files |
| Please reload this page | https://github.com/nodejs/node/pull/9498 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/9498#issue-187621105 |
| Please reload this page | https://github.com/nodejs/node/pull/9498 |
|
| https://github.com/Trott |
| test: refactor make-callback-recurse test | https://github.com/nodejs/node/pull/9498/commits/f474277bca103257f32d884548dd53db1af49875 |
| f474277 | https://github.com/nodejs/node/pull/9498/commits/f474277bca103257f32d884548dd53db1af49875 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
addons
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/9498#event-849353871 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/9498#event-849353887 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Nov 7, 2016
| https://github.com/nodejs/node/pull/9498#pullrequestreview-7355605 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9498/files/f474277bca103257f32d884548dd53db1af49875 |
| test/addons/make-callback-recurse/test.js | https://github.com/nodejs/node/pull/9498/files/f474277bca103257f32d884548dd53db1af49875#diff-1833dad6e9037b89bfcc90f143df30c717094a46e507b4f80a949c51cc5f1f3b |
| mscdex | https://github.com/mscdex |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/9498#discussion_r86712167 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9498 |
| Trott | https://github.com/Trott |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/9498#discussion_r86712682 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9498 |
|
| https://github.com/Trott |
| squash: no bind | https://github.com/nodejs/node/pull/9498/commits/22d6c5d2fe62f9e3af359b2b964e60226cb89e68 |
| 22d6c5d | https://github.com/nodejs/node/pull/9498/commits/22d6c5d2fe62f9e3af359b2b964e60226cb89e68 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 7, 2016
| https://github.com/nodejs/node/pull/9498#pullrequestreview-7417593 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9498/files/22d6c5d2fe62f9e3af359b2b964e60226cb89e68 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Nov 7, 2016
| https://github.com/nodejs/node/pull/9498#pullrequestreview-7421033 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9498/files/22d6c5d2fe62f9e3af359b2b964e60226cb89e68 |
| Fishrock123 | https://github.com/Fishrock123 |
| https://github.com/nodejs/node/pull/9498#pullrequestreview-7421033 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://ci.nodejs.org/job/node-test-pull-request/4799/ | https://ci.nodejs.org/job/node-test-pull-request/4799/ |
| Please reload this page | https://github.com/nodejs/node/pull/9498 |
| Trott | https://github.com/Trott |
|
Nov 10, 2016
| https://github.com/nodejs/node/pull/9498#ref-commit-837e822 |
|
| https://github.com/Trott |
| test: refactor make-callback-recurse test | https://github.com/Trott/io.js/commit/837e82299288e66300c318fc7567cb0bd022666d |
| 837e822 | https://github.com/Trott/io.js/commit/837e82299288e66300c318fc7567cb0bd022666d |
| nodejs#9498 | https://github.com/nodejs/node/pull/9498 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 10, 2016 | https://github.com/nodejs/node/pull/9498#issuecomment-259592356 |
| 837e822 | https://github.com/nodejs/node/commit/837e82299288e66300c318fc7567cb0bd022666d |
| Please reload this page | https://github.com/nodejs/node/pull/9498 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 10, 2016 | https://github.com/nodejs/node/pull/9498#event-853923348 |
| addaleax | https://github.com/addaleax |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/9498#ref-commit-dab3e45 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: refactor make-callback-recurse test | https://github.com/nodejs/node/commit/dab3e451acbdd4a8d0000ff06e63bec701fd13a2 |
| dab3e45 | https://github.com/nodejs/node/commit/dab3e451acbdd4a8d0000ff06e63bec701fd13a2 |
| #9498 | https://github.com/nodejs/node/pull/9498 |
| addaleax | https://github.com/addaleax |
|
Dec 8, 2016
| https://github.com/nodejs/node/pull/9498#ref-commit-31a3328 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: refactor make-callback-recurse test | https://github.com/addaleax/node/commit/31a3328269ed4fafa327ed9c71f92582843a8d0e |
| 31a3328 | https://github.com/addaleax/node/commit/31a3328269ed4fafa327ed9c71f92582843a8d0e |
| nodejs#9498 | https://github.com/nodejs/node/pull/9498 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| Dec 8, 2016 | https://github.com/nodejs/node/pull/9498#event-887676875 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/9498#event-900729343 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9498#ref-commit-778bacd |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: refactor make-callback-recurse test | https://github.com/nodejs/node/commit/778bacd8a4a0159aeb0fae19f948d95b505c5cc3 |
| 778bacd | https://github.com/nodejs/node/commit/778bacd8a4a0159aeb0fae19f948d95b505c5cc3 |
| #9498 | https://github.com/nodejs/node/pull/9498 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9498#ref-pullrequest-197028600 |
|
V6.9.3 proposal
#10394
| https://github.com/nodejs/node/pull/10394 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:44 | https://github.com/nodejs/node/pull/9498#event-5890943293 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9498 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/9498/files/22d6c5d2fe62f9e3af359b2b964e60226cb89e68 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/9498/files/f474277bca103257f32d884548dd53db1af49875 |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs/node/pull/9498/files/22d6c5d2fe62f9e3af359b2b964e60226cb89e68 |
|
addons
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Please reload this page | https://github.com/nodejs/node/pull/9498 |
|
| https://github.com/Trott |
|
| https://github.com/mscdex |
|
| https://github.com/Fishrock123 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |