| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2f3510e6-5977-3351-f753-163d19311d4a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A11E:22308E:DAA7CC:1348F09:696A6644 |
| html-safe-nonce | d52c727b177464914dae798058df2d2aefc4f33651d225f052fd493357557224 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTFFOjIyMzA4RTpEQUE3Q0M6MTM0OEYwOTo2OTZBNjY0NCIsInZpc2l0b3JfaWQiOiI1NzcwMjg0NTAwOTA1NTE4NjYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0f8e4be9c73ba875f9bec396cb2d176187213592c687020851eedece31072475 |
| hovercard-subject-tag | pull_request:92476167 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9487/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/57375b67c746e15a367e1137de1a380f49af35f10ce4575e157ed4ce267c95f5/nodejs/node/pull/9487 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/57375b67c746e15a367e1137de1a380f49af35f10ce4575e157ed4ce267c95f5/nodejs/node/pull/9487 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
test timers
Description of change
test-regress-GH-... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9487#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9487 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9487 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9487 |
| Reload | https://github.com/nodejs/node/pull/9487 |
| Reload | https://github.com/nodejs/node/pull/9487 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9487 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9487 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9487#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:897 | https://github.com/Trott/io.js/tree/897 |
|
test: move timer-dependent test to sequential
| https://github.com/nodejs/node/pull/9487#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:897 | https://github.com/Trott/io.js/tree/897 |
|
Conversation
6
| https://github.com/nodejs/node/pull/9487 |
|
Commits
2
| https://github.com/nodejs/node/pull/9487/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9487/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9487/files |
| Please reload this page | https://github.com/nodejs/node/pull/9487 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 6, 2016 | https://github.com/nodejs/node/pull/9487#issue-187540086 |
| Please reload this page | https://github.com/nodejs/node/pull/9487 |
|
| https://github.com/Trott |
| test: move timer-dependent test to sequential | https://github.com/nodejs/node/pull/9487/commits/d5a76f81490793778b6500be9c23b507fb3ac41a |
| d5a76f8 | https://github.com/nodejs/node/pull/9487/commits/d5a76f81490793778b6500be9c23b507fb3ac41a |
| nodejsGH-897 | https://github.com/nodejs/node/pull/897 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
freebsd
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afreebsd |
| Nov 6, 2016 | https://github.com/nodejs/node/pull/9487#event-848983477 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 6, 2016 | https://github.com/nodejs/node/pull/9487#event-848983484 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 6, 2016 | https://github.com/nodejs/node/pull/9487#issuecomment-258658707 |
| Please reload this page | https://github.com/nodejs/node/pull/9487 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 6, 2016
| https://github.com/nodejs/node/pull/9487#pullrequestreview-7326515 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9487/files/d5a76f81490793778b6500be9c23b507fb3ac41a |
| test/sequential/test-regress-GH-897.js | https://github.com/nodejs/node/pull/9487/files/d5a76f81490793778b6500be9c23b507fb3ac41a#diff-e1c32431bc838d4748fceb3c322971c35d278b3be40145eef629d932281aa2b9 |
| cjihrig | https://github.com/cjihrig |
| Nov 6, 2016 | https://github.com/nodejs/node/pull/9487#discussion_r86678629 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9487 |
| Trott | https://github.com/Trott |
| Nov 6, 2016 | https://github.com/nodejs/node/pull/9487#discussion_r86678673 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9487 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 6, 2016
| https://github.com/nodejs/node/pull/9487#pullrequestreview-7326516 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9487/files/d5a76f81490793778b6500be9c23b507fb3ac41a |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/9487#pullrequestreview-7326516 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9487 |
|
| https://github.com/Trott |
| squash: nit | https://github.com/nodejs/node/pull/9487/commits/64c8a1985b5b9a087e3233cbfeade60e2522372b |
| 64c8a19 | https://github.com/nodejs/node/pull/9487/commits/64c8a1985b5b9a087e3233cbfeade60e2522372b |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 6, 2016 | https://github.com/nodejs/node/pull/9487#issuecomment-258659452 |
| https://ci.nodejs.org/job/node-test-commit-freebsd/5179/nodes=freebsd10-64/ | https://ci.nodejs.org/job/node-test-commit-freebsd/5179/nodes=freebsd10-64/ |
| Please reload this page | https://github.com/nodejs/node/pull/9487 |
| https://github.com/santigimeno |
| santigimeno | https://github.com/santigimeno |
|
Nov 6, 2016
| https://github.com/nodejs/node/pull/9487#pullrequestreview-7328808 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9487/files/64c8a1985b5b9a087e3233cbfeade60e2522372b |
| https://github.com/JungMinu |
| JungMinu | https://github.com/JungMinu |
|
Nov 6, 2016
| https://github.com/nodejs/node/pull/9487#pullrequestreview-7334949 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9487/files/64c8a1985b5b9a087e3233cbfeade60e2522372b |
| Trott | https://github.com/Trott |
|
Nov 10, 2016
| https://github.com/nodejs/node/pull/9487#ref-commit-1ce05ad |
|
| https://github.com/Trott |
| test: move timer-dependent test to sequential | https://github.com/Trott/io.js/commit/1ce05ad5401447cff6df6e62e22ff5cf052e5c92 |
| 1ce05ad | https://github.com/Trott/io.js/commit/1ce05ad5401447cff6df6e62e22ff5cf052e5c92 |
| nodejsGH-897 | https://github.com/nodejs/node/pull/897 |
| nodejs#9487 | https://github.com/nodejs/node/pull/9487 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 10, 2016 | https://github.com/nodejs/node/pull/9487#issuecomment-259569628 |
| 1ce05ad | https://github.com/nodejs/node/commit/1ce05ad5401447cff6df6e62e22ff5cf052e5c92 |
| Please reload this page | https://github.com/nodejs/node/pull/9487 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 10, 2016 | https://github.com/nodejs/node/pull/9487#event-853813023 |
| addaleax | https://github.com/addaleax |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/9487#ref-commit-2a96256 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: move timer-dependent test to sequential | https://github.com/nodejs/node/commit/2a9625656d4f8e9268890e24a8454be7c0a2bac2 |
| 2a96256 | https://github.com/nodejs/node/commit/2a9625656d4f8e9268890e24a8454be7c0a2bac2 |
| GH-897 | https://github.com/nodejs/node/pull/897 |
| #9487 | https://github.com/nodejs/node/pull/9487 |
| addaleax | https://github.com/addaleax |
|
Dec 8, 2016
| https://github.com/nodejs/node/pull/9487#ref-commit-9808985 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: move timer-dependent test to sequential | https://github.com/addaleax/node/commit/9808985689cdc533c4c909435fedec9b1e6135b3 |
| 9808985 | https://github.com/addaleax/node/commit/9808985689cdc533c4c909435fedec9b1e6135b3 |
| nodejsGH-897 | https://github.com/nodejs/node/pull/897 |
| nodejs#9487 | https://github.com/nodejs/node/pull/9487 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| Dec 8, 2016 | https://github.com/nodejs/node/pull/9487#event-887676640 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 20, 2016
| https://github.com/nodejs/node/pull/9487#ref-commit-b2b2bc2 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: move timer-dependent test to sequential | https://github.com/nodejs/node/commit/b2b2bc2293fce186e27c4b16788d244cc92e8375 |
| b2b2bc2 | https://github.com/nodejs/node/commit/b2b2bc2293fce186e27c4b16788d244cc92e8375 |
| GH-897 | https://github.com/nodejs/node/pull/897 |
| #9487 | https://github.com/nodejs/node/pull/9487 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/9487#event-900732916 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9487#ref-commit-839b652 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: move timer-dependent test to sequential | https://github.com/nodejs/node/commit/839b652b2a1cf427f879605c64e3cb91673dcd1d |
| 839b652 | https://github.com/nodejs/node/commit/839b652b2a1cf427f879605c64e3cb91673dcd1d |
| GH-897 | https://github.com/nodejs/node/pull/897 |
| #9487 | https://github.com/nodejs/node/pull/9487 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9487#ref-commit-ec65984 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: move timer-dependent test to sequential | https://github.com/nodejs/node/commit/ec659840c00aa2261a20decd72ed4a84abd9b9d2 |
| ec65984 | https://github.com/nodejs/node/commit/ec659840c00aa2261a20decd72ed4a84abd9b9d2 |
| GH-897 | https://github.com/nodejs/node/pull/897 |
| #9487 | https://github.com/nodejs/node/pull/9487 |
|
V6.9.3 proposal
#10394
| https://github.com/nodejs/node/pull/10394 |
|
V4.7.1 proposal
#10395
| https://github.com/nodejs/node/pull/10395 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:44 | https://github.com/nodejs/node/pull/9487#event-5890943266 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9487 |
|
| https://github.com/santigimeno |
|
santigimeno
| https://github.com/santigimeno |
|
| https://github.com/nodejs/node/pull/9487/files/64c8a1985b5b9a087e3233cbfeade60e2522372b |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/9487/files/d5a76f81490793778b6500be9c23b507fb3ac41a |
|
| https://github.com/JungMinu |
|
JungMinu
| https://github.com/JungMinu |
|
| https://github.com/nodejs/node/pull/9487/files/64c8a1985b5b9a087e3233cbfeade60e2522372b |
|
freebsd
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afreebsd |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Please reload this page | https://github.com/nodejs/node/pull/9487 |
|
| https://github.com/Trott |
|
| https://github.com/santigimeno |
|
| https://github.com/cjihrig |
|
| https://github.com/JungMinu |
|
| https://github.com/MylesBorins |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |