| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ca041f15-091b-79b2-c11b-53cd7711c86f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D36E:30F550:11A55A2:18968F5:696A399C |
| html-safe-nonce | 218fe161d227fe3f2280d325c93f80631336b17f77a1a589b7bbe6cfb6b94f85 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzZFOjMwRjU1MDoxMUE1NUEyOjE4OTY4RjU6Njk2QTM5OUMiLCJ2aXNpdG9yX2lkIjoiODAxNzg3NDQ0Nzc3Njc1ODE3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cb4bb2b035fbcdd406ca34b0a7d849964d071689f2c8ad463a15871563c96c3a |
| hovercard-subject-tag | pull_request:92416768 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9472/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e7babec6b95cc9084071c29799a02e4f57e7fc8ac0f0fe93b067f32d4e0dfa20/nodejs/node/pull/9472 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e7babec6b95cc9084071c29799a02e4f57e7fc8ac0f0fe93b067f32d4e0dfa20/nodejs/node/pull/9472 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
tools test timers
Description of change
First comm... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9472#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9472 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9472 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9472 |
| Reload | https://github.com/nodejs/node/pull/9472 |
| Reload | https://github.com/nodejs/node/pull/9472 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9472#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:timer-arguments | https://github.com/Trott/io.js/tree/timer-arguments |
|
tools,test: provide duration/interval to timers, require it with lint rule
| https://github.com/nodejs/node/pull/9472#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:timer-arguments | https://github.com/Trott/io.js/tree/timer-arguments |
|
Conversation
10
| https://github.com/nodejs/node/pull/9472 |
|
Commits
2
| https://github.com/nodejs/node/pull/9472/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9472/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9472/files |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 4, 2016 | https://github.com/nodejs/node/pull/9472#issue-187439589 |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Nov 4, 2016 | https://github.com/nodejs/node/pull/9472#event-848508645 |
| https://github.com/not-an-aardvark |
| not-an-aardvark | https://github.com/not-an-aardvark |
|
Nov 4, 2016
| https://github.com/nodejs/node/pull/9472#pullrequestreview-7289771 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9472/files |
| not-an-aardvark | https://github.com/not-an-aardvark |
| https://github.com/nodejs/node/pull/9472#pullrequestreview-7289771 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| tools/eslint-rules/timer-arguments.js | https://github.com/nodejs/node/pull/9472/files#diff-7e9fb1811fa30165e7a806d61ab0ef4238c6e915285a7ef6b64ce78da53fad38 |
| not-an-aardvark | https://github.com/not-an-aardvark |
| Nov 4, 2016 | https://github.com/nodejs/node/pull/9472#discussion_r86637788 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| Trott | https://github.com/Trott |
| Nov 5, 2016 | https://github.com/nodejs/node/pull/9472#discussion_r86658191 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| tools/eslint-rules/timer-arguments.js | https://github.com/nodejs/node/pull/9472/files#diff-7e9fb1811fa30165e7a806d61ab0ef4238c6e915285a7ef6b64ce78da53fad38 |
| not-an-aardvark | https://github.com/not-an-aardvark |
| Nov 4, 2016 | https://github.com/nodejs/node/pull/9472#discussion_r86637955 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| Trott | https://github.com/Trott |
| Nov 5, 2016 | https://github.com/nodejs/node/pull/9472#discussion_r86658203 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Nov 4, 2016 | https://github.com/nodejs/node/pull/9472#issuecomment-258559579 |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Nov 4, 2016 | https://github.com/nodejs/node/pull/9472#issuecomment-258560074 |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/abfd24eb305f79f42bd814008f3699be6d0519fd..04043b190ccdfcc9a442889879ce50155b6f698b |
| abfd24e | https://github.com/nodejs/node/commit/abfd24eb305f79f42bd814008f3699be6d0519fd |
| 04043b1 | https://github.com/nodejs/node/commit/04043b190ccdfcc9a442889879ce50155b6f698b |
|
Compare
| https://github.com/nodejs/node/compare/abfd24eb305f79f42bd814008f3699be6d0519fd..04043b190ccdfcc9a442889879ce50155b6f698b |
| November 5, 2016 04:51 | https://github.com/nodejs/node/pull/9472#event-848712476 |
| https://github.com/not-an-aardvark |
| not-an-aardvark | https://github.com/not-an-aardvark |
|
Nov 5, 2016
| https://github.com/nodejs/node/pull/9472#pullrequestreview-7323155 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9472/files |
| not-an-aardvark | https://github.com/not-an-aardvark |
| https://github.com/nodejs/node/pull/9472#pullrequestreview-7323155 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/04043b190ccdfcc9a442889879ce50155b6f698b..d22e3b7191f8421c98b4948cae152256b1d4b642 |
| 04043b1 | https://github.com/nodejs/node/commit/04043b190ccdfcc9a442889879ce50155b6f698b |
| d22e3b7 | https://github.com/nodejs/node/commit/d22e3b7191f8421c98b4948cae152256b1d4b642 |
|
Compare
| https://github.com/nodejs/node/compare/04043b190ccdfcc9a442889879ce50155b6f698b..d22e3b7191f8421c98b4948cae152256b1d4b642 |
| November 6, 2016 13:32 | https://github.com/nodejs/node/pull/9472#event-849076681 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 7, 2016
| https://github.com/nodejs/node/pull/9472#pullrequestreview-7345271 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9472/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/7830fd5046810a38d578c52e8bae741dbad44cb8..11e40d1feb41e3e64388ddad50e42b6cfc9de873 |
| 7830fd5 | https://github.com/nodejs/node/commit/7830fd5046810a38d578c52e8bae741dbad44cb8 |
| 11e40d1 | https://github.com/nodejs/node/commit/11e40d1feb41e3e64388ddad50e42b6cfc9de873 |
|
Compare
| https://github.com/nodejs/node/compare/7830fd5046810a38d578c52e8bae741dbad44cb8..11e40d1feb41e3e64388ddad50e42b6cfc9de873 |
| November 10, 2016 05:58 | https://github.com/nodejs/node/pull/9472#event-854005165 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 11, 2016
| https://github.com/nodejs/node/pull/9472#ref-pullrequest-188428801 |
|
test: refactor test-next-tick-error-spin
#9537
| https://github.com/nodejs/node/pull/9537 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/4f67aecea2aec1eb8b60482baad00375814d6648..ddea83234476223aeef924bdf786cfc717fd5287 |
| 4f67aec | https://github.com/nodejs/node/commit/4f67aecea2aec1eb8b60482baad00375814d6648 |
| ddea832 | https://github.com/nodejs/node/commit/ddea83234476223aeef924bdf786cfc717fd5287 |
|
Compare
| https://github.com/nodejs/node/compare/4f67aecea2aec1eb8b60482baad00375814d6648..ddea83234476223aeef924bdf786cfc717fd5287 |
| November 16, 2016 22:42 | https://github.com/nodejs/node/pull/9472#event-861921195 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Nov 16, 2016 | https://github.com/nodejs/node/pull/9472#event-861921236 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Nov 16, 2016 | https://github.com/nodejs/node/pull/9472#event-861926234 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Nov 16, 2016
| https://github.com/nodejs/node/pull/9472#ref-pullrequest-186942806 |
|
scripts: new attempt-backport script for PRs
nodejs/github-bot#90
| https://github.com/nodejs/github-bot/pull/90 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Nov 16, 2016
| https://github.com/nodejs/node/pull/9472#ref-commit-015096f |
|
| https://github.com/Fishrock123 |
| attempt-backport: disable for now | https://github.com/Fishrock123/github-bot/commit/015096fa2813e4b23fb9b02866c6ab5d9c53a00f |
| 015096f | https://github.com/Fishrock123/github-bot/commit/015096fa2813e4b23fb9b02866c6ab5d9c53a00f |
| nodejs#90 | https://github.com/nodejs/github-bot/pull/90 |
| nodejs/node#9637 | https://github.com/nodejs/node/pull/9637 |
| nodejs/node#9472 | https://github.com/nodejs/node/pull/9472 |
| nodejs/node#9648 | https://github.com/nodejs/node/pull/9648 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/ddea83234476223aeef924bdf786cfc717fd5287..b7995897d7793e0af9f35a7382c6a68de9bcdf6e |
| ddea832 | https://github.com/nodejs/node/commit/ddea83234476223aeef924bdf786cfc717fd5287 |
| b799589 | https://github.com/nodejs/node/commit/b7995897d7793e0af9f35a7382c6a68de9bcdf6e |
|
Compare
| https://github.com/nodejs/node/compare/ddea83234476223aeef924bdf786cfc717fd5287..b7995897d7793e0af9f35a7382c6a68de9bcdf6e |
| November 16, 2016 23:15 | https://github.com/nodejs/node/pull/9472#event-861962171 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Nov 16, 2016 | https://github.com/nodejs/node/pull/9472#event-861962278 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 16, 2016 | https://github.com/nodejs/node/pull/9472#event-861962282 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/8e41a182659bb05624ec40398b8353063ace1bd1..41e6507c7ca9764b07e4f544d613707293bbe6b5 |
| 8e41a18 | https://github.com/nodejs/node/commit/8e41a182659bb05624ec40398b8353063ace1bd1 |
| 41e6507 | https://github.com/nodejs/node/commit/41e6507c7ca9764b07e4f544d613707293bbe6b5 |
|
Compare
| https://github.com/nodejs/node/compare/8e41a182659bb05624ec40398b8353063ace1bd1..41e6507c7ca9764b07e4f544d613707293bbe6b5 |
| November 21, 2016 04:51 | https://github.com/nodejs/node/pull/9472#event-865910748 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/b432284f90edcf98dbd246333fd32d6f9d4b0d09..acca9e6c48799e1548ca58840dd418fe03cb2356 |
| b432284 | https://github.com/nodejs/node/commit/b432284f90edcf98dbd246333fd32d6f9d4b0d09 |
| acca9e6 | https://github.com/nodejs/node/commit/acca9e6c48799e1548ca58840dd418fe03cb2356 |
|
Compare
| https://github.com/nodejs/node/compare/b432284f90edcf98dbd246333fd32d6f9d4b0d09..acca9e6c48799e1548ca58840dd418fe03cb2356 |
| January 6, 2017 06:13 | https://github.com/nodejs/node/pull/9472#event-913676959 |
| Trott | https://github.com/Trott |
| January 6, 2017 15:09 | https://github.com/nodejs/node/pull/9472#commits-pushed-defefba |
|
| https://github.com/Trott |
| test,benchmark: provide duration/interval to timers | https://github.com/nodejs/node/pull/9472/commits/defefba45cf21882568b82f167afde1a234c1cbe |
| defefba | https://github.com/nodejs/node/pull/9472/commits/defefba45cf21882568b82f167afde1a234c1cbe |
|
| https://github.com/Trott |
| tools: add lint rule to enforce timer arguments | https://github.com/nodejs/node/pull/9472/commits/8a4536d3035df430123c00f40c8d57e325e2b05b |
| 8a4536d | https://github.com/nodejs/node/pull/9472/commits/8a4536d3035df430123c00f40c8d57e325e2b05b |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/acca9e6c48799e1548ca58840dd418fe03cb2356..8a4536d3035df430123c00f40c8d57e325e2b05b |
| acca9e6 | https://github.com/nodejs/node/commit/acca9e6c48799e1548ca58840dd418fe03cb2356 |
| 8a4536d | https://github.com/nodejs/node/commit/8a4536d3035df430123c00f40c8d57e325e2b05b |
|
Compare
| https://github.com/nodejs/node/compare/acca9e6c48799e1548ca58840dd418fe03cb2356..8a4536d3035df430123c00f40c8d57e325e2b05b |
| January 6, 2017 23:10 | https://github.com/nodejs/node/pull/9472#event-914720569 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 6, 2017 | https://github.com/nodejs/node/pull/9472#event-914720626 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 6, 2017 | https://github.com/nodejs/node/pull/9472#issuecomment-271037666 |
| https://ci.nodejs.org/job/node-test-pull-request/5741/ | https://ci.nodejs.org/job/node-test-pull-request/5741/ |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 6, 2017 | https://github.com/nodejs/node/pull/9472#issuecomment-271041385 |
| 6263c00 | https://github.com/nodejs/node/commit/6263c00828ada8ed1cfd110e59906b99352131d0 |
| 4e5cf85 | https://github.com/nodejs/node/commit/4e5cf85adaabf74433731c970f844fe0de21804a |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 6, 2017 | https://github.com/nodejs/node/pull/9472#event-914749965 |
| Trott | https://github.com/Trott |
|
Jan 6, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-6263c00 |
|
| https://github.com/Trott |
| test: provide duration/interval to timers | https://github.com/Trott/io.js/commit/6263c00828ada8ed1cfd110e59906b99352131d0 |
| 6263c00 | https://github.com/Trott/io.js/commit/6263c00828ada8ed1cfd110e59906b99352131d0 |
| nodejs#9472 | https://github.com/nodejs/node/pull/9472 |
| Trott | https://github.com/Trott |
|
Jan 6, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-4e5cf85 |
|
| https://github.com/Trott |
| tools: add lint rule to enforce timer arguments | https://github.com/Trott/io.js/commit/4e5cf85adaabf74433731c970f844fe0de21804a |
| 4e5cf85 | https://github.com/Trott/io.js/commit/4e5cf85adaabf74433731c970f844fe0de21804a |
| nodejs#9472 | https://github.com/nodejs/node/pull/9472 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/9472#event-922862275 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-670062d |
|
| https://github.com/Trott |
| test: provide duration/interval to timers | https://github.com/italoacasas/node/commit/670062dde0cded6fe823e06004902d4d1617b8fd |
| 670062d | https://github.com/italoacasas/node/commit/670062dde0cded6fe823e06004902d4d1617b8fd |
| nodejs#9472 | https://github.com/nodejs/node/pull/9472 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-49bbdbb |
|
| https://github.com/Trott |
| tools: add lint rule to enforce timer arguments | https://github.com/italoacasas/node/commit/49bbdbb3940a433bca3a474d4fd2b1600217a85c |
| 49bbdbb | https://github.com/italoacasas/node/commit/49bbdbb3940a433bca3a474d4fd2b1600217a85c |
| nodejs#9472 | https://github.com/nodejs/node/pull/9472 |
| italoacasas | https://github.com/italoacasas |
|
Jan 19, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-21a929e |
|
| https://github.com/Trott |
| test: provide duration/interval to timers | https://github.com/italoacasas/node/commit/21a929e9d44f3e00e346ab8d47ffe84818119ea3 |
| 21a929e | https://github.com/italoacasas/node/commit/21a929e9d44f3e00e346ab8d47ffe84818119ea3 |
| nodejs#9472 | https://github.com/nodejs/node/pull/9472 |
| italoacasas | https://github.com/italoacasas |
|
Jan 19, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-8501a75 |
|
| https://github.com/Trott |
| tools: add lint rule to enforce timer arguments | https://github.com/italoacasas/node/commit/8501a7555c08bb5b78f9e816ddc895cb4a5e5b69 |
| 8501a75 | https://github.com/italoacasas/node/commit/8501a7555c08bb5b78f9e816ddc895cb4a5e5b69 |
| nodejs#9472 | https://github.com/nodejs/node/pull/9472 |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-e348d56 |
|
| https://github.com/Trott |
| test: provide duration/interval to timers | https://github.com/italoacasas/node/commit/e348d562b676758ecc88e843e1f4bbf3bc7f2a99 |
| e348d56 | https://github.com/italoacasas/node/commit/e348d562b676758ecc88e843e1f4bbf3bc7f2a99 |
| nodejs#9472 | https://github.com/nodejs/node/pull/9472 |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-a2a2661 |
|
| https://github.com/Trott |
| tools: add lint rule to enforce timer arguments | https://github.com/italoacasas/node/commit/a2a2661a3712c83a6b28c97b7522674f3b0f181a |
| a2a2661 | https://github.com/italoacasas/node/commit/a2a2661a3712c83a6b28c97b7522674f3b0f181a |
| nodejs#9472 | https://github.com/nodejs/node/pull/9472 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/9472#ref-pullrequest-203011190 |
|
Proposal to update v7.x-staging
#10989
| https://github.com/nodejs/node/pull/10989 |
| italoacasas | https://github.com/italoacasas |
|
Jan 27, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-09f35a4 |
|
| https://github.com/Trott |
| test: provide duration/interval to timers | https://github.com/italoacasas/node/commit/09f35a49e376cc6c8b5a74faa5b04517aa6fd3be |
| 09f35a4 | https://github.com/italoacasas/node/commit/09f35a49e376cc6c8b5a74faa5b04517aa6fd3be |
| nodejs#9472 | https://github.com/nodejs/node/pull/9472 |
| italoacasas | https://github.com/italoacasas |
|
Jan 27, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-dec5900 |
|
| https://github.com/Trott |
| tools: add lint rule to enforce timer arguments | https://github.com/italoacasas/node/commit/dec5900c421166291612afabe2832d11dde2d201 |
| dec5900 | https://github.com/italoacasas/node/commit/dec5900c421166291612afabe2832d11dde2d201 |
| nodejs#9472 | https://github.com/nodejs/node/pull/9472 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/9472#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Mar 7, 2017 | https://github.com/nodejs/node/pull/9472#event-990550140 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 8, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-3103c6e |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: provide duration/interval to timers | https://github.com/nodejs/node/commit/3103c6e9f936cda53d9f3efbdf89aedeb66a0374 |
| 3103c6e | https://github.com/nodejs/node/commit/3103c6e9f936cda53d9f3efbdf89aedeb66a0374 |
| #9472 | https://github.com/nodejs/node/pull/9472 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 8, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-9f0abf4 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: add lint rule to enforce timer arguments | https://github.com/nodejs/node/commit/9f0abf44420d6ebaae0d6c68a833989128585b1d |
| 9f0abf4 | https://github.com/nodejs/node/commit/9f0abf44420d6ebaae0d6c68a833989128585b1d |
| #9472 | https://github.com/nodejs/node/pull/9472 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-e81b1cc |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: provide duration/interval to timers | https://github.com/nodejs/node/commit/e81b1cc1ae20bb7370aaca9d6c58140c6250a6d7 |
| e81b1cc | https://github.com/nodejs/node/commit/e81b1cc1ae20bb7370aaca9d6c58140c6250a6d7 |
| #9472 | https://github.com/nodejs/node/pull/9472 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/9472#ref-commit-e4f7f5c |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: add lint rule to enforce timer arguments | https://github.com/nodejs/node/commit/e4f7f5c630d644ec9e6bda1005e8582c7908daea |
| e4f7f5c | https://github.com/nodejs/node/commit/e4f7f5c630d644ec9e6bda1005e8582c7908daea |
| #9472 | https://github.com/nodejs/node/pull/9472 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/9472#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:45 | https://github.com/nodejs/node/pull/9472#event-5890945173 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9472 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/9472/files/d22e3b7191f8421c98b4948cae152256b1d4b642 |
|
| https://github.com/not-an-aardvark |
|
not-an-aardvark
| https://github.com/not-an-aardvark |
|
| https://github.com/nodejs/node/pull/9472/files/04043b190ccdfcc9a442889879ce50155b6f698b |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/9472 |
|
| https://github.com/Trott |
|
| https://github.com/Fishrock123 |
|
| https://github.com/mscdex |
|
| https://github.com/jasnell |
|
| https://github.com/not-an-aardvark |
|
| https://github.com/MylesBorins |
|
| https://github.com/italoacasas |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |