| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d30aa7b1-caf8-c2a6-0070-205ab43bf669 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DBD8:31F0A2:C3FA1A:112AFA4:696A2BCA |
| html-safe-nonce | 84f9ea1b67ef0c3cfad582304c0cf255da94c594aad6211f041a6a96aafb8899 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkQ4OjMxRjBBMjpDM0ZBMUE6MTEyQUZBNDo2OTZBMkJDQSIsInZpc2l0b3JfaWQiOiI4NDI2NDUwMzYxNjEzMTY3NTYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ff4def8a51c92efdce73add4b9cb6fd48b337271d896385a87fdd5821047c6cf |
| hovercard-subject-tag | pull_request:91665361 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9385/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/36c5a467061106b44ac7b0921fb5ea483b04d751e39fe1d48718880a3f113d40/nodejs/node/pull/9385 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/36c5a467061106b44ac7b0921fb5ea483b04d751e39fe1d48718880a3f113d40/nodejs/node/pull/9385 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
build
Description of change
Enable the --shared param... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sxa |
| hostname | github.com |
| expected-hostname | github.com |
| None | ade130928b3890d20ecf9c887468a17e88d5c9a740ea2a85c2c2162e7c58e623 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c00842167ca2e5b13e8171812965d503e925ece6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9385#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9385 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9385 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9385 |
| Reload | https://github.com/nodejs/node/pull/9385 |
| Reload | https://github.com/nodejs/node/pull/9385 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9385#issue-comment-box |
| sxa | https://github.com/sxa |
| nodejs:v4.x-staging | https://github.com/nodejs/node/tree/v4.x-staging |
| sxa:v4.x-sharedlib | https://github.com/sxa/node/tree/v4.x-sharedlib |
|
Backport --shared to V4.x codebase to allow building as a shared library / DLL
| https://github.com/nodejs/node/pull/9385#top |
| sxa | https://github.com/sxa |
| nodejs:v4.x-staging | https://github.com/nodejs/node/tree/v4.x-staging |
| sxa:v4.x-sharedlib | https://github.com/sxa/node/tree/v4.x-sharedlib |
|
Conversation
40
| https://github.com/nodejs/node/pull/9385 |
|
Commits
4
| https://github.com/nodejs/node/pull/9385/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9385/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9385/files |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| Oct 31, 2016 | https://github.com/nodejs/node/pull/9385#issue-186362822 |
| #7687 | https://github.com/nodejs/node/pull/7687 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av4.x |
| Oct 31, 2016 | https://github.com/nodejs/node/pull/9385#event-842367438 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| Oct 31, 2016 | https://github.com/nodejs/node/pull/9385#event-842368676 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| Oct 31, 2016 | https://github.com/nodejs/node/pull/9385#event-842369202 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 2, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-257875529 |
| @jbergstroem | https://github.com/jbergstroem |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 2, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-257875661 |
| 4bb43f7 | https://github.com/nodejs/node/commit/4bb43f7b7c0b7e1b144c84a9ceb4a0a922904f20 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 2, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-257917037 |
| @sxa555 | https://github.com/sxa555 |
| #7687 | https://github.com/nodejs/node/pull/7687 |
| a722205 | https://github.com/nodejs/node/commit/a7222052d4e4cc4d46cf22e5a33c4f6a18c2d7bf |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| force-pushed | https://github.com/nodejs/node/compare/ab55c532f364b4713940565e991d717306a53cc9..fb2b7eff3780d51d3e1e74a343ffad02bbed7491 |
| ab55c53 | https://github.com/nodejs/node/commit/ab55c532f364b4713940565e991d717306a53cc9 |
| fb2b7ef | https://github.com/nodejs/node/commit/fb2b7eff3780d51d3e1e74a343ffad02bbed7491 |
|
Compare
| https://github.com/nodejs/node/compare/ab55c532f364b4713940565e991d717306a53cc9..fb2b7eff3780d51d3e1e74a343ffad02bbed7491 |
| November 2, 2016 16:53 | https://github.com/nodejs/node/pull/9385#event-845229204 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| Nov 2, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-257928471 |
| #6994 | https://github.com/nodejs/node/pull/6994 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| force-pushed | https://github.com/nodejs/node/compare/0adff4652342256513cb9037e6629cdf97ba0b26..9cd4f68f8195c7ae059163e71df4db311fc06d81 |
| 0adff46 | https://github.com/nodejs/node/commit/0adff4652342256513cb9037e6629cdf97ba0b26 |
| 9cd4f68 | https://github.com/nodejs/node/commit/9cd4f68f8195c7ae059163e71df4db311fc06d81 |
|
Compare
| https://github.com/nodejs/node/compare/0adff4652342256513cb9037e6629cdf97ba0b26..9cd4f68f8195c7ae059163e71df4db311fc06d81 |
| November 7, 2016 19:01 | https://github.com/nodejs/node/pull/9385#event-850387867 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-258933047 |
| @sxa555 | https://github.com/sxa555 |
| 8df50ac | https://github.com/nodejs/node/commit/8df50ace13741d5cd0c5fe13fd0682813e10080a |
| 7bfa0f2 | https://github.com/nodejs/node/commit/7bfa0f2087171b8ea2aa59f87afeaeda0ae3ecf5 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-258942533 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| 7bfa0f2 | https://github.com/nodejs/node/commit/7bfa0f27a6b3d63b344d459aca9f8067ac3da89b |
| 410296c | https://github.com/nodejs/node/commit/410296c37acb2ad5d939bd4633b2c3fbe3782084 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| force-pushed | https://github.com/nodejs/node/compare/9cd4f68f8195c7ae059163e71df4db311fc06d81..7bfa0f2087171b8ea2aa59f87afeaeda0ae3ecf5 |
| 9cd4f68 | https://github.com/nodejs/node/commit/9cd4f68f8195c7ae059163e71df4db311fc06d81 |
| 7bfa0f2 | https://github.com/nodejs/node/commit/7bfa0f2087171b8ea2aa59f87afeaeda0ae3ecf5 |
|
Compare
| https://github.com/nodejs/node/compare/9cd4f68f8195c7ae059163e71df4db311fc06d81..7bfa0f2087171b8ea2aa59f87afeaeda0ae3ecf5 |
| November 8, 2016 11:00 | https://github.com/nodejs/node/pull/9385#event-851314849 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Nov 8, 2016
| https://github.com/nodejs/node/pull/9385#pullrequestreview-7601537 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9385/files |
| vcbuild.bat | https://github.com/nodejs/node/pull/9385/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e |
| bnoordhuis | https://github.com/bnoordhuis |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/9385#discussion_r86971747 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| sxa | https://github.com/sxa |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/9385#discussion_r86976589 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| force-pushed | https://github.com/nodejs/node/compare/7bfa0f2087171b8ea2aa59f87afeaeda0ae3ecf5..3123873eece1f7941d436fba15adcfebe1a53e70 |
| 7bfa0f2 | https://github.com/nodejs/node/commit/7bfa0f2087171b8ea2aa59f87afeaeda0ae3ecf5 |
| 3123873 | https://github.com/nodejs/node/commit/3123873eece1f7941d436fba15adcfebe1a53e70 |
|
Compare
| https://github.com/nodejs/node/compare/7bfa0f2087171b8ea2aa59f87afeaeda0ae3ecf5..3123873eece1f7941d436fba15adcfebe1a53e70 |
| November 8, 2016 12:04 | https://github.com/nodejs/node/pull/9385#event-851383635 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| force-pushed | https://github.com/nodejs/node/compare/3123873eece1f7941d436fba15adcfebe1a53e70..004ff8b4b12e927e2cb53163d35e83f7bceecf35 |
| 3123873 | https://github.com/nodejs/node/commit/3123873eece1f7941d436fba15adcfebe1a53e70 |
| 004ff8b | https://github.com/nodejs/node/commit/004ff8b4b12e927e2cb53163d35e83f7bceecf35 |
|
Compare
| https://github.com/nodejs/node/compare/3123873eece1f7941d436fba15adcfebe1a53e70..004ff8b4b12e927e2cb53163d35e83f7bceecf35 |
| November 8, 2016 12:05 | https://github.com/nodejs/node/pull/9385#event-851385068 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Nov 8, 2016
| https://github.com/nodejs/node/pull/9385#pullrequestreview-7616687 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9385/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/9385#pullrequestreview-7616687 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| src/node.h | https://github.com/nodejs/node/pull/9385/files#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e |
| bnoordhuis | https://github.com/bnoordhuis |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/9385#discussion_r86987190 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| sxa | https://github.com/sxa |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/9385#discussion_r86991975 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| force-pushed | https://github.com/nodejs/node/compare/004ff8b4b12e927e2cb53163d35e83f7bceecf35..b9966280e9a9e287c0ce8cc1f02a364099eb538f |
| 004ff8b | https://github.com/nodejs/node/commit/004ff8b4b12e927e2cb53163d35e83f7bceecf35 |
| b996628 | https://github.com/nodejs/node/commit/b9966280e9a9e287c0ce8cc1f02a364099eb538f |
|
Compare
| https://github.com/nodejs/node/compare/004ff8b4b12e927e2cb53163d35e83f7bceecf35..b9966280e9a9e287c0ce8cc1f02a364099eb538f |
| November 8, 2016 13:45 | https://github.com/nodejs/node/pull/9385#event-851500531 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Nov 8, 2016
| https://github.com/nodejs/node/pull/9385#pullrequestreview-7705093 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9385/files |
| deps/v8/build/toolchain.gypi | https://github.com/nodejs/node/pull/9385/files#diff-09d9e045870c11208cc7f931f893ce59203a7cd6caea77042791d4b377c5ec89 |
| mhdawson | https://github.com/mhdawson |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/9385#discussion_r87078239 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Nov 8, 2016
| https://github.com/nodejs/node/pull/9385#pullrequestreview-7706487 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9385/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/9385#pullrequestreview-7706487 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| tools/install.py | https://github.com/nodejs/node/pull/9385/files#diff-40ff3cce92cc995fba907b3e9c0b3a1ba608b59766654ea4832c6efaa5273893 |
| mhdawson | https://github.com/mhdawson |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/9385#discussion_r87079678 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| configure | https://github.com/nodejs/node/pull/9385/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2 |
| mhdawson | https://github.com/mhdawson |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/9385#discussion_r87084640 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #6994 | https://github.com/nodejs/node/pull/6994 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| sxa | https://github.com/sxa |
| Nov 9, 2016 | https://github.com/nodejs/node/pull/9385#discussion_r87235974 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| vcbuild.bat | https://github.com/nodejs/node/pull/9385/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e |
| mhdawson | https://github.com/mhdawson |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/9385#discussion_r87085896 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #7487 | https://github.com/nodejs/node/pull/7487 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| sxa | https://github.com/sxa |
| Nov 9, 2016 | https://github.com/nodejs/node/pull/9385#discussion_r87234655 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| force-pushed | https://github.com/nodejs/node/compare/33f87299124f3c9eb573942d2462adb0351d758a..9ae8f71b23d4a3224567eef597b265625241aa79 |
| 33f8729 | https://github.com/nodejs/node/commit/33f87299124f3c9eb573942d2462adb0351d758a |
| 9ae8f71 | https://github.com/nodejs/node/commit/9ae8f71b23d4a3224567eef597b265625241aa79 |
|
Compare
| https://github.com/nodejs/node/compare/33f87299124f3c9eb573942d2462adb0351d758a..9ae8f71b23d4a3224567eef597b265625241aa79 |
| November 9, 2016 17:02 | https://github.com/nodejs/node/pull/9385#event-853272395 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9385#event-862644147 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| force-pushed | https://github.com/nodejs/node/compare/004b1f2324900b95f26b2d2c5bed8809cba2ed68..2efe64e077d6aa2f07846d154e69780c342795dc |
| 004b1f2 | https://github.com/nodejs/node/commit/004b1f2324900b95f26b2d2c5bed8809cba2ed68 |
| 2efe64e | https://github.com/nodejs/node/commit/2efe64e077d6aa2f07846d154e69780c342795dc |
|
Compare
| https://github.com/nodejs/node/compare/004b1f2324900b95f26b2d2c5bed8809cba2ed68..2efe64e077d6aa2f07846d154e69780c342795dc |
| November 17, 2016 11:31 | https://github.com/nodejs/node/pull/9385#event-862644148 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9385#event-862648524 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-261225128 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-261352251 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| @sxa555 | https://github.com/sxa555 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 17, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-261398331 |
| https://ci.nodejs.org/job/node-test-pull-request/4876/ | https://ci.nodejs.org/job/node-test-pull-request/4876/ |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2016
| https://github.com/nodejs/node/pull/9385#pullrequestreview-9138924 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9385/files |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| force-pushed | https://github.com/nodejs/node/compare/fc912e84b48ba4b8a8fe5061140e528cd3067c6d..8476b7c138e401726ca0cd0bc4ca1e5394ebba31 |
| fc912e8 | https://github.com/nodejs/node/commit/fc912e84b48ba4b8a8fe5061140e528cd3067c6d |
| 8476b7c | https://github.com/nodejs/node/commit/8476b7c138e401726ca0cd0bc4ca1e5394ebba31 |
|
Compare
| https://github.com/nodejs/node/compare/fc912e84b48ba4b8a8fe5061140e528cd3067c6d..8476b7c138e401726ca0cd0bc4ca1e5394ebba31 |
| November 18, 2016 14:01 | https://github.com/nodejs/node/pull/9385#event-864392771 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-261544007 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| November 18, 2016 18:24 | https://github.com/nodejs/node/pull/9385#event-864769635 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-261604292 |
| @sxa555 | https://github.com/sxa555 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| stefanmb | https://github.com/stefanmb |
| November 18, 2016 18:45 | https://github.com/nodejs/node/pull/9385#commits-pushed-4a42b86 |
|
| https://github.com/stefanmb |
| build: cherry pick V8 change for windows DLL support | https://github.com/nodejs/node/pull/9385/commits/4a42b861ac26ce5284cdd21bd1c6ddea3ec8fb3c |
| 4a42b86 | https://github.com/nodejs/node/pull/9385/commits/4a42b861ac26ce5284cdd21bd1c6ddea3ec8fb3c |
| nodejs#8084 | https://github.com/nodejs/node/pull/8084 |
|
| https://github.com/sxa |
| build: configure --shared | https://github.com/nodejs/node/pull/9385/commits/a39212ed1a66bd8a63634b8fd8587ff582bb0ac6 |
| a39212e | https://github.com/nodejs/node/pull/9385/commits/a39212ed1a66bd8a63634b8fd8587ff582bb0ac6 |
| nodejs#6994 | https://github.com/nodejs/node/pull/6994 |
| nodejs#9385 | https://github.com/nodejs/node/pull/9385 |
| nodejs#7487 | https://github.com/nodejs/node/pull/7487 |
| build: windows sharedlib support | https://github.com/nodejs/node/pull/9385/commits/d0078bcca45d4239c513c0fd59d752fdf5e79b0a |
| d0078bc | https://github.com/nodejs/node/pull/9385/commits/d0078bcca45d4239c513c0fd59d752fdf5e79b0a |
| build: abstract out shared library suffix | https://github.com/nodejs/node/pull/9385/commits/28dc7116afc7aa9d25491f9ea7193ee1ff45fc89 |
| 28dc711 | https://github.com/nodejs/node/pull/9385/commits/28dc7116afc7aa9d25491f9ea7193ee1ff45fc89 |
| nodejs#6994 | https://github.com/nodejs/node/pull/6994 |
| nodejs#9385 | https://github.com/nodejs/node/pull/9385 |
| nodejs#7687 | https://github.com/nodejs/node/pull/7687 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| force-pushed | https://github.com/nodejs/node/compare/8476b7c138e401726ca0cd0bc4ca1e5394ebba31..28dc7116afc7aa9d25491f9ea7193ee1ff45fc89 |
| 8476b7c | https://github.com/nodejs/node/commit/8476b7c138e401726ca0cd0bc4ca1e5394ebba31 |
| 28dc711 | https://github.com/nodejs/node/commit/28dc7116afc7aa9d25491f9ea7193ee1ff45fc89 |
|
Compare
| https://github.com/nodejs/node/compare/8476b7c138e401726ca0cd0bc4ca1e5394ebba31..28dc7116afc7aa9d25491f9ea7193ee1ff45fc89 |
| November 18, 2016 18:52 | https://github.com/nodejs/node/pull/9385#event-864804270 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-261611032 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-261611886 |
| https://ci.nodejs.org/job/node-test-pull-request/4891/ | https://ci.nodejs.org/job/node-test-pull-request/4891/ |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/9385#ref-commit-bb2fdf5 |
|
| https://github.com/stefanmb |
| build: cherry pick V8 change for windows DLL support | https://github.com/nodejs/node/commit/bb2fdf58f794b4af0baf90f0ab4c96374913202d |
| bb2fdf5 | https://github.com/nodejs/node/commit/bb2fdf58f794b4af0baf90f0ab4c96374913202d |
| #9385 | https://github.com/nodejs/node/pull/9385 |
| #8084 | https://github.com/nodejs/node/pull/8084 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/9385#ref-commit-f21c2b9 |
|
| https://github.com/sxa |
| build: configure --shared | https://github.com/nodejs/node/commit/f21c2b9d3b4595d63e7f9ebd88b9d5fc964131fb |
| f21c2b9 | https://github.com/nodejs/node/commit/f21c2b9d3b4595d63e7f9ebd88b9d5fc964131fb |
| #6994 | https://github.com/nodejs/node/pull/6994 |
| #7487 | https://github.com/nodejs/node/pull/7487 |
| #9385 | https://github.com/nodejs/node/pull/9385 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/9385#ref-commit-0138b4d |
| build: windows sharedlib support | https://github.com/nodejs/node/commit/0138b4db7c44c11a2ca01157222cf5744de99473 |
| 0138b4d | https://github.com/nodejs/node/commit/0138b4db7c44c11a2ca01157222cf5744de99473 |
| #7802 | https://github.com/nodejs/node/pull/7802 |
| #7487 | https://github.com/nodejs/node/pull/7487 |
| #9385 | https://github.com/nodejs/node/pull/9385 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/9385#ref-commit-e97723b |
| build: abstract out shared library suffix | https://github.com/nodejs/node/commit/e97723b18c2b0b61245e1a9a7726bacbf0e8957a |
| e97723b | https://github.com/nodejs/node/commit/e97723b18c2b0b61245e1a9a7726bacbf0e8957a |
| 410296c | https://github.com/nodejs/node/commit/410296c37acb2ad5d939bd4633b2c3fbe3782084 |
| #9385 | https://github.com/nodejs/node/pull/9385 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9385#issuecomment-261631675 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9385#event-864913974 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| 4.7.0 | https://github.com/nodejs/node/milestone/23 |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9385#event-867808004 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/9385#ref-pullrequest-190943787 |
|
v4.7.0 proposal
#9736
| https://github.com/nodejs/node/pull/9736 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 7, 2016
| https://github.com/nodejs/node/pull/9385#ref-commit-97e68d8 |
|
| https://github.com/stefanmb |
|
| https://github.com/BethGriggs |
| build: cherry pick V8 change for windows DLL support | https://github.com/ibmruntimes/node/commit/97e68d85b5a66d52a9fc2bc36ee1d6ed408d49f4 |
| 97e68d8 | https://github.com/ibmruntimes/node/commit/97e68d85b5a66d52a9fc2bc36ee1d6ed408d49f4 |
| nodejs/node#9385 | https://github.com/nodejs/node/pull/9385 |
| nodejs/node#8084 | https://github.com/nodejs/node/pull/8084 |
| https://github.com/springmeyer |
| springmeyer | https://github.com/springmeyer |
|
May 20, 2017
| https://github.com/nodejs/node/pull/9385#ref-issue-174980753 |
|
Build failing for node v6.5.0 on windows
mapnik/node-mapnik#691
| https://github.com/mapnik/node-mapnik/issues/691 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9385 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/9385/files/004ff8b4b12e927e2cb53163d35e83f7bceecf35 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/9385/files/9adac2deb8f2d3a233955a398697f6a61cba01e4 |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/nodejs/node/pull/9385/files/fc912e84b48ba4b8a8fe5061140e528cd3067c6d |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/9385 |
|
| https://github.com/sxa |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com/mhdawson |
|
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/stefanmb |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |