René's URL Explorer Experiment


Title: test: remove timers from streams test by addaleax · Pull Request #9360 · nodejs/node · GitHub

Open Graph Title: test: remove timers from streams test by addaleax · Pull Request #9360 · nodejs/node

X Title: test: remove timers from streams test by addaleax · Pull Request #9360 · nodejs/node

Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) test stream Description of change This is a proposed ...

Open Graph Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) test stream Description of change This is a proposed ...

X Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) test stream Description of change This is a proposed ...

Opengraph URL: https://github.com/nodejs/node/pull/9360

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f5a0667a-126e-bc35-e927-a85f78fcc925
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99A4:36D9CC:CE6163:11C5838:696A8D01
html-safe-noncead0666d54d580d67b1e8b5f0a001817eb06a8cce5095e2e1e3300aa27e4053b9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUE0OjM2RDlDQzpDRTYxNjM6MTFDNTgzODo2OTZBOEQwMSIsInZpc2l0b3JfaWQiOiIyNTc2MzMyOTM0NTIzNTU1MDczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4383200b3ff781842c6bdb06489b625fb72c7c80e79774fdb811a036fa0066b2
hovercard-subject-tagpull_request:91502574
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9360/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a82c6c2d872184f1b42038131ff3299706c89f45a336186bc3935bb2c02ca3ed/nodejs/node/pull/9360
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a82c6c2d872184f1b42038131ff3299706c89f45a336186bc3935bb2c02ca3ed/nodejs/node/pull/9360
og:image:altChecklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) test stream Description of change This is a proposed ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/9360#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9360
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9360
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/9360
Reloadhttps://github.com/nodejs/node/pull/9360
Reloadhttps://github.com/nodejs/node/pull/9360
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/9360
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/9360
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/9360#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:test-stream2-readable-empty-buffer-no-eof-no-timershttps://github.com/addaleax/node/tree/test-stream2-readable-empty-buffer-no-eof-no-timers
test: remove timers from streams test https://github.com/nodejs/node/pull/9360#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:test-stream2-readable-empty-buffer-no-eof-no-timershttps://github.com/addaleax/node/tree/test-stream2-readable-empty-buffer-no-eof-no-timers
Conversation 17 https://github.com/nodejs/node/pull/9360
Commits 4 https://github.com/nodejs/node/pull/9360/commits
Checks 0 https://github.com/nodejs/node/pull/9360/checks
Files changed https://github.com/nodejs/node/pull/9360/files
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 29, 2016https://github.com/nodejs/node/pull/9360#issue-186102076
#9359https://github.com/nodejs/node/pull/9359
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/addaleax
test: remove timers from streams testhttps://github.com/nodejs/node/pull/9360/commits/b8ffd2093cd48b858669159e04f61e618854704a
b8ffd20https://github.com/nodejs/node/pull/9360/commits/b8ffd2093cd48b858669159e04f61e618854704a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 29, 2016https://github.com/nodejs/node/pull/9360#event-841017088
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 29, 2016 https://github.com/nodejs/node/pull/9360#ref-pullrequest-186101496
test: move timer-dependent test to sequential #9359 https://github.com/nodejs/node/pull/9359
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Oct 29, 2016https://github.com/nodejs/node/pull/9360#event-841017286
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 29, 2016https://github.com/nodejs/node/pull/9360#issuecomment-257120995
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/addaleax
address nithttps://github.com/nodejs/node/pull/9360/commits/c8669941236fbf55ce29450dc343060c0ad16a63
c866994https://github.com/nodejs/node/pull/9360/commits/c8669941236fbf55ce29450dc343060c0ad16a63
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 29, 2016https://github.com/nodejs/node/pull/9360#issuecomment-257121206
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 29, 2016 https://github.com/nodejs/node/pull/9360#pullrequestreview-6355744
View reviewed changes https://github.com/nodejs/node/pull/9360/files/b8ffd2093cd48b858669159e04f61e618854704a
test/parallel/test-stream2-readable-empty-buffer-no-eof.jshttps://github.com/nodejs/node/pull/9360/files/b8ffd2093cd48b858669159e04f61e618854704a#diff-719f3dfeb65182476b8517d4d0384a9dcdfb67e6d87ec69a68f099f86954e5bc
Trotthttps://github.com/Trott
Oct 29, 2016https://github.com/nodejs/node/pull/9360#discussion_r85650214
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9360
addaleaxhttps://github.com/addaleax
Oct 29, 2016https://github.com/nodejs/node/pull/9360#discussion_r85650327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/9360
Trotthttps://github.com/Trott
Oct 29, 2016https://github.com/nodejs/node/pull/9360#discussion_r85650364
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9360
Trotthttps://github.com/Trott
Oct 29, 2016https://github.com/nodejs/node/pull/9360#discussion_r85650445
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9360
Trotthttps://github.com/Trott
Oct 30, 2016https://github.com/nodejs/node/pull/9360#discussion_r85652128
Please reload this pagehttps://github.com/nodejs/node/pull/9360
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9360
Trotthttps://github.com/Trott
Oct 30, 2016https://github.com/nodejs/node/pull/9360#discussion_r85652162
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9360
addaleaxhttps://github.com/addaleax
Oct 30, 2016https://github.com/nodejs/node/pull/9360#discussion_r85663121
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 29, 2016https://github.com/nodejs/node/pull/9360#issuecomment-257122748
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 29, 2016https://github.com/nodejs/node/pull/9360#issuecomment-257122938
Please reload this pagehttps://github.com/nodejs/node/pull/9360
addaleaxhttps://github.com/addaleax
October 30, 2016 17:10https://github.com/nodejs/node/pull/9360#commits-pushed-88c42da
https://github.com/addaleax
address nits for readabilityhttps://github.com/nodejs/node/pull/9360/commits/88c42daac0e9e49904228d8ed1e51510acaec734
88c42dahttps://github.com/nodejs/node/pull/9360/commits/88c42daac0e9e49904228d8ed1e51510acaec734
https://github.com/addaleax
reverse order of tests for clarityhttps://github.com/nodejs/node/pull/9360/commits/e8c82ed3c4235bd58a8d8ae066a26c3b5832b71a
e8c82edhttps://github.com/nodejs/node/pull/9360/commits/e8c82ed3c4235bd58a8d8ae066a26c3b5832b71a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 30, 2016https://github.com/nodejs/node/pull/9360#issuecomment-257160856
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2016 https://github.com/nodejs/node/pull/9360#pullrequestreview-6366818
View reviewed changes https://github.com/nodejs/node/pull/9360/files/e8c82ed3c4235bd58a8d8ae066a26c3b5832b71a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 30, 2016https://github.com/nodejs/node/pull/9360#issuecomment-257161900
https://ci.nodejs.org/job/node-test-commit/5869/https://ci.nodejs.org/job/node-test-commit/5869/
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 31, 2016 https://github.com/nodejs/node/pull/9360#pullrequestreview-6379762
View reviewed changes https://github.com/nodejs/node/pull/9360/files/e8c82ed3c4235bd58a8d8ae066a26c3b5832b71a
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/9360#pullrequestreview-6379762
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 31, 2016https://github.com/nodejs/node/pull/9360#issuecomment-257200499
https://ci.nodejs.org/job/node-test-pull-request/4751/https://ci.nodejs.org/job/node-test-pull-request/4751/
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/imyller
imyllerhttps://github.com/imyller
Oct 31, 2016 https://github.com/nodejs/node/pull/9360#pullrequestreview-6407123
View reviewed changes https://github.com/nodejs/node/pull/9360/files/e8c82ed3c4235bd58a8d8ae066a26c3b5832b71a
imyllerhttps://github.com/imyller
https://github.com/nodejs/node/pull/9360#pullrequestreview-6407123
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 31, 2016 https://github.com/nodejs/node/pull/9360#pullrequestreview-6421858
View reviewed changes https://github.com/nodejs/node/pull/9360/files/e8c82ed3c4235bd58a8d8ae066a26c3b5832b71a
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 2, 2016https://github.com/nodejs/node/pull/9360#issuecomment-257971303
45a716chttps://github.com/nodejs/node/commit/45a716c9687849b7ade2ce01f2421c8f791f907c
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 2, 2016https://github.com/nodejs/node/pull/9360#event-845452910
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Nov 22, 2016https://github.com/nodejs/node/pull/9360#event-867776123
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9360
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/9360/files/e8c82ed3c4235bd58a8d8ae066a26c3b5832b71a
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/9360/files/e8c82ed3c4235bd58a8d8ae066a26c3b5832b71a
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/9360/files/e8c82ed3c4235bd58a8d8ae066a26c3b5832b71a
https://github.com/imyller
imyller https://github.com/imyller
https://github.com/nodejs/node/pull/9360/files/e8c82ed3c4235bd58a8d8ae066a26c3b5832b71a
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/9360
https://github.com/addaleax
https://github.com/Trott
https://github.com/jasnell
https://github.com/imyller
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.