| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c1128fbf-dc98-5a26-b3c8-58b446354580 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C83E:280F84:27DF01:373806:696A1CE8 |
| html-safe-nonce | a41afbdbda7dab6ea253668e251d9c51c15393da38f77b46ba7f6ac5e9fddcbf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODNFOjI4MEY4NDoyN0RGMDE6MzczODA2OjY5NkExQ0U4IiwidmlzaXRvcl9pZCI6IjUxOTIyODA0MzgwMDM2MDQ3MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d034d618f9c8056893451d2353b4dba31191804324955805f315d13d6164379c |
| hovercard-subject-tag | pull_request:91342778 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9334/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1263a5133e4d74f5b37a80bf0f262b79fd6c5a7f6195d60a7563df95ce850cd5/nodejs/node/pull/9334 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1263a5133e4d74f5b37a80bf0f262b79fd6c5a7f6195d60a7563df95ce850cd5/nodejs/node/pull/9334 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
test
Description of change
Currently, make lint is ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d515f6f09fa57a93bf90355cb894eb84ca4f458f |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9334#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9334 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9334 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9334 |
| Reload | https://github.com/nodejs/node/pull/9334 |
| Reload | https://github.com/nodejs/node/pull/9334 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
698
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9334#issue-comment-box |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:fix-lint-issue-in-test-stream-writableState-ending.js | https://github.com/danbev/node/tree/fix-lint-issue-in-test-stream-writableState-ending.js |
|
test: fix lint error regarding unused commons const
| https://github.com/nodejs/node/pull/9334#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:fix-lint-issue-in-test-stream-writableState-ending.js | https://github.com/danbev/node/tree/fix-lint-issue-in-test-stream-writableState-ending.js |
|
Conversation
10
| https://github.com/nodejs/node/pull/9334 |
|
Commits
1
| https://github.com/nodejs/node/pull/9334/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9334/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9334/files |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#issue-185868777 |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
|
| https://github.com/danbev |
| test: fix lint error regarding unused commons const | https://github.com/nodejs/node/pull/9334/commits/b75a86634032e3117db9a294d54ee61aac90bf3e |
| b75a866 | https://github.com/nodejs/node/pull/9334/commits/b75a86634032e3117db9a294d54ee61aac90bf3e |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#event-839747628 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#issuecomment-256867633 |
| https://ci.nodejs.org/job/node-test-pull-request/4721/ | https://ci.nodejs.org/job/node-test-pull-request/4721/ |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#event-839796518 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 28, 2016
| https://github.com/nodejs/node/pull/9334#pullrequestreview-6220826 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9334/files/b75a86634032e3117db9a294d54ee61aac90bf3e |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 28, 2016
| https://github.com/nodejs/node/pull/9334#ref-pullrequest-185888509 |
|
test: fix minor stream-writableState linter error
#9335
| https://github.com/nodejs/node/pull/9335 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Oct 28, 2016
| https://github.com/nodejs/node/pull/9334#pullrequestreview-6222175 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9334/files/b75a86634032e3117db9a294d54ee61aac90bf3e |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#issuecomment-256891982 |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#issuecomment-256892322 |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#issuecomment-256892444 |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#issuecomment-256893043 |
| @mcollina | https://github.com/mcollina |
| https://ci.nodejs.org/job/node-test-commit/5798/ | https://ci.nodejs.org/job/node-test-commit/5798/ |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#issuecomment-256893111 |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| danbev | https://github.com/danbev |
|
Oct 28, 2016
| https://github.com/nodejs/node/pull/9334#ref-commit-690bded |
|
| https://github.com/danbev |
| test: fix lint error regarding unused commons const | https://github.com/danbev/node/commit/690bdede1307b4499683c417784e3c84b74bfb45 |
| 690bded | https://github.com/danbev/node/commit/690bdede1307b4499683c417784e3c84b74bfb45 |
| nodejs#9334 | https://github.com/nodejs/node/pull/9334 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#issuecomment-256893430 |
| 690bded | https://github.com/nodejs/node/commit/690bdede1307b4499683c417784e3c84b74bfb45 |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#event-839893835 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9334#issuecomment-256893682 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| evanlucas | https://github.com/evanlucas |
|
Nov 3, 2016
| https://github.com/nodejs/node/pull/9334#ref-commit-0ab008e |
|
| https://github.com/danbev |
|
| https://github.com/evanlucas |
| test: fix lint error regarding unused commons const | https://github.com/nodejs/node/commit/0ab008e50d516c2a023974e350e9e729586ec3e5 |
| 0ab008e | https://github.com/nodejs/node/commit/0ab008e50d516c2a023974e350e9e729586ec3e5 |
| #9334 | https://github.com/nodejs/node/pull/9334 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Nov 3, 2016
| https://github.com/nodejs/node/pull/9334#ref-pullrequest-187029471 |
|
v7.1.0 proposal - 2016-11-08
#9438
| https://github.com/nodejs/node/pull/9438 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9334#issuecomment-261606811 |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9334#event-864785521 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9334#issuecomment-261610750 |
| @thealphanerd | https://github.com/thealphanerd |
| #9334 (comment) | https://github.com/nodejs/node/pull/9334#issuecomment-256893043 |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/9334#event-864983268 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| January 17, 2017 07:16 | https://github.com/nodejs/node/pull/9334#event-925285170 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9334 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/9334/files/b75a86634032e3117db9a294d54ee61aac90bf3e |
|
| https://github.com/gibfahn |
|
gibfahn
| https://github.com/gibfahn |
|
| https://github.com/nodejs/node/pull/9334/files/b75a86634032e3117db9a294d54ee61aac90bf3e |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/9334 |
|
| https://github.com/danbev |
|
| https://github.com/gibfahn |
|
| https://github.com/lpinca |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |