| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3589778d-d312-d3bb-9d77-b909261279d1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC46:34E8DF:13489FA:1AEB442:696A3577 |
| html-safe-nonce | eeeeec062806e8949ce26b9b1299a475fbdfdc6a0a42ff0ac6277289cecb0a89 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzQ2OjM0RThERjoxMzQ4OUZBOjFBRUI0NDI6Njk2QTM1NzciLCJ2aXNpdG9yX2lkIjoiNTQ5MDYwMjg0MzU3Njg2NjQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 80dc719b6a8c4562619ab8ad4c4a84845b054dcd396081e314277dc106fa6dbc |
| hovercard-subject-tag | pull_request:91124716 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9307/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/828591f993897c42849e75f4e60f7993a2604bbba9515b7d1104b3ba3630728f/nodejs/node/pull/9307 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/828591f993897c42849e75f4e60f7993a2604bbba9515b7d1104b3ba3630728f/nodejs/node/pull/9307 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines
Affected core subsystem(s)
test, child_pro... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9307#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9307 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9307 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9307 |
| Reload | https://github.com/nodejs/node/pull/9307 |
| Reload | https://github.com/nodejs/node/pull/9307 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9307 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9307 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9307#issue-comment-box |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:customfds | https://github.com/cjihrig/node/tree/customfds |
|
test: add child_process customFds test
| https://github.com/nodejs/node/pull/9307#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:customfds | https://github.com/cjihrig/node/tree/customfds |
|
Conversation
6
| https://github.com/nodejs/node/pull/9307 |
|
Commits
2
| https://github.com/nodejs/node/pull/9307/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9307/checks |
|
Files changed
2
| https://github.com/nodejs/node/pull/9307/files |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Oct 27, 2016 | https://github.com/nodejs/node/pull/9307#issue-185560730 |
| Please reload this page | https://github.com/nodejs/node/pull/9307 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
| Oct 27, 2016 | https://github.com/nodejs/node/pull/9307#event-838003902 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 27, 2016
| https://github.com/nodejs/node/pull/9307#pullrequestreview-6165533 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9307/files |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/9307#pullrequestreview-6165533 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9307 |
| https://github.com/santigimeno |
| santigimeno | https://github.com/santigimeno |
|
Oct 28, 2016
| https://github.com/nodejs/node/pull/9307#pullrequestreview-6203243 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9307/files |
| https://github.com/santigimeno |
| santigimeno | https://github.com/santigimeno |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9307#issuecomment-256864786 |
| https://ci.nodejs.org/job/node-test-pull-request/4720/ | https://ci.nodejs.org/job/node-test-pull-request/4720/ |
| Please reload this page | https://github.com/nodejs/node/pull/9307 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 28, 2016
| https://github.com/nodejs/node/pull/9307#pullrequestreview-6265628 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9307/files |
| cjihrig | https://github.com/cjihrig |
| October 29, 2016 13:28 | https://github.com/nodejs/node/pull/9307#commits-pushed-d0ed173 |
|
| https://github.com/cjihrig |
| test: add child_process customFds test | https://github.com/nodejs/node/pull/9307/commits/d0ed173d6d3e1ee394901da167cb836ce1c83772 |
| d0ed173 | https://github.com/nodejs/node/pull/9307/commits/d0ed173d6d3e1ee394901da167cb836ce1c83772 |
| nodejs#9307 | https://github.com/nodejs/node/pull/9307 |
|
| https://github.com/cjihrig |
| child_process: remove unreachable code | https://github.com/nodejs/node/pull/9307/commits/ec7c27f4cb80c3f2600ec7e024276c2831273a47 |
| ec7c27f | https://github.com/nodejs/node/pull/9307/commits/ec7c27f4cb80c3f2600ec7e024276c2831273a47 |
| nodejs#9307 | https://github.com/nodejs/node/pull/9307 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/c65042f83f689ffdf8379de9e3ef75bc9f415dc6..ec7c27f4cb80c3f2600ec7e024276c2831273a47 |
| c65042f | https://github.com/nodejs/node/commit/c65042f83f689ffdf8379de9e3ef75bc9f415dc6 |
| ec7c27f | https://github.com/nodejs/node/commit/ec7c27f4cb80c3f2600ec7e024276c2831273a47 |
|
Compare
| https://github.com/nodejs/node/compare/c65042f83f689ffdf8379de9e3ef75bc9f415dc6..ec7c27f4cb80c3f2600ec7e024276c2831273a47 |
| October 29, 2016 17:34 | https://github.com/nodejs/node/pull/9307#event-840965664 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| ec7c27f | https://github.com/nodejs/node/commit/ec7c27f4cb80c3f2600ec7e024276c2831273a47 |
| Oct 29, 2016 | https://github.com/nodejs/node/pull/9307#event-840965840 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| October 29, 2016 17:35 | https://github.com/nodejs/node/pull/9307#event-840965877 |
| evanlucas | https://github.com/evanlucas |
|
Nov 3, 2016
| https://github.com/nodejs/node/pull/9307#ref-commit-1037463 |
|
| https://github.com/cjihrig |
|
| https://github.com/evanlucas |
| test: add child_process customFds test | https://github.com/nodejs/node/commit/1037463604000ba4e583eb35760c859a46a61dc0 |
| 1037463 | https://github.com/nodejs/node/commit/1037463604000ba4e583eb35760c859a46a61dc0 |
| #9307 | https://github.com/nodejs/node/pull/9307 |
| evanlucas | https://github.com/evanlucas |
|
Nov 3, 2016
| https://github.com/nodejs/node/pull/9307#ref-commit-4e3731c |
|
| https://github.com/cjihrig |
|
| https://github.com/evanlucas |
| child_process: remove unreachable code | https://github.com/nodejs/node/commit/4e3731c7e7c02bd208e2baa981ea9bc1f6ae91fa |
| 4e3731c | https://github.com/nodejs/node/commit/4e3731c7e7c02bd208e2baa981ea9bc1f6ae91fa |
| #9307 | https://github.com/nodejs/node/pull/9307 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Nov 3, 2016
| https://github.com/nodejs/node/pull/9307#ref-pullrequest-187029471 |
|
v7.1.0 proposal - 2016-11-08
#9438
| https://github.com/nodejs/node/pull/9438 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9307#event-867741070 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9307#issuecomment-262165721 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/9307 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/9307#issuecomment-262251206 |
| Please reload this page | https://github.com/nodejs/node/pull/9307 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9307#ref-commit-65e2717 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| test: add child_process customFds test | https://github.com/nodejs/node/commit/65e27176f6462d0bdd526e1131e3aebd4d8edc6c |
| 65e2717 | https://github.com/nodejs/node/commit/65e27176f6462d0bdd526e1131e3aebd4d8edc6c |
| #9307 | https://github.com/nodejs/node/pull/9307 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9307#ref-commit-9a526cb |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| child_process: remove unreachable code | https://github.com/nodejs/node/commit/9a526cb8fe9d67b5548bfcfb969698f2411eae68 |
| 9a526cb | https://github.com/nodejs/node/commit/9a526cb8fe9d67b5548bfcfb969698f2411eae68 |
| #9307 | https://github.com/nodejs/node/pull/9307 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Dec 21, 2016 | https://github.com/nodejs/node/pull/9307#event-902030118 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2016 | https://github.com/nodejs/node/pull/9307#issuecomment-268609610 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/9307 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9307#ref-commit-836714e |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| test: add child_process customFds test | https://github.com/nodejs/node/commit/836714ecae04e30773dcd919a6b75059e4e4a1d3 |
| 836714e | https://github.com/nodejs/node/commit/836714ecae04e30773dcd919a6b75059e4e4a1d3 |
| #9307 | https://github.com/nodejs/node/pull/9307 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9307#ref-commit-d456147 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| child_process: remove unreachable code | https://github.com/nodejs/node/commit/d456147a53559ea5b572a8c61cc8580a428134d6 |
| d456147 | https://github.com/nodejs/node/commit/d456147a53559ea5b572a8c61cc8580a428134d6 |
| #9307 | https://github.com/nodejs/node/pull/9307 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9307#ref-pullrequest-197028600 |
|
V6.9.3 proposal
#10394
| https://github.com/nodejs/node/pull/10394 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jan 5, 2017 | https://github.com/nodejs/node/pull/9307#issuecomment-270716778 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/9307 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jan 5, 2017 | https://github.com/nodejs/node/pull/9307#event-913040179 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9307 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/9307/files/c65042f83f689ffdf8379de9e3ef75bc9f415dc6 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/9307/files/c65042f83f689ffdf8379de9e3ef75bc9f415dc6 |
|
| https://github.com/santigimeno |
|
santigimeno
| https://github.com/santigimeno |
|
| https://github.com/nodejs/node/pull/9307/files/c65042f83f689ffdf8379de9e3ef75bc9f415dc6 |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
| Please reload this page | https://github.com/nodejs/node/pull/9307 |
|
| https://github.com/cjihrig |
|
| https://github.com/santigimeno |
|
| https://github.com/MylesBorins |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |