René's URL Explorer Experiment


Title: v8: fix new.target inheritance from c++ by bnoordhuis · Pull Request #9293 · nodejs/node · GitHub

Open Graph Title: v8: fix new.target inheritance from c++ by bnoordhuis · Pull Request #9293 · nodejs/node

X Title: v8: fix new.target inheritance from c++ by bnoordhuis · Pull Request #9293 · nodejs/node

Description: See #9288. Cherry-pick two commits from V8 5.2. The actual fix is commit v8/v8@73ee794 but it depends on commit v8/v8@306c412 which might be something of an ABI change. Opinions welcome on wheth...

Open Graph Description: See #9288. Cherry-pick two commits from V8 5.2. The actual fix is commit v8/v8@73ee794 but it depends on commit v8/v8@306c412 which might be something of an ABI change. Opinions welcome on wheth...

X Description: See #9288. Cherry-pick two commits from V8 5.2. The actual fix is commit v8/v8@73ee794 but it depends on commit v8/v8@306c412 which might be something of an ABI change. Opinions welcome on wheth...

Opengraph URL: https://github.com/nodejs/node/pull/9293

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b5ee3cbb-9385-d210-cfca-3f606a0e2874
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A70:C9E9C:FCE8F6:1617ACA:696A2B68
html-safe-noncef034ac1e1d2ce3ee7885ecb734833ca98f649ecd20f0247a4976ca374c8dc6ac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTcwOkM5RTlDOkZDRThGNjoxNjE3QUNBOjY5NkEyQjY4IiwidmlzaXRvcl9pZCI6IjM4NjEyNDM0ODcxMjU2NDYxODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4e687cd8e9e873f9452dfabd26f38f066d741961c44e4bbff9cb7814aa222e6c
hovercard-subject-tagpull_request:90990443
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9293/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1a3b8ce2863aa15eb1d5cfbebaf4113e64a7e8a7c93f99ac1c260779a1319263/nodejs/node/pull/9293
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1a3b8ce2863aa15eb1d5cfbebaf4113e64a7e8a7c93f99ac1c260779a1319263/nodejs/node/pull/9293
og:image:altSee #9288. Cherry-pick two commits from V8 5.2. The actual fix is commit v8/v8@73ee794 but it depends on commit v8/v8@306c412 which might be something of an ABI change. Opinions welcome on wheth...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
Nonea1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef472b8e6c7b3fdd5d0354972a3f4c516289bf0be
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/9293#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9293
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9293
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/9293
Reloadhttps://github.com/nodejs/node/pull/9293
Reloadhttps://github.com/nodejs/node/pull/9293
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/9293
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/9293
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/9293#issue-comment-box
bnoordhuishttps://github.com/bnoordhuis
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
bnoordhuis:fix9288https://github.com/bnoordhuis/io.js/tree/fix9288
v8: fix new.target inheritance from c++ https://github.com/nodejs/node/pull/9293#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
bnoordhuis:fix9288https://github.com/bnoordhuis/io.js/tree/fix9288
Conversation 37 https://github.com/nodejs/node/pull/9293
Commits 0 https://github.com/nodejs/node/pull/9293/commits
Checks 0 https://github.com/nodejs/node/pull/9293/checks
Files changed https://github.com/nodejs/node/pull/9293/files
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 26, 2016https://github.com/nodejs/node/pull/9293#issue-185374185
#9288https://github.com/nodejs/node/issues/9288
v8/v8@73ee794https://github.com/v8/v8/commit/73ee794
v8/v8@306c412https://github.com/v8/v8/commit/306c412
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x
Oct 26, 2016https://github.com/nodejs/node/pull/9293#event-836936836
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 26, 2016https://github.com/nodejs/node/pull/9293#issuecomment-256327578
https://ci.nodejs.org/job/node-test-pull-request/4684/https://ci.nodejs.org/job/node-test-pull-request/4684/
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 26, 2016 https://github.com/nodejs/node/pull/9293#ref-issue-185311504
inheritance of C/C++ Addons doesn't work #9288 https://github.com/nodejs/node/issues/9288
https://github.com/mscdex
mscdexhttps://github.com/mscdex
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
Oct 26, 2016https://github.com/nodejs/node/pull/9293#event-837129500
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 26, 2016 https://github.com/nodejs/node/pull/9293#pullrequestreview-5881823
View reviewed changes https://github.com/nodejs/node/pull/9293/files
deps/v8/include/v8.hhttps://github.com/nodejs/node/pull/9293/files#diff-e5d029e4c904b9b4385c0dfcf03afbbccf55a41af4e63904a7515fcb0bc7c478
addaleaxhttps://github.com/addaleax
Oct 26, 2016https://github.com/nodejs/node/pull/9293#discussion_r85149976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
bnoordhuishttps://github.com/bnoordhuis
Oct 26, 2016https://github.com/nodejs/node/pull/9293#discussion_r85168943
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
bnoordhuishttps://github.com/bnoordhuis
Nov 2, 2016https://github.com/nodejs/node/pull/9293#discussion_r86113093
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 27, 2016 https://github.com/nodejs/node/pull/9293#pullrequestreview-6067207
View reviewed changes https://github.com/nodejs/node/pull/9293/files
deps/v8/src/objects.cchttps://github.com/nodejs/node/pull/9293/files#diff-74522ccc5e51145509d0b9fb3eb3dcd081e37a565c28769fcdb78db8bdb2d160
addaleaxhttps://github.com/addaleax
Oct 27, 2016https://github.com/nodejs/node/pull/9293#discussion_r85345692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
bnoordhuishttps://github.com/bnoordhuis
Nov 2, 2016https://github.com/nodejs/node/pull/9293#discussion_r86113148
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/1d373dc31a8a543eda210bb4ee4efa71b45bf1ed..071124aacbb924a3358188ed4599c61afb459138
1d373dchttps://github.com/nodejs/node/commit/1d373dc31a8a543eda210bb4ee4efa71b45bf1ed
071124ahttps://github.com/nodejs/node/commit/071124aacbb924a3358188ed4599c61afb459138
Compare https://github.com/nodejs/node/compare/1d373dc31a8a543eda210bb4ee4efa71b45bf1ed..071124aacbb924a3358188ed4599c61afb459138
November 2, 2016 10:41https://github.com/nodejs/node/pull/9293#event-844693969
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 2, 2016https://github.com/nodejs/node/pull/9293#issuecomment-257830391
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://ci.nodejs.org/job/node-test-pull-request/4761/https://ci.nodejs.org/job/node-test-pull-request/4761/
https://ci.nodejs.org/job/node-test-commit-v8-linux/388/https://ci.nodejs.org/job/node-test-commit-v8-linux/388/
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 2, 2016 https://github.com/nodejs/node/pull/9293#pullrequestreview-6787426
View reviewed changes https://github.com/nodejs/node/pull/9293/files
deps/v8/include/v8.hhttps://github.com/nodejs/node/pull/9293/files#diff-e5d029e4c904b9b4385c0dfcf03afbbccf55a41af4e63904a7515fcb0bc7c478
bnoordhuishttps://github.com/bnoordhuis
Nov 2, 2016https://github.com/nodejs/node/pull/9293#discussion_r86113695
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
ofrobotshttps://github.com/ofrobots
Feb 8, 2017https://github.com/nodejs/node/pull/9293#discussion_r100127564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
ofrobotshttps://github.com/ofrobots
Feb 8, 2017https://github.com/nodejs/node/pull/9293#discussion_r100128316
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/rvagg
rvagghttps://github.com/rvagg
Nov 2, 2016https://github.com/nodejs/node/pull/9293#issuecomment-257833008
#9288https://github.com/nodejs/node/issues/9288
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 2, 2016https://github.com/nodejs/node/pull/9293#issuecomment-257836982
@rvagghttps://github.com/rvagg
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/rvagg
rvagghttps://github.com/rvagg
Nov 2, 2016https://github.com/nodejs/node/pull/9293#issuecomment-257838107
@bnoordhuishttps://github.com/bnoordhuis
@thealphanerdhttps://github.com/thealphanerd
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 4, 2016https://github.com/nodejs/node/pull/9293#issuecomment-258548626
https://ci.nodejs.org/job/node-test-commit-v8-linux/396/https://ci.nodejs.org/job/node-test-commit-v8-linux/396/
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 18, 2016https://github.com/nodejs/node/pull/9293#issuecomment-261632057
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 18, 2016 https://github.com/nodejs/node/pull/9293#ref-pullrequest-190432994
test: add new.target add-on regression test #9689 https://github.com/nodejs/node/pull/9689
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
stale reviewhttps://github.com/nodejs/node/pull/9293#pullrequestreview-5881823
November 18, 2016 22:06https://github.com/nodejs/node/pull/9293#event-865039404
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/071124aacbb924a3358188ed4599c61afb459138..5a15cbaa6a64a3ed8206c5aef320d50fef7469ae
071124ahttps://github.com/nodejs/node/commit/071124aacbb924a3358188ed4599c61afb459138
5a15cbahttps://github.com/nodejs/node/commit/5a15cbaa6a64a3ed8206c5aef320d50fef7469ae
Compare https://github.com/nodejs/node/compare/071124aacbb924a3358188ed4599c61afb459138..5a15cbaa6a64a3ed8206c5aef320d50fef7469ae
November 18, 2016 22:07https://github.com/nodejs/node/pull/9293#event-865040799
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 18, 2016https://github.com/nodejs/node/pull/9293#issuecomment-261655224
#9689https://github.com/nodejs/node/pull/9689
https://ci.nodejs.org/job/node-test-pull-request/4901/https://ci.nodejs.org/job/node-test-pull-request/4901/
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 18, 2016https://github.com/nodejs/node/pull/9293#issuecomment-261657743
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/5a15cbaa6a64a3ed8206c5aef320d50fef7469ae..e791ec9a8bd5baf537df54f5e193b228fdb68351
5a15cbahttps://github.com/nodejs/node/commit/5a15cbaa6a64a3ed8206c5aef320d50fef7469ae
e791ec9https://github.com/nodejs/node/commit/e791ec9a8bd5baf537df54f5e193b228fdb68351
Compare https://github.com/nodejs/node/compare/5a15cbaa6a64a3ed8206c5aef320d50fef7469ae..e791ec9a8bd5baf537df54f5e193b228fdb68351
November 18, 2016 22:31https://github.com/nodejs/node/pull/9293#event-865065298
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 18, 2016https://github.com/nodejs/node/pull/9293#issuecomment-261659712
https://ci.nodejs.org/job/node-test-pull-request/4902/https://ci.nodejs.org/job/node-test-pull-request/4902/
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/1e0a8d722ea5bcaecfef57faf7df81495ca103b9..ce999a60e1860bc6042f6f2707b25ad688172c4c
1e0a8d7https://github.com/nodejs/node/commit/1e0a8d722ea5bcaecfef57faf7df81495ca103b9
ce999a6https://github.com/nodejs/node/commit/ce999a60e1860bc6042f6f2707b25ad688172c4c
Compare https://github.com/nodejs/node/compare/1e0a8d722ea5bcaecfef57faf7df81495ca103b9..ce999a60e1860bc6042f6f2707b25ad688172c4c
November 19, 2016 00:04https://github.com/nodejs/node/pull/9293#event-865144151
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/e791ec9a8bd5baf537df54f5e193b228fdb68351..a4d3dec7eefb9100656fbc1e547ab20ae2aa744f
e791ec9https://github.com/nodejs/node/commit/e791ec9a8bd5baf537df54f5e193b228fdb68351
a4d3dechttps://github.com/nodejs/node/commit/a4d3dec7eefb9100656fbc1e547ab20ae2aa744f
Compare https://github.com/nodejs/node/compare/e791ec9a8bd5baf537df54f5e193b228fdb68351..a4d3dec7eefb9100656fbc1e547ab20ae2aa744f
November 19, 2016 11:13https://github.com/nodejs/node/pull/9293#event-865317752
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 19, 2016https://github.com/nodejs/node/pull/9293#issuecomment-261708023
https://ci.nodejs.org/job/node-test-pull-request/4908/https://ci.nodejs.org/job/node-test-pull-request/4908/
Please reload this pagehttps://github.com/nodejs/node/pull/9293
bnoordhuishttps://github.com/bnoordhuis
Nov 21, 2016 https://github.com/nodejs/node/pull/9293#ref-commit-13c4f44
https://github.com/bnoordhuis
test: add new.target add-on regression testhttps://github.com/bnoordhuis/io.js/commit/13c4f44e974534951564c110b0e718fb5c642464
13c4f44https://github.com/bnoordhuis/io.js/commit/13c4f44e974534951564c110b0e718fb5c642464
nodejs#9689https://github.com/nodejs/node/pull/9689
nodejs#9288https://github.com/nodejs/node/issues/9288
nodejs#9293https://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 21, 2016https://github.com/nodejs/node/pull/9293#issuecomment-261941181
#9689https://github.com/nodejs/node/pull/9689
https://ci.nodejs.org/job/node-test-pull-request/4920/https://ci.nodejs.org/job/node-test-pull-request/4920/
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 22, 2016https://github.com/nodejs/node/pull/9293#issuecomment-262152764
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 8, 2017https://github.com/nodejs/node/pull/9293#issuecomment-278352407
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Feb 8, 2017 https://github.com/nodejs/node/pull/9293#pullrequestreview-20823274
View reviewed changes https://github.com/nodejs/node/pull/9293/files
deps/v8/src/s390/code-stubs-s390.cchttps://github.com/nodejs/node/pull/9293/files#diff-9118dec8bcda2c5982369e48a5c0d3e7eb2a4d896f60094a140613ea1ecd3583
ofrobotshttps://github.com/ofrobots
Feb 8, 2017https://github.com/nodejs/node/pull/9293#discussion_r100126960
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
jbajwahttps://github.com/jbajwa
Feb 8, 2017https://github.com/nodejs/node/pull/9293#discussion_r100135463
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
v8/v8@4f75124https://github.com/v8/v8/commit/4f75124044899366e1492529fe9bea4597d2aefc
v8/v8@38e7d1fhttps://github.com/v8/v8/commit/38e7d1fb1ad3762562357626e3685cf7cfc67ca7
v8/v8@1542e46https://github.com/v8/v8/commit/1542e46d0d6b6c4579dd7c94f54fb72cd980f953
Please reload this pagehttps://github.com/nodejs/node/pull/9293
deps/v8/include/v8.hhttps://github.com/nodejs/node/pull/9293/files#diff-e5d029e4c904b9b4385c0dfcf03afbbccf55a41af4e63904a7515fcb0bc7c478
ofrobotshttps://github.com/ofrobots
Feb 8, 2017https://github.com/nodejs/node/pull/9293#discussion_r100127564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
deps/v8/include/v8.hhttps://github.com/nodejs/node/pull/9293/files#diff-e5d029e4c904b9b4385c0dfcf03afbbccf55a41af4e63904a7515fcb0bc7c478
ofrobotshttps://github.com/ofrobots
Feb 8, 2017https://github.com/nodejs/node/pull/9293#discussion_r100128316
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/6f1c1b85a812405473a45356af2e05192569f249..406134c5a9c4b1ec2bc5f02489d2f0909fe979a0
6f1c1b8https://github.com/nodejs/node/commit/6f1c1b85a812405473a45356af2e05192569f249
406134chttps://github.com/nodejs/node/commit/406134c5a9c4b1ec2bc5f02489d2f0909fe979a0
Compare https://github.com/nodejs/node/compare/6f1c1b85a812405473a45356af2e05192569f249..406134c5a9c4b1ec2bc5f02489d2f0909fe979a0
February 13, 2017 18:39https://github.com/nodejs/node/pull/9293#event-960112014
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 13, 2017https://github.com/nodejs/node/pull/9293#issuecomment-279482203
https://ci.nodejs.org/job/node-test-pull-request/6383/https://ci.nodejs.org/job/node-test-pull-request/6383/
https://ci.nodejs.org/job/node-test-commit-v8-linux/568/https://ci.nodejs.org/job/node-test-commit-v8-linux/568/
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 13, 2017 https://github.com/nodejs/node/pull/9293#pullrequestreview-21584360
View reviewed changes https://github.com/nodejs/node/pull/9293/files
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 21, 2017 https://github.com/nodejs/node/pull/9293#pullrequestreview-23071139
View reviewed changes https://github.com/nodejs/node/pull/9293/files
MylesBorinshttps://github.com/MylesBorins
https://github.com/nodejs/node/pull/9293#pullrequestreview-23071139
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/c3590181116ae2ce07891580e5d17bfd37f8648e..1d631ce9a8d47a021d9ebbf9de3225c3672b80d9
c359018https://github.com/nodejs/node/commit/c3590181116ae2ce07891580e5d17bfd37f8648e
1d631cehttps://github.com/nodejs/node/commit/1d631ce9a8d47a021d9ebbf9de3225c3672b80d9
Compare https://github.com/nodejs/node/compare/c3590181116ae2ce07891580e5d17bfd37f8648e..1d631ce9a8d47a021d9ebbf9de3225c3672b80d9
February 22, 2017 02:08https://github.com/nodejs/node/pull/9293#event-971829655
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 27, 2017https://github.com/nodejs/node/pull/9293#issuecomment-282767020
@MylesBorinshttps://github.com/MylesBorins
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 27, 2017https://github.com/nodejs/node/pull/9293#issuecomment-282816846
@bnoordhuishttps://github.com/bnoordhuis
@MylesBorinshttps://github.com/MylesBorins
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 2, 2017https://github.com/nodejs/node/pull/9293#event-983551628
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/406134c5a9c4b1ec2bc5f02489d2f0909fe979a0..2ebceed790641ee73026cf3c81785a7e957f161e
406134chttps://github.com/nodejs/node/commit/406134c5a9c4b1ec2bc5f02489d2f0909fe979a0
2ebceedhttps://github.com/nodejs/node/commit/2ebceed790641ee73026cf3c81785a7e957f161e
Compare https://github.com/nodejs/node/compare/406134c5a9c4b1ec2bc5f02489d2f0909fe979a0..2ebceed790641ee73026cf3c81785a7e957f161e
March 2, 2017 12:17https://github.com/nodejs/node/pull/9293#event-983551630
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
2ebceedhttps://github.com/nodejs/node/commit/2ebceed790641ee73026cf3c81785a7e957f161e
Mar 2, 2017https://github.com/nodejs/node/pull/9293#event-983551631
bnoordhuishttps://github.com/bnoordhuis
Mar 2, 2017 https://github.com/nodejs/node/pull/9293#ref-commit-daa56a6
https://github.com/bnoordhuis
v8: fix --always-opt bughttps://github.com/bnoordhuis/io.js/commit/daa56a6a9efa9241869fb5b7b191b2ac69e4d92e
daa56a6https://github.com/bnoordhuis/io.js/commit/daa56a6a9efa9241869fb5b7b191b2ac69e4d92e
nodejs#9293https://github.com/nodejs/node/pull/9293
bnoordhuishttps://github.com/bnoordhuis
Mar 2, 2017 https://github.com/nodejs/node/pull/9293#ref-commit-a38d091
https://github.com/bnoordhuis
deps: back-port 306c412c from v8 upstreamhttps://github.com/bnoordhuis/io.js/commit/a38d091009fa34ce410f6a3d2e652f8a6f4e7ae3
a38d091https://github.com/bnoordhuis/io.js/commit/a38d091009fa34ce410f6a3d2e652f8a6f4e7ae3
https://codereview.chromium.org/1910253005https://codereview.chromium.org/1910253005
nodejs#35833https://github.com/nodejs/node/issues/35833
nodejs#9288https://github.com/nodejs/node/issues/9288
nodejs#9293https://github.com/nodejs/node/pull/9293
bnoordhuishttps://github.com/bnoordhuis
Mar 2, 2017 https://github.com/nodejs/node/pull/9293#ref-commit-0eb4f1d
https://github.com/bnoordhuis
deps: back-port 73ee7943 from v8 upstreamhttps://github.com/bnoordhuis/io.js/commit/0eb4f1d84be5cfc7f8e71f43ad19a82a24d4922c
0eb4f1dhttps://github.com/bnoordhuis/io.js/commit/0eb4f1d84be5cfc7f8e71f43ad19a82a24d4922c
https://codereview.chromium.org/1972613002https://codereview.chromium.org/1972613002
nodejs#36179https://github.com/nodejs/node/issues/36179
nodejs#9288https://github.com/nodejs/node/issues/9288
nodejs#9293https://github.com/nodejs/node/pull/9293
bnoordhuishttps://github.com/bnoordhuis
Mar 2, 2017 https://github.com/nodejs/node/pull/9293#ref-commit-47cbb88
https://github.com/bnoordhuis
v8: drop v8::FunctionCallbackInfo::NewTarget()https://github.com/bnoordhuis/io.js/commit/47cbb88ac5929ce6ba17f681785034dd019ce063
47cbb88https://github.com/bnoordhuis/io.js/commit/47cbb88ac5929ce6ba17f681785034dd019ce063
v8/v8@306c412chttps://github.com/v8/v8/commit/306c412c
nodejs#9288https://github.com/nodejs/node/issues/9288
nodejs#9293https://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
March 2, 2017 12:17https://github.com/nodejs/node/pull/9293#event-983551668
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 2, 2017https://github.com/nodejs/node/pull/9293#issuecomment-283638502
1d631ce...2ebceedhttps://github.com/nodejs/node/compare/1d631ce9a8d47a021d9ebbf9de3225c3672b80d9...2ebceed790641ee73026cf3c81785a7e957f161e
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 2, 2017 https://github.com/nodejs/node/pull/9293#ref-pullrequest-211376760
Revert "v8: drop v8::FunctionCallbackInfo::NewTarget()" #11652 https://github.com/nodejs/node/pull/11652
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 3, 2017https://github.com/nodejs/node/pull/9293#issuecomment-283843075
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 3, 2017https://github.com/nodejs/node/pull/9293#issuecomment-283894637
@MylesBorinshttps://github.com/MylesBorins
#11652https://github.com/nodejs/node/pull/11652
Please reload this pagehttps://github.com/nodejs/node/pull/9293
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/9293#ref-commit-fd1ffe4
https://github.com/bnoordhuis
https://github.com/MylesBorins
v8: fix --always-opt bughttps://github.com/nodejs/node/commit/fd1ffe4f5aec75e14b8bca169c90652ab8e3ae2a
fd1ffe4https://github.com/nodejs/node/commit/fd1ffe4f5aec75e14b8bca169c90652ab8e3ae2a
#9293https://github.com/nodejs/node/pull/9293
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/9293#ref-commit-e774de1
https://github.com/bnoordhuis
https://github.com/MylesBorins
deps: back-port 306c412c from v8 upstreamhttps://github.com/nodejs/node/commit/e774de1685d279c460358bee557c7d804091d3d2
e774de1https://github.com/nodejs/node/commit/e774de1685d279c460358bee557c7d804091d3d2
v8:4261https://bugs.chromium.org/p/v8/issues/detail?id=4261
https://codereview.chromium.org/1910253005https://codereview.chromium.org/1910253005
#35833https://github.com/nodejs/node/issues/35833
#9288https://github.com/nodejs/node/issues/9288
#9293https://github.com/nodejs/node/pull/9293
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/9293#ref-commit-254cb1c
https://github.com/bnoordhuis
https://github.com/MylesBorins
deps: back-port 73ee7943 from v8 upstreamhttps://github.com/nodejs/node/commit/254cb1cb779860a83ecd46f70426f68d653c23f6
254cb1chttps://github.com/nodejs/node/commit/254cb1cb779860a83ecd46f70426f68d653c23f6
v8:3330https://bugs.chromium.org/p/v8/issues/detail?id=3330
v8:5001https://bugs.chromium.org/p/v8/issues/detail?id=5001
https://codereview.chromium.org/1972613002https://codereview.chromium.org/1972613002
#36179https://github.com/nodejs/node/issues/36179
#9288https://github.com/nodejs/node/issues/9288
#9293https://github.com/nodejs/node/pull/9293
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/9293#ref-commit-2e15d48
https://github.com/bnoordhuis
https://github.com/MylesBorins
v8: drop v8::FunctionCallbackInfo::NewTarget()https://github.com/nodejs/node/commit/2e15d48447542e74186289810d24e080b550c131
2e15d48https://github.com/nodejs/node/commit/2e15d48447542e74186289810d24e080b550c131
v8/v8@306c412chttps://github.com/v8/v8/commit/306c412c
#9288https://github.com/nodejs/node/issues/9288
#9293https://github.com/nodejs/node/pull/9293
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/9293#ref-commit-87760cc
https://github.com/bnoordhuis
https://github.com/MylesBorins
test: add new.target add-on regression testhttps://github.com/nodejs/node/commit/87760cc346920105467bd2e58c8145f32579fac1
87760cchttps://github.com/nodejs/node/commit/87760cc346920105467bd2e58c8145f32579fac1
#9689https://github.com/nodejs/node/pull/9689
#9288https://github.com/nodejs/node/issues/9288
#9293https://github.com/nodejs/node/pull/9293
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/9293#ref-pullrequest-212909365
v6.10.1 proposal #11759 https://github.com/nodejs/node/pull/11759
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 21, 2017 https://github.com/nodejs/node/pull/9293#ref-issue-215889351
V8 Fatal Exception, 0x99b617 #11977 https://github.com/nodejs/node/issues/11977
https://github.com/jasongin
jasonginhttps://github.com/jasongin
Mar 26, 2017 https://github.com/nodejs/node/pull/9293#ref-issue-217093999
Consider "new.target" for constructor callbacks nodejs/abi-stable-node#200 https://github.com/nodejs/abi-stable-node/issues/200
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9293
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/9293/files/1d373dc31a8a543eda210bb4ee4efa71b45bf1ed
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/9293/files/406134c5a9c4b1ec2bc5f02489d2f0909fe979a0
https://github.com/jbajwa
jbajwa https://github.com/jbajwa
https://github.com/nodejs/node/pull/9293/files/5250afdf08837cd332d2f9cbeb1e269c6eacaedb
https://github.com/ofrobots
ofrobots https://github.com/ofrobots
https://github.com/nodejs/node/pull/9293/files/5250afdf08837cd332d2f9cbeb1e269c6eacaedb
https://github.com/MylesBorins
MylesBorins https://github.com/MylesBorins
https://github.com/nodejs/node/pull/9293/files/406134c5a9c4b1ec2bc5f02489d2f0909fe979a0
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/9293
https://github.com/bnoordhuis
https://github.com/rvagg
https://github.com/mhdawson
https://github.com/MylesBorins
https://github.com/jasnell
https://github.com/ofrobots
https://github.com/jbajwa
https://github.com/addaleax
https://github.com/mscdex
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.