René's URL Explorer Experiment


Title: src: make cross-context MakeCallback() calls work by bnoordhuis · Pull Request #9221 · nodejs/node · GitHub

Open Graph Title: src: make cross-context MakeCallback() calls work by bnoordhuis · Pull Request #9221 · nodejs/node

X Title: src: make cross-context MakeCallback() calls work by bnoordhuis · Pull Request #9221 · nodejs/node

Description: From #9213 (comment), cc @addaleax. CI: https://ci.nodejs.org/job/node-test-pull-request/4607/

Open Graph Description: From #9213 (comment), cc @addaleax. CI: https://ci.nodejs.org/job/node-test-pull-request/4607/

X Description: From #9213 (comment), cc @addaleax. CI: https://ci.nodejs.org/job/node-test-pull-request/4607/

Opengraph URL: https://github.com/nodejs/node/pull/9221

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:12db2128-6d93-5919-4bff-033d3c3713e3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id849E:28B0D7:5B4C67:816F1E:696A0F72
html-safe-noncedaca8b539bad1adf1e1aa09c09494322b148122de057ac807fe6a89f28c9f5d6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDlFOjI4QjBENzo1QjRDNjc6ODE2RjFFOjY5NkEwRjcyIiwidmlzaXRvcl9pZCI6IjM1NDEwMjU5NzY5NjQ3NDcxMjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd5084652dc9c1b54c6fb9cf8dec7a5aa199258c0dfce79937c359858a1ea6ea9
hovercard-subject-tagpull_request:90360028
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9221/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e8ea097ddafac4ded84bc3f3d55239662e41f8b06a9b1fe3b7361351d4407a1e/nodejs/node/pull/9221
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e8ea097ddafac4ded84bc3f3d55239662e41f8b06a9b1fe3b7361351d4407a1e/nodejs/node/pull/9221
og:image:altFrom #9213 (comment), cc @addaleax. CI: https://ci.nodejs.org/job/node-test-pull-request/4607/
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7266b2d935baa1c6474b16dd9feaa5ca30607261
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/9221#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9221
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9221
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/9221
Reloadhttps://github.com/nodejs/node/pull/9221
Reloadhttps://github.com/nodejs/node/pull/9221
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/9221
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/9221
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/9221#issue-comment-box
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-foreign-context-callbackhttps://github.com/bnoordhuis/io.js/tree/fix-foreign-context-callback
src: make cross-context MakeCallback() calls work https://github.com/nodejs/node/pull/9221#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-foreign-context-callbackhttps://github.com/bnoordhuis/io.js/tree/fix-foreign-context-callback
Conversation 7 https://github.com/nodejs/node/pull/9221
Commits 1 https://github.com/nodejs/node/pull/9221/commits
Checks 0 https://github.com/nodejs/node/pull/9221/checks
Files changed https://github.com/nodejs/node/pull/9221/files
Please reload this pagehttps://github.com/nodejs/node/pull/9221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 21, 2016https://github.com/nodejs/node/pull/9221#issue-184452860
Please reload this pagehttps://github.com/nodejs/node/pull/9221
#9213 (comment)https://github.com/nodejs/node/pull/9213#issuecomment-255344622
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/job/node-test-pull-request/4607/https://ci.nodejs.org/job/node-test-pull-request/4607/
Please reload this pagehttps://github.com/nodejs/node/pull/9221
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 21, 2016 https://github.com/nodejs/node/pull/9221#pullrequestreview-5234412
View reviewed changes https://github.com/nodejs/node/pull/9221/files
src/node.cchttps://github.com/nodejs/node/pull/9221/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
bnoordhuishttps://github.com/bnoordhuis
Oct 21, 2016https://github.com/nodejs/node/pull/9221#discussion_r84456399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9221
https://github.com/mscdex
mscdexhttps://github.com/mscdex
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Oct 21, 2016https://github.com/nodejs/node/pull/9221#event-831998014
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Oct 21, 2016 https://github.com/nodejs/node/pull/9221#ref-issue-184481317
Bot failed to label PR nodejs/github-bot#88 https://github.com/nodejs/github-bot/issues/88
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 24, 2016https://github.com/nodejs/node/pull/9221#issuecomment-255869205
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/9221
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 24, 2016 https://github.com/nodejs/node/pull/9221#pullrequestreview-5543276
View reviewed changes https://github.com/nodejs/node/pull/9221/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/9221#pullrequestreview-5543276
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9221
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Oct 24, 2016https://github.com/nodejs/node/pull/9221#event-834566980
https://github.com/bnoordhuis
src: make cross-context MakeCallback() calls workhttps://github.com/nodejs/node/pull/9221/commits/921d2b080e810dff89c78db7d7f4c2e9e92f57ec
921d2b0https://github.com/nodejs/node/pull/9221/commits/921d2b080e810dff89c78db7d7f4c2e9e92f57ec
nodejs#9221https://github.com/nodejs/node/pull/9221
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/7201c08ce89b74fcd2d26e1908ce7e70801e5446..921d2b080e810dff89c78db7d7f4c2e9e92f57ec
7201c08https://github.com/nodejs/node/commit/7201c08ce89b74fcd2d26e1908ce7e70801e5446
921d2b0https://github.com/nodejs/node/commit/921d2b080e810dff89c78db7d7f4c2e9e92f57ec
Compare https://github.com/nodejs/node/compare/7201c08ce89b74fcd2d26e1908ce7e70801e5446..921d2b080e810dff89c78db7d7f4c2e9e92f57ec
October 25, 2016 11:30https://github.com/nodejs/node/pull/9221#event-835301804
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 25, 2016https://github.com/nodejs/node/pull/9221#event-835302212
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
October 25, 2016 11:30https://github.com/nodejs/node/pull/9221#event-835302216
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 25, 2016https://github.com/nodejs/node/pull/9221#issuecomment-256009772
Please reload this pagehttps://github.com/nodejs/node/pull/9221
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
921d2b0https://github.com/nodejs/node/commit/921d2b080e810dff89c78db7d7f4c2e9e92f57ec
Oct 25, 2016https://github.com/nodejs/node/pull/9221#event-835303637
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 25, 2016 https://github.com/nodejs/node/pull/9221#ref-pullrequest-184337037
src: remove unneeded AssignToContext() call #9213 https://github.com/nodejs/node/pull/9213
evanlucashttps://github.com/evanlucas
Nov 3, 2016 https://github.com/nodejs/node/pull/9221#ref-commit-c342bda
https://github.com/bnoordhuis
https://github.com/evanlucas
src: make cross-context MakeCallback() calls workhttps://github.com/nodejs/node/commit/c342bda49e08d414d23f02fb932cef5ffe8c98a5
c342bdahttps://github.com/nodejs/node/commit/c342bda49e08d414d23f02fb932cef5ffe8c98a5
#9221https://github.com/nodejs/node/pull/9221
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Nov 3, 2016 https://github.com/nodejs/node/pull/9221#ref-pullrequest-187029471
v7.1.0 proposal - 2016-11-08 #9438 https://github.com/nodejs/node/pull/9438
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Nov 18, 2016https://github.com/nodejs/node/pull/9221#event-865003373
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 18, 2016https://github.com/nodejs/node/pull/9221#issuecomment-261647834
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/9221
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Mar 9, 2017https://github.com/nodejs/node/pull/9221#event-992352346
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jun 15, 2017 https://github.com/nodejs/node/pull/9221#ref-issue-235404028
Auditing for 6.11.1 nodejs/Release#230 https://github.com/nodejs/Release/issues/230
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jun 17, 2017https://github.com/nodejs/node/pull/9221#issuecomment-309236383
@bnoordhuishttps://github.com/bnoordhuis
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/9221
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 18, 2017https://github.com/nodejs/node/pull/9221#issuecomment-309268207
@gibfahnhttps://github.com/gibfahn
Please reload this pagehttps://github.com/nodejs/node/pull/9221
gibfahnhttps://github.com/gibfahn
Jun 18, 2017 https://github.com/nodejs/node/pull/9221#ref-commit-fa9d6ad
https://github.com/bnoordhuis
https://github.com/gibfahn
src: make cross-context MakeCallback() calls workhttps://github.com/nodejs/node/commit/fa9d6ad2332e424d2cccf8c44b8c7a07e5ad8745
fa9d6adhttps://github.com/nodejs/node/commit/fa9d6ad2332e424d2cccf8c44b8c7a07e5ad8745
#9221https://github.com/nodejs/node/pull/9221
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Jun 18, 2017https://github.com/nodejs/node/pull/9221#event-1128121746
gibfahnhttps://github.com/gibfahn
Jun 20, 2017 https://github.com/nodejs/node/pull/9221#ref-commit-72e9a8d
https://github.com/bnoordhuis
https://github.com/gibfahn
src: make cross-context MakeCallback() calls workhttps://github.com/nodejs/node/commit/72e9a8d83c02742d909288da74c2c0463ea059c3
72e9a8dhttps://github.com/nodejs/node/commit/72e9a8d83c02742d909288da74c2c0463ea059c3
#9221https://github.com/nodejs/node/pull/9221
MylesBorinshttps://github.com/MylesBorins
Jul 11, 2017 https://github.com/nodejs/node/pull/9221#ref-commit-7aa5a99
https://github.com/bnoordhuis
https://github.com/MylesBorins
src: make cross-context MakeCallback() calls workhttps://github.com/nodejs/node/commit/7aa5a993b25eb333768503b5320224045df0d14a
7aa5a99https://github.com/nodejs/node/commit/7aa5a993b25eb333768503b5320224045df0d14a
#9221https://github.com/nodejs/node/pull/9221
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 18, 2017 https://github.com/nodejs/node/pull/9221#ref-pullrequest-243856504
v6.11.2 proposal #14356 https://github.com/nodejs/node/pull/14356
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9221
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/9221/files/7201c08ce89b74fcd2d26e1908ce7e70801e5446
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/9221
https://github.com/bnoordhuis
https://github.com/MylesBorins
https://github.com/gibfahn
https://github.com/addaleax
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.