René's URL Explorer Experiment


Title: repl: don’t write to input stream in editor mode by addaleax · Pull Request #9207 · nodejs/node · GitHub

Open Graph Title: repl: don’t write to input stream in editor mode by addaleax · Pull Request #9207 · nodejs/node

X Title: repl: don’t write to input stream in editor mode by addaleax · Pull Request #9207 · nodejs/node

Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) repl Descriptio...

Open Graph Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) repl Descriptio...

X Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) repl Descriptio...

Opengraph URL: https://github.com/nodejs/node/pull/9207

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fe0f3d3c-dd91-91d5-25ac-860194b99298
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8642:11D37A:591D35:7E169A:696A0F86
html-safe-nonce06917399b41d9c3ee307a62f2121204922455744e0b80a834aae75cf72b820d8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjQyOjExRDM3QTo1OTFEMzU6N0UxNjlBOjY5NkEwRjg2IiwidmlzaXRvcl9pZCI6IjMzNjE5MzQ3NTcwNzM2NTM2MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1146a5866db3692f833356e1bd10e5e176378c7103f2651f0161b93498c3c0c9
hovercard-subject-tagpull_request:90219380
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9207/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/82bcb13328f8f3998c24964da91ed6705f4b6df48723b6d7961d9ede5253c994/nodejs/node/pull/9207
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/82bcb13328f8f3998c24964da91ed6705f4b6df48723b6d7961d9ede5253c994/nodejs/node/pull/9207
og:image:altChecklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) repl Descriptio...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7266b2d935baa1c6474b16dd9feaa5ca30607261
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/9207#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9207
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9207
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/9207
Reloadhttps://github.com/nodejs/node/pull/9207
Reloadhttps://github.com/nodejs/node/pull/9207
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/9207
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/9207
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/9207#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:fix-repl-write-editor-modehttps://github.com/addaleax/node/tree/fix-repl-write-editor-mode
repl: don’t write to input stream in editor mode https://github.com/nodejs/node/pull/9207#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:fix-repl-write-editor-modehttps://github.com/addaleax/node/tree/fix-repl-write-editor-mode
Conversation 9 https://github.com/nodejs/node/pull/9207
Commits 3 https://github.com/nodejs/node/pull/9207/commits
Checks 0 https://github.com/nodejs/node/pull/9207/checks
Files changed https://github.com/nodejs/node/pull/9207/files
Please reload this pagehttps://github.com/nodejs/node/pull/9207
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2016https://github.com/nodejs/node/pull/9207#issue-184255670
#9189https://github.com/nodejs/node/issues/9189
Please reload this pagehttps://github.com/nodejs/node/pull/9207
https://github.com/addaleax
repl: make key of repl.write() optional alwayshttps://github.com/nodejs/node/pull/9207/commits/37c9d875e1b858b5a8a4aea753f3a7bcc5be46fb
37c9d87https://github.com/nodejs/node/pull/9207/commits/37c9d875e1b858b5a8a4aea753f3a7bcc5be46fb
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
Oct 20, 2016https://github.com/nodejs/node/pull/9207#event-830736524
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2016https://github.com/nodejs/node/pull/9207#issuecomment-255133507
https://ci.nodejs.org/job/node-test-commit/5701/https://ci.nodejs.org/job/node-test-commit/5701/
@princejwesleyhttps://github.com/princejwesley
Please reload this pagehttps://github.com/nodejs/node/pull/9207
https://github.com/princejwesley
princejwesleyhttps://github.com/princejwesley
Oct 20, 2016 https://github.com/nodejs/node/pull/9207#pullrequestreview-5092967
View reviewed changes https://github.com/nodejs/node/pull/9207/files
test/parallel/test-repl-.editor.jshttps://github.com/nodejs/node/pull/9207/files#diff-0f6137fd35cda2fd549d7ad44da24f88fad336f32a59d9a4bf9f37d1fde78dcc
princejwesleyhttps://github.com/princejwesley
Oct 20, 2016https://github.com/nodejs/node/pull/9207#discussion_r84307322
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/9207
addaleaxhttps://github.com/addaleax
Oct 20, 2016https://github.com/nodejs/node/pull/9207#discussion_r84309392
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@princejwesleyhttps://github.com/princejwesley
Please reload this pagehttps://github.com/nodejs/node/pull/9207
princejwesleyhttps://github.com/princejwesley
Oct 20, 2016https://github.com/nodejs/node/pull/9207#discussion_r84312565
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/9207
addaleaxhttps://github.com/addaleax
Oct 20, 2016https://github.com/nodejs/node/pull/9207#discussion_r84312828
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@princejwesleyhttps://github.com/princejwesley
Please reload this pagehttps://github.com/nodejs/node/pull/9207
addaleaxhttps://github.com/addaleax
October 20, 2016 17:28https://github.com/nodejs/node/pull/9207#commits-pushed-d197827
https://github.com/addaleax
[squash] use regex for control code + prompt strippinghttps://github.com/nodejs/node/pull/9207/commits/d19782764698a431e0558a56bda98455d7c8f884
d197827https://github.com/nodejs/node/pull/9207/commits/d19782764698a431e0558a56bda98455d7c8f884
https://github.com/addaleax
repl: don’t write to input stream in editor modehttps://github.com/nodejs/node/pull/9207/commits/979528dd535e5fef51bf2786f474ff95a6b3a9a9
979528dhttps://github.com/nodejs/node/pull/9207/commits/979528dd535e5fef51bf2786f474ff95a6b3a9a9
nodejs#9189https://github.com/nodejs/node/issues/9189
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/f536ac689f029f7fb70d9507212f445e24f3096c..979528dd535e5fef51bf2786f474ff95a6b3a9a9
f536ac6https://github.com/nodejs/node/commit/f536ac689f029f7fb70d9507212f445e24f3096c
979528dhttps://github.com/nodejs/node/commit/979528dd535e5fef51bf2786f474ff95a6b3a9a9
Compare https://github.com/nodejs/node/compare/f536ac689f029f7fb70d9507212f445e24f3096c..979528dd535e5fef51bf2786f474ff95a6b3a9a9
October 20, 2016 15:28https://github.com/nodejs/node/pull/9207#event-830773668
https://github.com/princejwesley
princejwesleyhttps://github.com/princejwesley
Oct 20, 2016 https://github.com/nodejs/node/pull/9207#pullrequestreview-5095180
View reviewed changes https://github.com/nodejs/node/pull/9207/files/979528dd535e5fef51bf2786f474ff95a6b3a9a9
princejwesleyhttps://github.com/princejwesley
https://github.com/nodejs/node/pull/9207#pullrequestreview-5095180
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9207
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 20, 2016 https://github.com/nodejs/node/pull/9207#pullrequestreview-5115604
View reviewed changes https://github.com/nodejs/node/pull/9207/files/979528dd535e5fef51bf2786f474ff95a6b3a9a9
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 26, 2016https://github.com/nodejs/node/pull/9207#issuecomment-256457352
8b6fd43https://github.com/nodejs/node/commit/8b6fd4386aac3fcae36fde0e63000121980cf98e
3dfc127https://github.com/nodejs/node/commit/3dfc12793f0f11d6736f54c86074c88b93ac6585
Please reload this pagehttps://github.com/nodejs/node/pull/9207
addaleaxhttps://github.com/addaleax
Oct 26, 2016 https://github.com/nodejs/node/pull/9207#ref-commit-8b6fd43
https://github.com/addaleax
repl: make key of repl.write() optional alwayshttps://github.com/nodejs/node/commit/8b6fd4386aac3fcae36fde0e63000121980cf98e
8b6fd43https://github.com/nodejs/node/commit/8b6fd4386aac3fcae36fde0e63000121980cf98e
#9207https://github.com/nodejs/node/pull/9207
addaleaxhttps://github.com/addaleax
Oct 26, 2016 https://github.com/nodejs/node/pull/9207#ref-commit-3dfc127
https://github.com/addaleax
repl: don’t write to input stream in editor modehttps://github.com/nodejs/node/commit/3dfc12793f0f11d6736f54c86074c88b93ac6585
3dfc127https://github.com/nodejs/node/commit/3dfc12793f0f11d6736f54c86074c88b93ac6585
#9189https://github.com/nodejs/node/issues/9189
#9207https://github.com/nodejs/node/pull/9207
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 26, 2016https://github.com/nodejs/node/pull/9207#event-837614484
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
October 26, 2016 19:49https://github.com/nodejs/node/pull/9207#event-837614610
evanlucashttps://github.com/evanlucas
Nov 3, 2016 https://github.com/nodejs/node/pull/9207#ref-commit-1c59cef
https://github.com/addaleax
https://github.com/evanlucas
repl: make key of repl.write() optional alwayshttps://github.com/nodejs/node/commit/1c59cefc44709159343ac6ef76c9a09603934be9
1c59cefhttps://github.com/nodejs/node/commit/1c59cefc44709159343ac6ef76c9a09603934be9
#9207https://github.com/nodejs/node/pull/9207
evanlucashttps://github.com/evanlucas
Nov 3, 2016 https://github.com/nodejs/node/pull/9207#ref-commit-0b9d80a
https://github.com/addaleax
https://github.com/evanlucas
repl: don’t write to input stream in editor modehttps://github.com/nodejs/node/commit/0b9d80a037fa865d7bcdef4a5247f1bbb0d90211
0b9d80ahttps://github.com/nodejs/node/commit/0b9d80a037fa865d7bcdef4a5247f1bbb0d90211
#9189https://github.com/nodejs/node/issues/9189
#9207https://github.com/nodejs/node/pull/9207
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Nov 3, 2016 https://github.com/nodejs/node/pull/9207#ref-pullrequest-187029471
v7.1.0 proposal - 2016-11-08 #9438 https://github.com/nodejs/node/pull/9438
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Nov 22, 2016https://github.com/nodejs/node/pull/9207#event-867724958
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 22, 2016https://github.com/nodejs/node/pull/9207#issuecomment-262162568
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/9207
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Nov 22, 2016https://github.com/nodejs/node/pull/9207#event-867727775
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 22, 2016https://github.com/nodejs/node/pull/9207#issuecomment-262163197
@thealphanerdhttps://github.com/thealphanerd
Please reload this pagehttps://github.com/nodejs/node/pull/9207
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Nov 22, 2016https://github.com/nodejs/node/pull/9207#event-867732323
MylesBorinshttps://github.com/MylesBorins
Nov 22, 2016 https://github.com/nodejs/node/pull/9207#ref-commit-ed3de08
https://github.com/addaleax
repl: make key of repl.write() optional alwayshttps://github.com/nodejs/node/commit/ed3de0854ed0e3c148dfbcdab624f85da04db52a
ed3de08https://github.com/nodejs/node/commit/ed3de0854ed0e3c148dfbcdab624f85da04db52a
#9207https://github.com/nodejs/node/pull/9207
MylesBorinshttps://github.com/MylesBorins
Nov 22, 2016 https://github.com/nodejs/node/pull/9207#ref-commit-58b60fc
https://github.com/addaleax
repl: don’t write to input stream in editor modehttps://github.com/nodejs/node/commit/58b60fc79de641c741a65abfb7d035488ace95a5
58b60fchttps://github.com/nodejs/node/commit/58b60fc79de641c741a65abfb7d035488ace95a5
#9189https://github.com/nodejs/node/issues/9189
#9207https://github.com/nodejs/node/pull/9207
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 22, 2016 https://github.com/nodejs/node/pull/9207#ref-pullrequest-190942302
v6.9.2 proposal #9735 https://github.com/nodejs/node/pull/9735
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9207
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/9207/files/979528dd535e5fef51bf2786f474ff95a6b3a9a9
https://github.com/princejwesley
princejwesley https://github.com/princejwesley
https://github.com/nodejs/node/pull/9207/files/f536ac689f029f7fb70d9507212f445e24f3096c
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
Please reload this pagehttps://github.com/nodejs/node/pull/9207
https://github.com/addaleax
https://github.com/MylesBorins
https://github.com/jasnell
https://github.com/princejwesley
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.