| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:171944e8-a8f4-d703-9eea-c5adc97cca16 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 97D0:F5C1C:10DF65C:1775450:696A2BCA |
| html-safe-nonce | 15d51ad1b05370f28fbddb62cca4f1e724dac8f33a272056efb15e1b4ecabebc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0QwOkY1QzFDOjEwREY2NUM6MTc3NTQ1MDo2OTZBMkJDQSIsInZpc2l0b3JfaWQiOiI5MjE3ODQ5NjUxMjc4NTIzMzM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 543e2de009fc058ac470ac572eeb63fcee21b01f37d1a7b1554c34d83becbcd3 |
| hovercard-subject-tag | pull_request:90087120 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9192/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9b8d35595aa547398e2f33d9755e1031b643928ec2e6a8a2205ea13ea848e43e/nodejs/node/pull/9192 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9b8d35595aa547398e2f33d9755e1031b643928ec2e6a8a2205ea13ea848e43e/nodejs/node/pull/9192 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
deps
Description of change
Original commit message... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | matthewloring |
| hostname | github.com |
| expected-hostname | github.com |
| None | ade130928b3890d20ecf9c887468a17e88d5c9a740ea2a85c2c2162e7c58e623 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c00842167ca2e5b13e8171812965d503e925ece6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9192#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9192 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9192 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9192 |
| Reload | https://github.com/nodejs/node/pull/9192 |
| Reload | https://github.com/nodejs/node/pull/9192 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9192#issue-comment-box |
| matthewloring | https://github.com/matthewloring |
| nodejs:v6.x-staging | https://github.com/nodejs/node/tree/v6.x-staging |
|
deps: cherry-pick bb4974d from v8 upstream
| https://github.com/nodejs/node/pull/9192#top |
| matthewloring | https://github.com/matthewloring |
| nodejs:v6.x-staging | https://github.com/nodejs/node/tree/v6.x-staging |
|
Conversation
8
| https://github.com/nodejs/node/pull/9192 |
|
Commits
1
| https://github.com/nodejs/node/pull/9192/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9192/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9192/files |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/matthewloring |
| matthewloring | https://github.com/matthewloring |
| Oct 19, 2016 | https://github.com/nodejs/node/pull/9192#issue-184069434 |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
| chromium:641270 | https://bugs.chromium.org/p/chromium/issues/detail?id=641270 |
| https://codereview.chromium.org/2280943002 | https://codereview.chromium.org/2280943002 |
| #38940 | https://github.com/nodejs/node/issues/38940 |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x |
| Oct 19, 2016 | https://github.com/nodejs/node/pull/9192#event-829693798 |
| https://github.com/matthewloring |
| matthewloring | https://github.com/matthewloring |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
|
v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x |
|
v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x |
| Oct 19, 2016 | https://github.com/nodejs/node/pull/9192#event-829693976 |
| https://github.com/matthewloring |
| matthewloring | https://github.com/matthewloring |
| Oct 19, 2016 | https://github.com/nodejs/node/pull/9192#issuecomment-254935824 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/56368e3d2416c11b0969236fa4213bc9b3d6422d..8bb346d61a83a9283f7446eb20c291e4459be11c |
| 56368e3 | https://github.com/nodejs/node/commit/56368e3d2416c11b0969236fa4213bc9b3d6422d |
| 8bb346d | https://github.com/nodejs/node/commit/8bb346d61a83a9283f7446eb20c291e4459be11c |
|
Compare
| https://github.com/nodejs/node/compare/56368e3d2416c11b0969236fa4213bc9b3d6422d..8bb346d61a83a9283f7446eb20c291e4459be11c |
| October 19, 2016 22:23 | https://github.com/nodejs/node/pull/9192#event-829808867 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Oct 19, 2016 | https://github.com/nodejs/node/pull/9192#issuecomment-254971908 |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 20, 2016
| https://github.com/nodejs/node/pull/9192#pullrequestreview-5021827 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9192/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/9192#pullrequestreview-5021827 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
| deps: cherry-pick bb4974d from v8 upstream | https://github.com/nodejs/node/pull/9192/commits/a8e7b3725528b12fac915b634015bff2d7aba0df |
| a8e7b37 | https://github.com/nodejs/node/pull/9192/commits/a8e7b3725528b12fac915b634015bff2d7aba0df |
| chromium:641270 | https://bugs.chromium.org/p/chromium/issues/detail?id=641270 |
| https://codereview.chromium.org/2280943002 | https://codereview.chromium.org/2280943002 |
| #38940 | https://github.com/nodejs/node/issues/38940 |
| https://github.com/matthewloring |
| matthewloring | https://github.com/matthewloring |
| Oct 20, 2016 | https://github.com/nodejs/node/pull/9192#issuecomment-255197264 |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 20, 2016
| https://github.com/nodejs/node/pull/9192#pullrequestreview-5142950 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9192/files/a8e7b3725528b12fac915b634015bff2d7aba0df |
| https://github.com/matthewloring |
| matthewloring | https://github.com/matthewloring |
| Oct 20, 2016 | https://github.com/nodejs/node/pull/9192#issuecomment-255229149 |
| https://ci.nodejs.org/job/node-test-pull-request/4600/ | https://ci.nodejs.org/job/node-test-pull-request/4600/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/367/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/367/ |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
| https://github.com/matthewloring |
| matthewloring | https://github.com/matthewloring |
| Oct 20, 2016 | https://github.com/nodejs/node/pull/9192#issuecomment-255234346 |
| https://github.com/nodejs/node.git/branches/HEAD/deps/v8/ | https://github.com/nodejs/node.git/branches/HEAD/deps/v8/ |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
| https://github.com/matthewloring |
| matthewloring | https://github.com/matthewloring |
| Oct 20, 2016 | https://github.com/nodejs/node/pull/9192#issuecomment-255235398 |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 28, 2016
| https://github.com/nodejs/node/pull/9192#pullrequestreview-6274683 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9192/files/a8e7b3725528b12fac915b634015bff2d7aba0df |
| jasnell | https://github.com/jasnell |
|
Oct 28, 2016
| https://github.com/nodejs/node/pull/9192#ref-commit-0fcf249 |
|
| https://github.com/jasnell |
| deps: cherry-pick bb4974d from v8 upstream | https://github.com/nodejs/node/commit/0fcf249078fe58310e35b814f34872a47affe6ab |
| 0fcf249 | https://github.com/nodejs/node/commit/0fcf249078fe58310e35b814f34872a47affe6ab |
| chromium:641270 | https://bugs.chromium.org/p/chromium/issues/detail?id=641270 |
| https://codereview.chromium.org/2280943002 | https://codereview.chromium.org/2280943002 |
| #38940 | https://github.com/nodejs/node/issues/38940 |
| #9192 | https://github.com/nodejs/node/pull/9192 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9192#issuecomment-256965044 |
| 0fcf249 | https://github.com/nodejs/node/commit/0fcf249078fe58310e35b814f34872a47affe6ab |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/9192#event-840287257 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/9192#ref-pullrequest-190942302 |
|
v6.9.2 proposal
#9735
| https://github.com/nodejs/node/pull/9735 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9192 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/9192/files/a8e7b3725528b12fac915b634015bff2d7aba0df |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/9192/files/a8e7b3725528b12fac915b634015bff2d7aba0df |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/9192 |
|
| https://github.com/matthewloring |
|
| https://github.com/richardlau |
|
| https://github.com/jasnell |
|
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |