| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:01f3104e-689b-9d29-7de2-a0dc9dbf74b7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D5E2:16594C:8B3CC:B6BAA:696B5B6B |
| html-safe-nonce | 3210a6bce62c50c306e281de0be9e32f3be999ecd71ec79ce3df99822a80b147 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUUyOjE2NTk0Qzo4QjNDQzpCNkJBQTo2OTZCNUI2QiIsInZpc2l0b3JfaWQiOiI3OTc5ODI3MjUyMzUxOTQ5Njc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b8d8489089c009e2f9adfc8e5beaf64e0496704b29b62b2de2ba7a312f559c29 |
| hovercard-subject-tag | pull_request:89608797 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9130/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/59bb0351ba7ac212e6c5fa7461c0022936afd77b522dc5c8ec142ef111d2bb99/nodejs/node/pull/9130 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/59bb0351ba7ac212e6c5fa7461c0022936afd77b522dc5c8ec142ef111d2bb99/nodejs/node/pull/9130 |
| og:image:alt | Checklist
make -j8 test
commit message follows commit guidelines
Description of change
Ref: #8913
For some callbacks I made a change to arrow funtions and for _stream_readable there was a chang... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | maasencioh |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9130#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9130 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9130 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9130 |
| Reload | https://github.com/nodejs/node/pull/9130 |
| Reload | https://github.com/nodejs/node/pull/9130 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
690
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9130#issue-comment-box |
| maasencioh | https://github.com/maasencioh |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| maasencioh:name_stream | https://github.com/maasencioh/node/tree/name_stream |
|
stream: name anonymous functions
| https://github.com/nodejs/node/pull/9130#top |
| maasencioh | https://github.com/maasencioh |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| maasencioh:name_stream | https://github.com/maasencioh/node/tree/name_stream |
|
Conversation
48
| https://github.com/nodejs/node/pull/9130 |
|
Commits
2
| https://github.com/nodejs/node/pull/9130/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9130/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9130/files |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#issue-183395826 |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| #8913 | https://github.com/nodejs/node/issues/8913 |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#event-825803180 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#event-826136499 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2016
| https://github.com/nodejs/node/pull/9130#pullrequestreview-4509314 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| lib/_stream_transform.js | https://github.com/nodejs/node/pull/9130/files#diff-fb9af420b78b49112ef87b1ee1b5927d71b03ff05d5181f745c1540fd7dca367 |
| jasnell | https://github.com/jasnell |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#discussion_r83681862 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| targos | https://github.com/targos |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#discussion_r83691883 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2016
| https://github.com/nodejs/node/pull/9130#pullrequestreview-4509436 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| lib/_stream_wrap.js | https://github.com/nodejs/node/pull/9130/files#diff-3af6f98bae1fad16ef5fdbbd03b7167dc7eb04bac4cc0376fcf43f50f732da84 |
| jasnell | https://github.com/jasnell |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#discussion_r83681996 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| maasencioh | https://github.com/maasencioh |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#discussion_r83700022 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 17, 2016
| https://github.com/nodejs/node/pull/9130#pullrequestreview-4518241 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| lib/_stream_readable.js | https://github.com/nodejs/node/pull/9130/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7 |
| targos | https://github.com/targos |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#discussion_r83691115 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| maasencioh | https://github.com/maasencioh |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#discussion_r83720361 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| lib/_stream_transform.js | https://github.com/nodejs/node/pull/9130/files#diff-fb9af420b78b49112ef87b1ee1b5927d71b03ff05d5181f745c1540fd7dca367 |
| targos | https://github.com/targos |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#discussion_r83691883 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#issuecomment-254312142 |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| #9113 | https://github.com/nodejs/node/pull/9113 |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#issuecomment-254314407 |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Oct 17, 2016 | https://github.com/nodejs/node/pull/9130#issuecomment-254315515 |
| @maasencioh | https://github.com/maasencioh |
| #9113 | https://github.com/nodejs/node/pull/9113 |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| force-pushed | https://github.com/nodejs/node/compare/2d4565b8902db2d96785e821726ef7b6c947ccfa..5a048618de503f13575f985aeb6f3be0d3d58ca6 |
| 2d4565b | https://github.com/nodejs/node/commit/2d4565b8902db2d96785e821726ef7b6c947ccfa |
| 5a04861 | https://github.com/nodejs/node/commit/5a048618de503f13575f985aeb6f3be0d3d58ca6 |
|
Compare
| https://github.com/nodejs/node/compare/2d4565b8902db2d96785e821726ef7b6c947ccfa..5a048618de503f13575f985aeb6f3be0d3d58ca6 |
| October 18, 2016 13:31 | https://github.com/nodejs/node/pull/9130#event-827480662 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| Oct 18, 2016 | https://github.com/nodejs/node/pull/9130#issuecomment-254508594 |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| force-pushed | https://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0 |
| c133999 | https://github.com/nodejs/node/commit/c13399980463b0a8691ea2cff9191aa5aede8d0e |
| 83c7a88 | https://github.com/nodejs/node/commit/83c7a8897c644e1eadeaaace4863a822c73359a0 |
|
Compare
| https://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0 |
| October 18, 2016 17:02 | https://github.com/nodejs/node/pull/9130#event-827821086 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 24, 2016
| https://github.com/nodejs/node/pull/9130#pullrequestreview-5406316 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| lib/_stream_readable.js | https://github.com/nodejs/node/pull/9130/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7 |
| targos | https://github.com/targos |
| Oct 24, 2016 | https://github.com/nodejs/node/pull/9130#discussion_r84642629 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| force-pushed | https://github.com/nodejs/node/compare/5a048618de503f13575f985aeb6f3be0d3d58ca6..391412430473a1a77dc7e46cdb68a37173f7b2ac |
| 5a04861 | https://github.com/nodejs/node/commit/5a048618de503f13575f985aeb6f3be0d3d58ca6 |
| 3914124 | https://github.com/nodejs/node/commit/391412430473a1a77dc7e46cdb68a37173f7b2ac |
|
Compare
| https://github.com/nodejs/node/compare/5a048618de503f13575f985aeb6f3be0d3d58ca6..391412430473a1a77dc7e46cdb68a37173f7b2ac |
| October 24, 2016 08:55 | https://github.com/nodejs/node/pull/9130#event-833536504 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 24, 2016
| https://github.com/nodejs/node/pull/9130#pullrequestreview-5454945 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/9130#pullrequestreview-5454945 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 24, 2016
| https://github.com/nodejs/node/pull/9130#pullrequestreview-5461295 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 24, 2016 | https://github.com/nodejs/node/pull/9130#issuecomment-255758723 |
| https://ci.nodejs.org/job/node-test-pull-request/4639/ | https://ci.nodejs.org/job/node-test-pull-request/4639/ |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| Nov 3, 2016 | https://github.com/nodejs/node/pull/9130#issuecomment-258095602 |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/9130#issuecomment-259077266 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jan 17, 2017
| https://github.com/nodejs/node/pull/9130#pullrequestreview-16960046 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/9130#pullrequestreview-16960046 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| lib/_stream_wrap.js | https://github.com/nodejs/node/pull/9130/files#diff-3af6f98bae1fad16ef5fdbbd03b7167dc7eb04bac4cc0376fcf43f50f732da84 |
| mcollina | https://github.com/mcollina |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r96381580 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| lib/_stream_wrap.js | https://github.com/nodejs/node/pull/9130/files#diff-3af6f98bae1fad16ef5fdbbd03b7167dc7eb04bac4cc0376fcf43f50f732da84 |
| mcollina | https://github.com/mcollina |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r96381618 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| lib/_stream_wrap.js | https://github.com/nodejs/node/pull/9130/files#diff-3af6f98bae1fad16ef5fdbbd03b7167dc7eb04bac4cc0376fcf43f50f732da84 |
| mcollina | https://github.com/mcollina |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r96381768 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| lib/_stream_wrap.js | https://github.com/nodejs/node/pull/9130/files#diff-3af6f98bae1fad16ef5fdbbd03b7167dc7eb04bac4cc0376fcf43f50f732da84 |
| mcollina | https://github.com/mcollina |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r96381805 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| lib/_stream_wrap.js | https://github.com/nodejs/node/pull/9130/files#diff-3af6f98bae1fad16ef5fdbbd03b7167dc7eb04bac4cc0376fcf43f50f732da84 |
| mcollina | https://github.com/mcollina |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r96381934 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jan 26, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-275355089 |
| @maasencioh | https://github.com/maasencioh |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Jan 26, 2017 | https://github.com/nodejs/node/pull/9130#event-937542221 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-275886231 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/9130#pullrequestreview-18984503 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| lib/_stream_readable.js | https://github.com/nodejs/node/pull/9130/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7 |
| cjihrig | https://github.com/cjihrig |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r98342904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| maasencioh | https://github.com/maasencioh |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r98343207 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/9130#pullrequestreview-18984520 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| lib/_stream_readable.js | https://github.com/nodejs/node/pull/9130/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7 |
| cjihrig | https://github.com/cjihrig |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r98342929 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| maasencioh | https://github.com/maasencioh |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r98343271 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/9130#event-940515615 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/9130#pullrequestreview-18990968 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/9130#pullrequestreview-18990968 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| lib/_stream_writable.js | https://github.com/nodejs/node/pull/9130/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3 |
| mcollina | https://github.com/mcollina |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r98350652 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| lib/_stream_writable.js | https://github.com/nodejs/node/pull/9130/files#diff-a7fdfe149712099064db4e7b80a1b39e28515b4efb3fab2f4b9499ce3b7c51c3 |
| mcollina | https://github.com/mcollina |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r98350660 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| force-pushed | https://github.com/nodejs/node/compare/1372b18f07ca300e6b1ea5f3555693167d03622a..3b05cc436e52818833c8f9885e602e7a599bf124 |
| 1372b18 | https://github.com/nodejs/node/commit/1372b18f07ca300e6b1ea5f3555693167d03622a |
| 3b05cc4 | https://github.com/nodejs/node/commit/3b05cc436e52818833c8f9885e602e7a599bf124 |
|
Compare
| https://github.com/nodejs/node/compare/1372b18f07ca300e6b1ea5f3555693167d03622a..3b05cc436e52818833c8f9885e602e7a599bf124 |
| January 30, 2017 00:30 | https://github.com/nodejs/node/pull/9130#event-940725595 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-275959299 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/9130#pullrequestreview-19025765 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| lib/_stream_wrap.js | https://github.com/nodejs/node/pull/9130/files#diff-3af6f98bae1fad16ef5fdbbd03b7167dc7eb04bac4cc0376fcf43f50f732da84 |
| mcollina | https://github.com/mcollina |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r98387665 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| lib/_stream_wrap.js | https://github.com/nodejs/node/pull/9130/files#diff-3af6f98bae1fad16ef5fdbbd03b7167dc7eb04bac4cc0376fcf43f50f732da84 |
| mcollina | https://github.com/mcollina |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r98387690 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| lib/_stream_wrap.js | https://github.com/nodejs/node/pull/9130/files#diff-3af6f98bae1fad16ef5fdbbd03b7167dc7eb04bac4cc0376fcf43f50f732da84 |
| mcollina | https://github.com/mcollina |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r98387780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| lib/_stream_wrap.js | https://github.com/nodejs/node/pull/9130/files#diff-3af6f98bae1fad16ef5fdbbd03b7167dc7eb04bac4cc0376fcf43f50f732da84 |
| mcollina | https://github.com/mcollina |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r98387842 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-275995617 |
| https://ci.nodejs.org/job/node-test-pull-request/6102/ | https://ci.nodejs.org/job/node-test-pull-request/6102/ |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-275995750 |
| @maasencioh | https://github.com/maasencioh |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/targos |
| targos | https://github.com/targos |
| stale review | https://github.com/nodejs/node/pull/9130#pullrequestreview-5461295 |
| January 30, 2017 07:36 | https://github.com/nodejs/node/pull/9130#event-940920883 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| force-pushed | https://github.com/nodejs/node/compare/3b05cc436e52818833c8f9885e602e7a599bf124..ca695082c280bb87612457c3db41b6277c18c312 |
| 3b05cc4 | https://github.com/nodejs/node/commit/3b05cc436e52818833c8f9885e602e7a599bf124 |
| ca69508 | https://github.com/nodejs/node/commit/ca695082c280bb87612457c3db41b6277c18c312 |
|
Compare
| https://github.com/nodejs/node/compare/3b05cc436e52818833c8f9885e602e7a599bf124..ca695082c280bb87612457c3db41b6277c18c312 |
| February 1, 2017 23:26 | https://github.com/nodejs/node/pull/9130#event-945646590 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| Feb 1, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-276817817 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Feb 1, 2017
| https://github.com/nodejs/node/pull/9130#pullrequestreview-19685293 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| lib/_stream_readable.js | https://github.com/nodejs/node/pull/9130/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7 |
| TimothyGu | https://github.com/TimothyGu |
| Feb 1, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r99023502 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| maasencioh | https://github.com/maasencioh |
| Feb 3, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r99261667 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Feb 1, 2017
| https://github.com/nodejs/node/pull/9130#pullrequestreview-19685531 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files |
| lib/_stream_readable.js | https://github.com/nodejs/node/pull/9130/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7 |
| TimothyGu | https://github.com/TimothyGu |
| Feb 1, 2017 | https://github.com/nodejs/node/pull/9130#discussion_r99023726 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| force-pushed | https://github.com/nodejs/node/compare/b930d7b54284f1d47d01ce1307bf4ef777e8f1fe..c9d14dd4974c507eed75dcc07bad0677f77dd934 |
| b930d7b | https://github.com/nodejs/node/commit/b930d7b54284f1d47d01ce1307bf4ef777e8f1fe |
| c9d14dd | https://github.com/nodejs/node/commit/c9d14dd4974c507eed75dcc07bad0677f77dd934 |
|
Compare
| https://github.com/nodejs/node/compare/b930d7b54284f1d47d01ce1307bf4ef777e8f1fe..c9d14dd4974c507eed75dcc07bad0677f77dd934 |
| February 3, 2017 01:40 | https://github.com/nodejs/node/pull/9130#event-947446237 |
|
| https://github.com/maasencioh |
| stream: name anonymous functions | https://github.com/nodejs/node/pull/9130/commits/b7dc9128136d0fccd45c14268aaf061dc05a5196 |
| b7dc912 | https://github.com/nodejs/node/pull/9130/commits/b7dc9128136d0fccd45c14268aaf061dc05a5196 |
| nodejs#8913 | https://github.com/nodejs/node/issues/8913 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| force-pushed | https://github.com/nodejs/node/compare/a4307a17646d48db3b8aebc8e71dd93c799af1cd..b7dc9128136d0fccd45c14268aaf061dc05a5196 |
| a4307a1 | https://github.com/nodejs/node/commit/a4307a17646d48db3b8aebc8e71dd93c799af1cd |
| b7dc912 | https://github.com/nodejs/node/commit/b7dc9128136d0fccd45c14268aaf061dc05a5196 |
|
Compare
| https://github.com/nodejs/node/compare/a4307a17646d48db3b8aebc8e71dd93c799af1cd..b7dc9128136d0fccd45c14268aaf061dc05a5196 |
| February 3, 2017 01:53 | https://github.com/nodejs/node/pull/9130#event-947456835 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| Feb 20, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-281104382 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Feb 21, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-281263103 |
| @maasencioh | https://github.com/maasencioh |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
|
| https://github.com/maasencioh |
| stream: name anonymous functions | https://github.com/nodejs/node/pull/9130/commits/b5bc0411137b19e7dc0214c679413c3bc38bc497 |
| b5bc041 | https://github.com/nodejs/node/pull/9130/commits/b5bc0411137b19e7dc0214c679413c3bc38bc497 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Feb 24, 2017
| https://github.com/nodejs/node/pull/9130#pullrequestreview-23769399 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files/b5bc0411137b19e7dc0214c679413c3bc38bc497 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Feb 24, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-282354278 |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Feb 24, 2017
| https://github.com/nodejs/node/pull/9130#pullrequestreview-23778015 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9130/files/b5bc0411137b19e7dc0214c679413c3bc38bc497 |
| https://github.com/maasencioh |
| maasencioh | https://github.com/maasencioh |
| Feb 24, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-282438004 |
| @jasnell | https://github.com/jasnell |
| @mcollina | https://github.com/mcollina |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Feb 25, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-282473185 |
| @maasencioh | https://github.com/maasencioh |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| Feb 25, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-282474881 |
| @maasencioh | https://github.com/maasencioh |
| this example | https://github.com/nodejs/node/blob/fb71ba49212dd21c0404892b4bddc37437bd5397/lib/internal/url.js#L306 |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Mar 24, 2017 | https://github.com/nodejs/node/pull/9130#event-1015082916 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
| 16073c0 | https://github.com/nodejs/node/commit/16073c083efdcaf70aef1e490679457dd0f624bd |
| fbe946b | https://github.com/nodejs/node/commit/fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
|
Compare
| https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
| April 14, 2017 04:11 | https://github.com/nodejs/node/pull/9130#event-1042928538 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| May 26, 2017 | https://github.com/nodejs/node/pull/9130#issuecomment-304365556 |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| May 26, 2017 | https://github.com/nodejs/node/pull/9130#event-1099428947 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9130 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/9130/files/b5bc0411137b19e7dc0214c679413c3bc38bc497 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/9130/files/391412430473a1a77dc7e46cdb68a37173f7b2ac |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/9130/files/b5bc0411137b19e7dc0214c679413c3bc38bc497 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/9130/files/391412430473a1a77dc7e46cdb68a37173f7b2ac |
|
| https://github.com/TimothyGu |
|
TimothyGu
| https://github.com/TimothyGu |
|
| https://github.com/nodejs/node/pull/9130/files/b930d7b54284f1d47d01ce1307bf4ef777e8f1fe |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/9130 |
|
| https://github.com/maasencioh |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
|
| https://github.com/mcollina |
|
| https://github.com/TimothyGu |
|
| https://github.com/fhinkel |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |