| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:750ce518-946d-a613-54f5-de1be88342af |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9E7C:29131D:D406DD:12AFDF6:696A664B |
| html-safe-nonce | a37c0d91de8c032ee8dcee4a7dc42482cac4489c0feecf49836a94f2690ea69f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTdDOjI5MTMxRDpENDA2REQ6MTJBRkRGNjo2OTZBNjY0QiIsInZpc2l0b3JfaWQiOiI4MTk3NTIxNDYyMjA1NzY5MjkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d9c99f967e6e816ba014fde17d1465f3fd3c0908a18e130e0d0d7f49c4602b30 |
| hovercard-subject-tag | pull_request:88978133 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9053/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ac4a0b9f006c054592d18f9154b9fda7fa8503eb58f7ef96b04196ea911604d4/nodejs/node/pull/9053 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ac4a0b9f006c054592d18f9154b9fda7fa8503eb58f7ef96b04196ea911604d4/nodejs/node/pull/9053 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
build
Description of change
The config.gypi target ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9053#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9053 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9053 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9053 |
| Reload | https://github.com/nodejs/node/pull/9053 |
| Reload | https://github.com/nodejs/node/pull/9053 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9053#issue-comment-box |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:makefile-config.gypi-fix | https://github.com/danbev/node/tree/makefile-config.gypi-fix |
|
build: fix config.gypi target
| https://github.com/nodejs/node/pull/9053#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:makefile-config.gypi-fix | https://github.com/danbev/node/tree/makefile-config.gypi-fix |
|
Conversation
9
| https://github.com/nodejs/node/pull/9053 |
|
Commits
3
| https://github.com/nodejs/node/pull/9053/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9053/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9053/files |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 12, 2016 | https://github.com/nodejs/node/pull/9053#issue-182472174 |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
|
| https://github.com/danbev |
| build: fix config.gypi target | https://github.com/nodejs/node/pull/9053/commits/23914d070982670cd849ac99d37021e4c05f9baa |
| 23914d0 | https://github.com/nodejs/node/pull/9053/commits/23914d070982670cd849ac99d37021e4c05f9baa |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Oct 12, 2016 | https://github.com/nodejs/node/pull/9053#event-820677934 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 12, 2016 | https://github.com/nodejs/node/pull/9053#issuecomment-253158872 |
| https://ci.nodejs.org/job/node-test-pull-request/4486/ | https://ci.nodejs.org/job/node-test-pull-request/4486/ |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 12, 2016 | https://github.com/nodejs/node/pull/9053#issuecomment-253181811 |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 12, 2016 | https://github.com/nodejs/node/pull/9053#issuecomment-253184403 |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 12, 2016 | https://github.com/nodejs/node/pull/9053#issuecomment-253184730 |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
|
| https://github.com/danbev |
| add single error message for both missing and stale | https://github.com/nodejs/node/pull/9053/commits/75ec3fb37340120851f99caa76a2e2bbc11500cb |
| 75ec3fb | https://github.com/nodejs/node/pull/9053/commits/75ec3fb37340120851f99caa76a2e2bbc11500cb |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 12, 2016 | https://github.com/nodejs/node/pull/9053#issuecomment-253185907 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 12, 2016
| https://github.com/nodejs/node/pull/9053#pullrequestreview-3853178 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9053/files/75ec3fb37340120851f99caa76a2e2bbc11500cb |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/9053#pullrequestreview-3853178 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
| Makefile | https://github.com/nodejs/node/pull/9053/files/75ec3fb37340120851f99caa76a2e2bbc11500cb#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 12, 2016 | https://github.com/nodejs/node/pull/9053#discussion_r82984628 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
| danbev | https://github.com/danbev |
| Oct 12, 2016 | https://github.com/nodejs/node/pull/9053#discussion_r82985004 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
|
| https://github.com/danbev |
| correct error message for both Missing/Stale config.gypi | https://github.com/nodejs/node/pull/9053/commits/2a093fd387f4ac4a46ad0c142b4a934de775fbba |
| 2a093fd | https://github.com/nodejs/node/pull/9053/commits/2a093fd387f4ac4a46ad0c142b4a934de775fbba |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Oct 12, 2016
| https://github.com/nodejs/node/pull/9053#pullrequestreview-3856110 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9053/files/2a093fd387f4ac4a46ad0c142b4a934de775fbba |
| danbev | https://github.com/danbev |
|
Oct 14, 2016
| https://github.com/nodejs/node/pull/9053#ref-commit-0ed6338 |
|
| https://github.com/danbev |
| build: fix config.gypi target | https://github.com/danbev/node/commit/0ed633801671af95c0dad1d1320b230ecbef6483 |
| 0ed6338 | https://github.com/danbev/node/commit/0ed633801671af95c0dad1d1320b230ecbef6483 |
| nodejs#9053 | https://github.com/nodejs/node/pull/9053 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 14, 2016 | https://github.com/nodejs/node/pull/9053#issuecomment-253714530 |
| 0ed6338 | https://github.com/nodejs/node/commit/0ed633801671af95c0dad1d1320b230ecbef6483 |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 14, 2016 | https://github.com/nodejs/node/pull/9053#event-823513001 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| October 14, 2016 05:44 | https://github.com/nodejs/node/pull/9053#event-823513407 |
| jasnell | https://github.com/jasnell |
|
Oct 14, 2016
| https://github.com/nodejs/node/pull/9053#ref-commit-c5f5bcb |
|
| https://github.com/danbev |
|
| https://github.com/jasnell |
| build: fix config.gypi target | https://github.com/nodejs/node/commit/c5f5bcb331a5b718e25b8ed9f789ff1c3c0efcb2 |
| c5f5bcb | https://github.com/nodejs/node/commit/c5f5bcb331a5b718e25b8ed9f789ff1c3c0efcb2 |
| #9053 | https://github.com/nodejs/node/pull/9053 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 11, 2016
| https://github.com/nodejs/node/pull/9053#ref-commit-9de8cfe |
|
| https://github.com/danbev |
| build: fix config.gypi target | https://github.com/nodejs/node/commit/9de8cfecd91818638e400d1a72f4c227ac8e5540 |
| 9de8cfe | https://github.com/nodejs/node/commit/9de8cfecd91818638e400d1a72f4c227ac8e5540 |
| #9053 | https://github.com/nodejs/node/pull/9053 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 11, 2016
| https://github.com/nodejs/node/pull/9053#ref-commit-4de7a6e |
|
| https://github.com/danbev |
| build: fix config.gypi target | https://github.com/nodejs/node/commit/4de7a6e2919dd640bbfeeb1b1c91c20976e5a792 |
| 4de7a6e | https://github.com/nodejs/node/commit/4de7a6e2919dd640bbfeeb1b1c91c20976e5a792 |
| #9053 | https://github.com/nodejs/node/pull/9053 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Nov 11, 2016 | https://github.com/nodejs/node/pull/9053#event-856345232 |
|
v6.9.2 proposal
#9735
| https://github.com/nodejs/node/pull/9735 |
|
v4.7.0 proposal
#9736
| https://github.com/nodejs/node/pull/9736 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9053 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/9053/files/75ec3fb37340120851f99caa76a2e2bbc11500cb |
|
| https://github.com/gibfahn |
|
gibfahn
| https://github.com/gibfahn |
|
| https://github.com/nodejs/node/pull/9053/files/2a093fd387f4ac4a46ad0c142b4a934de775fbba |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Please reload this page | https://github.com/nodejs/node/pull/9053 |
|
| https://github.com/danbev |
|
| https://github.com/bnoordhuis |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |