René's URL Explorer Experiment


Title: readline: use icu based string width calculation by jasnell · Pull Request #9040 · nodejs/node · GitHub

Open Graph Title: readline: use icu based string width calculation by jasnell · Pull Request #9040 · nodejs/node

X Title: readline: use icu based string width calculation by jasnell · Pull Request #9040 · nodejs/node

Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) readline, inter...

Open Graph Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) readline, inter...

X Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) readline, inter...

Mail addresses
notifications@github.com
notifications@github.com

Opengraph URL: https://github.com/nodejs/node/pull/9040

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cfc0bf25-ed84-e34b-e25e-e65515fc3ff5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF76:31EA40:D0A027:11E064E:6969F3E1
html-safe-nonce2f916255bca12c343670187c29ddee83c22ced8710b2cc5b74efc7e71d982b23
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjc2OjMxRUE0MDpEMEEwMjc6MTFFMDY0RTo2OTY5RjNFMSIsInZpc2l0b3JfaWQiOiIxMTQ4MzMzMjcwMTIyNDkyODk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfcdd1d2e6d526047f32e6846f69832720d3171a7b801d783d85bdc83891138d8
hovercard-subject-tagpull_request:88922310
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9040/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fda992ceae1aadfe02efeb81fe6c71cafe9df590eaafa9c838d5602e3e27bd19/nodejs/node/pull/9040
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fda992ceae1aadfe02efeb81fe6c71cafe9df590eaafa9c838d5602e3e27bd19/nodejs/node/pull/9040
og:image:altChecklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) readline, inter...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/9040#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9040
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9040
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/9040
Reloadhttps://github.com/nodejs/node/pull/9040
Reloadhttps://github.com/nodejs/node/pull/9040
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/9040
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/9040
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/9040#issue-comment-box
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:icu-stringwidthhttps://github.com/jasnell/node/tree/icu-stringwidth
readline: use icu based string width calculation https://github.com/nodejs/node/pull/9040#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:icu-stringwidthhttps://github.com/jasnell/node/tree/icu-stringwidth
Conversation 49 https://github.com/nodejs/node/pull/9040
Commits 1 https://github.com/nodejs/node/pull/9040/commits
Checks 0 https://github.com/nodejs/node/pull/9040/checks
Files changed https://github.com/nodejs/node/pull/9040/files
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 11, 2016https://github.com/nodejs/node/pull/9040#issue-182389915
#8075https://github.com/nodejs/node/pull/8075
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
Oct 11, 2016https://github.com/nodejs/node/pull/9040#event-820216826
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Oct 11, 2016https://github.com/nodejs/node/pull/9040#event-820216870
https://github.com/jasnell
jasnellhttps://github.com/jasnell
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Oct 11, 2016https://github.com/nodejs/node/pull/9040#event-820231961
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 11, 2016https://github.com/nodejs/node/pull/9040#issuecomment-253068302
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 12, 2016https://github.com/nodejs/node/pull/9040#issuecomment-253103774
https://ci.nodejs.org/job/node-test-pull-request/4484/https://ci.nodejs.org/job/node-test-pull-request/4484/
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 12, 2016 https://github.com/nodejs/node/pull/9040#ref-issue-155464678
Add --without-intl builds to CI matrix nodejs/build#419 https://github.com/nodejs/build/issues/419
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 12, 2016https://github.com/nodejs/node/pull/9040#issuecomment-253156327
nodejs/build#419https://github.com/nodejs/build/issues/419
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 12, 2016https://github.com/nodejs/node/pull/9040#issuecomment-253215894
nodejs/build#419https://github.com/nodejs/build/issues/419
nodejs/build#419https://github.com/nodejs/build/issues/419
#9040 (comment)https://github.com/nodejs/node/pull/9040#issuecomment-253156327
https://github.com/notifications/unsubscribe-auth/AAa2eTOFILRRLZmfbAkdyGUaprCAOECaks5qzJ_XgaJpZM4KUK7Uhttps://github.com/notifications/unsubscribe-auth/AAa2eTOFILRRLZmfbAkdyGUaprCAOECaks5qzJ_XgaJpZM4KUK7U
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 12, 2016https://github.com/nodejs/node/pull/9040#issuecomment-253220380
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 12, 2016https://github.com/nodejs/node/pull/9040#issuecomment-253243109
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 13, 2016 https://github.com/nodejs/node/pull/9040#pullrequestreview-4080989
View reviewed changes https://github.com/nodejs/node/pull/9040/files
lib/internal/readline.jshttps://github.com/nodejs/node/pull/9040/files#diff-53d192d436f201caf29dfcddd0efa58f7b006bbf707948d7314d2851fdc3dd1c
Fishrock123https://github.com/Fishrock123
Oct 13, 2016https://github.com/nodejs/node/pull/9040#discussion_r83224733
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
jasnellhttps://github.com/jasnell
Oct 21, 2016https://github.com/nodejs/node/pull/9040#discussion_r84516176
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
lib/internal/readline.jshttps://github.com/nodejs/node/pull/9040/files#diff-53d192d436f201caf29dfcddd0efa58f7b006bbf707948d7314d2851fdc3dd1c
Fishrock123https://github.com/Fishrock123
Oct 13, 2016https://github.com/nodejs/node/pull/9040#discussion_r83225144
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
jasnellhttps://github.com/jasnell
Oct 21, 2016https://github.com/nodejs/node/pull/9040#discussion_r84515880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
lib/internal/readline.jshttps://github.com/nodejs/node/pull/9040/files#diff-53d192d436f201caf29dfcddd0efa58f7b006bbf707948d7314d2851fdc3dd1c
Fishrock123https://github.com/Fishrock123
Oct 13, 2016https://github.com/nodejs/node/pull/9040#discussion_r83225332
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
jasnellhttps://github.com/jasnell
Oct 21, 2016https://github.com/nodejs/node/pull/9040#discussion_r84515943
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
lib/internal/readline.jshttps://github.com/nodejs/node/pull/9040/files#diff-53d192d436f201caf29dfcddd0efa58f7b006bbf707948d7314d2851fdc3dd1c
Fishrock123https://github.com/Fishrock123
Oct 13, 2016https://github.com/nodejs/node/pull/9040#discussion_r83225648
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
lib/readline.jshttps://github.com/nodejs/node/pull/9040/files#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
Fishrock123https://github.com/Fishrock123
Oct 13, 2016https://github.com/nodejs/node/pull/9040#discussion_r83225961
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
jasnellhttps://github.com/jasnell
Oct 21, 2016https://github.com/nodejs/node/pull/9040#discussion_r84516275
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/rvagg
rvagghttps://github.com/rvagg
force-pushedhttps://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0
c133999https://github.com/nodejs/node/commit/c13399980463b0a8691ea2cff9191aa5aede8d0e
83c7a88https://github.com/nodejs/node/commit/83c7a8897c644e1eadeaaace4863a822c73359a0
Compare https://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0
October 18, 2016 17:02https://github.com/nodejs/node/pull/9040#event-827820922
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/cc56bd3292a06e5af191d04270d08e3ab1f3fd2a..5e5522c67788fd23369106fed324971677ed3f1c
cc56bd3https://github.com/nodejs/node/commit/cc56bd3292a06e5af191d04270d08e3ab1f3fd2a
5e5522chttps://github.com/nodejs/node/commit/5e5522c67788fd23369106fed324971677ed3f1c
Compare https://github.com/nodejs/node/compare/cc56bd3292a06e5af191d04270d08e3ab1f3fd2a..5e5522c67788fd23369106fed324971677ed3f1c
October 21, 2016 20:58https://github.com/nodejs/node/pull/9040#event-832496115
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 21, 2016https://github.com/nodejs/node/pull/9040#issuecomment-255463995
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://ci.nodejs.org/job/node-test-pull-request/4611/https://ci.nodejs.org/job/node-test-pull-request/4611/
https://ci.nodejs.org/job/node-test-pull-request/4619/https://ci.nodejs.org/job/node-test-pull-request/4619/
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/5e5522c67788fd23369106fed324971677ed3f1c..bf886f8e879342e3309ef2093d56fc11eec7f882
5e5522chttps://github.com/nodejs/node/commit/5e5522c67788fd23369106fed324971677ed3f1c
bf886f8https://github.com/nodejs/node/commit/bf886f8e879342e3309ef2093d56fc11eec7f882
Compare https://github.com/nodejs/node/compare/5e5522c67788fd23369106fed324971677ed3f1c..bf886f8e879342e3309ef2093d56fc11eec7f882
October 21, 2016 21:39https://github.com/nodejs/node/pull/9040#event-832539259
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 22, 2016https://github.com/nodejs/node/pull/9040#issuecomment-255534670
@trevnorrishttps://github.com/trevnorris
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 23, 2016 https://github.com/nodejs/node/pull/9040#pullrequestreview-5363165
View reviewed changes https://github.com/nodejs/node/pull/9040/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/9040#pullrequestreview-5363165
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
lib/internal/readline.jshttps://github.com/nodejs/node/pull/9040/files#diff-53d192d436f201caf29dfcddd0efa58f7b006bbf707948d7314d2851fdc3dd1c
bnoordhuishttps://github.com/bnoordhuis
Oct 23, 2016https://github.com/nodejs/node/pull/9040#discussion_r84593539
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
jasnellhttps://github.com/jasnell
Oct 23, 2016https://github.com/nodejs/node/pull/9040#discussion_r84597191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
bnoordhuishttps://github.com/bnoordhuis
Oct 23, 2016https://github.com/nodejs/node/pull/9040#discussion_r84593605
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
bnoordhuishttps://github.com/bnoordhuis
Oct 23, 2016https://github.com/nodejs/node/pull/9040#discussion_r84593611
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
bnoordhuishttps://github.com/bnoordhuis
Oct 23, 2016https://github.com/nodejs/node/pull/9040#discussion_r84593627
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
bnoordhuishttps://github.com/bnoordhuis
Oct 23, 2016https://github.com/nodejs/node/pull/9040#discussion_r84593629
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
bnoordhuishttps://github.com/bnoordhuis
Oct 23, 2016https://github.com/nodejs/node/pull/9040#discussion_r84593636
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
bnoordhuishttps://github.com/bnoordhuis
Oct 23, 2016https://github.com/nodejs/node/pull/9040#discussion_r84593645
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
bnoordhuishttps://github.com/bnoordhuis
Oct 23, 2016https://github.com/nodejs/node/pull/9040#discussion_r84593668
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 23, 2016https://github.com/nodejs/node/pull/9040#issuecomment-255594114
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 23, 2016https://github.com/nodejs/node/pull/9040#issuecomment-255602200
@bnoordhuishttps://github.com/bnoordhuis
https://ci.nodejs.org/job/node-test-commit-linux-nointl/1/https://ci.nodejs.org/job/node-test-commit-linux-nointl/1/
@jbergstroemhttps://github.com/jbergstroem
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
Oct 23, 2016https://github.com/nodejs/node/pull/9040#issuecomment-255607019
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
bnoordhuishttps://github.com/bnoordhuis
stale reviewhttps://github.com/nodejs/node/pull/9040#pullrequestreview-5363165
October 24, 2016 14:18https://github.com/nodejs/node/pull/9040#event-833933479
@bnoordhuishttps://github.com/bnoordhuis
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 24, 2016 https://github.com/nodejs/node/pull/9040#pullrequestreview-5526868
View reviewed changes https://github.com/nodejs/node/pull/9040/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/9040#pullrequestreview-5526868
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
bnoordhuishttps://github.com/bnoordhuis
Oct 24, 2016https://github.com/nodejs/node/pull/9040#discussion_r84770097
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
bnoordhuishttps://github.com/bnoordhuis
Oct 24, 2016https://github.com/nodejs/node/pull/9040#discussion_r84770586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/srl295
srl295https://github.com/srl295
Oct 24, 2016 https://github.com/nodejs/node/pull/9040#pullrequestreview-5542970
View reviewed changes https://github.com/nodejs/node/pull/9040/files
srl295https://github.com/srl295
https://github.com/nodejs/node/pull/9040#pullrequestreview-5542970
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
srl295https://github.com/srl295
Oct 24, 2016https://github.com/nodejs/node/pull/9040#discussion_r84787428
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
srl295https://github.com/srl295
Oct 24, 2016https://github.com/nodejs/node/pull/9040#discussion_r84787572
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9040
src/node_i18n.cchttps://github.com/nodejs/node/pull/9040/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
srl295https://github.com/srl295
Oct 24, 2016https://github.com/nodejs/node/pull/9040#discussion_r84787967
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
http://www.unicode.org/reports/tr11/#Ambiguoushttp://www.unicode.org/reports/tr11/#Ambiguous
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/5dcbf747d10b4507812e106d1cccdce6e76646ae..924eef30e9823ae0160d417cfc62f4fceb67cc8b
5dcbf74https://github.com/nodejs/node/commit/5dcbf747d10b4507812e106d1cccdce6e76646ae
924eef3https://github.com/nodejs/node/commit/924eef30e9823ae0160d417cfc62f4fceb67cc8b
Compare https://github.com/nodejs/node/compare/5dcbf747d10b4507812e106d1cccdce6e76646ae..924eef30e9823ae0160d417cfc62f4fceb67cc8b
October 24, 2016 23:41https://github.com/nodejs/node/pull/9040#event-834700123
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 24, 2016https://github.com/nodejs/node/pull/9040#issuecomment-255896717
https://ci.nodejs.org/job/node-test-pull-request/4655/https://ci.nodejs.org/job/node-test-pull-request/4655/
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/924eef30e9823ae0160d417cfc62f4fceb67cc8b..518c711911b1e3f56324120fb88c58f115a53150
924eef3https://github.com/nodejs/node/commit/924eef30e9823ae0160d417cfc62f4fceb67cc8b
518c711https://github.com/nodejs/node/commit/518c711911b1e3f56324120fb88c58f115a53150
Compare https://github.com/nodejs/node/compare/924eef30e9823ae0160d417cfc62f4fceb67cc8b..518c711911b1e3f56324120fb88c58f115a53150
October 25, 2016 15:24https://github.com/nodejs/node/pull/9040#event-835644551
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 25, 2016https://github.com/nodejs/node/pull/9040#issuecomment-256068282
https://ci.nodejs.org/job/node-test-pull-request/4664/https://ci.nodejs.org/job/node-test-pull-request/4664/
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
readline: use icu based string width calculationhttps://github.com/nodejs/node/pull/9040/commits/876bb836cd463b79087e9436bee0ca9406991cbd
876bb83https://github.com/nodejs/node/pull/9040/commits/876bb836cd463b79087e9436bee0ca9406991cbd
nodejs#8075https://github.com/nodejs/node/pull/8075
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/518c711911b1e3f56324120fb88c58f115a53150..876bb836cd463b79087e9436bee0ca9406991cbd
518c711https://github.com/nodejs/node/commit/518c711911b1e3f56324120fb88c58f115a53150
876bb83https://github.com/nodejs/node/commit/876bb836cd463b79087e9436bee0ca9406991cbd
Compare https://github.com/nodejs/node/compare/518c711911b1e3f56324120fb88c58f115a53150..876bb836cd463b79087e9436bee0ca9406991cbd
October 25, 2016 15:51https://github.com/nodejs/node/pull/9040#event-835692081
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 25, 2016https://github.com/nodejs/node/pull/9040#issuecomment-256078824
Please reload this pagehttps://github.com/nodejs/node/pull/9040
jasnellhttps://github.com/jasnell
Oct 25, 2016 https://github.com/nodejs/node/pull/9040#ref-commit-72547fe
https://github.com/jasnell
readline: use icu based string width calculationhttps://github.com/nodejs/node/commit/72547fe28de95be435789716e0fd970e66c58477
72547fehttps://github.com/nodejs/node/commit/72547fe28de95be435789716e0fd970e66c58477
#8075https://github.com/nodejs/node/pull/8075
#9040https://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 25, 2016https://github.com/nodejs/node/pull/9040#issuecomment-256079641
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 25, 2016https://github.com/nodejs/node/pull/9040#event-835708808
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 25, 2016https://github.com/nodejs/node/pull/9040#issuecomment-256122035
@jasnellhttps://github.com/jasnell
https://github.com/jasnellhttps://github.com/jasnell
#9040 (comment)https://github.com/nodejs/node/pull/9040#issuecomment-255607019
https://github.com/notifications/unsubscribe-auth/AAa2eSj8DXEb45zGppZSrbdxdlcyksZkks5q2650gaJpZM4KUK7Uhttps://github.com/notifications/unsubscribe-auth/AAa2eSj8DXEb45zGppZSrbdxdlcyksZkks5q2650gaJpZM4KUK7U
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 25, 2016https://github.com/nodejs/node/pull/9040#issuecomment-256135391
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 25, 2016https://github.com/nodejs/node/pull/9040#issuecomment-256136510
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/srl295
srl295https://github.com/srl295
Oct 25, 2016https://github.com/nodejs/node/pull/9040#issuecomment-256154798
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 25, 2016https://github.com/nodejs/node/pull/9040#issuecomment-256166959
#9280https://github.com/nodejs/node/pull/9280
Please reload this pagehttps://github.com/nodejs/node/pull/9040
evanlucashttps://github.com/evanlucas
Nov 3, 2016 https://github.com/nodejs/node/pull/9040#ref-commit-a5c62cb
https://github.com/jasnell
https://github.com/evanlucas
readline: use icu based string width calculationhttps://github.com/nodejs/node/commit/a5c62cb4f2d8e19aabc92fef852b4efda4ea7a66
a5c62cbhttps://github.com/nodejs/node/commit/a5c62cb4f2d8e19aabc92fef852b4efda4ea7a66
#8075https://github.com/nodejs/node/pull/8075
#9040https://github.com/nodejs/node/pull/9040
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Nov 3, 2016 https://github.com/nodejs/node/pull/9040#ref-pullrequest-187029471
v7.1.0 proposal - 2016-11-08 #9438 https://github.com/nodejs/node/pull/9438
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Apr 24, 2017 https://github.com/nodejs/node/pull/9040#ref-issue-215046096
Potential Semver Minor Backports nodejs/Release#188 https://github.com/nodejs/Release/issues/188
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 15, 2017https://github.com/nodejs/node/pull/9040#issuecomment-301500114
@srl295https://github.com/srl295
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 15, 2017https://github.com/nodejs/node/pull/9040#issuecomment-301502989
@srl295https://github.com/srl295
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
May 16, 2017https://github.com/nodejs/node/pull/9040#event-1084615817
https://github.com/srl295
srl295https://github.com/srl295
Aug 31, 2017https://github.com/nodejs/node/pull/9040#issuecomment-326379285
Please reload this pagehttps://github.com/nodejs/node/pull/9040
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9040
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/9040/files/5dcbf747d10b4507812e106d1cccdce6e76646ae
https://github.com/srl295
srl295 https://github.com/srl295
https://github.com/nodejs/node/pull/9040/files/5dcbf747d10b4507812e106d1cccdce6e76646ae
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/9040/files/cc56bd3292a06e5af191d04270d08e3ab1f3fd2a
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/9040
https://github.com/jasnell
https://github.com/bnoordhuis
https://github.com/jbergstroem
https://github.com/srl295
https://github.com/MylesBorins
https://github.com/Fishrock123
https://github.com/gibfahn
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.