René's URL Explorer Experiment


Title: tls: copy the Buffer object before using (backport to v4.x) by MylesBorins · Pull Request #9016 · nodejs/node · GitHub

Open Graph Title: tls: copy the Buffer object before using (backport to v4.x) by MylesBorins · Pull Request #9016 · nodejs/node

X Title: tls: copy the Buffer object before using (backport to v4.x) by MylesBorins · Pull Request #9016 · nodejs/node

Description: This is a backport of #8055 There was quite a bit of difference between this and the original so I would like to get sign off from @thefourtheye or @jasnell that this is doing what is should be doing.

Open Graph Description: This is a backport of #8055 There was quite a bit of difference between this and the original so I would like to get sign off from @thefourtheye or @jasnell that this is doing what is should be doing.

X Description: This is a backport of #8055 There was quite a bit of difference between this and the original so I would like to get sign off from @thefourtheye or @jasnell that this is doing what is should be doing.

Opengraph URL: https://github.com/nodejs/node/pull/9016

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:404be685-a83c-aab9-c759-81da145bd81f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA2E:B8A9A:1A61BE7:2531C59:696A53A5
html-safe-noncee7ba2451022b23251108ec3b2f1aafcd8ca39991762a5413faa73ba723e463e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTJFOkI4QTlBOjFBNjFCRTc6MjUzMUM1OTo2OTZBNTNBNSIsInZpc2l0b3JfaWQiOiIxMDgxNjMxOTk0MjIzOTQwNTE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2a2b9623d73041da65c39c21c92a8d9fce9e815d1d71486580124a82eace0faf
hovercard-subject-tagpull_request:88744717
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9016/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/adf789b569db6c79cb0a095741df1e3f1b6c5bb6cf22356588962f30f17197dd/nodejs/node/pull/9016
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/adf789b569db6c79cb0a095741df1e3f1b6c5bb6cf22356588962f30f17197dd/nodejs/node/pull/9016
og:image:altThis is a backport of #8055 There was quite a bit of difference between this and the original so I would like to get sign off from @thefourtheye or @jasnell that this is doing what is should be doing.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMylesBorins
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/9016#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9016
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9016
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/9016
Reloadhttps://github.com/nodejs/node/pull/9016
Reloadhttps://github.com/nodejs/node/pull/9016
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/9016
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/9016
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/9016#issue-comment-box
MylesBorinshttps://github.com/MylesBorins
nodejs:v4.x-staginghttps://github.com/nodejs/node/tree/v4.x-staging
MylesBorins:backport-8055https://github.com/MylesBorins/node/tree/backport-8055
tls: copy the Buffer object before using (backport to v4.x) https://github.com/nodejs/node/pull/9016#top
MylesBorinshttps://github.com/MylesBorins
nodejs:v4.x-staginghttps://github.com/nodejs/node/tree/v4.x-staging
MylesBorins:backport-8055https://github.com/MylesBorins/node/tree/backport-8055
Conversation 4 https://github.com/nodejs/node/pull/9016
Commits 1 https://github.com/nodejs/node/pull/9016/commits
Checks 0 https://github.com/nodejs/node/pull/9016/checks
Files changed https://github.com/nodejs/node/pull/9016/files
Please reload this pagehttps://github.com/nodejs/node/pull/9016
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 10, 2016https://github.com/nodejs/node/pull/9016#issue-182134708
#8055https://github.com/nodejs/node/pull/8055
@thefourtheyehttps://github.com/thefourtheye
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/9016
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av4.x
Oct 10, 2016https://github.com/nodejs/node/pull/9016#event-818732379
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av4.x
Oct 10, 2016https://github.com/nodejs/node/pull/9016#event-818732424
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 11, 2016 https://github.com/nodejs/node/pull/9016#pullrequestreview-3695924
View reviewed changes https://github.com/nodejs/node/pull/9016/files
lib/tls.jshttps://github.com/nodejs/node/pull/9016/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
thefourtheyehttps://github.com/thefourtheye
Oct 11, 2016https://github.com/nodejs/node/pull/9016#discussion_r82815234
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9016
MylesBorinshttps://github.com/MylesBorins
Oct 11, 2016https://github.com/nodejs/node/pull/9016#discussion_r82828950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9016
https://github.com/thefourtheye
tls: copy the Buffer object before usinghttps://github.com/nodejs/node/pull/9016/commits/28474903e7343cab767029dc88e8c97769aaecf2
2847490https://github.com/nodejs/node/pull/9016/commits/28474903e7343cab767029dc88e8c97769aaecf2
nodejs#8055https://github.com/nodejs/node/pull/8055
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/fe12577f1ec922d43f1598ef598e3691b408ca37..28474903e7343cab767029dc88e8c97769aaecf2
fe12577https://github.com/nodejs/node/commit/fe12577f1ec922d43f1598ef598e3691b408ca37
2847490https://github.com/nodejs/node/commit/28474903e7343cab767029dc88e8c97769aaecf2
Compare https://github.com/nodejs/node/compare/fe12577f1ec922d43f1598ef598e3691b408ca37..28474903e7343cab767029dc88e8c97769aaecf2
October 11, 2016 16:08https://github.com/nodejs/node/pull/9016#event-819723279
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 11, 2016 https://github.com/nodejs/node/pull/9016#pullrequestreview-3710659
View reviewed changes https://github.com/nodejs/node/pull/9016/files/28474903e7343cab767029dc88e8c97769aaecf2
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 11, 2016 https://github.com/nodejs/node/pull/9016#pullrequestreview-3710707
View reviewed changes https://github.com/nodejs/node/pull/9016/files/28474903e7343cab767029dc88e8c97769aaecf2
thefourtheyehttps://github.com/thefourtheye
https://github.com/nodejs/node/pull/9016#pullrequestreview-3710707
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9016
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 11, 2016 https://github.com/nodejs/node/pull/9016#pullrequestreview-3720269
View reviewed changes https://github.com/nodejs/node/pull/9016/files/28474903e7343cab767029dc88e8c97769aaecf2
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/9016#pullrequestreview-3720269
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/9016
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
2847490https://github.com/nodejs/node/commit/28474903e7343cab767029dc88e8c97769aaecf2
Oct 11, 2016https://github.com/nodejs/node/pull/9016#event-819865203
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
October 11, 2016 18:57https://github.com/nodejs/node/pull/9016#event-819957876
https://github.com/aliscco
alisccohttps://github.com/aliscco
Dec 1, 2023 https://github.com/nodejs/node/pull/9016#ref-pullrequest-2019804902
[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#903 https://github.com/aliscco/alisco-node/pull/903
https://github.com/leonardoadame
leonardoadamehttps://github.com/leonardoadame
Dec 3, 2023 https://github.com/nodejs/node/pull/9016#ref-pullrequest-2022613735
[Snyk] Fix for 1 vulnerabilities leonardoadame/node#508 https://github.com/leonardoadame/node/pull/508
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9016
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/9016/files/28474903e7343cab767029dc88e8c97769aaecf2
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/9016/files/28474903e7343cab767029dc88e8c97769aaecf2
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/9016
https://github.com/MylesBorins
https://github.com/jasnell
https://github.com/thefourtheye
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.