| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:02c2a53d-a4c5-497d-4721-122c4fde86af |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DDE2:297F82:2373482:3048A5A:696AD311 |
| html-safe-nonce | 253d1d61edccfabe51c7c8ddf7da00d3e9caf40ea0af15dfcee41cd3b7095f3b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREUyOjI5N0Y4MjoyMzczNDgyOjMwNDhBNUE6Njk2QUQzMTEiLCJ2aXNpdG9yX2lkIjoiNzU3NDQxMjYxNDgzMzk4NDI3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 20f17c646bed5658ad5928c4376e88b51d60e6eeedcd486d98aaa389140f6f44 |
| hovercard-subject-tag | pull_request:88329639 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8960/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/26a62ae8423d8e7c29175e68178cd4a35da365cdc0959e227d9802a97d0da846/nodejs/node/pull/8960 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/26a62ae8423d8e7c29175e68178cd4a35da365cdc0959e227d9802a97d0da846/nodejs/node/pull/8960 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines
Affected core subsystem(s)
test
Descriptio... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | c785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c718a376fcf780eb22089171adb84a543f660bf7 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8960#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8960 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8960 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8960 |
| Reload | https://github.com/nodejs/node/pull/8960 |
| Reload | https://github.com/nodejs/node/pull/8960 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8960 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/8960 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/8960#issue-comment-box |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:killsignal | https://github.com/cjihrig/node/tree/killsignal |
|
test: add coverage for spawnSync() killSignal
| https://github.com/nodejs/node/pull/8960#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:killsignal | https://github.com/cjihrig/node/tree/killsignal |
|
Conversation
5
| https://github.com/nodejs/node/pull/8960 |
|
Commits
1
| https://github.com/nodejs/node/pull/8960/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/8960/checks |
|
Files changed
| https://github.com/nodejs/node/pull/8960/files |
| Please reload this page | https://github.com/nodejs/node/pull/8960 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8960#issue-181509874 |
| https://node-core-coverage.addaleax.net/ | https://node-core-coverage.addaleax.net/ |
| Please reload this page | https://github.com/nodejs/node/pull/8960 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8960#event-815311478 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 6, 2016
| https://github.com/nodejs/node/pull/8960#pullrequestreview-3190608 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8960/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/8960#pullrequestreview-3190608 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8960 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8960#event-815431434 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 7, 2016
| https://github.com/nodejs/node/pull/8960#pullrequestreview-3274214 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8960/files |
| test/parallel/test-child-process-spawnsync-kill-signal.js | https://github.com/nodejs/node/pull/8960/files#diff-cedcf1e542815fdb5ff51f727b578d589c656f30ed459f070ffa4ed575e69c4a |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 7, 2016 | https://github.com/nodejs/node/pull/8960#discussion_r82361036 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8960 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/7e630442ae731b12d30403caa9bdbfd8178c00b0..a6790fbd530f557006e98ad6b5a440e3f39a149f |
| 7e63044 | https://github.com/nodejs/node/commit/7e630442ae731b12d30403caa9bdbfd8178c00b0 |
| a6790fb | https://github.com/nodejs/node/commit/a6790fbd530f557006e98ad6b5a440e3f39a149f |
|
Compare
| https://github.com/nodejs/node/compare/7e630442ae731b12d30403caa9bdbfd8178c00b0..a6790fbd530f557006e98ad6b5a440e3f39a149f |
| October 10, 2016 14:39 | https://github.com/nodejs/node/pull/8960#event-818117597 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8960#issuecomment-252641064 |
| https://ci.nodejs.org/job/node-test-pull-request/4445/ | https://ci.nodejs.org/job/node-test-pull-request/4445/ |
| Please reload this page | https://github.com/nodejs/node/pull/8960 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8960#issuecomment-252655625 |
| Please reload this page | https://github.com/nodejs/node/pull/8960 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/dc1c87f1017637910098351c50106eaf6894ec93..532e7f73d6771a85af3677917a816c1c1ebd351a |
| dc1c87f | https://github.com/nodejs/node/commit/dc1c87f1017637910098351c50106eaf6894ec93 |
| 532e7f7 | https://github.com/nodejs/node/commit/532e7f73d6771a85af3677917a816c1c1ebd351a |
|
Compare
| https://github.com/nodejs/node/compare/dc1c87f1017637910098351c50106eaf6894ec93..532e7f73d6771a85af3677917a816c1c1ebd351a |
| October 10, 2016 17:06 | https://github.com/nodejs/node/pull/8960#event-818321019 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8960#issuecomment-252688003 |
| https://ci.nodejs.org/job/node-test-pull-request/4447/ | https://ci.nodejs.org/job/node-test-pull-request/4447/ |
| Please reload this page | https://github.com/nodejs/node/pull/8960 |
|
| https://github.com/cjihrig |
| test: add coverage for spawnSync() killSignal | https://github.com/nodejs/node/pull/8960/commits/01db04bd304c39f222cf71e5b16e2e26d1bdf8d5 |
| 01db04b | https://github.com/nodejs/node/pull/8960/commits/01db04bd304c39f222cf71e5b16e2e26d1bdf8d5 |
| nodejs#8960 | https://github.com/nodejs/node/pull/8960 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/532e7f73d6771a85af3677917a816c1c1ebd351a..01db04bd304c39f222cf71e5b16e2e26d1bdf8d5 |
| 532e7f7 | https://github.com/nodejs/node/commit/532e7f73d6771a85af3677917a816c1c1ebd351a |
| 01db04b | https://github.com/nodejs/node/commit/01db04bd304c39f222cf71e5b16e2e26d1bdf8d5 |
|
Compare
| https://github.com/nodejs/node/compare/532e7f73d6771a85af3677917a816c1c1ebd351a..01db04bd304c39f222cf71e5b16e2e26d1bdf8d5 |
| October 10, 2016 18:33 | https://github.com/nodejs/node/pull/8960#event-818427511 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| 01db04b | https://github.com/nodejs/node/commit/01db04bd304c39f222cf71e5b16e2e26d1bdf8d5 |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8960#event-818428948 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| October 10, 2016 18:34 | https://github.com/nodejs/node/pull/8960#event-818429392 |
| jasnell | https://github.com/jasnell |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/8960#ref-commit-16c4df9 |
|
| https://github.com/cjihrig |
|
| https://github.com/jasnell |
| test: add coverage for spawnSync() killSignal | https://github.com/nodejs/node/commit/16c4df92c4788fea55f6a01546ef0fb675491e0e |
| 16c4df9 | https://github.com/nodejs/node/commit/16c4df92c4788fea55f6a01546ef0fb675491e0e |
| #8960 | https://github.com/nodejs/node/pull/8960 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 11, 2016
| https://github.com/nodejs/node/pull/8960#ref-commit-56951b4 |
|
| https://github.com/cjihrig |
|
| https://github.com/Fishrock123 |
| test: add coverage for spawnSync() killSignal | https://github.com/nodejs/node/commit/56951b43679d069ee939bcfc60128ad6fe9b7c35 |
| 56951b4 | https://github.com/nodejs/node/commit/56951b43679d069ee939bcfc60128ad6fe9b7c35 |
| #8960 | https://github.com/nodejs/node/pull/8960 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/8960#ref-commit-51b251d |
|
| https://github.com/cjihrig |
| test: add coverage for spawnSync() killSignal | https://github.com/nodejs/node/commit/51b251d8eb0ea52305bb8b870fa85b80363e0691 |
| 51b251d | https://github.com/nodejs/node/commit/51b251d8eb0ea52305bb8b870fa85b80363e0691 |
| #8960 | https://github.com/nodejs/node/pull/8960 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Nov 22, 2016 | https://github.com/nodejs/node/pull/8960#event-867715119 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/8960#ref-pullrequest-190943787 |
|
v4.7.0 proposal
#9736
| https://github.com/nodejs/node/pull/9736 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8960 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/8960/files/7e630442ae731b12d30403caa9bdbfd8178c00b0 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/8960/files/7e630442ae731b12d30403caa9bdbfd8178c00b0 |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/8960 |
|
| https://github.com/cjihrig |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |