| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c08657f7-463b-7390-e103-2067c8b73127 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E1D0:24CD64:11AF09B:17AC5A8:696AD47E |
| html-safe-nonce | b42eac4efe8bcf20fcff279072d183ba2868588c1cc28389d8db2489943f084b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUQwOjI0Q0Q2NDoxMUFGMDlCOjE3QUM1QTg6Njk2QUQ0N0UiLCJ2aXNpdG9yX2lkIjoiMTM1ODM2MDMyNzY5NzkxMjk1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ec72d3894db77ca88cbf04700bcf658bf4a7d7d61affaa69505bcb43fad3f63e |
| hovercard-subject-tag | pull_request:88201410 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8946/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/baac11148a0ad17fb204e006d380026d13d6b8b3e599bb3ef733833f09484f30/nodejs/node/pull/8946 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/baac11148a0ad17fb204e006d380026d13d6b8b3e599bb3ef733833f09484f30/nodejs/node/pull/8946 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
documentation is changed or added
commit message follows commit guidelines
Affected core subsystem(s)
buffer
Descripti... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mscdex |
| hostname | github.com |
| expected-hostname | github.com |
| None | c785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c718a376fcf780eb22089171adb84a543f660bf7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8946#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8946 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8946 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8946 |
| Reload | https://github.com/nodejs/node/pull/8946 |
| Reload | https://github.com/nodejs/node/pull/8946 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/8946#issue-comment-box |
| mscdex | https://github.com/mscdex |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mscdex:buffer-bytelength-typeof | https://github.com/mscdex/io.js/tree/buffer-bytelength-typeof |
|
buffer: make byteLength throw on invalid input
| https://github.com/nodejs/node/pull/8946#top |
| mscdex | https://github.com/mscdex |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mscdex:buffer-bytelength-typeof | https://github.com/mscdex/io.js/tree/buffer-bytelength-typeof |
|
Conversation
25
| https://github.com/nodejs/node/pull/8946 |
|
Commits
1
| https://github.com/nodejs/node/pull/8946/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/8946/checks |
|
Files changed
| https://github.com/nodejs/node/pull/8946/files |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8946#issue-181328695 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://ci.nodejs.org/job/node-test-pull-request/4404/ | https://ci.nodejs.org/job/node-test-pull-request/4404/ |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/403/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/403/ |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8946#event-814262852 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 6, 2016
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3131815 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8946/files |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3131815 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
error-handling
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerror-handling |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8946#event-815202203 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 6, 2016
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3174437 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8946/files |
| test/parallel/test-buffer-bytelength.js | https://github.com/nodejs/node/pull/8946/files#diff-1c90fa3012bd913e7d8a8e2968573fd24e8d2f8d9e383839122b3fbecef6266d |
| jasnell | https://github.com/jasnell |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8946#discussion_r82253715 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| mscdex | https://github.com/mscdex |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8946#discussion_r82279788 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 6, 2016
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3174496 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8946/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3174496 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| force-pushed | https://github.com/nodejs/node/compare/e265f1c49d974813fa614e08ddf59c46911f26e2..591026d195d7bcacbc82c1982a9055e4ac62e9b5 |
| e265f1c | https://github.com/nodejs/node/commit/e265f1c49d974813fa614e08ddf59c46911f26e2 |
| 591026d | https://github.com/nodejs/node/commit/591026d195d7bcacbc82c1982a9055e4ac62e9b5 |
|
Compare
| https://github.com/nodejs/node/compare/e265f1c49d974813fa614e08ddf59c46911f26e2..591026d195d7bcacbc82c1982a9055e4ac62e9b5 |
| October 6, 2016 20:40 | https://github.com/nodejs/node/pull/8946#event-815370055 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Oct 7, 2016
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3242894 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8946/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 7, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252285832 |
| https://ci.nodejs.org/job/node-test-pull-request/4419/ | https://ci.nodejs.org/job/node-test-pull-request/4419/ |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 7, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252296205 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Oct 7, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252353998 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Oct 7, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252372850 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 7, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252383017 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 7, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252383154 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/406/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/406/ |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Oct 7, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252385166 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/not-an-aardvark |
| not-an-aardvark | https://github.com/not-an-aardvark |
|
Oct 7, 2016
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3395543 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8946/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 8, 2016
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3402811 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8946/files |
| lpinca | https://github.com/lpinca |
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3402811 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Oct 8, 2016
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3403819 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8946/files |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/8946/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| silverwind | https://github.com/silverwind |
| Oct 8, 2016 | https://github.com/nodejs/node/pull/8946#discussion_r82497327 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| thefourtheye | https://github.com/thefourtheye |
| Oct 8, 2016 | https://github.com/nodejs/node/pull/8946#discussion_r82497572 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @silverwind | https://github.com/silverwind |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| mscdex | https://github.com/mscdex |
| Oct 8, 2016 | https://github.com/nodejs/node/pull/8946#discussion_r82498527 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| silverwind | https://github.com/silverwind |
| Oct 8, 2016 | https://github.com/nodejs/node/pull/8946#discussion_r82506648 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| mscdex | https://github.com/mscdex |
| Oct 8, 2016 | https://github.com/nodejs/node/pull/8946#discussion_r82506800 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 8, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252432077 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
|
| https://github.com/mscdex |
| buffer: make byteLength throw on invalid input | https://github.com/nodejs/node/pull/8946/commits/a89e03bd6a3d7daeb7eaf055cbda8905ebb301ed |
| a89e03b | https://github.com/nodejs/node/pull/8946/commits/a89e03bd6a3d7daeb7eaf055cbda8905ebb301ed |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| force-pushed | https://github.com/nodejs/node/compare/591026d195d7bcacbc82c1982a9055e4ac62e9b5..a89e03bd6a3d7daeb7eaf055cbda8905ebb301ed |
| 591026d | https://github.com/nodejs/node/commit/591026d195d7bcacbc82c1982a9055e4ac62e9b5 |
| a89e03b | https://github.com/nodejs/node/commit/a89e03bd6a3d7daeb7eaf055cbda8905ebb301ed |
|
Compare
| https://github.com/nodejs/node/compare/591026d195d7bcacbc82c1982a9055e4ac62e9b5..a89e03bd6a3d7daeb7eaf055cbda8905ebb301ed |
| October 8, 2016 17:50 | https://github.com/nodejs/node/pull/8946#event-817145341 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Oct 8, 2016
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3412078 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8946/files/a89e03bd6a3d7daeb7eaf055cbda8905ebb301ed |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252692502 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252694437 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252694860 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3547561 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8946/files/a89e03bd6a3d7daeb7eaf055cbda8905ebb301ed |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/8946#pullrequestreview-3547561 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252707851 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252716781 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| jasnell | https://github.com/jasnell |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/8946#ref-commit-c9dade4 |
|
| https://github.com/mscdex |
|
| https://github.com/jasnell |
| buffer: make byteLength throw on invalid input | https://github.com/nodejs/node/commit/c9dade48b46851cabc9ef3677a55ed1dd038c4a1 |
| c9dade4 | https://github.com/nodejs/node/commit/c9dade48b46851cabc9ef3677a55ed1dd038c4a1 |
| #8946 | https://github.com/nodejs/node/pull/8946 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8946#issuecomment-252731511 |
| c9dade4 | https://github.com/nodejs/node/commit/c9dade48b46851cabc9ef3677a55ed1dd038c4a1 |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8946#event-818555144 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| October 10, 2016 20:47 | https://github.com/nodejs/node/pull/8946#event-818604767 |
| jasnell | https://github.com/jasnell |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/8946#ref-commit-96b501d |
|
| https://github.com/mscdex |
|
| https://github.com/jasnell |
| buffer: make byteLength throw on invalid input | https://github.com/nodejs/node/commit/96b501d3383ab9c0b26bacdf5bc33affe9548cb2 |
| 96b501d | https://github.com/nodejs/node/commit/96b501d3383ab9c0b26bacdf5bc33affe9548cb2 |
| #8946 | https://github.com/nodejs/node/pull/8946 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 14, 2016
| https://github.com/nodejs/node/pull/8946#ref-pullrequest-183122097 |
|
v7.0.0 Proposal
#9099
| https://github.com/nodejs/node/pull/9099 |
| jasnell | https://github.com/jasnell |
|
Oct 24, 2016
| https://github.com/nodejs/node/pull/8946#ref-commit-c1e20df |
|
| https://github.com/jasnell |
| 2016-10-25, Version 7.0.0 (Current) | https://github.com/jasnell/node/commit/c1e20df2deef8e81baa2206443dd888bb4c249f0 |
| c1e20df | https://github.com/jasnell/node/commit/c1e20df2deef8e81baa2206443dd888bb4c249f0 |
| nodejs#8946 | https://github.com/nodejs/node/pull/8946 |
| nodejs#8946 | https://github.com/nodejs/node/pull/8946 |
| nodejs#8169 | https://github.com/nodejs/node/pull/8169 |
| nodejs#8169 | https://github.com/nodejs/node/pull/8169 |
| nodejs#7079 | https://github.com/nodejs/node/pull/7079 |
| nodejs#7079 | https://github.com/nodejs/node/pull/7079 |
| nodejs#7399 | https://github.com/nodejs/node/pull/7399 |
| nodejs#7399 | https://github.com/nodejs/node/pull/7399 |
| nodejs#3747 | https://github.com/nodejs/node/pull/3747 |
| nodejs#3747 | https://github.com/nodejs/node/pull/3747 |
| nodejs#8317 | https://github.com/nodejs/node/pull/8317 |
| nodejs#8317 | https://github.com/nodejs/node/pull/8317 |
| nodejs#8852 | https://github.com/nodejs/node/pull/8852 |
| nodejs#8852 | https://github.com/nodejs/node/pull/8852 |
| nodejs#9253 | https://github.com/nodejs/node/pull/9253 |
| nodejs#9253 | https://github.com/nodejs/node/pull/9253 |
| nodejs#8808 | https://github.com/nodejs/node/pull/8808 |
| nodejs#8808 | https://github.com/nodejs/node/pull/8808 |
| nodejs#7897 | https://github.com/nodejs/node/pull/7897 |
| nodejs#7897 | https://github.com/nodejs/node/pull/7897 |
| nodejs#8908 | https://github.com/nodejs/node/pull/8908 |
| nodejs#8908 | https://github.com/nodejs/node/pull/8908 |
| nodejs#8217 | https://github.com/nodejs/node/pull/8217 |
| nodejs#8217 | https://github.com/nodejs/node/pull/8217 |
| nodejs#7941 | https://github.com/nodejs/node/pull/7941 |
| nodejs#7941 | https://github.com/nodejs/node/pull/7941 |
| nodejs#7448 | https://github.com/nodejs/node/pull/7448 |
| nodejs#7448 | https://github.com/nodejs/node/pull/7448 |
| jasnell | https://github.com/jasnell |
|
Oct 25, 2016
| https://github.com/nodejs/node/pull/8946#ref-commit-362fe01 |
|
| https://github.com/jasnell |
| 2016-10-25, Version 7.0.0 (Current) | https://github.com/nodejs/node/commit/362fe010fe8f6feb0030e1e02c689b501e11ddb7 |
|
| https://github.com/nodejs/node/commit/362fe010fe8f6feb0030e1e02c689b501e11ddb7#comments |
| 362fe01 | https://github.com/nodejs/node/commit/362fe010fe8f6feb0030e1e02c689b501e11ddb7 |
| #8946 | https://github.com/nodejs/node/pull/8946 |
| #8946 | https://github.com/nodejs/node/pull/8946 |
| #8169 | https://github.com/nodejs/node/pull/8169 |
| #8169 | https://github.com/nodejs/node/pull/8169 |
| #7079 | https://github.com/nodejs/node/pull/7079 |
| #7079 | https://github.com/nodejs/node/pull/7079 |
| #7399 | https://github.com/nodejs/node/pull/7399 |
| #7399 | https://github.com/nodejs/node/pull/7399 |
| #3747 | https://github.com/nodejs/node/pull/3747 |
| #3747 | https://github.com/nodejs/node/pull/3747 |
| #8317 | https://github.com/nodejs/node/pull/8317 |
| #8317 | https://github.com/nodejs/node/pull/8317 |
| #8852 | https://github.com/nodejs/node/pull/8852 |
| #8852 | https://github.com/nodejs/node/pull/8852 |
| #9253 | https://github.com/nodejs/node/pull/9253 |
| #9253 | https://github.com/nodejs/node/pull/9253 |
| #8808 | https://github.com/nodejs/node/pull/8808 |
| #8808 | https://github.com/nodejs/node/pull/8808 |
| #7897 | https://github.com/nodejs/node/pull/7897 |
| #7897 | https://github.com/nodejs/node/pull/7897 |
| #8908 | https://github.com/nodejs/node/pull/8908 |
| #8908 | https://github.com/nodejs/node/pull/8908 |
| #8217 | https://github.com/nodejs/node/pull/8217 |
| #8217 | https://github.com/nodejs/node/pull/8217 |
| #7941 | https://github.com/nodejs/node/pull/7941 |
| #7941 | https://github.com/nodejs/node/pull/7941 |
| #7448 | https://github.com/nodejs/node/pull/7448 |
| #7448 | https://github.com/nodejs/node/pull/7448 |
| #9099 | https://github.com/nodejs/node/pull/9099 |
| jasnell | https://github.com/jasnell |
|
Oct 25, 2016
| https://github.com/nodejs/node/pull/8946#ref-commit-1e4fafc |
|
| https://github.com/jasnell |
| 2016-10-25, Version 7.0.0 (Current) | https://github.com/nodejs/node/commit/1e4fafcb1a07900080afeb52917515c15268b60b |
| 1e4fafc | https://github.com/nodejs/node/commit/1e4fafcb1a07900080afeb52917515c15268b60b |
| #8946 | https://github.com/nodejs/node/pull/8946 |
| #8946 | https://github.com/nodejs/node/pull/8946 |
| #8169 | https://github.com/nodejs/node/pull/8169 |
| #8169 | https://github.com/nodejs/node/pull/8169 |
| #7079 | https://github.com/nodejs/node/pull/7079 |
| #7079 | https://github.com/nodejs/node/pull/7079 |
| #7399 | https://github.com/nodejs/node/pull/7399 |
| #7399 | https://github.com/nodejs/node/pull/7399 |
| #3747 | https://github.com/nodejs/node/pull/3747 |
| #3747 | https://github.com/nodejs/node/pull/3747 |
| #8317 | https://github.com/nodejs/node/pull/8317 |
| #8317 | https://github.com/nodejs/node/pull/8317 |
| #8852 | https://github.com/nodejs/node/pull/8852 |
| #8852 | https://github.com/nodejs/node/pull/8852 |
| #9253 | https://github.com/nodejs/node/pull/9253 |
| #9253 | https://github.com/nodejs/node/pull/9253 |
| #8808 | https://github.com/nodejs/node/pull/8808 |
| #8808 | https://github.com/nodejs/node/pull/8808 |
| #7897 | https://github.com/nodejs/node/pull/7897 |
| #7897 | https://github.com/nodejs/node/pull/7897 |
| #8908 | https://github.com/nodejs/node/pull/8908 |
| #8908 | https://github.com/nodejs/node/pull/8908 |
| #8217 | https://github.com/nodejs/node/pull/8217 |
| #8217 | https://github.com/nodejs/node/pull/8217 |
| #7941 | https://github.com/nodejs/node/pull/7941 |
| #7941 | https://github.com/nodejs/node/pull/7941 |
| #7448 | https://github.com/nodejs/node/pull/7448 |
| #7448 | https://github.com/nodejs/node/pull/7448 |
| #9099 | https://github.com/nodejs/node/pull/9099 |
| imyller | https://github.com/imyller |
|
Oct 25, 2016
| https://github.com/nodejs/node/pull/8946#ref-commit-7aae498 |
|
| https://github.com/imyller |
| 2016-10-25, Version 7.0.0 (Current) | https://github.com/imyller/meta-nodejs/commit/7aae49813e3077043672cfbd4bdfe4025acf4405 |
| 7aae498 | https://github.com/imyller/meta-nodejs/commit/7aae49813e3077043672cfbd4bdfe4025acf4405 |
| nodejs/node#8946 | https://github.com/nodejs/node/pull/8946 |
| nodejs/node#8169 | https://github.com/nodejs/node/pull/8169 |
| nodejs/node#7079 | https://github.com/nodejs/node/pull/7079 |
| nodejs/node#7399 | https://github.com/nodejs/node/pull/7399 |
| nodejs/node#3747 | https://github.com/nodejs/node/pull/3747 |
| nodejs/node#8317 | https://github.com/nodejs/node/pull/8317 |
| nodejs/node#8852 | https://github.com/nodejs/node/pull/8852 |
| nodejs/node#9253 | https://github.com/nodejs/node/pull/9253 |
| nodejs/node#8808 | https://github.com/nodejs/node/pull/8808 |
| nodejs/node#7897 | https://github.com/nodejs/node/pull/7897 |
| nodejs/node#8908 | https://github.com/nodejs/node/pull/8908 |
| nodejs/node#8217 | https://github.com/nodejs/node/pull/8217 |
| nodejs/node#7941 | https://github.com/nodejs/node/pull/7941 |
| nodejs/node#7448 | https://github.com/nodejs/node/pull/7448 |
| https://github.com/Shwetajain148 |
| Shwetajain148 | https://github.com/Shwetajain148 |
|
May 26, 2017
| https://github.com/nodejs/node/pull/8946#ref-pullrequest-231553380 |
|
Fix undefined issue while logging from node-loggly-bulk library
loggly/node-loggly-bulk#11
| https://github.com/loggly/node-loggly-bulk/pull/11 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/8946#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/Ezwal |
| Ezwal | https://github.com/Ezwal |
|
Nov 10, 2017
| https://github.com/nodejs/node/pull/8946#ref-issue-272867109 |
|
Crash on empty file upload
lennym/busboy-body-parser#21
| https://github.com/lennym/busboy-body-parser/issues/21 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8946 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/8946/files/e265f1c49d974813fa614e08ddf59c46911f26e2 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/8946/files/a89e03bd6a3d7daeb7eaf055cbda8905ebb301ed |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/8946/files/591026d195d7bcacbc82c1982a9055e4ac62e9b5 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/8946/files/e265f1c49d974813fa614e08ddf59c46911f26e2 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/8946/files/591026d195d7bcacbc82c1982a9055e4ac62e9b5 |
|
| https://github.com/silverwind |
|
silverwind
| https://github.com/silverwind |
|
| https://github.com/nodejs/node/pull/8946/files/a89e03bd6a3d7daeb7eaf055cbda8905ebb301ed |
|
| https://github.com/not-an-aardvark |
|
not-an-aardvark
| https://github.com/not-an-aardvark |
|
| https://github.com/nodejs/node/pull/8946/files/591026d195d7bcacbc82c1982a9055e4ac62e9b5 |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Please reload this page | https://github.com/nodejs/node/pull/8946 |
|
| https://github.com/mscdex |
|
| https://github.com/jasnell |
|
| https://github.com/mcollina |
|
| https://github.com/trevnorris |
|
| https://github.com/addaleax |
|
| https://github.com/silverwind |
|
| https://github.com/thefourtheye |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/not-an-aardvark |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |