René's URL Explorer Experiment


Title: http: set socket timeout when socket connects by lpinca · Pull Request #8895 · nodejs/node · GitHub

Open Graph Title: http: set socket timeout when socket connects by lpinca · Pull Request #8895 · nodejs/node

X Title: http: set socket timeout when socket connects by lpinca · Pull Request #8895 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) http Descript...

X Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) http Descript...

Opengraph URL: https://github.com/nodejs/node/pull/8895

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:51327347-dc83-f2ec-dc30-6676a817a738
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id81E2:1A6069:1760A70:1D96E69:69917106
html-safe-noncebda9472f56b953f0d58d1115f1f91fcbb0a5af3a35c6ad7a6e940003b45cc1fe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUUyOjFBNjA2OToxNzYwQTcwOjFEOTZFNjk6Njk5MTcxMDYiLCJ2aXNpdG9yX2lkIjoiODQzMjUyODAxNTIxNzQ4ODEzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac53e70c4e3f8afc6541e8fa29edcc815ee6af24c183e7f480b41ee1a555115f75
hovercard-subject-tagpull_request:87630560
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8895/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9fdca05ba6dc1b758fed63dba721cd1e75d4fd309fd45174e86f6413dd3193d0/nodejs/node/pull/8895
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9fdca05ba6dc1b758fed63dba721cd1e75d4fd309fd45174e86f6413dd3193d0/nodejs/node/pull/8895
og:image:altChecklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) http Descript...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelpinca
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8895#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8895
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8895
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8895
Reloadhttps://github.com/nodejs/node/pull/8895
Reloadhttps://github.com/nodejs/node/pull/8895
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/8895
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:fix/request-set-timeouthttps://github.com/lpinca/node/tree/fix/request-set-timeout
Conversationhttps://github.com/nodejs/node/pull/8895
Commits1 (1)https://github.com/nodejs/node/pull/8895/commits
Checkshttps://github.com/nodejs/node/pull/8895/checks
Files changedhttps://github.com/nodejs/node/pull/8895/files
http: set socket timeout when socket connectshttps://github.com/nodejs/node/pull/8895#top
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:fix/request-set-timeouthttps://github.com/lpinca/node/tree/fix/request-set-timeout
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 2, 2016https://github.com/nodejs/node/pull/8895#issue-180506021
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Oct 2, 2016https://github.com/nodejs/node/pull/8895#event-809547134
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 2, 2016https://github.com/nodejs/node/pull/8895#issuecomment-250964907
https://ci.nodejs.org/job/node-test-pull-request/4354/https://ci.nodejs.org/job/node-test-pull-request/4354/
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 3, 2016 https://github.com/nodejs/node/pull/8895#pullrequestreview-2503390
View reviewed changes https://github.com/nodejs/node/pull/8895/files
evanlucashttps://github.com/evanlucas
https://github.com/nodejs/node/pull/8895#pullrequestreview-2503390
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
test/parallel/test-http-client-timeout-on-connect.jshttps://github.com/nodejs/node/pull/8895/files#diff-40f6f4c8f677c70370ed1b20fb4082a4bca1ded64563332cfd437de741e58b7d
evanlucashttps://github.com/evanlucas
Oct 3, 2016https://github.com/nodejs/node/pull/8895#discussion_r81530610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
lpincahttps://github.com/lpinca
Oct 3, 2016https://github.com/nodejs/node/pull/8895#discussion_r81533273
Please reload this pagehttps://github.com/nodejs/node/pull/8895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 3, 2016https://github.com/nodejs/node/pull/8895#issuecomment-251084760
@evanlucashttps://github.com/evanlucas
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/lpinca
lpincahttps://github.com/lpinca
force-pushedhttps://github.com/nodejs/node/compare/832de1ed325bc4620c044e695a564d88ad15d531..c8a10c7b7584a70045c5c3122744863bb0b2da23
832de1ehttps://github.com/nodejs/node/commit/832de1ed325bc4620c044e695a564d88ad15d531
c8a10c7https://github.com/nodejs/node/commit/c8a10c7b7584a70045c5c3122744863bb0b2da23
Compare https://github.com/nodejs/node/compare/832de1ed325bc4620c044e695a564d88ad15d531..c8a10c7b7584a70045c5c3122744863bb0b2da23
October 3, 2016 11:38https://github.com/nodejs/node/pull/8895#event-810146692
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 3, 2016 https://github.com/nodejs/node/pull/8895#pullrequestreview-2509326
View reviewed changes https://github.com/nodejs/node/pull/8895/files
lib/_http_client.jshttps://github.com/nodejs/node/pull/8895/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
addaleaxhttps://github.com/addaleax
Oct 3, 2016https://github.com/nodejs/node/pull/8895#discussion_r81537113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
lpincahttps://github.com/lpinca
Oct 3, 2016https://github.com/nodejs/node/pull/8895#discussion_r81537978
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/lpinca
lpincahttps://github.com/lpinca
force-pushedhttps://github.com/nodejs/node/compare/c8a10c7b7584a70045c5c3122744863bb0b2da23..22a1bbebe2bf4f993f1315924a2bfe8ef7349077
c8a10c7https://github.com/nodejs/node/commit/c8a10c7b7584a70045c5c3122744863bb0b2da23
22a1bbehttps://github.com/nodejs/node/commit/22a1bbebe2bf4f993f1315924a2bfe8ef7349077
Compare https://github.com/nodejs/node/compare/c8a10c7b7584a70045c5c3122744863bb0b2da23..22a1bbebe2bf4f993f1315924a2bfe8ef7349077
October 3, 2016 12:15https://github.com/nodejs/node/pull/8895#event-810181184
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 3, 2016 https://github.com/nodejs/node/pull/8895#pullrequestreview-2518472
View reviewed changes https://github.com/nodejs/node/pull/8895/files
test/parallel/test-http-client-timeout-on-connect.jshttps://github.com/nodejs/node/pull/8895/files#diff-40f6f4c8f677c70370ed1b20fb4082a4bca1ded64563332cfd437de741e58b7d
cjihrighttps://github.com/cjihrig
Oct 3, 2016https://github.com/nodejs/node/pull/8895#discussion_r81546838
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
lpincahttps://github.com/lpinca
Oct 3, 2016https://github.com/nodejs/node/pull/8895#discussion_r81547828
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
cjihrighttps://github.com/cjihrig
Oct 3, 2016https://github.com/nodejs/node/pull/8895#discussion_r81548588
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
lpincahttps://github.com/lpinca
Oct 3, 2016https://github.com/nodejs/node/pull/8895#discussion_r81549432
Please reload this pagehttps://github.com/nodejs/node/pull/8895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/lpinca
lpincahttps://github.com/lpinca
force-pushedhttps://github.com/nodejs/node/compare/22a1bbebe2bf4f993f1315924a2bfe8ef7349077..2a263a69d7cdbdbd0af20580fbc513524f2bf623
22a1bbehttps://github.com/nodejs/node/commit/22a1bbebe2bf4f993f1315924a2bfe8ef7349077
2a263a6https://github.com/nodejs/node/commit/2a263a69d7cdbdbd0af20580fbc513524f2bf623
Compare https://github.com/nodejs/node/compare/22a1bbebe2bf4f993f1315924a2bfe8ef7349077..2a263a69d7cdbdbd0af20580fbc513524f2bf623
October 3, 2016 13:30https://github.com/nodejs/node/pull/8895#event-810265938
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 6, 2016 https://github.com/nodejs/node/pull/8895#pullrequestreview-3155423
View reviewed changes https://github.com/nodejs/node/pull/8895/files
lib/_http_client.jshttps://github.com/nodejs/node/pull/8895/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
jasnellhttps://github.com/jasnell
Oct 6, 2016https://github.com/nodejs/node/pull/8895#discussion_r82233619
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
lpincahttps://github.com/lpinca
Oct 6, 2016https://github.com/nodejs/node/pull/8895#discussion_r82234192
Please reload this pagehttps://github.com/nodejs/node/pull/8895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jasnellhttps://github.com/jasnell
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/8895
addaleaxhttps://github.com/addaleax
Oct 6, 2016https://github.com/nodejs/node/pull/8895#discussion_r82234686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
lpincahttps://github.com/lpinca
Oct 6, 2016https://github.com/nodejs/node/pull/8895#discussion_r82252040
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
jasnellhttps://github.com/jasnell
Oct 6, 2016https://github.com/nodejs/node/pull/8895#discussion_r82255936
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/lpinca
lpincahttps://github.com/lpinca
force-pushedhttps://github.com/nodejs/node/compare/2a263a69d7cdbdbd0af20580fbc513524f2bf623..ce555e25c195e8da04cd8c1e0eff89559061bbd6
2a263a6https://github.com/nodejs/node/commit/2a263a69d7cdbdbd0af20580fbc513524f2bf623
ce555e2https://github.com/nodejs/node/commit/ce555e25c195e8da04cd8c1e0eff89559061bbd6
Compare https://github.com/nodejs/node/compare/2a263a69d7cdbdbd0af20580fbc513524f2bf623..ce555e25c195e8da04cd8c1e0eff89559061bbd6
October 6, 2016 18:20https://github.com/nodejs/node/pull/8895#event-815189820
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 6, 2016 https://github.com/nodejs/node/pull/8895#pullrequestreview-3176593
View reviewed changes https://github.com/nodejs/node/pull/8895/files
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/8895#pullrequestreview-3176593
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 7, 2016https://github.com/nodejs/node/pull/8895#issuecomment-252313260
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 7, 2016https://github.com/nodejs/node/pull/8895#issuecomment-252370602
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/indutny
indutnyhttps://github.com/indutny
Oct 8, 2016 https://github.com/nodejs/node/pull/8895#pullrequestreview-3413871
View reviewed changes https://github.com/nodejs/node/pull/8895/files
indutnyhttps://github.com/indutny
https://github.com/nodejs/node/pull/8895#pullrequestreview-3413871
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 8, 2016https://github.com/nodejs/node/pull/8895#issuecomment-252445543
@indutnyhttps://github.com/indutny
casehttps://github.com/nodejs/node/blob/7084b9c5a179098edc8952c3348fc66c61ddcfc6/lib/_http_client.js#L633-L639
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/indutny
indutnyhttps://github.com/indutny
Oct 8, 2016https://github.com/nodejs/node/pull/8895#issuecomment-252445732
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 8, 2016https://github.com/nodejs/node/pull/8895#issuecomment-252447356
Please reload this pagehttps://github.com/nodejs/node/pull/8895
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/indutny
indutnyhttps://github.com/indutny
Oct 8, 2016https://github.com/nodejs/node/pull/8895#issuecomment-252448083
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 18, 2016https://github.com/nodejs/node/pull/8895#issuecomment-254512246
@indutnyhttps://github.com/indutny
1https://github.com/nodejs/node/blob/7014566273ecef5bb28822a66fec0c1e625f30fb/lib/_http_client.js#L622-L628
2https://github.com/nodejs/node/blob/7014566273ecef5bb28822a66fec0c1e625f30fb/lib/_http_client.js#L632-L638
net.createConnection()https://github.com/nodejs/node/blob/7014566273ecef5bb28822a66fec0c1e625f30fb/lib/_http_client.js#L174
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/rvagg
rvagghttps://github.com/rvagg
force-pushedhttps://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0
c133999https://github.com/nodejs/node/commit/c13399980463b0a8691ea2cff9191aa5aede8d0e
83c7a88https://github.com/nodejs/node/commit/83c7a8897c644e1eadeaaace4863a822c73359a0
Compare https://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0
October 18, 2016 17:02https://github.com/nodejs/node/pull/8895#event-827820785
lpincahttps://github.com/lpinca
Jan 16, 2017 https://github.com/nodejs/node/pull/8895#ref-commit-42f6998
https://github.com/floatdrop
simplify code (move out socket timeout part)https://github.com/sindresorhus/timed-out/commit/42f6998828a04d1cf10c6929cb51317df39bbf05
https://github.com/sindresorhus/timed-out/commit/42f6998828a04d1cf10c6929cb51317df39bbf05#comments
42f6998https://github.com/sindresorhus/timed-out/commit/42f6998828a04d1cf10c6929cb51317df39bbf05
https://github.com/jasnell
jasnellhttps://github.com/jasnell
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Mar 1, 2017https://github.com/nodejs/node/pull/8895#event-981154938
https://github.com/refack
refackhttps://github.com/refack
force-pushedhttps://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00
16073c0https://github.com/nodejs/node/commit/16073c083efdcaf70aef1e490679457dd0f624bd
fbe946bhttps://github.com/nodejs/node/commit/fbe946bb6316f1e1083ec47baaf812fc98d60f00
Compare https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00
April 14, 2017 04:11https://github.com/nodejs/node/pull/8895#event-1042928527
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 24, 2017https://github.com/nodejs/node/pull/8895#issuecomment-324784719
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 24, 2017https://github.com/nodejs/node/pull/8895#event-1220669651
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 25, 2017https://github.com/nodejs/node/pull/8895#issuecomment-324825694
Please reload this pagehttps://github.com/nodejs/node/pull/8895
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 25, 2017https://github.com/nodejs/node/pull/8895#issuecomment-324835238
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 25, 2017https://github.com/nodejs/node/pull/8895#event-1221888916
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Nov 3, 2017 https://github.com/nodejs/node/pull/8895#ref-issue-270974735
In node V 9.0.0, HTTP Client Agent is leaking when reusing a socket in HTTP Request #16716 https://github.com/nodejs/node/issues/16716
lpincahttps://github.com/lpinca
Nov 6, 2017 https://github.com/nodejs/node/pull/8895#ref-commit-407389d
https://github.com/lpinca
http: use 'connect' event only if socket is connectinghttps://github.com/lpinca/node/commit/407389dd4e3a59a41e6d8cb6915d5452e77e5873
407389dhttps://github.com/lpinca/node/commit/407389dd4e3a59a41e6d8cb6915d5452e77e5873
nodejs#16716https://github.com/nodejs/node/issues/16716
nodejs#8895https://github.com/nodejs/node/pull/8895
lpincahttps://github.com/lpinca
Nov 6, 2017 https://github.com/nodejs/node/pull/8895#ref-commit-f60c692
https://github.com/lpinca
http: use 'connect' event only if socket is connectinghttps://github.com/nodejs/node/commit/f60c692499c488d4ab59b67b258eea88dc826287
f60c692https://github.com/nodejs/node/commit/f60c692499c488d4ab59b67b258eea88dc826287
#16716https://github.com/nodejs/node/issues/16716
#8895https://github.com/nodejs/node/pull/8895
#16725https://github.com/nodejs/node/pull/16725
cjihrighttps://github.com/cjihrig
Nov 6, 2017 https://github.com/nodejs/node/pull/8895#ref-commit-77f0359
https://github.com/lpinca
https://github.com/cjihrig
http: use 'connect' event only if socket is connectinghttps://github.com/cjihrig/node/commit/77f0359708be792135a9866ce8292cee1f7c37a9
77f0359https://github.com/cjihrig/node/commit/77f0359708be792135a9866ce8292cee1f7c37a9
nodejs#16716https://github.com/nodejs/node/issues/16716
nodejs#8895https://github.com/nodejs/node/pull/8895
nodejs#16725https://github.com/nodejs/node/pull/16725
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 19, 2017 https://github.com/nodejs/node/pull/8895#ref-issue-283353288
Investigate flaky parallel/test-listen-fd-ebadf #17762 https://github.com/nodejs/node/issues/17762
Update docs for http request set timeout #25121 https://github.com/nodejs/node/pull/25121
Update v8.x docs for http request set timeout #25122 https://github.com/nodejs/node/pull/25122
jbunton-atlassianhttps://github.com/jbunton-atlassian
Dec 19, 2018 https://github.com/nodejs/node/pull/8895#ref-commit-b1d62ee
https://github.com/jbunton-atlassian
update the http.request.setTimeout docs to be accuratehttps://github.com/jbunton-atlassian/node/commit/b1d62ee77e70687c3900b92c6d8bc2c379cf9e2f
b1d62eehttps://github.com/jbunton-atlassian/node/commit/b1d62ee77e70687c3900b92c6d8bc2c379cf9e2f
nodejs#8895https://github.com/nodejs/node/pull/8895
jbunton-atlassianhttps://github.com/jbunton-atlassian
Dec 19, 2018 https://github.com/nodejs/node/pull/8895#ref-commit-84cd47b
https://github.com/jbunton-atlassian
doc: update http.request.setTimeout docs to include historyhttps://github.com/jbunton-atlassian/node/commit/84cd47b99749c362f0f6b6fe019316e78df6204c
84cd47bhttps://github.com/jbunton-atlassian/node/commit/84cd47b99749c362f0f6b6fe019316e78df6204c
nodejs#8895https://github.com/nodejs/node/pull/8895
https://github.com/jbunton-atlassian
jbunton-atlassianhttps://github.com/jbunton-atlassian
Dec 19, 2018 https://github.com/nodejs/node/pull/8895#ref-pullrequest-392455618
[v8.x] update the http.request.setTimeout docs to be accurate #25123 https://github.com/nodejs/node/pull/25123
jbunton-atlassianhttps://github.com/jbunton-atlassian
Dec 19, 2018 https://github.com/nodejs/node/pull/8895#ref-commit-fc173b3
https://github.com/jbunton-atlassian
doc: update the http.request.setTimeout docs to be accuratehttps://github.com/jbunton-atlassian/node/commit/fc173b3d72262e0871c576b6dd4a92340d7d9260
fc173b3https://github.com/jbunton-atlassian/node/commit/fc173b3d72262e0871c576b6dd4a92340d7d9260
nodejs#8895https://github.com/nodejs/node/pull/8895
jbunton-atlassianhttps://github.com/jbunton-atlassian
Dec 19, 2018 https://github.com/nodejs/node/pull/8895#ref-commit-5708c6a
https://github.com/jbunton-atlassian
doc: update http.request.setTimeout docs to include historyhttps://github.com/jbunton-atlassian/node/commit/5708c6aa17ad1095d76e133ce64b850f495abcc8
5708c6ahttps://github.com/jbunton-atlassian/node/commit/5708c6aa17ad1095d76e133ce64b850f495abcc8
nodejs#8895https://github.com/nodejs/node/pull/8895
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018 https://github.com/nodejs/node/pull/8895#ref-commit-3812a99
https://github.com/jbunton-atlassian
https://github.com/MylesBorins
doc: update the http.request.setTimeout docs to be accuratehttps://github.com/nodejs/node/commit/3812a9953a46ecb0b71e6028c266710e54509e62
3812a99https://github.com/nodejs/node/commit/3812a9953a46ecb0b71e6028c266710e54509e62
#8895https://github.com/nodejs/node/pull/8895
#25123https://github.com/nodejs/node/pull/25123
MylesBorinshttps://github.com/MylesBorins
Dec 26, 2018 https://github.com/nodejs/node/pull/8895#ref-commit-3af7528
https://github.com/jbunton-atlassian
https://github.com/MylesBorins
doc: update the http.request.setTimeout docs to be accuratehttps://github.com/nodejs/node/commit/3af7528ac399e77eca40b2d00a39afb8dc935b95
3af7528https://github.com/nodejs/node/commit/3af7528ac399e77eca40b2d00a39afb8dc935b95
#8895https://github.com/nodejs/node/pull/8895
#25123https://github.com/nodejs/node/pull/25123
vsemozhetbythttps://github.com/vsemozhetbyt
Jan 9, 2019 https://github.com/nodejs/node/pull/8895#ref-commit-b83088b
https://github.com/jbunton-atlassian
https://github.com/vsemozhetbyt
doc: add history to http.request.setTimeout()https://github.com/nodejs/node/commit/b83088b0bb2b8dfa6ee72a807cc10fe1ac898278
b83088bhttps://github.com/nodejs/node/commit/b83088b0bb2b8dfa6ee72a807cc10fe1ac898278
#25121https://github.com/nodejs/node/pull/25121
#8895https://github.com/nodejs/node/pull/8895
addaleaxhttps://github.com/addaleax
Jan 14, 2019 https://github.com/nodejs/node/pull/8895#ref-commit-8380bd4
https://github.com/jbunton-atlassian
https://github.com/addaleax
doc: add history to http.request.setTimeout()https://github.com/nodejs/node/commit/8380bd46a01f3e912f0b7609d8f390018106c85f
8380bd4https://github.com/nodejs/node/commit/8380bd46a01f3e912f0b7609d8f390018106c85f
#25121https://github.com/nodejs/node/pull/25121
#8895https://github.com/nodejs/node/pull/8895
BridgeARhttps://github.com/BridgeAR
Jan 16, 2019 https://github.com/nodejs/node/pull/8895#ref-commit-ddaf69c
https://github.com/jbunton-atlassian
https://github.com/BridgeAR
doc: add history to http.request.setTimeout()https://github.com/BridgeAR/node/commit/ddaf69c9638c3f4ad40ae87f1e2a96c57794c408
ddaf69chttps://github.com/BridgeAR/node/commit/ddaf69c9638c3f4ad40ae87f1e2a96c57794c408
nodejs#25121https://github.com/nodejs/node/pull/25121
nodejs#8895https://github.com/nodejs/node/pull/8895
rvagghttps://github.com/rvagg
Feb 28, 2019 https://github.com/nodejs/node/pull/8895#ref-commit-b17819d
https://github.com/jbunton-atlassian
https://github.com/rvagg
doc: update the http.request.setTimeout docs to be accuratehttps://github.com/nodejs/node/commit/b17819db3d58693c40a5711bbaa50592fc638816
b17819dhttps://github.com/nodejs/node/commit/b17819db3d58693c40a5711bbaa50592fc638816
#8895https://github.com/nodejs/node/pull/8895
#25123https://github.com/nodejs/node/pull/25123
BethGriggshttps://github.com/BethGriggs
Apr 28, 2019 https://github.com/nodejs/node/pull/8895#ref-commit-abacd1e
https://github.com/jbunton-atlassian
https://github.com/BethGriggs
doc: add history to http.request.setTimeout()https://github.com/nodejs/node/commit/abacd1e4a9a93ab43bde40f339ebbe2d13e97b81
abacd1ehttps://github.com/nodejs/node/commit/abacd1e4a9a93ab43bde40f339ebbe2d13e97b81
#25121https://github.com/nodejs/node/pull/25121
#8895https://github.com/nodejs/node/pull/8895
BethGriggshttps://github.com/BethGriggs
May 10, 2019 https://github.com/nodejs/node/pull/8895#ref-commit-7964746
https://github.com/jbunton-atlassian
https://github.com/BethGriggs
doc: add history to http.request.setTimeout()https://github.com/nodejs/node/commit/7964746f3cebce3b711810fdcfc17ce0161934de
7964746https://github.com/nodejs/node/commit/7964746f3cebce3b711810fdcfc17ce0161934de
#25121https://github.com/nodejs/node/pull/25121
#8895https://github.com/nodejs/node/pull/8895
MylesBorinshttps://github.com/MylesBorins
May 16, 2019 https://github.com/nodejs/node/pull/8895#ref-commit-487f653
https://github.com/jbunton-atlassian
https://github.com/MylesBorins
doc: add history to http.request.setTimeout()https://github.com/nodejs/node/commit/487f6536bcf1a08539f22eb8c9877c8da78dbcee
487f653https://github.com/nodejs/node/commit/487f6536bcf1a08539f22eb8c9877c8da78dbcee
#25121https://github.com/nodejs/node/pull/25121
#8895https://github.com/nodejs/node/pull/8895
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8895
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/8895/files/2a263a69d7cdbdbd0af20580fbc513524f2bf623
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/8895/files/22a1bbebe2bf4f993f1315924a2bfe8ef7349077
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/8895/files/88e4f97e8a2284d672ab3d9193dcb22de917dd2b
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/8895/files/ce555e25c195e8da04cd8c1e0eff89559061bbd6
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/8895/files/0d72053f705dbba33d57113e7aff946502b63645
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/8895/files/0d72053f705dbba33d57113e7aff946502b63645
https://github.com/evanlucas
evanlucas https://github.com/evanlucas
https://github.com/nodejs/node/pull/8895/files/832de1ed325bc4620c044e695a564d88ad15d531
https://github.com/indutny
indutny https://github.com/indutny
https://github.com/nodejs/node/pull/8895/files/ce555e25c195e8da04cd8c1e0eff89559061bbd6
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/8895
https://github.com/lpinca
https://github.com/jasnell
https://github.com/addaleax
https://github.com/indutny
https://github.com/BridgeAR
https://github.com/mscdex
https://github.com/mcollina
https://github.com/evanlucas
https://github.com/cjihrig
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.