René's URL Explorer Experiment


Title: build: don't build icu with -fno-rtti by bnoordhuis · Pull Request #8886 · nodejs/node · GitHub

Open Graph Title: build: don't build icu with -fno-rtti by bnoordhuis · Pull Request #8886 · nodejs/node

X Title: build: don't build icu with -fno-rtti by bnoordhuis · Pull Request #8886 · nodejs/node

Description: ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867

Open Graph Description: ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867

X Description: ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867

Opengraph URL: https://github.com/nodejs/node/pull/8886

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:515a9db1-3d50-de9e-7fe0-807326cf8351
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE2E:371600:27C196:3760DA:696A6649
html-safe-nonce7d3e48bd09f2b9112f2d27c0dae3d8681b3bee9b6ce95f9138de1a1973c48279
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTJFOjM3MTYwMDoyN0MxOTY6Mzc2MERBOjY5NkE2NjQ5IiwidmlzaXRvcl9pZCI6Ijc1NTM5OTM0MzgzNjU2NDAyNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac777e4c7b593c0f93e14b02f0776175136cccb6cece573cb422bbebd2ed31251c
hovercard-subject-tagpull_request:87603525
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8886/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/60b650c15da65b9a7d24a8e8c00e4e16f7edf5463639d389b3c0624ba371d16e/nodejs/node/pull/8886
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/60b650c15da65b9a7d24a8e8c00e4e16f7edf5463639d389b3c0624ba371d16e/nodejs/node/pull/8886
og:image:altICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release87cbd411c2982752221b5751d583a515b23bf5fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8886#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8886
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8886
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8886
Reloadhttps://github.com/nodejs/node/pull/8886
Reloadhttps://github.com/nodejs/node/pull/8886
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/8886
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/8886
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/8886#issue-comment-box
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix8867https://github.com/bnoordhuis/io.js/tree/fix8867
build: don't build icu with -fno-rtti https://github.com/nodejs/node/pull/8886#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix8867https://github.com/bnoordhuis/io.js/tree/fix8867
Conversation 5 https://github.com/nodejs/node/pull/8886
Commits 1 https://github.com/nodejs/node/pull/8886/commits
Checks 0 https://github.com/nodejs/node/pull/8886/checks
Files changed https://github.com/nodejs/node/pull/8886/files
Please reload this pagehttps://github.com/nodejs/node/pull/8886
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 1, 2016https://github.com/nodejs/node/pull/8886#issue-180459260
#8867https://github.com/nodejs/node/issues/8867
Please reload this pagehttps://github.com/nodejs/node/pull/8886
https://github.com/bnoordhuis
build: don't build icu with -fno-rttihttps://github.com/nodejs/node/pull/8886/commits/dae477118a104665338c3b38f0f16597e85f12c0
dae4771https://github.com/nodejs/node/pull/8886/commits/dae477118a104665338c3b38f0f16597e85f12c0
nodejs#8867https://github.com/nodejs/node/issues/8867
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
Oct 1, 2016https://github.com/nodejs/node/pull/8886#event-809335549
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Oct 1, 2016https://github.com/nodejs/node/pull/8886#event-809335554
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 1, 2016 https://github.com/nodejs/node/pull/8886#ref-issue-180381067
Cannot Build Node.js 6.7.0 on CorePure64 Tinycore Linux #8867 https://github.com/nodejs/node/issues/8867
https://github.com/mscdex
mscdexhttps://github.com/mscdex
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Oct 1, 2016https://github.com/nodejs/node/pull/8886#event-809341996
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
Oct 1, 2016 https://github.com/nodejs/node/pull/8886#pullrequestreview-2439162
View reviewed changes https://github.com/nodejs/node/pull/8886/files/dae477118a104665338c3b38f0f16597e85f12c0
jbergstroemhttps://github.com/jbergstroem
https://github.com/nodejs/node/pull/8886#pullrequestreview-2439162
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8886
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 3, 2016 https://github.com/nodejs/node/pull/8886#pullrequestreview-2500986
View reviewed changes https://github.com/nodejs/node/pull/8886/files/dae477118a104665338c3b38f0f16597e85f12c0
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 3, 2016https://github.com/nodejs/node/pull/8886#issuecomment-251078710
c1be609https://github.com/nodejs/node/commit/c1be60945a0fa829b546ec162f6f7e8ece83e3ba
Please reload this pagehttps://github.com/nodejs/node/pull/8886
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 3, 2016https://github.com/nodejs/node/pull/8886#event-810106676
fhinkelhttps://github.com/fhinkel
Oct 3, 2016 https://github.com/nodejs/node/pull/8886#ref-commit-c1be609
https://github.com/bnoordhuis
https://github.com/fhinkel
build: don't build icu with -fno-rttihttps://github.com/nodejs/node/commit/c1be60945a0fa829b546ec162f6f7e8ece83e3ba
c1be609https://github.com/nodejs/node/commit/c1be60945a0fa829b546ec162f6f7e8ece83e3ba
#8867https://github.com/nodejs/node/issues/8867
#8886https://github.com/nodejs/node/pull/8886
jasnellhttps://github.com/jasnell
Oct 6, 2016 https://github.com/nodejs/node/pull/8886#ref-commit-d98ae6a
https://github.com/bnoordhuis
https://github.com/jasnell
build: don't build icu with -fno-rttihttps://github.com/nodejs/node/commit/d98ae6a5416b9ee34eb40bbb1b8ae785896f2bc1
d98ae6ahttps://github.com/nodejs/node/commit/d98ae6a5416b9ee34eb40bbb1b8ae785896f2bc1
#8867https://github.com/nodejs/node/issues/8867
#8886https://github.com/nodejs/node/pull/8886
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Oct 6, 2016https://github.com/nodejs/node/pull/8886#event-815565497
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 6, 2016https://github.com/nodejs/node/pull/8886#issuecomment-252119993
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/8886
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 7, 2016https://github.com/nodejs/node/pull/8886#issuecomment-252182257
Please reload this pagehttps://github.com/nodejs/node/pull/8886
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 7, 2016 https://github.com/nodejs/node/pull/8886#ref-issue-181683783
nodejs Linux clang libc++ no joy? #8973 https://github.com/nodejs/node/issues/8973
Fishrock123https://github.com/Fishrock123
Oct 11, 2016 https://github.com/nodejs/node/pull/8886#ref-commit-a202be6
https://github.com/bnoordhuis
https://github.com/Fishrock123
build: don't build icu with -fno-rttihttps://github.com/nodejs/node/commit/a202be6690d1ee40bd1a9d38300ee2f055553e11
a202be6https://github.com/nodejs/node/commit/a202be6690d1ee40bd1a9d38300ee2f055553e11
#8867https://github.com/nodejs/node/issues/8867
#8886https://github.com/nodejs/node/pull/8886
MylesBorinshttps://github.com/MylesBorins
Nov 18, 2016 https://github.com/nodejs/node/pull/8886#ref-commit-3919edb
https://github.com/bnoordhuis
build: don't build icu with -fno-rttihttps://github.com/nodejs/node/commit/3919edb47e5871226b196ad13f621f6f8363799d
3919edbhttps://github.com/nodejs/node/commit/3919edb47e5871226b196ad13f621f6f8363799d
#8867https://github.com/nodejs/node/issues/8867
#8886https://github.com/nodejs/node/pull/8886
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Nov 18, 2016https://github.com/nodejs/node/pull/8886#event-864969752
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 22, 2016 https://github.com/nodejs/node/pull/8886#ref-pullrequest-190943787
v4.7.0 proposal #9736 https://github.com/nodejs/node/pull/9736
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Aug 23, 2017 https://github.com/nodejs/node/pull/8886#ref-issue-249796699
_ZNKSt9type_infoeqERKS_ not found with gcc 6.3.0.1 on AIX 7.1 #14785 https://github.com/nodejs/node/issues/14785
https://github.com/srl295
srl295https://github.com/srl295
Aug 30, 2017 https://github.com/nodejs/node/pull/8886#pullrequestreview-59667585
View reviewed changes https://github.com/nodejs/node/pull/8886/files/dae477118a104665338c3b38f0f16597e85f12c0
srl295https://github.com/srl295
https://github.com/nodejs/node/pull/8886#pullrequestreview-59667585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8886
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8886
https://github.com/srl295
srl295 https://github.com/srl295
https://github.com/nodejs/node/pull/8886/files/dae477118a104665338c3b38f0f16597e85f12c0
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/8886/files/dae477118a104665338c3b38f0f16597e85f12c0
https://github.com/jbergstroem
jbergstroem https://github.com/jbergstroem
https://github.com/nodejs/node/pull/8886/files/dae477118a104665338c3b38f0f16597e85f12c0
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
Please reload this pagehttps://github.com/nodejs/node/pull/8886
https://github.com/bnoordhuis
https://github.com/fhinkel
https://github.com/MylesBorins
https://github.com/jbergstroem
https://github.com/srl295
https://github.com/mscdex
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.