| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b18c47ae-6d54-8e31-6438-9340988df1a0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 93A2:28AE23:2D4669:3F26CF:696A721D |
| html-safe-nonce | 333d080bd0f76ea8b6c7f265131b8850f8e104eafb26a74bff36d836c7ea1c67 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0EyOjI4QUUyMzoyRDQ2Njk6M0YyNkNGOjY5NkE3MjFEIiwidmlzaXRvcl9pZCI6Ijc1OTcwMjc1NDYwODc3MTUzNTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c5cbe37b54ddcc43d808423be0bcc0066e7370b87808b6fe0c6fa5743319c440 |
| hovercard-subject-tag | pull_request:87576543 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8873/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/805db640b044deb71d987ec7cb4fe95e6bac29929f678aebab9061de4b7f9993/nodejs/node/pull/8873 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/805db640b044deb71d987ec7cb4fe95e6bac29929f678aebab9061de4b7f9993/nodejs/node/pull/8873 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
lib
Description of change
This is a known de-opt. ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MylesBorins |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8873#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8873 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8873 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8873 |
| Reload | https://github.com/nodejs/node/pull/8873 |
| Reload | https://github.com/nodejs/node/pull/8873 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/8873#issue-comment-box |
| MylesBorins | https://github.com/MylesBorins |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| MylesBorins:for-de-let | https://github.com/MylesBorins/node/tree/for-de-let |
|
meta: remove let from for loops
| https://github.com/nodejs/node/pull/8873#top |
| MylesBorins | https://github.com/MylesBorins |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| MylesBorins:for-de-let | https://github.com/MylesBorins/node/tree/for-de-let |
|
Conversation
23
| https://github.com/nodejs/node/pull/8873 |
|
Commits
1
| https://github.com/nodejs/node/pull/8873/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/8873/checks |
|
Files changed
| https://github.com/nodejs/node/pull/8873/files |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/8873#issue-180415944 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/8873#event-809112272 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/8873#event-809112298 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/8873#event-809112382 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/dd23ad33783041527c951638e59d86729939bdf1..abdf1a01d5994c997505a0a12273a687f09cd86f |
| dd23ad3 | https://github.com/nodejs/node/commit/dd23ad33783041527c951638e59d86729939bdf1 |
| abdf1a0 | https://github.com/nodejs/node/commit/abdf1a01d5994c997505a0a12273a687f09cd86f |
|
Compare
| https://github.com/nodejs/node/compare/dd23ad33783041527c951638e59d86729939bdf1..abdf1a01d5994c997505a0a12273a687f09cd86f |
| September 30, 2016 22:34 | https://github.com/nodejs/node/pull/8873#event-809112708 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Oct 1, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-250879513 |
| https://ci.nodejs.org/job/node-test-pull-request/4343/ | https://ci.nodejs.org/job/node-test-pull-request/4343/ |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Oct 1, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-250880541 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/abdf1a01d5994c997505a0a12273a687f09cd86f..42b97cfe0dde82dde11fabf21c271f90e2364dff |
| abdf1a0 | https://github.com/nodejs/node/commit/abdf1a01d5994c997505a0a12273a687f09cd86f |
| 42b97cf | https://github.com/nodejs/node/commit/42b97cfe0dde82dde11fabf21c271f90e2364dff |
|
Compare
| https://github.com/nodejs/node/compare/abdf1a01d5994c997505a0a12273a687f09cd86f..42b97cfe0dde82dde11fabf21c271f90e2364dff |
| October 1, 2016 00:41 | https://github.com/nodejs/node/pull/8873#event-809183463 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 1, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-250881707 |
| https://ci.nodejs.org/job/node-test-pull-request/4344/ | https://ci.nodejs.org/job/node-test-pull-request/4344/ |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 1, 2016
| https://github.com/nodejs/node/pull/8873#pullrequestreview-2427093 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8873/files |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Oct 1, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-250895534 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 1, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-250895677 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://ci.nodejs.org/job/node-test-binary-windows/4129/RUN_SUBSET=0,VS_VERSION=vs2015,label=win2012r2/tapTestReport/test.tap-238/ | https://ci.nodejs.org/job/node-test-binary-windows/4129/RUN_SUBSET=0,VS_VERSION=vs2015,label=win2012r2/tapTestReport/test.tap-238/ |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Oct 1, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-250896501 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 1, 2016
| https://github.com/nodejs/node/pull/8873#pullrequestreview-2429116 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8873/files |
| lpinca | https://github.com/lpinca |
| https://github.com/nodejs/node/pull/8873#pullrequestreview-2429116 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
|
Oct 1, 2016
| https://github.com/nodejs/node/pull/8873#pullrequestreview-2430865 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8873/files |
| jbergstroem | https://github.com/jbergstroem |
| https://github.com/nodejs/node/pull/8873#pullrequestreview-2430865 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 1, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-250924036 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
|
Oct 1, 2016
| https://github.com/nodejs/node/pull/8873#pullrequestreview-2437471 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8873/files |
| imyller | https://github.com/imyller |
| https://github.com/nodejs/node/pull/8873#pullrequestreview-2437471 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/AndreasMadsen |
| AndreasMadsen | https://github.com/AndreasMadsen |
|
Oct 1, 2016
| https://github.com/nodejs/node/pull/8873#ref-pullrequest-172666763 |
|
Prototype for running a subset of benchmarks on a pull request
nodejs/benchmarking#58
| https://github.com/nodejs/benchmarking/pull/58 |
| https://github.com/AndreasMadsen |
| AndreasMadsen | https://github.com/AndreasMadsen |
| Oct 2, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-250962136 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| meta: remove let from for loops | https://github.com/nodejs/node/pull/8873/commits/95ba482a8ee663a1333ccc52b372e81d39df7166 |
| 95ba482 | https://github.com/nodejs/node/pull/8873/commits/95ba482a8ee663a1333ccc52b372e81d39df7166 |
| nodejs#8873 | https://github.com/nodejs/node/pull/8873 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/42b97cfe0dde82dde11fabf21c271f90e2364dff..95ba482a8ee663a1333ccc52b372e81d39df7166 |
| 42b97cf | https://github.com/nodejs/node/commit/42b97cfe0dde82dde11fabf21c271f90e2364dff |
| 95ba482 | https://github.com/nodejs/node/commit/95ba482a8ee663a1333ccc52b372e81d39df7166 |
|
Compare
| https://github.com/nodejs/node/compare/42b97cfe0dde82dde11fabf21c271f90e2364dff..95ba482a8ee663a1333ccc52b372e81d39df7166 |
| October 4, 2016 15:33 | https://github.com/nodejs/node/pull/8873#event-811943260 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| 95ba482 | https://github.com/nodejs/node/commit/95ba482a8ee663a1333ccc52b372e81d39df7166 |
| Oct 4, 2016 | https://github.com/nodejs/node/pull/8873#event-811945081 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Oct 4, 2016 | https://github.com/nodejs/node/pull/8873#event-811945687 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Oct 4, 2016
| https://github.com/nodejs/node/pull/8873#ref-pullrequest-180491340 |
|
doc: correct grammar in README.md
#8892
| https://github.com/nodejs/node/pull/8892 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Oct 4, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-251434804 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 4, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-251435124 |
| @gibfahn | https://github.com/gibfahn |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Oct 4, 2016 | https://github.com/nodejs/node/pull/8873#event-812009200 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Oct 4, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-251436603 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 4, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-251436701 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 4, 2016
| https://github.com/nodejs/node/pull/8873#ref-commit-2e568d9 |
| lib: remove let from for loops | https://github.com/MylesBorins/node/commit/2e568d95bdd689494b163f1cfe8bbc38f32e45ed |
| 2e568d9 | https://github.com/MylesBorins/node/commit/2e568d95bdd689494b163f1cfe8bbc38f32e45ed |
| nodejs#8873 | https://github.com/nodejs/node/pull/8873 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 4, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-251437300 |
| 2e568d9 | https://github.com/nodejs/node/commit/2e568d95bdd689494b163f1cfe8bbc38f32e45ed |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| jasnell | https://github.com/jasnell |
|
Oct 6, 2016
| https://github.com/nodejs/node/pull/8873#ref-commit-ab33ed0 |
|
| https://github.com/jasnell |
| lib: remove let from for loops | https://github.com/nodejs/node/commit/ab33ed01f30b7714cce7bde0814ba877fae9533c |
| ab33ed0 | https://github.com/nodejs/node/commit/ab33ed01f30b7714cce7bde0814ba877fae9533c |
| #8873 | https://github.com/nodejs/node/pull/8873 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 11, 2016
| https://github.com/nodejs/node/pull/8873#ref-commit-ba361a2 |
|
| https://github.com/Fishrock123 |
| lib: remove let from for loops | https://github.com/nodejs/node/commit/ba361a2aa0be68c2294c02cc583d65f28a3b4fa1 |
| ba361a2 | https://github.com/nodejs/node/commit/ba361a2aa0be68c2294c02cc583d65f28a3b4fa1 |
| #8873 | https://github.com/nodejs/node/pull/8873 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 12, 2016
| https://github.com/nodejs/node/pull/8873#ref-issue-182420639 |
|
Create Lint Rule to avoid let in for loops
#9045
| https://github.com/nodejs/node/issues/9045 |
| https://github.com/jalafel |
| jalafel | https://github.com/jalafel |
|
Oct 12, 2016
| https://github.com/nodejs/node/pull/8873#ref-pullrequest-182438962 |
|
tools: avoid let in for loops
#9049
| https://github.com/nodejs/node/pull/9049 |
| jalafel | https://github.com/jalafel |
|
Oct 14, 2016
| https://github.com/nodejs/node/pull/8873#ref-commit-8b704d6 |
|
| https://github.com/jalafel |
| tools: avoid let in for loops | https://github.com/jalafel/node/commit/8b704d6b5e9992246eb9da00be6477d9b54a20d6 |
| 8b704d6 | https://github.com/jalafel/node/commit/8b704d6b5e9992246eb9da00be6477d9b54a20d6 |
| nodejs#9045 | https://github.com/nodejs/node/issues/9045 |
| nodejs#8873 | https://github.com/nodejs/node/pull/8873 |
| Trott | https://github.com/Trott |
|
Oct 14, 2016
| https://github.com/nodejs/node/pull/8873#ref-commit-b16a97e |
|
| https://github.com/jalafel |
|
| https://github.com/Trott |
| tools: avoid let in for loops | https://github.com/Trott/io.js/commit/b16a97e042657d4f20c0716c69fb61652c857117 |
| b16a97e | https://github.com/Trott/io.js/commit/b16a97e042657d4f20c0716c69fb61652c857117 |
| nodejs#9045 | https://github.com/nodejs/node/issues/9045 |
| nodejs#8873 | https://github.com/nodejs/node/pull/8873 |
| nodejs#9049 | https://github.com/nodejs/node/pull/9049 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2016
| https://github.com/nodejs/node/pull/8873#ref-commit-8ac29bd |
|
| https://github.com/jalafel |
|
| https://github.com/jasnell |
| tools: avoid let in for loops | https://github.com/nodejs/node/commit/8ac29bd7c105c1d6e2a1d6e1eec9350a7f5a6109 |
| 8ac29bd | https://github.com/nodejs/node/commit/8ac29bd7c105c1d6e2a1d6e1eec9350a7f5a6109 |
| #9045 | https://github.com/nodejs/node/issues/9045 |
| #8873 | https://github.com/nodejs/node/pull/8873 |
| #9049 | https://github.com/nodejs/node/pull/9049 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 19, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-254833074 |
| #9171 | https://github.com/nodejs/node/pull/9171 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 11, 2016
| https://github.com/nodejs/node/pull/8873#ref-commit-87285ed |
|
| https://github.com/jalafel |
| tools: avoid let in for loops | https://github.com/nodejs/node/commit/87285ed984535a152a63e4ca6c047dbf8cae25af |
| 87285ed | https://github.com/nodejs/node/commit/87285ed984535a152a63e4ca6c047dbf8cae25af |
| #9045 | https://github.com/nodejs/node/issues/9045 |
| #8873 | https://github.com/nodejs/node/pull/8873 |
| #9049 | https://github.com/nodejs/node/pull/9049 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 11, 2016
| https://github.com/nodejs/node/pull/8873#ref-pullrequest-188842299 |
|
Backport removing let in for loop declaration
#9553
| https://github.com/nodejs/node/pull/9553 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 11, 2016
| https://github.com/nodejs/node/pull/8873#ref-commit-d7b9f36 |
| lib: remove let from for loops | https://github.com/MylesBorins/node/commit/d7b9f361df1f28ddd12dcc636270100b05f2a559 |
| d7b9f36 | https://github.com/MylesBorins/node/commit/d7b9f361df1f28ddd12dcc636270100b05f2a559 |
| nodejs#9553 | https://github.com/nodejs/node/pull/9553 |
| nodejs#8873 | https://github.com/nodejs/node/pull/8873 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 11, 2016
| https://github.com/nodejs/node/pull/8873#ref-commit-d1d3379 |
|
| https://github.com/jalafel |
| tools: avoid let in for loops | https://github.com/MylesBorins/node/commit/d1d337926b3b4a9c1eb1b431addc9f2fc4b3e104 |
| d1d3379 | https://github.com/MylesBorins/node/commit/d1d337926b3b4a9c1eb1b431addc9f2fc4b3e104 |
| nodejs#9045 | https://github.com/nodejs/node/issues/9045 |
| nodejs#9553 | https://github.com/nodejs/node/pull/9553 |
| nodejs#8873 | https://github.com/nodejs/node/pull/8873 |
| nodejs#9049 | https://github.com/nodejs/node/pull/9049 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 14, 2016
| https://github.com/nodejs/node/pull/8873#ref-commit-4238460 |
| lib: remove let from for loops | https://github.com/nodejs/node/commit/423846053b0f66e4822166b6e8191f75a1d0970c |
| 4238460 | https://github.com/nodejs/node/commit/423846053b0f66e4822166b6e8191f75a1d0970c |
| #9553 | https://github.com/nodejs/node/pull/9553 |
| #8873 | https://github.com/nodejs/node/pull/8873 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 14, 2016
| https://github.com/nodejs/node/pull/8873#ref-commit-c8dccf2 |
|
| https://github.com/jalafel |
| tools: avoid let in for loops | https://github.com/nodejs/node/commit/c8dccf29dd8109a77fe0f79e68f4a08d32f7ea8d |
| c8dccf2 | https://github.com/nodejs/node/commit/c8dccf29dd8109a77fe0f79e68f4a08d32f7ea8d |
| #9045 | https://github.com/nodejs/node/issues/9045 |
| #9553 | https://github.com/nodejs/node/pull/9553 |
| #8873 | https://github.com/nodejs/node/pull/8873 |
| #9049 | https://github.com/nodejs/node/pull/9049 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/8873#event-864968426 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/8873#ref-pullrequest-190943787 |
|
v4.7.0 proposal
#9736
| https://github.com/nodejs/node/pull/9736 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Dec 2, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-264478621 |
| https://bugs.chromium.org/p/v8/issues/detail?id=5666#c10 | https://bugs.chromium.org/p/v8/issues/detail?id=5666#c10 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 2, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-264478865 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 2, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-264481880 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 2, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-264482117 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Dec 2, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-264483831 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| @ofrobots | https://github.com/ofrobots |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Dec 2, 2016
| https://github.com/nodejs/node/pull/8873#ref-issue-193126651 |
|
let var in loop (question)
hapijs/hapi#3403
| https://github.com/hapijs/hapi/issues/3403 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Dec 3, 2016 | https://github.com/nodejs/node/pull/8873#issuecomment-264618973 |
| Ignition and TurboFan being significantly more prominent | http://benediktmeurer.de/2016/11/25/v8-behind-the-scenes-november-edition/ |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| November 14, 2017 17:43 | https://github.com/nodejs/node/pull/8873#event-1341394645 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8873 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/8873/files/42b97cfe0dde82dde11fabf21c271f90e2364dff |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/8873/files/42b97cfe0dde82dde11fabf21c271f90e2364dff |
|
| https://github.com/jbergstroem |
|
jbergstroem
| https://github.com/jbergstroem |
|
| https://github.com/nodejs/node/pull/8873/files/42b97cfe0dde82dde11fabf21c271f90e2364dff |
|
| https://github.com/imyller |
|
imyller
| https://github.com/imyller |
|
| https://github.com/nodejs/node/pull/8873/files/42b97cfe0dde82dde11fabf21c271f90e2364dff |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/8873 |
|
| https://github.com/MylesBorins |
|
| https://github.com/mscdex |
|
| https://github.com/ChALkeR |
|
| https://github.com/AndreasMadsen |
|
| https://github.com/gibfahn |
|
| https://github.com/addaleax |
|
| https://github.com/ofrobots |
|
| https://github.com/Trott |
|
| https://github.com/jbergstroem |
|
| https://github.com/lpinca |
|
| https://github.com/imyller |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |