| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:05b335b1-88d1-4f93-18cf-c3a198746a05 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DBE2:C76DF:137B8:1AF4F:696A6453 |
| html-safe-nonce | d9261f78a6b6487d00383c772cee648be4266bef2c3cdc6a6e72e63405f78ec7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkUyOkM3NkRGOjEzN0I4OjFBRjRGOjY5NkE2NDUzIiwidmlzaXRvcl9pZCI6Ijc2MDQ2NDAxNTY1NzY1Mzk3MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 860c96e8df3181bc85360e51dd9fea3867f9cabd99a9e6c871f2a60894aeaa9a |
| hovercard-subject-tag | pull_request:86856708 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8799/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/735274b74efb21045cd002787deb6ddb33c29d9081c4bcb4ce81c109e741a1cd/nodejs/node/pull/8799 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/735274b74efb21045cd002787deb6ddb33c29d9081c4bcb4ce81c109e741a1cd/nodejs/node/pull/8799 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines
Affect... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | italoacasas |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8799#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8799 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8799 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8799 |
| Reload | https://github.com/nodejs/node/pull/8799 |
| Reload | https://github.com/nodejs/node/pull/8799 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/8799#issue-comment-box |
| italoacasas | https://github.com/italoacasas |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
adding test for _stream_writable.js needDrain state
| https://github.com/nodejs/node/pull/8799#top |
| italoacasas | https://github.com/italoacasas |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
9
| https://github.com/nodejs/node/pull/8799 |
|
Commits
1
| https://github.com/nodejs/node/pull/8799/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/8799/checks |
|
Files changed
| https://github.com/nodejs/node/pull/8799/files |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Sep 27, 2016 | https://github.com/nodejs/node/pull/8799#issue-179389333 |
| #8686 | https://github.com/nodejs/node/issues/8686 |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Sep 27, 2016 | https://github.com/nodejs/node/pull/8799#event-803222511 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Sep 27, 2016 | https://github.com/nodejs/node/pull/8799#event-803307569 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 27, 2016
| https://github.com/nodejs/node/pull/8799#pullrequestreview-1748095 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8799/files |
| test/parallel/test-stream-writable-needdrain-state.js | https://github.com/nodejs/node/pull/8799/files#diff-db8aaa122cc38d19a37eb2d7b48a6e280b7f9a94cd223074e7eb9dc502b2db6c |
| jasnell | https://github.com/jasnell |
| Sep 27, 2016 | https://github.com/nodejs/node/pull/8799#discussion_r80710545 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 30, 2016
| https://github.com/nodejs/node/pull/8799#pullrequestreview-2337363 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8799/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/8799#pullrequestreview-2337363 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 30, 2016
| https://github.com/nodejs/node/pull/8799#pullrequestreview-2355739 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8799/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/8799#pullrequestreview-2355739 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/8799#issuecomment-250786337 |
| https://ci.nodejs.org/job/node-test-pull-request/4334/ | https://ci.nodejs.org/job/node-test-pull-request/4334/ |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| test: writable stream needDrain state | https://github.com/nodejs/node/pull/8799/commits/4b9c5032a7b55d0dc5b24a68367c63ddbdbb52e8 |
| 4b9c503 | https://github.com/nodejs/node/pull/8799/commits/4b9c5032a7b55d0dc5b24a68367c63ddbdbb52e8 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| force-pushed | https://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0 |
| c133999 | https://github.com/nodejs/node/commit/c13399980463b0a8691ea2cff9191aa5aede8d0e |
| 83c7a88 | https://github.com/nodejs/node/commit/83c7a8897c644e1eadeaaace4863a822c73359a0 |
|
Compare
| https://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0 |
| October 18, 2016 17:02 | https://github.com/nodejs/node/pull/8799#event-827820713 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Oct 25, 2016 | https://github.com/nodejs/node/pull/8799#issuecomment-255915842 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/8799#pullrequestreview-5825244 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8799/files/4b9c5032a7b55d0dc5b24a68367c63ddbdbb52e8 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/8799#pullrequestreview-5825244 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Oct 26, 2016 | https://github.com/nodejs/node/pull/8799#issuecomment-256306302 |
| https://ci.nodejs.org/job/node-test-pull-request/4681/ | https://ci.nodejs.org/job/node-test-pull-request/4681/ |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Oct 26, 2016 | https://github.com/nodejs/node/pull/8799#issuecomment-256326870 |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/8799#pullrequestreview-5848108 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8799/files/4b9c5032a7b55d0dc5b24a68367c63ddbdbb52e8 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/8799#issuecomment-256848201 |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| 9ed7261 | https://github.com/nodejs/node/commit/9ed7261b57ca05d1a08583bbb0897e35bb78ebdc |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Oct 28, 2016 | https://github.com/nodejs/node/pull/8799#event-839643475 |
| mcollina | https://github.com/mcollina |
|
Oct 28, 2016
| https://github.com/nodejs/node/pull/8799#ref-commit-9ed7261 |
|
| https://github.com/mcollina |
| test: writable stream needDrain state | https://github.com/nodejs/node/commit/9ed7261b57ca05d1a08583bbb0897e35bb78ebdc |
| 9ed7261 | https://github.com/nodejs/node/commit/9ed7261b57ca05d1a08583bbb0897e35bb78ebdc |
| #8799 | https://github.com/nodejs/node/pull/8799 |
| #8686 | https://github.com/nodejs/node/issues/8686 |
| evanlucas | https://github.com/evanlucas |
|
Nov 3, 2016
| https://github.com/nodejs/node/pull/8799#ref-commit-c9b67c6 |
|
| https://github.com/evanlucas |
| test: writable stream needDrain state | https://github.com/nodejs/node/commit/c9b67c6a91ce124f4ac2a495a0a0ee14609e1359 |
| c9b67c6 | https://github.com/nodejs/node/commit/c9b67c6a91ce124f4ac2a495a0a0ee14609e1359 |
| #8799 | https://github.com/nodejs/node/pull/8799 |
| #8686 | https://github.com/nodejs/node/issues/8686 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Nov 3, 2016
| https://github.com/nodejs/node/pull/8799#ref-pullrequest-187029471 |
|
v7.1.0 proposal - 2016-11-08
#9438
| https://github.com/nodejs/node/pull/9438 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/8799#ref-commit-4b50419 |
| test: writable stream needDrain state | https://github.com/nodejs/node/commit/4b50419bbfe0c9e1f5e61456411f7ef17afe7262 |
| 4b50419 | https://github.com/nodejs/node/commit/4b50419bbfe0c9e1f5e61456411f7ef17afe7262 |
| #8799 | https://github.com/nodejs/node/pull/8799 |
| #8686 | https://github.com/nodejs/node/issues/8686 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/8799#ref-commit-40ef239 |
| test: writable stream needDrain state | https://github.com/nodejs/node/commit/40ef23969d8f86842a8a9102a10f249ea8eb52c2 |
| 40ef239 | https://github.com/nodejs/node/commit/40ef23969d8f86842a8a9102a10f249ea8eb52c2 |
| #8799 | https://github.com/nodejs/node/pull/8799 |
| #8686 | https://github.com/nodejs/node/issues/8686 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/8799#event-864782505 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 19, 2016
| https://github.com/nodejs/node/pull/8799#ref-commit-1fee6c1 |
|
| https://github.com/MylesBorins |
| test: writable stream needDrain state | https://github.com/nodejs/node/commit/1fee6c11e5071ca8de09e1c5541c2e198894508e |
| 1fee6c1 | https://github.com/nodejs/node/commit/1fee6c11e5071ca8de09e1c5541c2e198894508e |
| #8799 | https://github.com/nodejs/node/pull/8799 |
| #8686 | https://github.com/nodejs/node/issues/8686 |
|
v6.9.2 proposal
#9735
| https://github.com/nodejs/node/pull/9735 |
|
v4.7.0 proposal
#9736
| https://github.com/nodejs/node/pull/9736 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8799 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/8799/files/4b9c5032a7b55d0dc5b24a68367c63ddbdbb52e8 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/8799/files/56c2daf0ddf5c20b591e016a574b70bc9b182f77 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/8799/files/56c2daf0ddf5c20b591e016a574b70bc9b182f77 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/8799/files/4b9c5032a7b55d0dc5b24a68367c63ddbdbb52e8 |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/8799 |
|
| https://github.com/italoacasas |
|
| https://github.com/jasnell |
|
| https://github.com/mcollina |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
|
| https://github.com/lpinca |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |