| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:631b7e54-1747-d0d3-77f9-659f28eb6a3e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E062:2B7A56:62B1F4:8B72D1:696A53A5 |
| html-safe-nonce | 70dd84ed9b22f101760cdea642a6e154c861d5dde84d8528bc0fb2fc2f73568e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDYyOjJCN0E1Njo2MkIxRjQ6OEI3MkQxOjY5NkE1M0E1IiwidmlzaXRvcl9pZCI6IjgxNDQ1ODUxOTg3NDU4OTYwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 635934cbfd3a6097cb54496a3df8aad6cd56bf50d490f569178e43353d3a70de |
| hovercard-subject-tag | pull_request:86795101 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8795/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2a684cb973776c504bc74620f0000fc24dd239be219c0f06c4d5adf39eaf5a7a/nodejs/node/pull/8795 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2a684cb973776c504bc74620f0000fc24dd239be219c0f06c4d5adf39eaf5a7a/nodejs/node/pull/8795 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
Windows, MSI.
Description of change
When installing w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joaocgreis |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8795#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8795 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8795 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8795 |
| Reload | https://github.com/nodejs/node/pull/8795 |
| Reload | https://github.com/nodejs/node/pull/8795 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/8795#issue-comment-box |
| joaocgreis | https://github.com/joaocgreis |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| JaneaSystems:joaocgreis-G9Q-INSTALLDIR-secure | https://github.com/JaneaSystems/node/tree/joaocgreis-G9Q-INSTALLDIR-secure |
|
win,msi: mark INSTALLDIR property as secure
| https://github.com/nodejs/node/pull/8795#top |
| joaocgreis | https://github.com/joaocgreis |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| JaneaSystems:joaocgreis-G9Q-INSTALLDIR-secure | https://github.com/JaneaSystems/node/tree/joaocgreis-G9Q-INSTALLDIR-secure |
|
Conversation
7
| https://github.com/nodejs/node/pull/8795 |
|
Commits
1
| https://github.com/nodejs/node/pull/8795/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/8795/checks |
|
Files changed
| https://github.com/nodejs/node/pull/8795/files |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Sep 26, 2016 | https://github.com/nodejs/node/pull/8795#issue-179304288 |
| #6057 | https://github.com/nodejs/node/issues/6057 |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
|
| https://github.com/joaocgreis |
| win,msi: mark INSTALLDIR property as secure | https://github.com/nodejs/node/pull/8795/commits/c01a163c603014bea1497f79d63b182bab37053e |
| c01a163 | https://github.com/nodejs/node/pull/8795/commits/c01a163c603014bea1497f79d63b182bab37053e |
| nodejs#6057 | https://github.com/nodejs/node/issues/6057 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
|
install
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainstall |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Sep 26, 2016 | https://github.com/nodejs/node/pull/8795#event-802729916 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Sep 26, 2016 | https://github.com/nodejs/node/pull/8795#event-802729987 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Sep 26, 2016 | https://github.com/nodejs/node/pull/8795#issuecomment-249657653 |
| https://ci.nodejs.org/view/All/job/node-test-pull-request/4292/ | https://ci.nodejs.org/view/All/job/node-test-pull-request/4292/ |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Sep 26, 2016 | https://github.com/nodejs/node/pull/8795#issuecomment-249658935 |
| http://wixtoolset.org/documentation/manual/v3/xsd/wix/property.html | http://wixtoolset.org/documentation/manual/v3/xsd/wix/property.html |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 27, 2016
| https://github.com/nodejs/node/pull/8795#pullrequestreview-1745642 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8795/files/c01a163c603014bea1497f79d63b182bab37053e |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/8795#pullrequestreview-1745642 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
| https://github.com/jasongin |
| jasongin | https://github.com/jasongin |
| Sep 27, 2016 | https://github.com/nodejs/node/pull/8795#issuecomment-249934166 |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 7, 2016 | https://github.com/nodejs/node/pull/8795#issuecomment-252318436 |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Oct 7, 2016 | https://github.com/nodejs/node/pull/8795#issuecomment-252367384 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8795#issuecomment-252673785 |
| 4896f0f | https://github.com/nodejs/node/commit/4896f0f6103154da355606653606bc79b0f8f01d |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8795#event-818284867 |
| joaocgreis | https://github.com/joaocgreis |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/8795#ref-commit-4896f0f |
|
| https://github.com/joaocgreis |
| win,msi: mark INSTALLDIR property as secure | https://github.com/nodejs/node/commit/4896f0f6103154da355606653606bc79b0f8f01d |
| 4896f0f | https://github.com/nodejs/node/commit/4896f0f6103154da355606653606bc79b0f8f01d |
| #8795 | https://github.com/nodejs/node/pull/8795 |
| #6057 | https://github.com/nodejs/node/issues/6057 |
| jasnell | https://github.com/jasnell |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/8795#ref-commit-58550fd |
|
| https://github.com/joaocgreis |
|
| https://github.com/jasnell |
| win,msi: mark INSTALLDIR property as secure | https://github.com/nodejs/node/commit/58550fd6842571d7ba1f1ea184d045b6f4706581 |
| 58550fd | https://github.com/nodejs/node/commit/58550fd6842571d7ba1f1ea184d045b6f4706581 |
| #8795 | https://github.com/nodejs/node/pull/8795 |
| #6057 | https://github.com/nodejs/node/issues/6057 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 11, 2016
| https://github.com/nodejs/node/pull/8795#ref-commit-b83f51a |
|
| https://github.com/joaocgreis |
|
| https://github.com/Fishrock123 |
| win,msi: mark INSTALLDIR property as secure | https://github.com/nodejs/node/commit/b83f51a3265c3acfa485c1c05ad98178869a1c34 |
| b83f51a | https://github.com/nodejs/node/commit/b83f51a3265c3acfa485c1c05ad98178869a1c34 |
| #8795 | https://github.com/nodejs/node/pull/8795 |
| #6057 | https://github.com/nodejs/node/issues/6057 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/8795#ref-commit-bdb6cf9 |
|
| https://github.com/joaocgreis |
| win,msi: mark INSTALLDIR property as secure | https://github.com/nodejs/node/commit/bdb6cf92c75d6f3066ffbd202e95a7ba2d27f4a1 |
| bdb6cf9 | https://github.com/nodejs/node/commit/bdb6cf92c75d6f3066ffbd202e95a7ba2d27f4a1 |
| #8795 | https://github.com/nodejs/node/pull/8795 |
| #6057 | https://github.com/nodejs/node/issues/6057 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/8795#event-864957280 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/8795#ref-pullrequest-190943787 |
|
v4.7.0 proposal
#9736
| https://github.com/nodejs/node/pull/9736 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8795 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/8795/files/c01a163c603014bea1497f79d63b182bab37053e |
|
install
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainstall |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Please reload this page | https://github.com/nodejs/node/pull/8795 |
|
| https://github.com/joaocgreis |
|
| https://github.com/benjamingr |
|
| https://github.com/jasongin |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |