| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a179b11d-a54f-7f8b-1dc3-56812c1abdbe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8696:1E1D6F:E8A8BC:1412ED3:696A90F3 |
| html-safe-nonce | 0d2995c50375396e887ef5ae5b78189a1b238f19d560298357a74519767447fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Njk2OjFFMUQ2RjpFOEE4QkM6MTQxMkVEMzo2OTZBOTBGMyIsInZpc2l0b3JfaWQiOiIzMTg1MjY5MDExMzI2MjgyMTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e068d5388235196d49e0e60084a8ef10ce1bd7d84fa4e45ee4653cbcaf373b4b |
| hovercard-subject-tag | pull_request:85679985 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8634/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1fa8c9c755f0bfa5f3e29d641cde89762213d043369619ddf7365ad5166a4db3/nodejs/node/pull/8634 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1fa8c9c755f0bfa5f3e29d641cde89762213d043369619ddf7365ad5166a4db3/nodejs/node/pull/8634 |
| og:image:alt | Checklist
make -j4 test (UNIX) passes
commit message follows commit guidelines
Affected core subsystem(s)
vm, watchdog
Description of change
Add an error message if we abort because uv_init_l... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | fhinkel |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8634#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8634 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8634 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8634 |
| Reload | https://github.com/nodejs/node/pull/8634 |
| Reload | https://github.com/nodejs/node/pull/8634 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/8634#issue-comment-box |
| fhinkel | https://github.com/fhinkel |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| fhinkel:i8555 | https://github.com/fhinkel/node/tree/i8555 |
|
src: add error message if we abort
| https://github.com/nodejs/node/pull/8634#top |
| fhinkel | https://github.com/fhinkel |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| fhinkel:i8555 | https://github.com/fhinkel/node/tree/i8555 |
|
Conversation
30
| https://github.com/nodejs/node/pull/8634 |
|
Commits
1
| https://github.com/nodejs/node/pull/8634/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/8634/checks |
|
Files changed
| https://github.com/nodejs/node/pull/8634/files |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#issue-177591137 |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| #8555 | https://github.com/nodejs/node/issues/8555 |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#event-793050192 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#event-793050705 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 17, 2016
| https://github.com/nodejs/node/pull/8634#pullrequestreview-460254 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8634/files |
| src/node_watchdog.cc | https://github.com/nodejs/node/pull/8634/files#diff-bb0739d9e70b7fda9e825ede9d654a832e29f7c538657a52804a4b645d322ff1 |
| targos | https://github.com/targos |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79287889 |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| fhinkel | https://github.com/fhinkel |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79288096 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| src/node_watchdog.cc | https://github.com/nodejs/node/pull/8634/files#diff-bb0739d9e70b7fda9e825ede9d654a832e29f7c538657a52804a4b645d322ff1 |
| targos | https://github.com/targos |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79287908 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Sep 17, 2016
| https://github.com/nodejs/node/pull/8634#pullrequestreview-460261 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8634/files |
| src/node_watchdog.cc | https://github.com/nodejs/node/pull/8634/files#diff-bb0739d9e70b7fda9e825ede9d654a832e29f7c538657a52804a4b645d322ff1 |
| cjihrig | https://github.com/cjihrig |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79287895 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| src/node_watchdog.cc | https://github.com/nodejs/node/pull/8634/files#diff-bb0739d9e70b7fda9e825ede9d654a832e29f7c538657a52804a4b645d322ff1 |
| cjihrig | https://github.com/cjihrig |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79287942 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| Fishrock123 | https://github.com/Fishrock123 |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79288025 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| fhinkel | https://github.com/fhinkel |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79288235 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| fhinkel | https://github.com/fhinkel |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79288306 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| addaleax | https://github.com/addaleax |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79289732 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| jasnell | https://github.com/jasnell |
| Sep 20, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79683070 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| force-pushed | https://github.com/nodejs/node/compare/33e05fae22e44b754f16db1bb051d2e6651f27ca..738323309828a8fd2fdb98cd37bee48924b323c5 |
| 33e05fa | https://github.com/nodejs/node/commit/33e05fae22e44b754f16db1bb051d2e6651f27ca |
| 7383233 | https://github.com/nodejs/node/commit/738323309828a8fd2fdb98cd37bee48924b323c5 |
|
Compare
| https://github.com/nodejs/node/compare/33e05fae22e44b754f16db1bb051d2e6651f27ca..738323309828a8fd2fdb98cd37bee48924b323c5 |
| September 17, 2016 17:09 | https://github.com/nodejs/node/pull/8634#event-793054003 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 17, 2016
| https://github.com/nodejs/node/pull/8634#pullrequestreview-460520 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8634/files |
| src/node_watchdog.cc | https://github.com/nodejs/node/pull/8634/files#diff-bb0739d9e70b7fda9e825ede9d654a832e29f7c538657a52804a4b645d322ff1 |
| targos | https://github.com/targos |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79288191 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| fhinkel | https://github.com/fhinkel |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79288233 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| force-pushed | https://github.com/nodejs/node/compare/892de3330c2d42a14e555c9cf1b561ba01e0ca1c..7fe7b13cee46c9321feae2e095c14fbf0142b057 |
| 892de33 | https://github.com/nodejs/node/commit/892de3330c2d42a14e555c9cf1b561ba01e0ca1c |
| 7fe7b13 | https://github.com/nodejs/node/commit/7fe7b13cee46c9321feae2e095c14fbf0142b057 |
|
Compare
| https://github.com/nodejs/node/compare/892de3330c2d42a14e555c9cf1b561ba01e0ca1c..7fe7b13cee46c9321feae2e095c14fbf0142b057 |
| September 17, 2016 17:32 | https://github.com/nodejs/node/pull/8634#event-793064711 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
vm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#event-793107899 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-247815176 |
| https://ci.nodejs.org/job/node-test-pull-request/4098/ | https://ci.nodejs.org/job/node-test-pull-request/4098/ |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Sep 17, 2016
| https://github.com/nodejs/node/pull/8634#pullrequestreview-465752 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8634/files |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/8634#pullrequestreview-465752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
|
Sep 18, 2016
| https://github.com/nodejs/node/pull/8634#pullrequestreview-472073 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8634/files |
| imyller | https://github.com/imyller |
| https://github.com/nodejs/node/pull/8634#pullrequestreview-472073 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
| Sep 18, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-247838168 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 18, 2016
| https://github.com/nodejs/node/pull/8634#pullrequestreview-472352 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8634/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/8634#pullrequestreview-472352 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| src/node_watchdog.cc | https://github.com/nodejs/node/pull/8634/files#diff-bb0739d9e70b7fda9e825ede9d654a832e29f7c538657a52804a4b645d322ff1 |
| addaleax | https://github.com/addaleax |
| Sep 18, 2016 | https://github.com/nodejs/node/pull/8634#discussion_r79302354 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
|
| https://github.com/fhinkel |
| vm: add error message if we abort | https://github.com/nodejs/node/pull/8634/commits/a1e3f7b19121d9e455f4391ceec5dc011824b201 |
| a1e3f7b | https://github.com/nodejs/node/pull/8634/commits/a1e3f7b19121d9e455f4391ceec5dc011824b201 |
| nodejs#8555 | https://github.com/nodejs/node/issues/8555 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| force-pushed | https://github.com/nodejs/node/compare/7fe7b13cee46c9321feae2e095c14fbf0142b057..a1e3f7b19121d9e455f4391ceec5dc011824b201 |
| 7fe7b13 | https://github.com/nodejs/node/commit/7fe7b13cee46c9321feae2e095c14fbf0142b057 |
| a1e3f7b | https://github.com/nodejs/node/commit/a1e3f7b19121d9e455f4391ceec5dc011824b201 |
|
Compare
| https://github.com/nodejs/node/compare/7fe7b13cee46c9321feae2e095c14fbf0142b057..a1e3f7b19121d9e455f4391ceec5dc011824b201 |
| September 20, 2016 09:32 | https://github.com/nodejs/node/pull/8634#event-795374737 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| Sep 20, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-248251859 |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://ci.nodejs.org/view/All/job/node-test-pull-request/4146/ | https://ci.nodejs.org/view/All/job/node-test-pull-request/4146/ |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| Sep 20, 2016 | https://github.com/nodejs/node/pull/8634#event-795400451 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
error-handling
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerror-handling |
| Sep 20, 2016 | https://github.com/nodejs/node/pull/8634#event-796127315 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 20, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-248393460 |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Sep 20, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-248452800 |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 20, 2016
| https://github.com/nodejs/node/pull/8634#pullrequestreview-859787 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8634/files/a1e3f7b19121d9e455f4391ceec5dc011824b201 |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/8634#pullrequestreview-859787 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720 |
| b0df363 | https://github.com/nodejs/node/commit/b0df363eda7d8a4314efaee5245b5073476c7362 |
| c5ce7f4 | https://github.com/nodejs/node/commit/c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720 |
|
Compare
| https://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720 |
| September 21, 2016 00:10 | https://github.com/nodejs/node/pull/8634#event-796539644 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
| Sep 22, 2016 | https://github.com/nodejs/node/pull/8634#event-799582883 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
| Sep 22, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-249043503 |
| https://ci.nodejs.org/job/node-test-pull-request/4228/ | https://ci.nodejs.org/job/node-test-pull-request/4228/ |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
| Sep 23, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-249063021 |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| imyller | https://github.com/imyller |
|
Sep 23, 2016
| https://github.com/nodejs/node/pull/8634#ref-commit-fba5319 |
|
| https://github.com/fhinkel |
|
| https://github.com/imyller |
| vm: add error message if we abort | https://github.com/imyller/node/commit/fba531907e170c034a30a86e7027a23c8b4fae89 |
| fba5319 | https://github.com/imyller/node/commit/fba531907e170c034a30a86e7027a23c8b4fae89 |
| nodejs#8634 | https://github.com/nodejs/node/pull/8634 |
| nodejs#8555 | https://github.com/nodejs/node/issues/8555 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
| Sep 23, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-249064395 |
| fba5319 | https://github.com/nodejs/node/commit/fba531907e170c034a30a86e7027a23c8b4fae89 |
| @fhinkel | https://github.com/fhinkel |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
| Sep 23, 2016 | https://github.com/nodejs/node/pull/8634#event-799696554 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
| Sep 23, 2016 | https://github.com/nodejs/node/pull/8634#event-799696605 |
| jasnell | https://github.com/jasnell |
|
Sep 29, 2016
| https://github.com/nodejs/node/pull/8634#ref-commit-01b3d5a |
|
| https://github.com/fhinkel |
|
| https://github.com/jasnell |
| vm: add error message if we abort | https://github.com/nodejs/node/commit/01b3d5a8a3786637061842289b02eb862069bd05 |
| 01b3d5a | https://github.com/nodejs/node/commit/01b3d5a8a3786637061842289b02eb862069bd05 |
| #8634 | https://github.com/nodejs/node/pull/8634 |
| #8555 | https://github.com/nodejs/node/issues/8555 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8634#event-815535447 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-252114295 |
| @fhinkel | https://github.com/fhinkel |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 11, 2016
| https://github.com/nodejs/node/pull/8634#ref-commit-8282d6f |
|
| https://github.com/fhinkel |
|
| https://github.com/Fishrock123 |
| vm: add error message if we abort | https://github.com/nodejs/node/commit/8282d6fc60f44788b1b1a353a798a001be4a3cea |
| 8282d6f | https://github.com/nodejs/node/commit/8282d6fc60f44788b1b1a353a798a001be4a3cea |
| #8634 | https://github.com/nodejs/node/pull/8634 |
| #8555 | https://github.com/nodejs/node/issues/8555 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 18, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-261636223 |
| @fhemberger | https://github.com/fhemberger |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/fhemberger |
| fhemberger | https://github.com/fhemberger |
| Nov 19, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-261694529 |
| @fhinkel | https://github.com/fhinkel |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-268624188 |
| @fhinkel | https://github.com/fhinkel |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| Dec 21, 2016 | https://github.com/nodejs/node/pull/8634#issuecomment-268630986 |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/8634#event-932260434 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/8634#ref-commit-2b6581c |
|
| https://github.com/fhinkel |
|
| https://github.com/MylesBorins |
| vm: add error message if we abort | https://github.com/nodejs/node/commit/2b6581c5d402080ab87e6a2af0e3f651e6d80c1f |
| 2b6581c | https://github.com/nodejs/node/commit/2b6581c5d402080ab87e6a2af0e3f651e6d80c1f |
| #8634 | https://github.com/nodejs/node/pull/8634 |
| #8555 | https://github.com/nodejs/node/issues/8555 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/8634#ref-commit-56a5857 |
|
| https://github.com/fhinkel |
|
| https://github.com/MylesBorins |
| vm: add error message if we abort | https://github.com/nodejs/node/commit/56a58572215e5b13b9b6f45e34c122baec91043e |
| 56a5857 | https://github.com/nodejs/node/commit/56a58572215e5b13b9b6f45e34c122baec91043e |
| #8634 | https://github.com/nodejs/node/pull/8634 |
| #8555 | https://github.com/nodejs/node/issues/8555 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/8634#ref-pullrequest-202753055 |
|
v4.8.0 proposal
#10973
| https://github.com/nodejs/node/pull/10973 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 1, 2017
| https://github.com/nodejs/node/pull/8634#ref-commit-9556ef3 |
|
| https://github.com/fhinkel |
|
| https://github.com/MylesBorins |
| vm: add error message if we abort | https://github.com/nodejs/node/commit/9556ef32410bc23915bd597941e212246022331f |
| 9556ef3 | https://github.com/nodejs/node/commit/9556ef32410bc23915bd597941e212246022331f |
| #8634 | https://github.com/nodejs/node/pull/8634 |
| #8555 | https://github.com/nodejs/node/issues/8555 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8634 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/8634/files/738323309828a8fd2fdb98cd37bee48924b323c5 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/8634/files/a1e3f7b19121d9e455f4391ceec5dc011824b201 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/8634/files/7fe7b13cee46c9321feae2e095c14fbf0142b057 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/8634/files/7fe7b13cee46c9321feae2e095c14fbf0142b057 |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs/node/pull/8634/files/33e05fae22e44b754f16db1bb051d2e6651f27ca |
|
| https://github.com/imyller |
|
imyller
| https://github.com/imyller |
|
| https://github.com/nodejs/node/pull/8634/files/7fe7b13cee46c9321feae2e095c14fbf0142b057 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
vm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm |
|
vm: node crashes if timeout is set and nofile limit is reached
| https://github.com/nodejs/node/issues/8555 |
| Please reload this page | https://github.com/nodejs/node/pull/8634 |
|
| https://github.com/fhinkel |
|
| https://github.com/imyller |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
|
| https://github.com/fhemberger |
|
| https://github.com/addaleax |
|
| https://github.com/Fishrock123 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |