| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:674b61b7-9ca8-b151-d3b1-ec17378f1a37 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E0C8:D1427:1DC78:26DE8:696AF372 |
| html-safe-nonce | 48505c235734f0bc140ac5df0b1ce254d9d035b916becd18668f1f56194a2ab3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEM4OkQxNDI3OjFEQzc4OjI2REU4OjY5NkFGMzcyIiwidmlzaXRvcl9pZCI6IjQ0MTM0ODA2MjgxNzQ2NDgxNzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8137e5eab9b5349e7bd9c46157c4eb84e0674019ac9b268bb6d8c9deca914846 |
| hovercard-subject-tag | pull_request:85672583 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8625/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/aa7e181ad74b8eb4a827a90ce9ea30b690c99479a011fa70c4878dfc5ccaa14e/nodejs/node/pull/8625 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/aa7e181ad74b8eb4a827a90ce9ea30b690c99479a011fa70c4878dfc5ccaa14e/nodejs/node/pull/8625 |
| og:image:alt | Checklist
commit message follows commit guidelines
Affected core subsystem(s)
?
Description of change
This changes var to let in test/parallel/test-async-wrap-post-did-throw.js. Replaces equal m... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | graphicbeacon |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8625#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8625 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8625 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8625 |
| Reload | https://github.com/nodejs/node/pull/8625 |
| Reload | https://github.com/nodejs/node/pull/8625 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/8625#issue-comment-box |
| graphicbeacon | https://github.com/graphicbeacon |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| graphicbeacon:master | https://github.com/graphicbeacon/node/tree/master |
|
test: Refactors test/parallel/test-async-wrap-post-did-throw.js
| https://github.com/nodejs/node/pull/8625#top |
| graphicbeacon | https://github.com/graphicbeacon |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| graphicbeacon:master | https://github.com/graphicbeacon/node/tree/master |
|
Conversation
8
| https://github.com/nodejs/node/pull/8625 |
|
Commits
2
| https://github.com/nodejs/node/pull/8625/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/8625/checks |
|
Files changed
| https://github.com/nodejs/node/pull/8625/files |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/graphicbeacon |
| graphicbeacon | https://github.com/graphicbeacon |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8625#issue-177571974 |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
| graphicbeacon | https://github.com/graphicbeacon |
| September 17, 2016 10:35 | https://github.com/nodejs/node/pull/8625#commits-pushed-747ed7f |
|
| https://github.com/graphicbeacon |
| test: Changes var to let in parallel/test-async-wrap-post-did-throw.j… | https://github.com/nodejs/node/pull/8625/commits/747ed7ffb54a1fdc312d8e098c7f0e7279b18f27 |
| 747ed7f | https://github.com/nodejs/node/pull/8625/commits/747ed7ffb54a1fdc312d8e098c7f0e7279b18f27 |
|
| https://github.com/graphicbeacon |
| Merge commit 'a89c23f8ebb8d47e2f577d3594bfb465c1861d25' | https://github.com/nodejs/node/pull/8625/commits/6b51f9317e74c11438bcb6b79856485df4fddcce |
| 6b51f93 | https://github.com/nodejs/node/pull/8625/commits/6b51f9317e74c11438bcb6b79856485df4fddcce |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8625#event-792942482 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8625#issuecomment-247766452 |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Sep 17, 2016
| https://github.com/nodejs/node/pull/8625#pullrequestreview-455815 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8625/files/6b51f9317e74c11438bcb6b79856485df4fddcce |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
async_hooks
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks |
|
async_wrap
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_wrap |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8625#event-792984126 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8625#issuecomment-247790901 |
| #8531 | https://github.com/nodejs/node/pull/8531 |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 20, 2016 | https://github.com/nodejs/node/pull/8625#issuecomment-248370655 |
| #8531 | https://github.com/nodejs/node/pull/8531 |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 20, 2016
| https://github.com/nodejs/node/pull/8625#pullrequestreview-797426 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8625/files/6b51f9317e74c11438bcb6b79856485df4fddcce |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/8625#pullrequestreview-797426 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720 |
| b0df363 | https://github.com/nodejs/node/commit/b0df363eda7d8a4314efaee5245b5073476c7362 |
| c5ce7f4 | https://github.com/nodejs/node/commit/c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720 |
|
Compare
| https://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720 |
| September 21, 2016 00:10 | https://github.com/nodejs/node/pull/8625#event-796539640 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 21, 2016
| https://github.com/nodejs/node/pull/8625#pullrequestreview-938600 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8625/files/6b51f9317e74c11438bcb6b79856485df4fddcce |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/8625#pullrequestreview-938600 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 22, 2016
| https://github.com/nodejs/node/pull/8625#pullrequestreview-1086656 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8625/files/6b51f9317e74c11438bcb6b79856485df4fddcce |
| lpinca | https://github.com/lpinca |
| https://github.com/nodejs/node/pull/8625#pullrequestreview-1086656 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
| jasnell | https://github.com/jasnell |
|
Sep 22, 2016
| https://github.com/nodejs/node/pull/8625#ref-commit-0a9f56a |
|
| https://github.com/graphicbeacon |
|
| https://github.com/jasnell |
| test: fixup parallel/test-async-wrap-post-did-throw.js | https://github.com/nodejs/node/commit/0a9f56a827e4d8bb1f1b3d1ed5a1732066a41af9 |
| 0a9f56a | https://github.com/nodejs/node/commit/0a9f56a827e4d8bb1f1b3d1ed5a1732066a41af9 |
| #8625 | https://github.com/nodejs/node/pull/8625 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 22, 2016 | https://github.com/nodejs/node/pull/8625#issuecomment-248958951 |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 22, 2016 | https://github.com/nodejs/node/pull/8625#event-799150148 |
| https://github.com/graphicbeacon |
| graphicbeacon | https://github.com/graphicbeacon |
| Sep 22, 2016 | https://github.com/nodejs/node/pull/8625#issuecomment-249059057 |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
| jasnell | https://github.com/jasnell |
|
Sep 29, 2016
| https://github.com/nodejs/node/pull/8625#ref-commit-0fbd59e |
|
| https://github.com/graphicbeacon |
|
| https://github.com/jasnell |
| test: fixup parallel/test-async-wrap-post-did-throw.js | https://github.com/nodejs/node/commit/0fbd59e8c3e4cc56b310b90f71d31a0f513025e2 |
| 0fbd59e | https://github.com/nodejs/node/commit/0fbd59e8c3e4cc56b310b90f71d31a0f513025e2 |
| #8625 | https://github.com/nodejs/node/pull/8625 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8625#event-815522010 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 11, 2016
| https://github.com/nodejs/node/pull/8625#ref-commit-1b494d3 |
|
| https://github.com/graphicbeacon |
|
| https://github.com/Fishrock123 |
| test: fixup parallel/test-async-wrap-post-did-throw.js | https://github.com/nodejs/node/commit/1b494d3b966852171353a40a0a48e4dbd705e621 |
| 1b494d3 | https://github.com/nodejs/node/commit/1b494d3b966852171353a40a0a48e4dbd705e621 |
| #8625 | https://github.com/nodejs/node/pull/8625 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8625 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/8625/files/6b51f9317e74c11438bcb6b79856485df4fddcce |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/8625/files/6b51f9317e74c11438bcb6b79856485df4fddcce |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/8625/files/6b51f9317e74c11438bcb6b79856485df4fddcce |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/8625/files/6b51f9317e74c11438bcb6b79856485df4fddcce |
|
async_hooks
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/8625 |
|
| https://github.com/graphicbeacon |
|
| https://github.com/cjihrig |
|
| https://github.com/Fishrock123 |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |