René's URL Explorer Experiment


Title: Fix path.relative UNC path result by jasongin · Pull Request #8523 · nodejs/node · GitHub

Open Graph Title: Fix path.relative UNC path result by jasongin · Pull Request #8523 · nodejs/node

X Title: Fix path.relative UNC path result by jasongin · Pull Request #8523 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist vcbuild test nosign (Windows) passes (Some tests failed, but they're unrelated: the failures repro without this change.) tests are included commit message follows commit guideline...

X Description: Checklist vcbuild test nosign (Windows) passes (Some tests failed, but they're unrelated: the failures repro without this change.) tests are included commit message follows commit guide...

Opengraph URL: https://github.com/nodejs/node/pull/8523

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6e457589-a0aa-f52b-5e8c-ea3ee9af9d1a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B4C:2AB324:510CBD:6E890A:6AED1EAC
html-safe-nonceaf9f39f1981b15afa6e8a38aa5ea0d65a10e703d720c54f8645b2d0062407425
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjRDOjJBQjMyNDo1MTBDQkQ6NkU4OTBBOjZBRUQxRUFDIiwidmlzaXRvcl9pZCI6IjEzMDk5MTk3MTk0NjM5MTkyNzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf85f69152bf6afe9ff0bb26a7dc328219844e5fbf8cafed1a2d9a9522e2d52fd
hovercard-subject-tagpull_request:85133325
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8523/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/98d73f83ca4354754767cca7ce5c1559767566a6607d70906f557f7313c72113/nodejs/node/pull/8523
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/98d73f83ca4354754767cca7ce5c1559767566a6607d70906f557f7313c72113/nodejs/node/pull/8523
og:image:altChecklist vcbuild test nosign (Windows) passes (Some tests failed, but they're unrelated: the failures repro without this change.) tests are included commit message follows commit guideline...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasongin
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8523#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8523
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8523
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8523
Reloadhttps://github.com/nodejs/node/pull/8523
Reloadhttps://github.com/nodejs/node/pull/8523
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
jasonginhttps://github.com/jasongin
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasongin:resolveunchttps://github.com/jasongin/nodejs/tree/resolveunc
Conversationhttps://github.com/nodejs/node/pull/8523
Commits1 (1)https://github.com/nodejs/node/pull/8523/commits
Checkshttps://github.com/nodejs/node/pull/8523/checks
Files changedhttps://github.com/nodejs/node/pull/8523/files
Fix path.relative UNC path resulthttps://github.com/nodejs/node/pull/8523#top
jasonginhttps://github.com/jasongin
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasongin:resolveunchttps://github.com/jasongin/nodejs/tree/resolveunc
https://github.com/jasongin
jasonginhttps://github.com/jasongin
Sep 13, 2016https://github.com/nodejs/node/pull/8523#issue-176761460
Please reload this pagehttps://github.com/nodejs/node/pull/8523
#8444https://github.com/nodejs/node/issues/8444
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
path https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apath
Sep 13, 2016https://github.com/nodejs/node/pull/8523#event-788272052
https://github.com/jasongin
Fix path.relative UNC path resulthttps://github.com/nodejs/node/pull/8523/commits/5712f3362cac556c1ef978112a2d8be5bfbf9174
5712f33https://github.com/nodejs/node/pull/8523/commits/5712f3362cac556c1ef978112a2d8be5bfbf9174
nodejs#8444https://github.com/nodejs/node/issues/8444
https://github.com/jasongin
jasonginhttps://github.com/jasongin
force-pushedhttps://github.com/nodejs/node/compare/a3827eda1a39e53ec92b0805163b84aadef71bf7..5712f3362cac556c1ef978112a2d8be5bfbf9174
a3827edhttps://github.com/nodejs/node/commit/a3827eda1a39e53ec92b0805163b84aadef71bf7
5712f33https://github.com/nodejs/node/commit/5712f3362cac556c1ef978112a2d8be5bfbf9174
Compare https://github.com/nodejs/node/compare/a3827eda1a39e53ec92b0805163b84aadef71bf7..5712f3362cac556c1ef978112a2d8be5bfbf9174
September 13, 2016 22:01https://github.com/nodejs/node/pull/8523#event-788274882
https://github.com/jasongin
jasonginhttps://github.com/jasongin
Sep 13, 2016https://github.com/nodejs/node/pull/8523#event-788275695
https://github.com/jasongin
jasonginhttps://github.com/jasongin
Sep 13, 2016https://github.com/nodejs/node/pull/8523#issuecomment-246840198
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/mscdex
mscdexhttps://github.com/mscdex
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Sep 13, 2016https://github.com/nodejs/node/pull/8523#event-788291226
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 13, 2016https://github.com/nodejs/node/pull/8523#issuecomment-246843166
https://ci.nodejs.org/job/node-test-pull-request/4036/https://ci.nodejs.org/job/node-test-pull-request/4036/
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 13, 2016https://github.com/nodejs/node/pull/8523#issuecomment-246852645
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 15, 2016 https://github.com/nodejs/node/pull/8523#pullrequestreview-212648
View reviewed changes https://github.com/nodejs/node/pull/8523/files/5712f3362cac556c1ef978112a2d8be5bfbf9174
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/8523#pullrequestreview-212648
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/bzoz
bzozhttps://github.com/bzoz
Sep 16, 2016 https://github.com/nodejs/node/pull/8523#pullrequestreview-351988
View reviewed changes https://github.com/nodejs/node/pull/8523/files/5712f3362cac556c1ef978112a2d8be5bfbf9174
bzozhttps://github.com/bzoz
https://github.com/nodejs/node/pull/8523#pullrequestreview-351988
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8523
jasnellhttps://github.com/jasnell
Sep 20, 2016 https://github.com/nodejs/node/pull/8523#ref-commit-c1e47ed
https://github.com/jasongin
https://github.com/jasnell
path: fix path.relative UNC path resulthttps://github.com/nodejs/node/commit/c1e47ed8c883afba3c240e89d763a28a57ec1373
c1e47edhttps://github.com/nodejs/node/commit/c1e47ed8c883afba3c240e89d763a28a57ec1373
#8444https://github.com/nodejs/node/issues/8444
#8523https://github.com/nodejs/node/pull/8523
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 20, 2016https://github.com/nodejs/node/pull/8523#issuecomment-248363858
c1e47edhttps://github.com/nodejs/node/commit/c1e47ed8c883afba3c240e89d763a28a57ec1373
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 20, 2016https://github.com/nodejs/node/pull/8523#event-795979238
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Oct 6, 2016https://github.com/nodejs/node/pull/8523#event-815493730
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 6, 2016https://github.com/nodejs/node/pull/8523#issuecomment-252106300
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 6, 2016https://github.com/nodejs/node/pull/8523#issuecomment-252106553
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Oct 6, 2016https://github.com/nodejs/node/pull/8523#event-815496912
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 6, 2016https://github.com/nodejs/node/pull/8523#issuecomment-252106891
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Oct 6, 2016https://github.com/nodejs/node/pull/8523#event-815503557
Fishrock123https://github.com/Fishrock123
Oct 11, 2016 https://github.com/nodejs/node/pull/8523#ref-commit-d72a7b3
https://github.com/jasongin
https://github.com/Fishrock123
path: fix path.relative UNC path resulthttps://github.com/nodejs/node/commit/d72a7b3d0cc9d52a0be6a11fe7d73c5c77dfe6f9
d72a7b3https://github.com/nodejs/node/commit/d72a7b3d0cc9d52a0be6a11fe7d73c5c77dfe6f9
#8444https://github.com/nodejs/node/issues/8444
#8523https://github.com/nodejs/node/pull/8523
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 18, 2016https://github.com/nodejs/node/pull/8523#issuecomment-261635280
@addaleaxhttps://github.com/addaleax
@jasonginhttps://github.com/jasongin
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2016https://github.com/nodejs/node/pull/8523#issuecomment-261637185
@jasonginhttps://github.com/jasongin
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Nov 18, 2016https://github.com/nodejs/node/pull/8523#issuecomment-261638303
@thealphanerdhttps://github.com/thealphanerd
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Nov 18, 2016https://github.com/nodejs/node/pull/8523#event-864954008
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2016https://github.com/nodejs/node/pull/8523#issuecomment-261638888
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/jasongin
jasonginhttps://github.com/jasongin
November 21, 2016 17:55https://github.com/nodejs/node/pull/8523#event-866959376
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Dec 30, 2016 https://github.com/nodejs/node/pull/8523#ref-issue-198079829
UNC paths are not handled appropriately by path.relative #10528 https://github.com/nodejs/node/issues/10528
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8523
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/8523/files/5712f3362cac556c1ef978112a2d8be5bfbf9174
https://github.com/bzoz
bzoz https://github.com/bzoz
https://github.com/nodejs/node/pull/8523/files/5712f3362cac556c1ef978112a2d8be5bfbf9174
Please reload this pagehttps://github.com/nodejs/node/pull/8523
path https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apath
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Please reload this pagehttps://github.com/nodejs/node/pull/8523
https://github.com/jasongin
https://github.com/mscdex
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/addaleax
https://github.com/bzoz
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.