Title: Make it build using openssl 1.1.0 by kroeckx · Pull Request #8491 · nodejs/node · GitHub
Open Graph Title: Make it build using openssl 1.1.0 by kroeckx · Pull Request #8491 · nodejs/node
X Title: Make it build using openssl 1.1.0 by kroeckx · Pull Request #8491 · nodejs/node
Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) crypto Description of change This is to make it possible to build against OpenSSL 1.1.0 (#4270) It currently has 2 new test failures when build against 1.0.2, because OpenSSL generates a different error message in 1.0.2 and 1.1.0. I'm not sure how to deal with that. In test/parallel/test-crypto.js the message is changed from "asn1 encoding routines:ASN1_CHECK_TLEN:wrong tag" to "asn1 encoding routines:asn1_check_tlen:wrong tag". (The function name in openssl got renamed from all capital letters to small letters.) In test/parallel/test-tls-junk-server.js, the error message changed from "/unknown protocol/" to "/wrong version number/". It also fixes 3 current issues with the test suite against the 1.0.2 version. When building against the 1.1.0 version there are various tests that fail. There are a total of 11 test failures. Some tests assumes the TLS ticket is 48 bytes. This was always just an implementation details and you could already ask OpenSSL what the size was. The encryption got changed from AES128 to AES256 in 1.1.0 and so the size changed. I have no idea how to get that size to the right places in the test suite. Some of the other failures are related to ciphers that are disabled by default. For instance anonymous ciphers like AECDH are disabled and you need to enable them by selecting a different security level, which can for instance be done by adding @SECLEVEL=0 to the cipher list, but that's not compatible with the 1.0.x version. Ciphers like 3DES and RC4 are disabled by default. Other tests fails because the key size that's used is too small. I'm not sure yet why some of the other tests fail. There are also a bunch of warnings about deprecated functions. I left them like they are. The proper way to deal with it will probably break compatibility. PS: During make test I'm getting invalid opcode traps, this seems unrelated to my changes and doesn't seem to cause test suite failures.
Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) crypto Description of change This is to make it po...
X Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) crypto Description of change This is to make it po...
Opengraph URL: https://github.com/nodejs/node/pull/8491
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:a055bd5b-7b17-9312-b3e8-bfa5923e74db |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC22:312852:29732E:3A8E0D:69974383 |
| html-safe-nonce | d1800c53405649f51773b3d9d0a5260ae4fd346a7b8681edaf5df8b6948fcf3c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzIyOjMxMjg1MjoyOTczMkU6M0E4RTBEOjY5OTc0MzgzIiwidmlzaXRvcl9pZCI6Ijc5NzQ3MDMwMjk5NTMxODQ2NDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d4506dd53a23569fc6c73348b5407e0fd7d5767776c19939990aeb40ae76167e |
| hovercard-subject-tag | pull_request:84784936 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/8491/commits/62cc7b80c0840528e6936bd72e3d370e24f8d99f |
| twitter:image | https://avatars.githubusercontent.com/u/1616242?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1616242?s=400&v=4 |
| og:image:alt | Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) crypto Description of change This is to make it po... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c2f6b9675e9141deef3eda21e5cb896d461bd4d25aeaeeba804502ef0e8d01f2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 06ceed63f0d4941788d6c52a00d38ad77b6eaf89 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width