| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8a009758-dd06-0a62-ea6b-96e37bd75063 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E09E:D209A:6148F7:7D5FD1:696B10B7 |
| html-safe-nonce | 6dbdd28a653b8a3e5b2c2b07bb122407bd580191c2e72c30ff9dcd22fc472e0f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDlFOkQyMDlBOjYxNDhGNzo3RDVGRDE6Njk2QjEwQjciLCJ2aXNpdG9yX2lkIjoiODcwMzk1NzkxODExODc3NzAxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 71a480830342feac62a23aa37dffc17f3a5abbf1d277243b7b71d6a360260e34 |
| hovercard-subject-tag | pull_request:84760811 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8482/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a582becaeb71f2da2b46decbc5a491717323ea587c7f8674a125932e59b04756/nodejs/node/pull/8482 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a582becaeb71f2da2b46decbc5a491717323ea587c7f8674a125932e59b04756/nodejs/node/pull/8482 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
src
Description of change
Add an optional size param... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8482#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8482 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8482 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8482 |
| Reload | https://github.com/nodejs/node/pull/8482 |
| Reload | https://github.com/nodejs/node/pull/8482 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/8482#issue-comment-box |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:allocation-rework | https://github.com/addaleax/node/tree/allocation-rework |
|
src: simplify memory management using node::Malloc() and friends
| https://github.com/nodejs/node/pull/8482#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:allocation-rework | https://github.com/addaleax/node/tree/allocation-rework |
|
Conversation
40
| https://github.com/nodejs/node/pull/8482 |
|
Commits
4
| https://github.com/nodejs/node/pull/8482/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/8482/checks |
|
Files changed
| https://github.com/nodejs/node/pull/8482/files |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 10, 2016 | https://github.com/nodejs/node/pull/8482#issue-176189107 |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://ci.nodejs.org/job/node-test-commit/4994/ | https://ci.nodejs.org/job/node-test-commit/4994/ |
| https://ci.nodejs.org/job/node-test-commit/4995/ | https://ci.nodejs.org/job/node-test-commit/4995/ |
| https://ci.nodejs.org/job/node-test-commit/4996/ | https://ci.nodejs.org/job/node-test-commit/4996/ |
| https://ci.nodejs.org/job/node-test-commit/4997/ | https://ci.nodejs.org/job/node-test-commit/4997/ |
| https://ci.nodejs.org/job/node-test-commit/5008/ | https://ci.nodejs.org/job/node-test-commit/5008/ |
| https://ci.nodejs.org/job/node-test-commit/5013/ | https://ci.nodejs.org/job/node-test-commit/5013/ |
| https://ci.nodejs.org/job/node-test-commit/5025/ | https://ci.nodejs.org/job/node-test-commit/5025/ |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Sep 10, 2016 | https://github.com/nodejs/node/pull/8482#event-784955880 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Sep 10, 2016 | https://github.com/nodejs/node/pull/8482#event-784956075 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/9e3309c53ed4951afea4f1fa100d5da965c4c493..f04c5ed4bc1ae3dcb639da469605ae1ea47ca612 |
| 9e3309c | https://github.com/nodejs/node/commit/9e3309c53ed4951afea4f1fa100d5da965c4c493 |
| f04c5ed | https://github.com/nodejs/node/commit/f04c5ed4bc1ae3dcb639da469605ae1ea47ca612 |
|
Compare
| https://github.com/nodejs/node/compare/9e3309c53ed4951afea4f1fa100d5da965c4c493..f04c5ed4bc1ae3dcb639da469605ae1ea47ca612 |
| September 10, 2016 18:03 | https://github.com/nodejs/node/pull/8482#event-784972152 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 10, 2016 | https://github.com/nodejs/node/pull/8482#issuecomment-246129196 |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://ci.nodejs.org/job/node-compile-windows/4115/label=win-vs2015/console | https://ci.nodejs.org/job/node-compile-windows/4115/label=win-vs2015/console |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 10, 2016 | https://github.com/nodejs/node/pull/8482#issuecomment-246141640 |
| @joshgav | https://github.com/joshgav |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Sep 11, 2016
| https://github.com/nodejs/node/pull/8482#discussion-diff-78290037 |
| View reviewed changes
| https://github.com/nodejs/node/pull/8482/files#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec |
| src/cares_wrap.cc | https://github.com/nodejs/node/pull/8482/files#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 11, 2016 | https://github.com/nodejs/node/pull/8482#discussion_r78290037 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| addaleax | https://github.com/addaleax |
| Sep 11, 2016 | https://github.com/nodejs/node/pull/8482#discussion_r78296376 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 11, 2016 | https://github.com/nodejs/node/pull/8482#issuecomment-246168968 |
| https://ci.nodejs.org/job/node-compile-windows/4115/label=win-vs2015/console | https://ci.nodejs.org/job/node-compile-windows/4115/label=win-vs2015/console |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Sep 11, 2016 | https://github.com/nodejs/node/pull/8482#issuecomment-246177413 |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/4b39181f2ad089294107d1503dddea18b6119717..1491d998c35b1b301ed9eac4649a3976a01ca4da |
| 4b39181 | https://github.com/nodejs/node/commit/4b39181f2ad089294107d1503dddea18b6119717 |
| 1491d99 | https://github.com/nodejs/node/commit/1491d998c35b1b301ed9eac4649a3976a01ca4da |
|
Compare
| https://github.com/nodejs/node/compare/4b39181f2ad089294107d1503dddea18b6119717..1491d998c35b1b301ed9eac4649a3976a01ca4da |
| September 11, 2016 14:48 | https://github.com/nodejs/node/pull/8482#event-785207514 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 11, 2016 | https://github.com/nodejs/node/pull/8482#issuecomment-246184439 |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://ci.nodejs.org/job/node-test-pull-request/4012/ | https://ci.nodejs.org/job/node-test-pull-request/4012/ |
| https://ci.nodejs.org/job/node-test-commit/5008/ | https://ci.nodejs.org/job/node-test-commit/5008/ |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Sep 12, 2016
| https://github.com/nodejs/node/pull/8482#discussion-diff-78328958 |
| View reviewed changes
| https://github.com/nodejs/node/pull/8482/files#diff-b1af53e84de922979cfdda57cca9fe06a3741f616981733417d3fc62e249e83f |
| src/stream_wrap.cc | https://github.com/nodejs/node/pull/8482/files#diff-b1af53e84de922979cfdda57cca9fe06a3741f616981733417d3fc62e249e83f |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 12, 2016 | https://github.com/nodejs/node/pull/8482#discussion_r78328958 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/1491d998c35b1b301ed9eac4649a3976a01ca4da..f46329c89104ec407d34d75b43db5759e79e93f9 |
| 1491d99 | https://github.com/nodejs/node/commit/1491d998c35b1b301ed9eac4649a3976a01ca4da |
| f46329c | https://github.com/nodejs/node/commit/f46329c89104ec407d34d75b43db5759e79e93f9 |
|
Compare
| https://github.com/nodejs/node/compare/1491d998c35b1b301ed9eac4649a3976a01ca4da..f46329c89104ec407d34d75b43db5759e79e93f9 |
| September 12, 2016 09:07 | https://github.com/nodejs/node/pull/8482#event-785655103 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 12, 2016 | https://github.com/nodejs/node/pull/8482#issuecomment-246290645 |
| https://ci.nodejs.org/job/node-test-commit/5013/ | https://ci.nodejs.org/job/node-test-commit/5013/ |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Sep 12, 2016
| https://github.com/nodejs/node/pull/8482#discussion-diff-78350356 |
| View reviewed changes
| https://github.com/nodejs/node/pull/8482/files#diff-1e725bfa950eda4d4b5c0c00a2bb6be3e5b83d819872a1adf2ef87c658273903 |
| src/util-inl.h | https://github.com/nodejs/node/pull/8482/files#diff-1e725bfa950eda4d4b5c0c00a2bb6be3e5b83d819872a1adf2ef87c658273903 |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 12, 2016 | https://github.com/nodejs/node/pull/8482#discussion_r78350356 |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 12, 2016 | https://github.com/nodejs/node/pull/8482#issuecomment-246312374 |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| seishun | https://github.com/seishun |
|
Sep 12, 2016
| https://github.com/nodejs/node/pull/8482#discussion-diff-78353196 |
| View reviewed changes
| https://github.com/nodejs/node/pull/8482/files#diff-1e725bfa950eda4d4b5c0c00a2bb6be3e5b83d819872a1adf2ef87c658273903 |
| src/util-inl.h | https://github.com/nodejs/node/pull/8482/files#diff-1e725bfa950eda4d4b5c0c00a2bb6be3e5b83d819872a1adf2ef87c658273903 |
| seishun | https://github.com/seishun |
| Sep 12, 2016 | https://github.com/nodejs/node/pull/8482#discussion_r78353196 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| addaleax | https://github.com/addaleax |
| Sep 12, 2016 | https://github.com/nodejs/node/pull/8482#discussion_r78465307 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @seishun | https://github.com/seishun |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| seishun | https://github.com/seishun |
| Sep 13, 2016 | https://github.com/nodejs/node/pull/8482#discussion_r78516418 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| addaleax | https://github.com/addaleax |
| Sep 13, 2016 | https://github.com/nodejs/node/pull/8482#discussion_r78519724 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @seishun | https://github.com/seishun |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/f46329c89104ec407d34d75b43db5759e79e93f9..d03ff039b67aeecfba40e54a0b66ae6aa089cf17 |
| f46329c | https://github.com/nodejs/node/commit/f46329c89104ec407d34d75b43db5759e79e93f9 |
| d03ff03 | https://github.com/nodejs/node/commit/d03ff039b67aeecfba40e54a0b66ae6aa089cf17 |
|
Compare
| https://github.com/nodejs/node/compare/f46329c89104ec407d34d75b43db5759e79e93f9..d03ff039b67aeecfba40e54a0b66ae6aa089cf17 |
| September 13, 2016 08:49 | https://github.com/nodejs/node/pull/8482#event-787229333 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 15, 2016
| https://github.com/nodejs/node/pull/8482#pullrequestreview-215787 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/8482/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/8482#pullrequestreview-215787 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Sep 17, 2016 | https://github.com/nodejs/node/pull/8482#event-793151533 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 17, 2016
| https://github.com/nodejs/node/pull/8482#ref-pullrequest-177558054 |
|
src: Malloc/Calloc size 0 returns non-null pointer
#8572
| https://github.com/nodejs/node/pull/8572 |
| jasnell | https://github.com/jasnell |
|
Sep 29, 2016
| https://github.com/nodejs/node/pull/8482#ref-commit-de94601 |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
| src: add Malloc() size param + overflow detection | https://github.com/nodejs/node/commit/de946013c25fb49e511816a6d3dce8ff6d68f800 |
| de94601 | https://github.com/nodejs/node/commit/de946013c25fb49e511816a6d3dce8ff6d68f800 |
| #8482 | https://github.com/nodejs/node/pull/8482 |
| jasnell | https://github.com/jasnell |
|
Sep 29, 2016
| https://github.com/nodejs/node/pull/8482#ref-commit-d2470d4 |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
| src: pass desired return type to allocators | https://github.com/nodejs/node/commit/d2470d4dff55726e88fe59b3e21aee2a006e2a55 |
| d2470d4 | https://github.com/nodejs/node/commit/d2470d4dff55726e88fe59b3e21aee2a006e2a55 |
| #8482 | https://github.com/nodejs/node/pull/8482 |
| jasnell | https://github.com/jasnell |
|
Sep 29, 2016
| https://github.com/nodejs/node/pull/8482#ref-commit-aed9792 |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
| src: provide allocation + nullptr check shortcuts | https://github.com/nodejs/node/commit/aed9792ff41099a83cbbff174694816e35adb0fd |
| aed9792 | https://github.com/nodejs/node/commit/aed9792ff41099a83cbbff174694816e35adb0fd |
| #8482 | https://github.com/nodejs/node/pull/8482 |
| jasnell | https://github.com/jasnell |
|
Sep 29, 2016
| https://github.com/nodejs/node/pull/8482#ref-commit-ebad043 |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
| src: notify V8 for low memory when alloc fails | https://github.com/nodejs/node/commit/ebad04326d5c76f60eca59e3b6e22536b750f3dd |
| ebad043 | https://github.com/nodejs/node/commit/ebad04326d5c76f60eca59e3b6e22536b750f3dd |
| #8482 | https://github.com/nodejs/node/pull/8482 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| September 30, 2016 15:12 | https://github.com/nodejs/node/pull/8482#event-808604005 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8482#event-815558946 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/8482#issuecomment-252118826 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 7, 2016
| https://github.com/nodejs/node/pull/8482#ref-pullrequest-164111874 |
|
core: normalize malloc, realloc
#7564
| https://github.com/nodejs/node/pull/7564 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8482#event-818292381 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/8482#issuecomment-252675071 |
| #7082 | https://github.com/nodejs/node/pull/7082 |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Nov 18, 2016
| https://github.com/nodejs/node/pull/8482#ref-commit-b80f05e |
|
| https://github.com/bnoordhuis |
| test: fix memory leaks in malloc cctests | https://github.com/bnoordhuis/io.js/commit/b80f05efaafdb8b4f0ef6afc92bfb31762904e02 |
| b80f05e | https://github.com/bnoordhuis/io.js/commit/b80f05efaafdb8b4f0ef6afc92bfb31762904e02 |
| ea94086 | https://github.com/bnoordhuis/io.js/commit/ea94086ad2b53268b5cb870f9ba5a1f84741fa41 |
| nodejs#9667 | https://github.com/nodejs/node/pull/9667 |
| nodejs#8482 | https://github.com/nodejs/node/pull/8482 |
| addaleax | https://github.com/addaleax |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/8482#ref-commit-a29be52 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/addaleax |
| test: fix memory leaks in malloc cctests | https://github.com/nodejs/node/commit/a29be5282eeea8f49b18255a484af4b628eaff9f |
| a29be52 | https://github.com/nodejs/node/commit/a29be5282eeea8f49b18255a484af4b628eaff9f |
| ea94086 | https://github.com/nodejs/node/commit/ea94086ad2b53268b5cb870f9ba5a1f84741fa41 |
| #9667 | https://github.com/nodejs/node/pull/9667 |
| #8482 | https://github.com/nodejs/node/pull/8482 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/8482#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/XadillaX |
| XadillaX | https://github.com/XadillaX |
|
Jun 21, 2017
| https://github.com/nodejs/node/pull/8482#ref-pullrequest-236561432 |
|
(v6.x backport) dns: fix crash while using dns.setServers after dns.resolve4
#13724
| https://github.com/nodejs/node/pull/13724 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 29, 2017
| https://github.com/nodejs/node/pull/8482#ref-commit-5935818 |
|
| https://github.com/addaleax |
|
| https://github.com/bnoordhuis |
| src: add Malloc() size param + overflow detection | https://github.com/bnoordhuis/io.js/commit/59358182e2d30c60858cd42a9b3ba4ace23736ce |
| 5935818 | https://github.com/bnoordhuis/io.js/commit/59358182e2d30c60858cd42a9b3ba4ace23736ce |
| nodejs#8482 | https://github.com/nodejs/node/pull/8482 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 29, 2017
| https://github.com/nodejs/node/pull/8482#ref-commit-e0a5328 |
|
| https://github.com/addaleax |
|
| https://github.com/bnoordhuis |
| src: pass desired return type to allocators | https://github.com/bnoordhuis/io.js/commit/e0a53288a8f82c6ec5fba00d4897fc08c7599c21 |
| e0a5328 | https://github.com/bnoordhuis/io.js/commit/e0a53288a8f82c6ec5fba00d4897fc08c7599c21 |
| nodejs#8482 | https://github.com/nodejs/node/pull/8482 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 29, 2017
| https://github.com/nodejs/node/pull/8482#ref-commit-28af6bb |
|
| https://github.com/addaleax |
|
| https://github.com/bnoordhuis |
| src: provide allocation + nullptr check shortcuts | https://github.com/bnoordhuis/io.js/commit/28af6bbe4a0715e0ad4d8a6ce09d3148751e1fad |
| 28af6bb | https://github.com/bnoordhuis/io.js/commit/28af6bbe4a0715e0ad4d8a6ce09d3148751e1fad |
| nodejs#8482 | https://github.com/nodejs/node/pull/8482 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 29, 2017
| https://github.com/nodejs/node/pull/8482#ref-commit-618ca42 |
|
| https://github.com/addaleax |
|
| https://github.com/bnoordhuis |
| src: notify V8 for low memory when alloc fails | https://github.com/bnoordhuis/io.js/commit/618ca4276d344be2c6d1ebfe22df5fbe8c3c9fef |
| 618ca42 | https://github.com/bnoordhuis/io.js/commit/618ca4276d344be2c6d1ebfe22df5fbe8c3c9fef |
| nodejs#8482 | https://github.com/nodejs/node/pull/8482 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 29, 2017
| https://github.com/nodejs/node/pull/8482#ref-pullrequest-269394475 |
|
[v6.x backport] src: simplify memory management using node::Malloc() and friends
#16587
| https://github.com/nodejs/node/pull/16587 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Oct 29, 2017 | https://github.com/nodejs/node/pull/8482#event-1315510678 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 29, 2017 | https://github.com/nodejs/node/pull/8482#issuecomment-340258126 |
| #16587 | https://github.com/nodejs/node/pull/16587 |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 14, 2017
| https://github.com/nodejs/node/pull/8482#ref-commit-19f3ac9 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: add Malloc() size param + overflow detection | https://github.com/nodejs/node/commit/19f3ac9749f80b3cab9d4248d6784dffbdf1a368 |
| 19f3ac9 | https://github.com/nodejs/node/commit/19f3ac9749f80b3cab9d4248d6784dffbdf1a368 |
| #16587 | https://github.com/nodejs/node/pull/16587 |
| #8482 | https://github.com/nodejs/node/pull/8482 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 14, 2017
| https://github.com/nodejs/node/pull/8482#ref-commit-4aec8cf |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: pass desired return type to allocators | https://github.com/nodejs/node/commit/4aec8cfcd23abbb0d7be172d63a2dbed1e31fb61 |
| 4aec8cf | https://github.com/nodejs/node/commit/4aec8cfcd23abbb0d7be172d63a2dbed1e31fb61 |
| #16587 | https://github.com/nodejs/node/pull/16587 |
| #8482 | https://github.com/nodejs/node/pull/8482 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 14, 2017
| https://github.com/nodejs/node/pull/8482#ref-commit-6a0eb9f |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: provide allocation + nullptr check shortcuts | https://github.com/nodejs/node/commit/6a0eb9f6cfbe3c76a3508418997de7ab2becd4b5 |
| 6a0eb9f | https://github.com/nodejs/node/commit/6a0eb9f6cfbe3c76a3508418997de7ab2becd4b5 |
| #16587 | https://github.com/nodejs/node/pull/16587 |
| #8482 | https://github.com/nodejs/node/pull/8482 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 14, 2017
| https://github.com/nodejs/node/pull/8482#ref-commit-e18df46 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: notify V8 for low memory when alloc fails | https://github.com/nodejs/node/commit/e18df46092624980a0218982af757a0743cf1d98 |
| e18df46 | https://github.com/nodejs/node/commit/e18df46092624980a0218982af757a0743cf1d98 |
| #16587 | https://github.com/nodejs/node/pull/16587 |
| #8482 | https://github.com/nodejs/node/pull/8482 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backported-to-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v6.x |
| Nov 14, 2017 | https://github.com/nodejs/node/pull/8482#event-1341545658 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 21, 2017
| https://github.com/nodejs/node/pull/8482#ref-pullrequest-275653593 |
|
v6.12.1 proposal
#17180
| https://github.com/nodejs/node/pull/17180 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8482 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/8482/files/d03ff039b67aeecfba40e54a0b66ae6aa089cf17 |
|
| https://github.com/imyller |
|
imyller
| https://github.com/imyller |
|
| https://github.com/nodejs/node/pull/8482/files/bb64c865c4df10f6fee501c10286e0d5d78e3d2b |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/8482 |
|
| https://github.com/addaleax |
|
| https://github.com/bnoordhuis |
|
| https://github.com/seishun |
|
| https://github.com/mhdawson |
|
| https://github.com/MylesBorins |
|
| https://github.com/Fishrock123 |
|
| https://github.com/jasnell |
|
| https://github.com/imyller |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |