| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:97a3a0e4-2e97-2047-56da-ab849c6e0582 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 977C:204447:65C322:8AED34:6A541390 |
| html-safe-nonce | cfd0871c660f3f495fbd3ac22e71dd68fe264484ce3f3ebacadeb10e8e05dacf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzdDOjIwNDQ0Nzo2NUMzMjI6OEFFRDM0OjZBNTQxMzkwIiwidmlzaXRvcl9pZCI6IjI5MzE2OTQxMjYyNjg0MjEwMDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c0fe070bb82bc170d2e47c8688300e8d93468ad09ceb3bd173d570f44ab175a2 |
| hovercard-subject-tag | pull_request:84705443 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8470/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1b51c4af8dea262677652bae657e47eba5ece1b1f9dd70e43e5bdd3c9a131d72/nodejs/node/pull/8470 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1b51c4af8dea262677652bae657e47eba5ece1b1f9dd70e43e5bdd3c9a131d72/nodejs/node/pull/8470 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
test
We had marked pseudo-tty/no_dropped_stdio as fl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mhdawson |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8470#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8470 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8470 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8470 |
| Reload | https://github.com/nodejs/node/pull/8470 |
| Reload | https://github.com/nodejs/node/pull/8470 |
| Please reload this page | https://github.com/nodejs/node/pull/8470 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8470 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
997
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mhdawson:pseudo | https://github.com/mhdawson/io.js/tree/pseudo |
| Conversation | https://github.com/nodejs/node/pull/8470 |
| Commits1 (1) | https://github.com/nodejs/node/pull/8470/commits |
| Checks | https://github.com/nodejs/node/pull/8470/checks |
| Files changed | https://github.com/nodejs/node/pull/8470/files |
| test: skip pseudo-tty/no_dropped_stdio test | https://github.com/nodejs/node/pull/8470#top |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mhdawson:pseudo | https://github.com/mhdawson/io.js/tree/pseudo |
|
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8470#issue-176089736 |
| Please reload this page | https://github.com/nodejs/node/pull/8470 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8470#event-784416076 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8470#event-784416188 |
|
| https://github.com/mhdawson |
| test: skip pseudo-tty/no_dropped_stdio test | https://github.com/nodejs/node/pull/8470/commits/f44c13f23091d48549980d4c17ad85d29641bec2 |
| f44c13f | https://github.com/nodejs/node/pull/8470/commits/f44c13f23091d48549980d4c17ad85d29641bec2 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| force-pushed | https://github.com/nodejs/node/compare/e63a820cb604cf585fc24a664762419d7fbe4751..f44c13f23091d48549980d4c17ad85d29641bec2 |
| e63a820 | https://github.com/nodejs/node/commit/e63a820cb604cf585fc24a664762419d7fbe4751 |
| f44c13f | https://github.com/nodejs/node/commit/f44c13f23091d48549980d4c17ad85d29641bec2 |
|
Compare
| https://github.com/nodejs/node/compare/e63a820cb604cf585fc24a664762419d7fbe4751..f44c13f23091d48549980d4c17ad85d29641bec2 |
| September 9, 2016 19:31 | https://github.com/nodejs/node/pull/8470#event-784417878 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8470#event-784417945 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8470#issuecomment-246016278 |
| https://ci.nodejs.org/job/node-test-pull-request/3990/ | https://ci.nodejs.org/job/node-test-pull-request/3990/ |
| Please reload this page | https://github.com/nodejs/node/pull/8470 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8470#event-784422138 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8470#issuecomment-246024351 |
| Please reload this page | https://github.com/nodejs/node/pull/8470 |
| https://github.com/santigimeno |
| santigimeno | https://github.com/santigimeno |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8470#issuecomment-246025535 |
| Please reload this page | https://github.com/nodejs/node/pull/8470 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 10, 2016 | https://github.com/nodejs/node/pull/8470#issuecomment-246073879 |
| Please reload this page | https://github.com/nodejs/node/pull/8470 |
| mhdawson | https://github.com/mhdawson |
|
Sep 12, 2016
| https://github.com/nodejs/node/pull/8470#ref-commit-1ffdbb6 |
|
| https://github.com/mhdawson |
| test: skip pseudo-tty/no_dropped_stdio test | https://github.com/nodejs/node/commit/1ffdbb6f423a7e1a3ae1f298e67c0f111443e629 |
| 1ffdbb6 | https://github.com/nodejs/node/commit/1ffdbb6f423a7e1a3ae1f298e67c0f111443e629 |
| #8470 | https://github.com/nodejs/node/pull/8470 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 12, 2016 | https://github.com/nodejs/node/pull/8470#issuecomment-246356713 |
| 1ffdbb6 | https://github.com/nodejs/node/commit/1ffdbb6f423a7e1a3ae1f298e67c0f111443e629 |
| Please reload this page | https://github.com/nodejs/node/pull/8470 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 12, 2016 | https://github.com/nodejs/node/pull/8470#event-785985906 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Sep 14, 2016
| https://github.com/nodejs/node/pull/8470#ref-commit-3294c2c |
|
| https://github.com/mhdawson |
|
| https://github.com/Fishrock123 |
| test: skip pseudo-tty/no_dropped_stdio test | https://github.com/nodejs/node/commit/3294c2c82b40fa9dcfee6b310e1a515b6c2d2b9e |
| 3294c2c | https://github.com/nodejs/node/commit/3294c2c82b40fa9dcfee6b310e1a515b6c2d2b9e |
| #8470 | https://github.com/nodejs/node/pull/8470 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 30, 2016
| https://github.com/nodejs/node/pull/8470#ref-commit-fc9f46b |
|
| https://github.com/mhdawson |
| test: skip pseudo-tty/no_dropped_stdio test | https://github.com/nodejs/node/commit/fc9f46be949bca80272388cfc4d1ff4050f4f5ad |
| fc9f46b | https://github.com/nodejs/node/commit/fc9f46be949bca80272388cfc4d1ff4050f4f5ad |
| #8470 | https://github.com/nodejs/node/pull/8470 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/8470#event-809113873 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Oct 3, 2016
| https://github.com/nodejs/node/pull/8470#ref-issue-180038463 |
|
AIX: hang on 4.x run
#8847
| https://github.com/nodejs/node/issues/8847 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/8470#ref-commit-2c31e5b |
|
| https://github.com/mhdawson |
| test: skip pseudo-tty/no_dropped_stdio test | https://github.com/nodejs/node/commit/2c31e5b3b089476876678969cd9c9389f53a3543 |
| 2c31e5b | https://github.com/nodejs/node/commit/2c31e5b3b089476876678969cd9c9389f53a3543 |
| #8470 | https://github.com/nodejs/node/pull/8470 |
| rvagg | https://github.com/rvagg |
|
Oct 18, 2016
| https://github.com/nodejs/node/pull/8470#ref-commit-a3eb9b8 |
|
| https://github.com/mhdawson |
|
| https://github.com/rvagg |
| test: skip pseudo-tty/no_dropped_stdio test | https://github.com/nodejs/node/commit/a3eb9b8cfc0355f14ba84ce22306c3f0f6d7c1e5 |
| a3eb9b8 | https://github.com/nodejs/node/commit/a3eb9b8cfc0355f14ba84ce22306c3f0f6d7c1e5 |
| #8470 | https://github.com/nodejs/node/pull/8470 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/8470#ref-commit-ad1230e |
|
| https://github.com/mhdawson |
|
| https://github.com/MylesBorins |
| test: skip pseudo-tty/no_dropped_stdio test | https://github.com/nodejs/node/commit/ad1230e7317f70da2a255a9c2ba87ccb537114d5 |
| ad1230e | https://github.com/nodejs/node/commit/ad1230e7317f70da2a255a9c2ba87ccb537114d5 |
| #8470 | https://github.com/nodejs/node/pull/8470 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/8470#ref-pullrequest-185475513 |
|
V4.6.2 proposal
#9298
| https://github.com/nodejs/node/pull/9298 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| March 15, 2017 21:57 | https://github.com/nodejs/node/pull/8470#event-1001766031 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8470 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/8470 |
|
| https://github.com/mhdawson |
|
| https://github.com/santigimeno |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |