René's URL Explorer Experiment


Title: v6.x backport: buffer,string_decoder: consolidate encoding validation logic by addaleax · Pull Request #8463 · nodejs/node · GitHub

Open Graph Title: v6.x backport: buffer,string_decoder: consolidate encoding validation logic by addaleax · Pull Request #8463 · nodejs/node

X Title: v6.x backport: buffer,string_decoder: consolidate encoding validation logic by addaleax · Pull Request #8463 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: v6.x backport of #7207. Conflicts where with neighbouring, unrelated code both in lib/internal/util.js and test/parallel/test-buffer-alloc.js. It’s only a cleanup change but other changes like a6f7...

X Description: v6.x backport of #7207. Conflicts where with neighbouring, unrelated code both in lib/internal/util.js and test/parallel/test-buffer-alloc.js. It’s only a cleanup change but other changes like a6f7...

Opengraph URL: https://github.com/nodejs/node/pull/8463

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:037edd74-0a58-4edf-db09-6ef7ade40fdc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC6A8:814DC:9D4DA:CF937:6A52EA46
html-safe-nonce765c35f955fb0a5172d4cbef7271036f15483b52c7ca880cac993874e1f56f8f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkE4OjgxNERDOjlENERBOkNGOTM3OjZBNTJFQTQ2IiwidmlzaXRvcl9pZCI6IjExODgyODE2NjcxOTU5NTU3ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac45042673e2cce14b44b60b85c8793e16478edf1f16f5bb07698ef074f016f88d
hovercard-subject-tagpull_request:84637167
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8463/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/858d29b374c9d626746321513e1f364b942652802ce9770ebf3afa994800f4e3/nodejs/node/pull/8463
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/858d29b374c9d626746321513e1f364b942652802ce9770ebf3afa994800f4e3/nodejs/node/pull/8463
og:image:altv6.x backport of #7207. Conflicts where with neighbouring, unrelated code both in lib/internal/util.js and test/parallel/test-buffer-alloc.js. It’s only a cleanup change but other changes like a6f7...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8463#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8463
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8463
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8463
Reloadhttps://github.com/nodejs/node/pull/8463
Reloadhttps://github.com/nodejs/node/pull/8463
Please reload this pagehttps://github.com/nodejs/node/pull/8463
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/8463
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 995 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
addaleax:backport-7207https://github.com/addaleax/node/tree/backport-7207
Conversationhttps://github.com/nodejs/node/pull/8463
Commits1 (1)https://github.com/nodejs/node/pull/8463/commits
Checkshttps://github.com/nodejs/node/pull/8463/checks
Files changedhttps://github.com/nodejs/node/pull/8463/files
v6.x backport: buffer,string_decoder: consolidate encoding validation logichttps://github.com/nodejs/node/pull/8463#top
addaleaxhttps://github.com/addaleax
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
addaleax:backport-7207https://github.com/addaleax/node/tree/backport-7207
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 9, 2016https://github.com/nodejs/node/pull/8463#issue-175990217
Please reload this pagehttps://github.com/nodejs/node/pull/8463
#7207https://github.com/nodejs/node/pull/7207
a6f7b13https://github.com/nodejs/node/commit/a6f7b13d02c20ffad48840832fcff2e23a72a7fb
https://ci.nodejs.org/job/node-test-commit/4975/https://ci.nodejs.org/job/node-test-commit/4975/
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/8463
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
string_decoder https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astring_decoder
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x
Sep 9, 2016https://github.com/nodejs/node/pull/8463#event-783806530
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 9, 2016https://github.com/nodejs/node/pull/8463#issuecomment-245921145
Please reload this pagehttps://github.com/nodejs/node/pull/8463
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 9, 2016https://github.com/nodejs/node/pull/8463#issuecomment-245935411
Please reload this pagehttps://github.com/nodejs/node/pull/8463
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
force-pushedhttps://github.com/nodejs/node/compare/b596da0c7c2311c0de61e17885d718e18f98b0f2..49f996f4f6a8001cf46be40edea88f3f43ab5d11
b596da0https://github.com/nodejs/node/commit/b596da0c7c2311c0de61e17885d718e18f98b0f2
49f996fhttps://github.com/nodejs/node/commit/49f996f4f6a8001cf46be40edea88f3f43ab5d11
Compare https://github.com/nodejs/node/compare/b596da0c7c2311c0de61e17885d718e18f98b0f2..49f996f4f6a8001cf46be40edea88f3f43ab5d11
September 9, 2016 15:19https://github.com/nodejs/node/pull/8463#event-784068163
https://github.com/jasnell
https://github.com/addaleax
buffer,string_decoder: consolidate encoding validation logichttps://github.com/nodejs/node/pull/8463/commits/9fda52612c9bcffd29524c639fdc3ebf328ef727
9fda526https://github.com/nodejs/node/pull/8463/commits/9fda52612c9bcffd29524c639fdc3ebf328ef727
nodejs#7207https://github.com/nodejs/node/pull/7207
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 9, 2016https://github.com/nodejs/node/pull/8463#issuecomment-245947269
Please reload this pagehttps://github.com/nodejs/node/pull/8463
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/8463
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/8141ff1aea001fcc87b0782eb603d6374ae4cdf0..9fda52612c9bcffd29524c639fdc3ebf328ef727
8141ff1https://github.com/nodejs/node/commit/8141ff1aea001fcc87b0782eb603d6374ae4cdf0
9fda526https://github.com/nodejs/node/commit/9fda52612c9bcffd29524c639fdc3ebf328ef727
Compare https://github.com/nodejs/node/compare/8141ff1aea001fcc87b0782eb603d6374ae4cdf0..9fda52612c9bcffd29524c639fdc3ebf328ef727
September 9, 2016 15:28https://github.com/nodejs/node/pull/8463#event-784082161
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 9, 2016https://github.com/nodejs/node/pull/8463#issuecomment-245948606
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/8463
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 9, 2016https://github.com/nodejs/node/pull/8463#issuecomment-245949205
Please reload this pagehttps://github.com/nodejs/node/pull/8463
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 9, 2016 https://github.com/nodejs/node/pull/8463#ref-pullrequest-173604477
crypto: fix ucs2/ucs-2/utf16le/utf-16le encoding check #8301 https://github.com/nodejs/node/pull/8301
Fishrock123https://github.com/Fishrock123
Sep 13, 2016 https://github.com/nodejs/node/pull/8463#ref-commit-dd51b1f
https://github.com/jasnell
https://github.com/Fishrock123
buffer,string_decoder: consolidate encoding validation logichttps://github.com/nodejs/node/commit/dd51b1f428af888100d40ebb2915e20ab07c1f15
dd51b1fhttps://github.com/nodejs/node/commit/dd51b1f428af888100d40ebb2915e20ab07c1f15
#7207https://github.com/nodejs/node/pull/7207
#8463https://github.com/nodejs/node/pull/8463
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 13, 2016https://github.com/nodejs/node/pull/8463#issuecomment-246856416
dd51b1fhttps://github.com/nodejs/node/commit/dd51b1f428af888100d40ebb2915e20ab07c1f15
Please reload this pagehttps://github.com/nodejs/node/pull/8463
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 13, 2016https://github.com/nodejs/node/pull/8463#event-788358616
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8463
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
string_decoder https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astring_decoder
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Please reload this pagehttps://github.com/nodejs/node/pull/8463
https://github.com/addaleax
https://github.com/jasnell
https://github.com/Fishrock123
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.