| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d922bfc5-53bb-f635-5c75-c34a7e5bf5bd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C1D0:3410DA:13BA86D:1981348:696B1B1B |
| html-safe-nonce | 0fe77b1c2049e6db27908198c5dec51dc41214fdeabebbf0bb680ff4826f84b3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUQwOjM0MTBEQToxM0JBODZEOjE5ODEzNDg6Njk2QjFCMUIiLCJ2aXNpdG9yX2lkIjoiNDk1Nzc4MTA3NzY4MjQ5NDIzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a0d547224fbad83b5f5f0e762aef5dbb2a1f6e91f8f22172cf435bda000b34df |
| hovercard-subject-tag | pull_request:84545545 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8450/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dc9e03812e6f9bf85c20dc07c2a300043a2406f02bf5135ba5e9b64994c2aca7/nodejs/node/pull/8450 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dc9e03812e6f9bf85c20dc07c2a300043a2406f02bf5135ba5e9b64994c2aca7/nodejs/node/pull/8450 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
c++
Description of change
I was getting these warn... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | santigimeno |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8450#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8450 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8450 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8450 |
| Reload | https://github.com/nodejs/node/pull/8450 |
| Reload | https://github.com/nodejs/node/pull/8450 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/8450#issue-comment-box |
| santigimeno | https://github.com/santigimeno |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| santigimeno:fix_warning | https://github.com/santigimeno/node/tree/fix_warning |
|
src: fix unused-result warning
| https://github.com/nodejs/node/pull/8450#top |
| santigimeno | https://github.com/santigimeno |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| santigimeno:fix_warning | https://github.com/santigimeno/node/tree/fix_warning |
|
Conversation
8
| https://github.com/nodejs/node/pull/8450 |
|
Commits
1
| https://github.com/nodejs/node/pull/8450/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/8450/checks |
|
Files changed
| https://github.com/nodejs/node/pull/8450/files |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/santigimeno |
| santigimeno | https://github.com/santigimeno |
| Sep 8, 2016 | https://github.com/nodejs/node/pull/8450#issue-175852212 |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Sep 8, 2016 | https://github.com/nodejs/node/pull/8450#event-783001914 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 8, 2016 | https://github.com/nodejs/node/pull/8450#issuecomment-245726658 |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 8, 2016 | https://github.com/nodejs/node/pull/8450#issuecomment-245731097 |
| https://ci.nodejs.org/job/node-test-commit/4959/ | https://ci.nodejs.org/job/node-test-commit/4959/ |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 8, 2016 | https://github.com/nodejs/node/pull/8450#issuecomment-245770397 |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8450#issuecomment-245842536 |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8450#issuecomment-245849781 |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8450#issuecomment-245979716 |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
|
| https://github.com/santigimeno |
| src: fix -Wunused-result warning | https://github.com/nodejs/node/pull/8450/commits/cc00be6aceac5eb8bb135c32da99eaf217b29a24 |
| cc00be6 | https://github.com/nodejs/node/pull/8450/commits/cc00be6aceac5eb8bb135c32da99eaf217b29a24 |
| nodejs#8450 | https://github.com/nodejs/node/pull/8450 |
| https://github.com/santigimeno |
| santigimeno | https://github.com/santigimeno |
| force-pushed | https://github.com/nodejs/node/compare/513d696817506ba38e83410a65ad11995fe2760b..cc00be6aceac5eb8bb135c32da99eaf217b29a24 |
| 513d696 | https://github.com/nodejs/node/commit/513d696817506ba38e83410a65ad11995fe2760b |
| cc00be6 | https://github.com/nodejs/node/commit/cc00be6aceac5eb8bb135c32da99eaf217b29a24 |
|
Compare
| https://github.com/nodejs/node/compare/513d696817506ba38e83410a65ad11995fe2760b..cc00be6aceac5eb8bb135c32da99eaf217b29a24 |
| September 9, 2016 20:00 | https://github.com/nodejs/node/pull/8450#event-784456060 |
| https://github.com/santigimeno |
| santigimeno | https://github.com/santigimeno |
| cc00be6 | https://github.com/nodejs/node/commit/cc00be6aceac5eb8bb135c32da99eaf217b29a24 |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8450#event-784457797 |
| https://github.com/santigimeno |
| santigimeno | https://github.com/santigimeno |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8450#issuecomment-246023867 |
| cc00be6 | https://github.com/nodejs/node/commit/cc00be6aceac5eb8bb135c32da99eaf217b29a24 |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Sep 13, 2016 | https://github.com/nodejs/node/pull/8450#issuecomment-246846117 |
| #7082 | https://github.com/nodejs/node/pull/7082 |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Sep 13, 2016 | https://github.com/nodejs/node/pull/8450#event-788307101 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Sep 13, 2016 | https://github.com/nodejs/node/pull/8450#event-788308222 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/8450#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8450 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/8450 |
|
| https://github.com/santigimeno |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
|
| https://github.com/bnoordhuis |
|
| https://github.com/fhinkel |
|
| https://github.com/cjihrig |
|
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |