René's URL Explorer Experiment


Title: timers: do not expose .unref()._handle._list by Fishrock123 · Pull Request #8422 · nodejs/node · GitHub

Open Graph Title: timers: do not expose .unref()._handle._list by Fishrock123 · Pull Request #8422 · nodejs/node

X Title: timers: do not expose .unref()._handle._list by Fishrock123 · Pull Request #8422 · nodejs/node

Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) timers Descri...

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) timers Descri...

X Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) timers Descri...

Opengraph URL: https://github.com/nodejs/node/pull/8422

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:22641dd5-a77c-1e4c-85be-a12090c3eb64
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB474:3B507F:1A195AD:23EE496:696AB17F
html-safe-nonce44d7d3435267b69ddad2315a80aff27693b3560aab7f3e6482f7baca8c10b060
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDc0OjNCNTA3RjoxQTE5NUFEOjIzRUU0OTY6Njk2QUIxN0YiLCJ2aXNpdG9yX2lkIjoiODEwMTE3NDkxMzI4MDk0NjU1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac44ec557d4b93fb10df528d25a94c73653e7eacbac1f7617b2d16c84faf3d37d3
hovercard-subject-tagpull_request:84148136
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8422/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9be4a65c49cac0e0012464f368170d4ea739b7031f1130735b6b6af9ab92e0e8/nodejs/node/pull/8422
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9be4a65c49cac0e0012464f368170d4ea739b7031f1130735b6b6af9ab92e0e8/nodejs/node/pull/8422
og:image:altChecklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) timers Descri...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFishrock123
hostnamegithub.com
expected-hostnamegithub.com
None4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release41f276818bd204c4a30a0281fb3c576298d9474c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8422#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8422
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8422
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8422
Reloadhttps://github.com/nodejs/node/pull/8422
Reloadhttps://github.com/nodejs/node/pull/8422
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/8422#issue-comment-box
Fishrock123https://github.com/Fishrock123
nodejs:masterhttps://github.com/nodejs/node/tree/master
Fishrock123:timers-fix-list-propagationhttps://github.com/Fishrock123/node/tree/timers-fix-list-propagation
timers: do not expose .unref()._handle._list https://github.com/nodejs/node/pull/8422#top
Fishrock123https://github.com/Fishrock123
nodejs:masterhttps://github.com/nodejs/node/tree/master
Fishrock123:timers-fix-list-propagationhttps://github.com/Fishrock123/node/tree/timers-fix-list-propagation
Conversation 56 https://github.com/nodejs/node/pull/8422
Commits 3 https://github.com/nodejs/node/pull/8422/commits
Checks 0 https://github.com/nodejs/node/pull/8422/checks
Files changed https://github.com/nodejs/node/pull/8422/files
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 6, 2016https://github.com/nodejs/node/pull/8422#issue-175283440
Please reload this pagehttps://github.com/nodejs/node/pull/8422
3eecdf9https://github.com/nodejs/node/commit/3eecdf9f1422640c7439507cb39ffb3dff57b3e4
#8372https://github.com/nodejs/node/pull/8372
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
Sep 6, 2016https://github.com/nodejs/node/pull/8422#event-779558164
YurySolovyovhttps://github.com/YurySolovyov
Sep 6, 2016 https://github.com/nodejs/node/pull/8422#discussion-diff-77676005
lib/timers.jshttps://github.com/nodejs/node/pull/8422/files#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724
YurySolovyovhttps://github.com/YurySolovyov
Sep 6, 2016https://github.com/nodejs/node/pull/8422#discussion_r77676005
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Fishrock123https://github.com/Fishrock123
Sep 6, 2016https://github.com/nodejs/node/pull/8422#discussion_r77687714
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#8372https://github.com/nodejs/node/pull/8372
Please reload this pagehttps://github.com/nodejs/node/pull/8422
misterdjuleshttps://github.com/misterdjules
Sep 6, 2016https://github.com/nodejs/node/pull/8422#discussion_r77728145
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#8372https://github.com/nodejs/node/pull/8372
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Fishrock123https://github.com/Fishrock123
Sep 6, 2016https://github.com/nodejs/node/pull/8422#discussion_r77734923
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
misterdjuleshttps://github.com/misterdjules
Sep 7, 2016https://github.com/nodejs/node/pull/8422#discussion_r77880889
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
misterdjuleshttps://github.com/misterdjules
Sep 12, 2016https://github.com/nodejs/node/pull/8422#discussion_r78473969
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/8422
indutnyhttps://github.com/indutny
Jan 6, 2017https://github.com/nodejs/node/pull/8422#discussion_r94936772
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Fishrock123https://github.com/Fishrock123
Jan 6, 2017https://github.com/nodejs/node/pull/8422#discussion_r94957321
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
jasnellhttps://github.com/jasnell
Jan 6, 2017https://github.com/nodejs/node/pull/8422#discussion_r94975665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
trevnorrishttps://github.com/trevnorris
Jan 11, 2017https://github.com/nodejs/node/pull/8422#discussion_r95694076
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 6, 2016https://github.com/nodejs/node/pull/8422#issuecomment-245090038
@misterdjuleshttps://github.com/misterdjules
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Sep 6, 2016https://github.com/nodejs/node/pull/8422#issuecomment-245112089
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 9, 2016 https://github.com/nodejs/node/pull/8422#ref-issue-175937772
Investigate flaky sequential/test-timers-same-timeout-wrong-list-deleted #8459 https://github.com/nodejs/node/issues/8459
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Sep 12, 2016https://github.com/nodejs/node/pull/8422#issuecomment-246531516
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 13, 2016https://github.com/nodejs/node/pull/8422#issuecomment-246571028
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Sep 13, 2016https://github.com/nodejs/node/pull/8422#issuecomment-246580619
@Fishrock123https://github.com/Fishrock123
https://github.com/ChALkeR/Gzemnidhttps://github.com/ChALkeR/Gzemnid
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 13, 2016https://github.com/nodejs/node/pull/8422#issuecomment-246839949
@ChALkeRhttps://github.com/ChALkeR
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Sep 15, 2016https://github.com/nodejs/node/pull/8422#issuecomment-247403536
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720
b0df363https://github.com/nodejs/node/commit/b0df363eda7d8a4314efaee5245b5073476c7362
c5ce7f4https://github.com/nodejs/node/commit/c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720
Compare https://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720
September 21, 2016 00:09https://github.com/nodejs/node/pull/8422#event-796539504
https://github.com/rvagg
rvagghttps://github.com/rvagg
force-pushedhttps://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0
c133999https://github.com/nodejs/node/commit/c13399980463b0a8691ea2cff9191aa5aede8d0e
83c7a88https://github.com/nodejs/node/commit/83c7a8897c644e1eadeaaace4863a822c73359a0
Compare https://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0
October 18, 2016 17:02https://github.com/nodejs/node/pull/8422#event-827820530
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Jan 5, 2017https://github.com/nodejs/node/pull/8422#event-913036950
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jan 5, 2017https://github.com/nodejs/node/pull/8422#issuecomment-270716617
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/targos
targoshttps://github.com/targos
Jan 6, 2017https://github.com/nodejs/node/pull/8422#issuecomment-270869320
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/indutny
indutnyhttps://github.com/indutny
Jan 6, 2017 https://github.com/nodejs/node/pull/8422#pullrequestreview-15479457
View reviewed changes https://github.com/nodejs/node/pull/8422/files
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 11, 2017https://github.com/nodejs/node/pull/8422#issuecomment-272026117
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jan 12, 2017https://github.com/nodejs/node/pull/8422#issuecomment-272206687
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jan 12, 2017https://github.com/nodejs/node/pull/8422#issuecomment-272206853
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 1, 2017https://github.com/nodejs/node/pull/8422#issuecomment-283222625
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 22, 2017https://github.com/nodejs/node/pull/8422#issuecomment-288558919
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/jasnell
jasnellhttps://github.com/jasnell
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Mar 22, 2017https://github.com/nodejs/node/pull/8422#event-1011402373
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Mar 22, 2017https://github.com/nodejs/node/pull/8422#issuecomment-288566042
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
force-pushedhttps://github.com/nodejs/node/compare/a64d9fc13d9a6d140ba80e5d0a95ee771db247e3..51090c494244b8c916023bc8bf61b40efc3d69dd
a64d9fchttps://github.com/nodejs/node/commit/a64d9fc13d9a6d140ba80e5d0a95ee771db247e3
51090c4https://github.com/nodejs/node/commit/51090c494244b8c916023bc8bf61b40efc3d69dd
Compare https://github.com/nodejs/node/compare/a64d9fc13d9a6d140ba80e5d0a95ee771db247e3..51090c494244b8c916023bc8bf61b40efc3d69dd
March 24, 2017 14:37https://github.com/nodejs/node/pull/8422#event-1014393755
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Mar 24, 2017https://github.com/nodejs/node/pull/8422#issuecomment-289041205
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://ci.nodejs.org/job/node-test-pull-request/7020/https://ci.nodejs.org/job/node-test-pull-request/7020/
@indutnyhttps://github.com/indutny
@misterdjuleshttps://github.com/misterdjules
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Mar 24, 2017https://github.com/nodejs/node/pull/8422#issuecomment-289044177
https://ci.nodejs.org/job/node-test-pull-request/7021/https://ci.nodejs.org/job/node-test-pull-request/7021/
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/targos
targoshttps://github.com/targos
Mar 24, 2017 https://github.com/nodejs/node/pull/8422#pullrequestreview-28924116
View reviewed changes https://github.com/nodejs/node/pull/8422/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 24, 2017 https://github.com/nodejs/node/pull/8422#pullrequestreview-28927043
View reviewed changes https://github.com/nodejs/node/pull/8422/files
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Apr 3, 2017 https://github.com/nodejs/node/pull/8422#pullrequestreview-30603919
View reviewed changes https://github.com/nodejs/node/pull/8422/files
misterdjuleshttps://github.com/misterdjules
https://github.com/nodejs/node/pull/8422#pullrequestreview-30603919
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
lib/timers.jshttps://github.com/nodejs/node/pull/8422/files#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724
misterdjuleshttps://github.com/misterdjules
Apr 3, 2017https://github.com/nodejs/node/pull/8422#discussion_r109498028
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
[Squash] set _list to undefinedhttps://github.com/nodejs/node/pull/8422/commits/33b213c462d8c725fe81acd356552eebbef73e5f
33b213chttps://github.com/nodejs/node/pull/8422/commits/33b213c462d8c725fe81acd356552eebbef73e5f
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
force-pushedhttps://github.com/nodejs/node/compare/8847f56d0f60b86b02ace65a08bac13c585d6200..33b213c462d8c725fe81acd356552eebbef73e5f
8847f56https://github.com/nodejs/node/commit/8847f56d0f60b86b02ace65a08bac13c585d6200
33b213chttps://github.com/nodejs/node/commit/33b213c462d8c725fe81acd356552eebbef73e5f
Compare https://github.com/nodejs/node/compare/8847f56d0f60b86b02ace65a08bac13c585d6200..33b213c462d8c725fe81acd356552eebbef73e5f
April 10, 2017 23:51https://github.com/nodejs/node/pull/8422#event-1037415386
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 10, 2017https://github.com/nodejs/node/pull/8422#issuecomment-293110726
https://ci.nodejs.org/job/node-test-pull-request/7316/https://ci.nodejs.org/job/node-test-pull-request/7316/
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Apr 11, 2017 https://github.com/nodejs/node/pull/8422#pullrequestreview-32233478
View reviewed changes https://github.com/nodejs/node/pull/8422/files/33b213c462d8c725fe81acd356552eebbef73e5f
test/parallel/test-timers-unref-reuse-no-exposed-list.jshttps://github.com/nodejs/node/pull/8422/files/33b213c462d8c725fe81acd356552eebbef73e5f#diff-502b0214eb47dd7bad71cff11d1117b17e7e8a56aa663b73535def1008301c21
misterdjuleshttps://github.com/misterdjules
Apr 11, 2017https://github.com/nodejs/node/pull/8422#discussion_r111018694
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#10155https://github.com/nodejs/node/pull/10155
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Fishrock123https://github.com/Fishrock123
Apr 12, 2017https://github.com/nodejs/node/pull/8422#discussion_r111168558
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
misterdjuleshttps://github.com/misterdjules
Apr 12, 2017https://github.com/nodejs/node/pull/8422#discussion_r111203812
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Apr 11, 2017 https://github.com/nodejs/node/pull/8422#pullrequestreview-32233900
View reviewed changes https://github.com/nodejs/node/pull/8422/files/33b213c462d8c725fe81acd356552eebbef73e5f
test/parallel/test-timers-unref-reuse-no-exposed-list.jshttps://github.com/nodejs/node/pull/8422/files/33b213c462d8c725fe81acd356552eebbef73e5f#diff-502b0214eb47dd7bad71cff11d1117b17e7e8a56aa663b73535def1008301c21
misterdjuleshttps://github.com/misterdjules
Apr 11, 2017https://github.com/nodejs/node/pull/8422#discussion_r111019133
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Fishrock123https://github.com/Fishrock123
Apr 12, 2017https://github.com/nodejs/node/pull/8422#discussion_r111171468
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
misterdjuleshttps://github.com/misterdjules
Apr 12, 2017https://github.com/nodejs/node/pull/8422#discussion_r111206544
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Fishrock123https://github.com/Fishrock123
Apr 13, 2017https://github.com/nodejs/node/pull/8422#discussion_r111405057
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
misterdjuleshttps://github.com/misterdjules
Apr 13, 2017https://github.com/nodejs/node/pull/8422#discussion_r111425366
Please reload this pagehttps://github.com/nodejs/node/pull/8422
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Apr 11, 2017 https://github.com/nodejs/node/pull/8422#pullrequestreview-32234134
View reviewed changes https://github.com/nodejs/node/pull/8422/files/33b213c462d8c725fe81acd356552eebbef73e5f
misterdjuleshttps://github.com/misterdjules
https://github.com/nodejs/node/pull/8422#pullrequestreview-32234134
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 12, 2017https://github.com/nodejs/node/pull/8422#issuecomment-293602296
@misterdjuleshttps://github.com/misterdjules
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/refack
refackhttps://github.com/refack
force-pushedhttps://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00
16073c0https://github.com/nodejs/node/commit/16073c083efdcaf70aef1e490679457dd0f624bd
fbe946bhttps://github.com/nodejs/node/commit/fbe946bb6316f1e1083ec47baaf812fc98d60f00
Compare https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00
April 14, 2017 04:11https://github.com/nodejs/node/pull/8422#event-1042928492
https://github.com/Fishrock123
[Squash] remove commenthttps://github.com/nodejs/node/pull/8422/commits/dc49d916c0ceb869f8e747ba12f0a63e451b6725
dc49d91https://github.com/nodejs/node/pull/8422/commits/dc49d916c0ceb869f8e747ba12f0a63e451b6725
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 20, 2017https://github.com/nodejs/node/pull/8422#issuecomment-295786132
@misterdjuleshttps://github.com/misterdjules
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 20, 2017https://github.com/nodejs/node/pull/8422#issuecomment-295789743
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/719/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/719/
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Apr 20, 2017 https://github.com/nodejs/node/pull/8422#pullrequestreview-33813094
View reviewed changes https://github.com/nodejs/node/pull/8422/files/dc49d916c0ceb869f8e747ba12f0a63e451b6725
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Apr 20, 2017https://github.com/nodejs/node/pull/8422#event-1050845442
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 26, 2017https://github.com/nodejs/node/pull/8422#issuecomment-325107262
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 26, 2017 https://github.com/nodejs/node/pull/8422#pullrequestreview-58797848
View reviewed changes https://github.com/nodejs/node/pull/8422/files/dc49d916c0ceb869f8e747ba12f0a63e451b6725
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 14, 2017 https://github.com/nodejs/node/pull/8422#pullrequestreview-62792578
View reviewed changes https://github.com/nodejs/node/pull/8422/files/dc49d916c0ceb869f8e747ba12f0a63e451b6725
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/8422#pullrequestreview-62792578
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
indutnyhttps://github.com/indutny
stale reviewhttps://github.com/nodejs/node/pull/8422#pullrequestreview-15479457
September 20, 2017 00:57https://github.com/nodejs/node/pull/8422#event-1256553950
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 20, 2017https://github.com/nodejs/node/pull/8422#issuecomment-330714838
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 20, 2017https://github.com/nodejs/node/pull/8422#issuecomment-330750634
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 20, 2017 https://github.com/nodejs/node/pull/8422#pullrequestreview-63889828
View reviewed changes https://github.com/nodejs/node/pull/8422/files/dc49d916c0ceb869f8e747ba12f0a63e451b6725
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 20, 2017https://github.com/nodejs/node/pull/8422#issuecomment-330773607
https://ci.nodejs.org/job/node-test-pull-request/10153/https://ci.nodejs.org/job/node-test-pull-request/10153/
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 20, 2017https://github.com/nodejs/node/pull/8422#issuecomment-330861332
Please reload this pagehttps://github.com/nodejs/node/pull/8422
11f7dcfhttps://github.com/nodejs/node/commit/11f7dcf91ef3538e2f7e3be57ef22073ff5b9d4b
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 20, 2017https://github.com/nodejs/node/pull/8422#event-1257498464
BridgeARhttps://github.com/BridgeAR
Sep 20, 2017 https://github.com/nodejs/node/pull/8422#ref-commit-11f7dcf
https://github.com/Fishrock123
https://github.com/BridgeAR
timers: do not expose .unref()._handle._listhttps://github.com/nodejs/node/commit/11f7dcf91ef3538e2f7e3be57ef22073ff5b9d4b
11f7dcfhttps://github.com/nodejs/node/commit/11f7dcf91ef3538e2f7e3be57ef22073ff5b9d4b
3eecdf9https://github.com/nodejs/node/commit/3eecdf9f1422640c7439507cb39ffb3dff57b3e4
#8422https://github.com/nodejs/node/pull/8422
Qardhttps://github.com/Qard
Sep 21, 2017 https://github.com/nodejs/node/pull/8422#ref-commit-b1b9467
https://github.com/Fishrock123
timers: do not expose .unref()._handle._listhttps://github.com/Qard/ayo/commit/b1b94678d8e81caa9f0e123d5e85828acd03a961
b1b9467https://github.com/Qard/ayo/commit/b1b94678d8e81caa9f0e123d5e85828acd03a961
3eecdf9https://github.com/Qard/ayo/commit/3eecdf9f1422640c7439507cb39ffb3dff57b3e4
nodejs/node#8422https://github.com/nodejs/node/pull/8422
Qardhttps://github.com/Qard
Sep 21, 2017 https://github.com/nodejs/node/pull/8422#ref-commit-3d0d4d3
https://github.com/Fishrock123
timers: do not expose .unref()._handle._listhttps://github.com/Qard/ayo/commit/3d0d4d38c9da4ee88ef81ab7d28fa72245d8cd49
3d0d4d3https://github.com/Qard/ayo/commit/3d0d4d38c9da4ee88ef81ab7d28fa72245d8cd49
3eecdf9https://github.com/Qard/ayo/commit/3eecdf9f1422640c7439507cb39ffb3dff57b3e4
nodejs/node#8422https://github.com/nodejs/node/pull/8422
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2017 https://github.com/nodejs/node/pull/8422#ref-pullrequest-254697213
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135 https://github.com/nodejs/node/pull/15135
[Snyk] Upgrade @typescript-eslint/eslint-plugin from 6.21.0 to 7.0.1 B020239/node#2 https://github.com/B020239/node/pull/2
[Snyk] Upgrade @typescript-eslint/parser from 6.21.0 to 7.0.1 B020239/node#3 https://github.com/B020239/node/pull/3
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8422
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/8422/files/dc49d916c0ceb869f8e747ba12f0a63e451b6725
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/8422/files/dc49d916c0ceb869f8e747ba12f0a63e451b6725
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/8422/files/deb3d77b83e3e1f1a9a23c8e2ac589e12ac51b05
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/8422/files/deb3d77b83e3e1f1a9a23c8e2ac589e12ac51b05
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/8422/files/dc49d916c0ceb869f8e747ba12f0a63e451b6725
https://github.com/trevnorris
trevnorris https://github.com/trevnorris
https://github.com/nodejs/node/pull/8422/files/a64d9fc13d9a6d140ba80e5d0a95ee771db247e3
https://github.com/misterdjules
misterdjules https://github.com/misterdjules
https://github.com/nodejs/node/pull/8422/files/dc49d916c0ceb869f8e747ba12f0a63e451b6725
https://github.com/indutny
indutny https://github.com/indutny
https://github.com/nodejs/node/pull/8422/files/a64d9fc13d9a6d140ba80e5d0a95ee771db247e3
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
Please reload this pagehttps://github.com/nodejs/node/pull/8422
https://github.com/Fishrock123
https://github.com/misterdjules
https://github.com/ChALkeR
https://github.com/targos
https://github.com/trevnorris
https://github.com/jasnell
https://github.com/BridgeAR
https://github.com/mcollina
https://github.com/indutny
https://github.com/YurySolovyov
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.