René's URL Explorer Experiment


Title: Cherrypick commits from joyent/node by cjihrig · Pull Request #834 · nodejs/node · GitHub

Open Graph Title: Cherrypick commits from joyent/node by cjihrig · Pull Request #834 · nodejs/node

X Title: Cherrypick commits from joyent/node by cjihrig · Pull Request #834 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: These are the commits listed in #832 minus nodejs/node-v0.x-archive@ad06848, which I'll handle in #278. Closes #832 R=@bnoordhuis

X Description: These are the commits listed in #832 minus nodejs/node-v0.x-archive@ad06848, which I'll handle in #278. Closes #832 R=@bnoordhuis

Opengraph URL: https://github.com/nodejs/node/pull/834

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:853ee0d0-a8bd-7536-868f-3f754c4857aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBD0:1587FA:6AAE8E:8E6EEC:6AED21DB
html-safe-noncef28a9de1b75e1e67f460ed511527bc3d010e495fce2e8e54d4c6e04b4ba5c61d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkQwOjE1ODdGQTo2QUFFOEU6OEU2RUVDOjZBRUQyMURCIiwidmlzaXRvcl9pZCI6IjE1ODU3MDU5ODE5MjYyNTMwMTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacad18156883b1bd4a01e30fcc28098c3964aa29455d00d79d0fb10e1dee909291
hovercard-subject-tagpull_request:29282745
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/834/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5b2cfca6df04c5983b4211ffd70240506ddf0331bfe5e199174e2e4c92593cd3/nodejs/node/pull/834
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5b2cfca6df04c5983b4211ffd70240506ddf0331bfe5e199174e2e4c92593cd3/nodejs/node/pull/834
og:image:altThese are the commits listed in #832 minus nodejs/node-v0.x-archive@ad06848, which I'll handle in #278. Closes #832 R=@bnoordhuis
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/834#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F834
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F834
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/834
Reloadhttps://github.com/nodejs/node/pull/834
Reloadhttps://github.com/nodejs/node/pull/834
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
cjihrighttps://github.com/cjihrig
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
Conversationhttps://github.com/nodejs/node/pull/834
Commits7 (7)https://github.com/nodejs/node/pull/834/commits
Checkshttps://github.com/nodejs/node/pull/834/checks
Files changedhttps://github.com/nodejs/node/pull/834/files
Cherrypick commits from joyent/nodehttps://github.com/nodejs/node/pull/834#top
cjihrighttps://github.com/cjihrig
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 13, 2015https://github.com/nodejs/node/pull/834#issue-57628119
#832https://github.com/nodejs/node/issues/832
nodejs/node-v0.x-archive@ad06848https://github.com/nodejs/node-v0.x-archive/commit/ad0684807c474db5cda7d28592e34e19910eb7ab
#278https://github.com/nodejs/node/pull/278
#832https://github.com/nodejs/node/issues/832
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/834
cjihrighttps://github.com/cjihrig
February 13, 2015 12:02https://github.com/nodejs/node/pull/834#commits-pushed-faafbe7
https://github.com/cjihrig
net: throw on invalid socket timeoutshttps://github.com/nodejs/node/pull/834/commits/faafbe7ff7b0aa34201eecd2b51532e1b4f7c4ff
faafbe7https://github.com/nodejs/node/pull/834/commits/faafbe7ff7b0aa34201eecd2b51532e1b4f7c4ff
nodejs/node-v0.x-archive#8618https://github.com/nodejs/node-v0.x-archive/issues/8618
nodejs/node-v0.x-archive#8884https://github.com/nodejs/node-v0.x-archive/pull/8884
https://github.com/bsnote
https://github.com/cjihrig
doc: use correct signature for assert()https://github.com/nodejs/node/pull/834/commits/39be594c3d6b89493ff6b3e8b50956caff516f92
39be594https://github.com/nodejs/node/pull/834/commits/39be594c3d6b89493ff6b3e8b50956caff516f92
nodejs/node-v0.x-archive#9003https://github.com/nodejs/node-v0.x-archive/pull/9003
https://github.com/cjihrig
module: replace NativeModule.requirehttps://github.com/nodejs/node/pull/834/commits/970841d13d85b0fb20e1bd2de9c64da2ff5545c3
970841dhttps://github.com/nodejs/node/pull/834/commits/970841d13d85b0fb20e1bd2de9c64da2ff5545c3
nodejs/node-v0.x-archive#9201https://github.com/nodejs/node-v0.x-archive/pull/9201
nodejs/node-v0.x-archive#2009https://github.com/nodejs/node-v0.x-archive/issues/2009
https://github.com/dandv
https://github.com/cjihrig
doc: fix code syntaxhttps://github.com/nodejs/node/pull/834/commits/43907ca7e08cec306ed80ab3a26fdbb8dea2b20a
43907cahttps://github.com/nodejs/node/pull/834/commits/43907ca7e08cec306ed80ab3a26fdbb8dea2b20a
nodejs/node-v0.x-archive#9198https://github.com/nodejs/node-v0.x-archive/pull/9198
https://github.com/jscissr
https://github.com/cjihrig
test: Timeout#unref() does not return instancehttps://github.com/nodejs/node/pull/834/commits/ff66973c53be75d1f597bcfce19d827daab6db1d
ff66973https://github.com/nodejs/node/pull/834/commits/ff66973c53be75d1f597bcfce19d827daab6db1d
nodejs/node-v0.x-archive#9171https://github.com/nodejs/node-v0.x-archive/pull/9171
https://github.com/cjihrig
doc: grammar fix in smallochttps://github.com/nodejs/node/pull/834/commits/22c034676e4fb6500386f862a6a5d3577722d960
22c0346https://github.com/nodejs/node/pull/834/commits/22c034676e4fb6500386f862a6a5d3577722d960
nodejs/node-v0.x-archive#9164https://github.com/nodejs/node-v0.x-archive/pull/9164
https://github.com/cjihrig
net: remove use of arguments in Server constructorhttps://github.com/nodejs/node/pull/834/commits/a699cee296be33f9b11071d67f7986f137f03918
a699ceehttps://github.com/nodejs/node/pull/834/commits/a699cee296be33f9b11071d67f7986f137f03918
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 13, 2015https://github.com/nodejs/node/pull/834#issuecomment-74292369
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/173/https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/173/
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 13, 2015https://github.com/nodejs/node/pull/834#issuecomment-74292758
faafbe7https://github.com/nodejs/node/commit/faafbe7ff7b0aa34201eecd2b51532e1b4f7c4ff
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 13, 2015https://github.com/nodejs/node/pull/834#issuecomment-74294606
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/mikeal
mikealhttps://github.com/mikeal
Feb 13, 2015https://github.com/nodejs/node/pull/834#issuecomment-74296751
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 13, 2015https://github.com/nodejs/node/pull/834#issuecomment-74296974
@mikealhttps://github.com/mikeal
nodejs/node-v0.x-archive#8618https://github.com/nodejs/node-v0.x-archive/issues/8618
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 13, 2015https://github.com/nodejs/node/pull/834#issuecomment-74297787
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/mikeal
mikealhttps://github.com/mikeal
Feb 13, 2015https://github.com/nodejs/node/pull/834#issuecomment-74301017
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Feb 13, 2015https://github.com/nodejs/node/pull/834#issuecomment-74302698
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 13, 2015https://github.com/nodejs/node/pull/834#issuecomment-74303444
0cff052https://github.com/nodejs/node/commit/0cff0521c333df8649bc6a2b1f40adbf899b1261
8c1df7ahttps://github.com/nodejs/node/commit/8c1df7a8a882860da81ccdd543f5a00663548b31
6a2b204https://github.com/nodejs/node/commit/6a2b204bbca1f5189df46ef5c363cab3b2d73262
30dca66https://github.com/nodejs/node/commit/30dca66958daa8ae1ca25834118a16a68c08f65b
3b1b4dehttps://github.com/nodejs/node/commit/3b1b4de9033e2dd167061692c31b9231368ccb81
4ca7ccahttps://github.com/nodejs/node/commit/4ca7cca84a2449c29eb9eb25e71a4a730baef065
cca8de6https://github.com/nodejs/node/commit/cca8de6709ece5b4791d52a8b834da83bfb782d5
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 13, 2015https://github.com/nodejs/node/pull/834#event-235579526
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
February 13, 2015 18:40https://github.com/nodejs/node/pull/834#event-235579879
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 16, 2015 https://github.com/nodejs/node/pull/834#ref-issue-68841345
Release proposal: 1.8.0 #1436 https://github.com/nodejs/node/issues/1436
https://github.com/solebox
soleboxhttps://github.com/solebox
May 13, 2022 https://github.com/nodejs/node/pull/834#ref-pullrequest-1235743764
[Snyk] Fix for 1 vulnerabilities solebox/node#29 https://github.com/solebox/node/pull/29
https://github.com/enterstudio
enterstudiohttps://github.com/enterstudio
May 14, 2022 https://github.com/nodejs/node/pull/834#ref-pullrequest-1235857572
[Snyk] Fix for 1 vulnerabilities enterstudio/node#28 https://github.com/enterstudio/node/pull/28
https://github.com/s4sc
s4schttps://github.com/s4sc
May 14, 2022 https://github.com/nodejs/node/pull/834#ref-pullrequest-1235909300
[Snyk] Fix for 1 vulnerabilities s4sc/node#28 https://github.com/s4sc/node/pull/28
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2026https://github.com/nodejs/node/pull/834#issuecomment-4111935775
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7075/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7075/
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2026https://github.com/nodejs/node/pull/834#issuecomment-4111944557
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/7075/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/7075/
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2026https://github.com/nodejs/node/pull/834#issuecomment-4111947665
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7075/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7075/
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2026https://github.com/nodejs/node/pull/834#issuecomment-4111958342
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7075/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7075/
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2026https://github.com/nodejs/node/pull/834#issuecomment-4112247626
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7077/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7077/
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2026https://github.com/nodejs/node/pull/834#issuecomment-4112252711
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7077/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7077/
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2026https://github.com/nodejs/node/pull/834#issuecomment-4112334061
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7078/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7078/
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2026https://github.com/nodejs/node/pull/834#issuecomment-4112350994
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7078/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7078/
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2026https://github.com/nodejs/node/pull/834#issuecomment-4112525182
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7078/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7078/
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 23, 2026https://github.com/nodejs/node/pull/834#issuecomment-4112732766
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/7078/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/7078/
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F834
Please reload this pagehttps://github.com/nodejs/node/pull/834
Please reload this pagehttps://github.com/nodejs/node/pull/834
https://github.com/cjihrig
https://github.com/bnoordhuis
https://github.com/mikeal
https://github.com/Fishrock123
https://github.com/nodejs-github-bot
https://github.com/bsnote
https://github.com/dandv
https://github.com/jscissr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.