René's URL Explorer Experiment


Title: child_process: spawn() and spawnSync() validation by cjihrig · Pull Request #8312 · nodejs/node · GitHub

Open Graph Title: child_process: spawn() and spawnSync() validation by cjihrig · Pull Request #8312 · nodejs/node

X Title: child_process: spawn() and spawnSync() validation by cjihrig · Pull Request #8312 · nodejs/node

Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) child_process, ...

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) child_process, ...

X Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) child_process, ...

Mail addresses
notifications@github.com

Opengraph URL: https://github.com/nodejs/node/pull/8312

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9723a6d4-c583-c539-8020-66eb128feb22
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8B0:359457:66FEBD:90C029:696A1C02
html-safe-noncef6c8a40a0419fcc6251f9f8da34f4d3a2f32affb1232938e966ebcacc3be4d26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEIwOjM1OTQ1Nzo2NkZFQkQ6OTBDMDI5OjY5NkExQzAyIiwidmlzaXRvcl9pZCI6IjQwMDc5MDU1ODY1MTMwNTg4MTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7d5e280c29a6d609977129ea2f5ecfb1933486f8b23e136e9b18d98b27e55380
hovercard-subject-tagpull_request:83022860
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8312/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3123ea65fa340484bf0883023a041e57f8345c1761a4f9090111193210a03c34/nodejs/node/pull/8312
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3123ea65fa340484bf0883023a041e57f8345c1761a4f9090111193210a03c34/nodejs/node/pull/8312
og:image:altChecklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) child_process, ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None34a52bd10bd674f68e5c1b6b74413b79bf2ca20c551055ace3f7cdd112803923
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee8bd37502700f365b18a4d39acf7cb7947e11b1a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8312#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8312
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8312
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8312
Reloadhttps://github.com/nodejs/node/pull/8312
Reloadhttps://github.com/nodejs/node/pull/8312
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/8312
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/8312
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/8312#issue-comment-box
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:spawnsynchttps://github.com/cjihrig/node/tree/spawnsync
child_process: spawn() and spawnSync() validation https://github.com/nodejs/node/pull/8312#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:spawnsynchttps://github.com/cjihrig/node/tree/spawnsync
Conversation 46 https://github.com/nodejs/node/pull/8312
Commits 3 https://github.com/nodejs/node/pull/8312/commits
Checks 0 https://github.com/nodejs/node/pull/8312/checks
Files changed https://github.com/nodejs/node/pull/8312/files
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 28, 2016https://github.com/nodejs/node/pull/8312#issue-173659783
Please reload this pagehttps://github.com/nodejs/node/pull/8312
#8096https://github.com/nodejs/node/issues/8096
#8096https://github.com/nodejs/node/issues/8096
@bnoordhuishttps://github.com/bnoordhuis
@targoshttps://github.com/targos
@retrohackerhttps://github.com/retrohacker
#8096https://github.com/nodejs/node/issues/8096
#8096https://github.com/nodejs/node/issues/8096
#8539https://github.com/nodejs/node/issues/8539
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Aug 28, 2016https://github.com/nodejs/node/pull/8312#event-770036437
Fishrock123https://github.com/Fishrock123
Aug 28, 2016 https://github.com/nodejs/node/pull/8312#discussion-diff-76536916
View reviewed changes https://github.com/nodejs/node/pull/8312/files#diff-56c0eb11e943939908cf3d1d251bf1aadda236b5adbf8111d79b0809ec403f97
lib/child_process.jshttps://github.com/nodejs/node/pull/8312/files#diff-56c0eb11e943939908cf3d1d251bf1aadda236b5adbf8111d79b0809ec403f97
Fishrock123https://github.com/Fishrock123
Aug 28, 2016https://github.com/nodejs/node/pull/8312#discussion_r76536916
Please reload this pagehttps://github.com/nodejs/node/pull/8312
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
princejwesleyhttps://github.com/princejwesley
Aug 28, 2016https://github.com/nodejs/node/pull/8312#discussion_r76539566
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#8312 (comment)https://github.com/nodejs/node/pull/8312#discussion_r76536916
https://github.com/nodejs/node/pull/8312/files/b4a6558fcbcf6cde50ff29af2d3487896ad91c68#r76536916https://github.com/nodejs/node/pull/8312/files/b4a6558fcbcf6cde50ff29af2d3487896ad91c68#r76536916
https://github.com/notifications/unsubscribe-auth/ABjB841u9wl3B9jlsDIb7RdsDKU0iWTcks5qkdXdgaJpZM4Ju-4Ihttps://github.com/notifications/unsubscribe-auth/ABjB841u9wl3B9jlsDIb7RdsDKU0iWTcks5qkdXdgaJpZM4Ju-4I
Please reload this pagehttps://github.com/nodejs/node/pull/8312
cjihrighttps://github.com/cjihrig
Aug 28, 2016https://github.com/nodejs/node/pull/8312#discussion_r76540962
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
bnoordhuishttps://github.com/bnoordhuis
Sep 2, 2016https://github.com/nodejs/node/pull/8312#discussion_r77311560
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 1, 2016https://github.com/nodejs/node/pull/8312#issuecomment-244175098
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 2, 2016https://github.com/nodejs/node/pull/8312#issuecomment-244317977
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 15, 2016 https://github.com/nodejs/node/pull/8312#ref-issue-177011933
child_process.spawnSync is memory unsafe and can be used to dump core #8539 https://github.com/nodejs/node/issues/8539
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720
b0df363https://github.com/nodejs/node/commit/b0df363eda7d8a4314efaee5245b5073476c7362
c5ce7f4https://github.com/nodejs/node/commit/c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720
Compare https://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720
September 21, 2016 00:09https://github.com/nodejs/node/pull/8312#event-796539470
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 12, 2016https://github.com/nodejs/node/pull/8312#issuecomment-253160926
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 12, 2016https://github.com/nodejs/node/pull/8312#issuecomment-253210222
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/b4a6558fcbcf6cde50ff29af2d3487896ad91c68..7aede77c9b6ec866c50edadbc4d66a50a4206628
b4a6558https://github.com/nodejs/node/commit/b4a6558fcbcf6cde50ff29af2d3487896ad91c68
7aede77https://github.com/nodejs/node/commit/7aede77c9b6ec866c50edadbc4d66a50a4206628
Compare https://github.com/nodejs/node/compare/b4a6558fcbcf6cde50ff29af2d3487896ad91c68..7aede77c9b6ec866c50edadbc4d66a50a4206628
October 18, 2016 14:55https://github.com/nodejs/node/pull/8312#event-827619380
https://github.com/rvagg
rvagghttps://github.com/rvagg
force-pushedhttps://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0
c133999https://github.com/nodejs/node/commit/c13399980463b0a8691ea2cff9191aa5aede8d0e
83c7a88https://github.com/nodejs/node/commit/83c7a8897c644e1eadeaaace4863a822c73359a0
Compare https://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0
October 18, 2016 17:02https://github.com/nodejs/node/pull/8312#event-827820491
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/af5c2f5fb9237e69b764957976d76ff444f77147..76d7181d301cf106c8b7cbe32f6c4ffc7dfd1fac
af5c2f5https://github.com/nodejs/node/commit/af5c2f5fb9237e69b764957976d76ff444f77147
76d7181https://github.com/nodejs/node/commit/76d7181d301cf106c8b7cbe32f6c4ffc7dfd1fac
Compare https://github.com/nodejs/node/compare/af5c2f5fb9237e69b764957976d76ff444f77147..76d7181d301cf106c8b7cbe32f6c4ffc7dfd1fac
October 18, 2016 17:17https://github.com/nodejs/node/pull/8312#event-827843038
https://github.com/rvagg
rvagghttps://github.com/rvagg
force-pushedhttps://github.com/nodejs/node/compare/6f558a7aa153c02543838ffa0d267864ec81d03e..0e6750d1cde710bcdea7657b3800bb5c65e5c70f
6f558a7https://github.com/nodejs/node/commit/6f558a7aa153c02543838ffa0d267864ec81d03e
0e6750dhttps://github.com/nodejs/node/commit/0e6750d1cde710bcdea7657b3800bb5c65e5c70f
Compare https://github.com/nodejs/node/compare/6f558a7aa153c02543838ffa0d267864ec81d03e..0e6750d1cde710bcdea7657b3800bb5c65e5c70f
October 18, 2016 17:23https://github.com/nodejs/node/pull/8312#event-827851569
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/50f599e41c1b77937b9298962903277cd5f24b9b..146129b40a7f67bc99c2279e647fad4f50d6513f
50f599ehttps://github.com/nodejs/node/commit/50f599e41c1b77937b9298962903277cd5f24b9b
146129bhttps://github.com/nodejs/node/commit/146129b40a7f67bc99c2279e647fad4f50d6513f
Compare https://github.com/nodejs/node/compare/50f599e41c1b77937b9298962903277cd5f24b9b..146129b40a7f67bc99c2279e647fad4f50d6513f
October 18, 2016 18:58https://github.com/nodejs/node/pull/8312#event-827991129
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 18, 2016https://github.com/nodejs/node/pull/8312#event-828005658
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 18, 2016https://github.com/nodejs/node/pull/8312#issuecomment-254608953
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 26, 2016https://github.com/nodejs/node/pull/8312#issuecomment-256353397
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 15, 2016https://github.com/nodejs/node/pull/8312#issuecomment-260762484
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Nov 16, 2016https://github.com/nodejs/node/pull/8312#issuecomment-260821221
Please reload this pagehttps://github.com/nodejs/node/pull/8312
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Nov 16, 2016https://github.com/nodejs/node/pull/8312#issuecomment-260967623
Please reload this pagehttps://github.com/nodejs/node/pull/8312
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Nov 16, 2016 https://github.com/nodejs/node/pull/8312#pullrequestreview-8834020
View reviewed changes https://github.com/nodejs/node/pull/8312/files
lib/child_process.jshttps://github.com/nodejs/node/pull/8312/files#diff-56c0eb11e943939908cf3d1d251bf1aadda236b5adbf8111d79b0809ec403f97
sam-githubhttps://github.com/sam-github
Nov 16, 2016https://github.com/nodejs/node/pull/8312#discussion_r88255826
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
cjihrighttps://github.com/cjihrig
Nov 16, 2016https://github.com/nodejs/node/pull/8312#discussion_r88258376
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
sam-githubhttps://github.com/sam-github
Nov 16, 2016https://github.com/nodejs/node/pull/8312#discussion_r88281391
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 16, 2016https://github.com/nodejs/node/pull/8312#issuecomment-260977182
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Nov 16, 2016https://github.com/nodejs/node/pull/8312#issuecomment-261010656
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Nov 16, 2016 https://github.com/nodejs/node/pull/8312#pullrequestreview-8863225
View reviewed changes https://github.com/nodejs/node/pull/8312/files
test/parallel/test-child-process-spawnsync-validation-errors.jshttps://github.com/nodejs/node/pull/8312/files#diff-e2d8efafd2b86015223f32aa2b6f3ace18237a1022427aeb70c9a1e077579509
sam-githubhttps://github.com/sam-github
Nov 16, 2016https://github.com/nodejs/node/pull/8312#discussion_r88284969
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Nov 16, 2016 https://github.com/nodejs/node/pull/8312#pullrequestreview-8863424
View reviewed changes https://github.com/nodejs/node/pull/8312/files
test/parallel/test-child-process-spawnsync-validation-errors.jshttps://github.com/nodejs/node/pull/8312/files#diff-e2d8efafd2b86015223f32aa2b6f3ace18237a1022427aeb70c9a1e077579509
sam-githubhttps://github.com/sam-github
Nov 16, 2016https://github.com/nodejs/node/pull/8312#discussion_r88285185
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
bnoordhuishttps://github.com/bnoordhuis
Dec 22, 2016https://github.com/nodejs/node/pull/8312#discussion_r93589320
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 22, 2016 https://github.com/nodejs/node/pull/8312#pullrequestreview-14119347
View reviewed changes https://github.com/nodejs/node/pull/8312/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/8312#pullrequestreview-14119347
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
test/parallel/test-child-process-spawnsync-validation-errors.jshttps://github.com/nodejs/node/pull/8312/files#diff-e2d8efafd2b86015223f32aa2b6f3ace18237a1022427aeb70c9a1e077579509
bnoordhuishttps://github.com/bnoordhuis
Dec 22, 2016https://github.com/nodejs/node/pull/8312#discussion_r93589320
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Dec 22, 2016 https://github.com/nodejs/node/pull/8312#pullrequestreview-14143023
View reviewed changes https://github.com/nodejs/node/pull/8312/files
lib/child_process.jshttps://github.com/nodejs/node/pull/8312/files#diff-56c0eb11e943939908cf3d1d251bf1aadda236b5adbf8111d79b0809ec403f97
thefourtheyehttps://github.com/thefourtheye
Dec 22, 2016https://github.com/nodejs/node/pull/8312#discussion_r93612029
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
cjihrighttps://github.com/cjihrig
Dec 22, 2016https://github.com/nodejs/node/pull/8312#discussion_r93670187
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/fd3750cfe267cc5536276f7a56ec4670a340ce42..01834d82f53e85c93e24c28c5530992779bc4be6
fd3750chttps://github.com/nodejs/node/commit/fd3750cfe267cc5536276f7a56ec4670a340ce42
01834d8https://github.com/nodejs/node/commit/01834d82f53e85c93e24c28c5530992779bc4be6
Compare https://github.com/nodejs/node/compare/fd3750cfe267cc5536276f7a56ec4670a340ce42..01834d82f53e85c93e24c28c5530992779bc4be6
December 22, 2016 18:05https://github.com/nodejs/node/pull/8312#event-903309115
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 22, 2016https://github.com/nodejs/node/pull/8312#event-903309336
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 22, 2016https://github.com/nodejs/node/pull/8312#issuecomment-268856558
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://ci.nodejs.org/job/node-test-pull-request/5539/https://ci.nodejs.org/job/node-test-pull-request/5539/
https://ci.nodejs.org/job/node-test-pull-request/5545/https://ci.nodejs.org/job/node-test-pull-request/5545/
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/01834d82f53e85c93e24c28c5530992779bc4be6..a2f31d3d9887be63991bdab73c6f5f47e80e86c4
01834d8https://github.com/nodejs/node/commit/01834d82f53e85c93e24c28c5530992779bc4be6
a2f31d3https://github.com/nodejs/node/commit/a2f31d3d9887be63991bdab73c6f5f47e80e86c4
Compare https://github.com/nodejs/node/compare/01834d82f53e85c93e24c28c5530992779bc4be6..a2f31d3d9887be63991bdab73c6f5f47e80e86c4
December 22, 2016 23:33https://github.com/nodejs/node/pull/8312#event-903628610
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 22, 2016https://github.com/nodejs/node/pull/8312#event-903628701
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 23, 2016https://github.com/nodejs/node/pull/8312#issuecomment-268918407
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 23, 2016 https://github.com/nodejs/node/pull/8312#ref-pullrequest-197344629
child_process: improve killSignal validations #10423 https://github.com/nodejs/node/pull/10423
cjihrighttps://github.com/cjihrig
December 25, 2016 12:46https://github.com/nodejs/node/pull/8312#commits-pushed-b374ee8
https://github.com/cjihrig
src: add handle check to spawn_synchttps://github.com/nodejs/node/pull/8312/commits/b374ee8c3dfcefe7b22060c1a2073ee07e4e1b8c
b374ee8https://github.com/nodejs/node/pull/8312/commits/b374ee8c3dfcefe7b22060c1a2073ee07e4e1b8c
nodejs#8096https://github.com/nodejs/node/issues/8096
nodejs#8539https://github.com/nodejs/node/issues/8539
nodejs#9722https://github.com/nodejs/node/issues/9722
nodejs#8312https://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
child_process: improve input validationhttps://github.com/nodejs/node/pull/8312/commits/fc7b0dda85c006e5830a0e34645d769e20b894d2
fc7b0ddhttps://github.com/nodejs/node/pull/8312/commits/fc7b0dda85c006e5830a0e34645d769e20b894d2
nodejs#8096https://github.com/nodejs/node/issues/8096
nodejs#8539https://github.com/nodejs/node/issues/8539
nodejs#9722https://github.com/nodejs/node/issues/9722
nodejs#8312https://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
src: remove redundant spawn/spawnSync type checkshttps://github.com/nodejs/node/pull/8312/commits/45c9ca7fd430022a9c0567e1b9f535b3e3f956fd
45c9ca7https://github.com/nodejs/node/pull/8312/commits/45c9ca7fd430022a9c0567e1b9f535b3e3f956fd
nodejs#8096https://github.com/nodejs/node/issues/8096
nodejs#8539https://github.com/nodejs/node/issues/8539
nodejs#9722https://github.com/nodejs/node/issues/9722
nodejs#8312https://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/a2f31d3d9887be63991bdab73c6f5f47e80e86c4..45c9ca7fd430022a9c0567e1b9f535b3e3f956fd
a2f31d3https://github.com/nodejs/node/commit/a2f31d3d9887be63991bdab73c6f5f47e80e86c4
45c9ca7https://github.com/nodejs/node/commit/45c9ca7fd430022a9c0567e1b9f535b3e3f956fd
Compare https://github.com/nodejs/node/compare/a2f31d3d9887be63991bdab73c6f5f47e80e86c4..45c9ca7fd430022a9c0567e1b9f535b3e3f956fd
December 25, 2016 17:52https://github.com/nodejs/node/pull/8312#event-904740110
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 25, 2016https://github.com/nodejs/node/pull/8312#event-904740127
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
45c9ca7https://github.com/nodejs/node/commit/45c9ca7fd430022a9c0567e1b9f535b3e3f956fd
Dec 25, 2016https://github.com/nodejs/node/pull/8312#event-904740325
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 25, 2016https://github.com/nodejs/node/pull/8312#issuecomment-269131696
b374ee8https://github.com/nodejs/node/commit/b374ee8c3dfcefe7b22060c1a2073ee07e4e1b8c
fc7b0ddhttps://github.com/nodejs/node/commit/fc7b0dda85c006e5830a0e34645d769e20b894d2
45c9ca7https://github.com/nodejs/node/commit/45c9ca7fd430022a9c0567e1b9f535b3e3f956fd
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
December 25, 2016 17:54https://github.com/nodejs/node/pull/8312#event-904740441
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Jan 16, 2017https://github.com/nodejs/node/pull/8312#event-924610654
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 16, 2017https://github.com/nodejs/node/pull/8312#issuecomment-272914264
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jan 16, 2017https://github.com/nodejs/node/pull/8312#issuecomment-272916062
@MylesBorinshttps://github.com/MylesBorins
nodejs/github-bot#105https://github.com/nodejs/github-bot/issues/105
Please reload this pagehttps://github.com/nodejs/node/pull/8312
italoacasashttps://github.com/italoacasas
Jan 18, 2017 https://github.com/nodejs/node/pull/8312#ref-commit-7a3781b
https://github.com/cjihrig
src: add handle check to spawn_synchttps://github.com/italoacasas/node/commit/7a3781bba799a33e1825fc22bdcb70cf08557d2e
7a3781bhttps://github.com/italoacasas/node/commit/7a3781bba799a33e1825fc22bdcb70cf08557d2e
nodejs#8096https://github.com/nodejs/node/issues/8096
nodejs#8539https://github.com/nodejs/node/issues/8539
nodejs#9722https://github.com/nodejs/node/issues/9722
nodejs#8312https://github.com/nodejs/node/pull/8312
italoacasashttps://github.com/italoacasas
Jan 18, 2017 https://github.com/nodejs/node/pull/8312#ref-commit-edcb385
https://github.com/cjihrig
child_process: improve input validationhttps://github.com/italoacasas/node/commit/edcb385b416e09de268bf697650d95eaf544486d
edcb385https://github.com/italoacasas/node/commit/edcb385b416e09de268bf697650d95eaf544486d
nodejs#8096https://github.com/nodejs/node/issues/8096
nodejs#8539https://github.com/nodejs/node/issues/8539
nodejs#9722https://github.com/nodejs/node/issues/9722
nodejs#8312https://github.com/nodejs/node/pull/8312
italoacasashttps://github.com/italoacasas
Jan 18, 2017 https://github.com/nodejs/node/pull/8312#ref-commit-f3e921a
https://github.com/cjihrig
src: remove redundant spawn/spawnSync type checkshttps://github.com/italoacasas/node/commit/f3e921aee4ce304f43056a3a5aade328ca70fd11
f3e921ahttps://github.com/italoacasas/node/commit/f3e921aee4ce304f43056a3a5aade328ca70fd11
nodejs#8096https://github.com/nodejs/node/issues/8096
nodejs#8539https://github.com/nodejs/node/issues/8539
nodejs#9722https://github.com/nodejs/node/issues/9722
nodejs#8312https://github.com/nodejs/node/pull/8312
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Mar 8, 2017 https://github.com/nodejs/node/pull/8312#ref-pullrequest-212732553
(v7.x backport) child_process: fix deoptimizing use of arguments #11748 https://github.com/nodejs/node/pull/11748
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 4, 2017 https://github.com/nodejs/node/pull/8312#ref-pullrequest-219383958
8.0.0 Release Proposal #12220 https://github.com/nodejs/node/pull/12220
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8312
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/8312/files/16bb99d5e5340347999c8b62f3dee3f7cc0d62bb
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/8312/files/16bb99d5e5340347999c8b62f3dee3f7cc0d62bb
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/8312/files/fd3750cfe267cc5536276f7a56ec4670a340ce42
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/8312/files/16bb99d5e5340347999c8b62f3dee3f7cc0d62bb
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/8312/files/a2f31d3d9887be63991bdab73c6f5f47e80e86c4
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
child_process.spawnSync is memory unsafe and can be used to dump core https://github.com/nodejs/node/issues/8539
uv_close: Assertion `0' failed on child_process.execSync w/ Infinite maxBuffer https://github.com/nodejs/node/issues/8096
Please reload this pagehttps://github.com/nodejs/node/pull/8312
https://github.com/cjihrig
https://github.com/bnoordhuis
https://github.com/sam-github
https://github.com/MylesBorins
https://github.com/Fishrock123
https://github.com/jasnell
https://github.com/thefourtheye
https://github.com/princejwesley
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.