René's URL Explorer Experiment


Title: crypto: fix ucs2/ucs-2/utf16le/utf-16le encoding check by atstoyanov · Pull Request #8301 · nodejs/node · GitHub

Open Graph Title: crypto: fix ucs2/ucs-2/utf16le/utf-16le encoding check by atstoyanov · Pull Request #8301 · nodejs/node

X Title: crypto: fix ucs2/ucs-2/utf16le/utf-16le encoding check by atstoyanov · Pull Request #8301 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) crypto Descrip...

X Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) crypto Descrip...

Opengraph URL: https://github.com/nodejs/node/pull/8301

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b0f2b925-ac9a-9081-1bb8-52229df4b26d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC44E:215443:25F2513:33036BF:6A53991D
html-safe-nonce000a7f383fe29f05bc91703421df60fc1ec0c066c41c74983e43e8ef8791ccc0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDRFOjIxNTQ0MzoyNUYyNTEzOjMzMDM2QkY6NkE1Mzk5MUQiLCJ2aXNpdG9yX2lkIjoiMTY3NjM4NTU3NDg5NzAzMTQ1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2dc330c9cdab240b7dea06941c0c1ccf9fa913172df4a3f30157bfc64114048f
hovercard-subject-tagpull_request:82992560
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8301/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7ccebb95ec0847ee6cba3f015fe89155b0972c1e55c96f6786e705582951e40f/nodejs/node/pull/8301
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7ccebb95ec0847ee6cba3f015fe89155b0972c1e55c96f6786e705582951e40f/nodejs/node/pull/8301
og:image:altChecklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) crypto Descrip...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatstoyanov
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8301#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8301
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8301
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8301
Reloadhttps://github.com/nodejs/node/pull/8301
Reloadhttps://github.com/nodejs/node/pull/8301
Please reload this pagehttps://github.com/nodejs/node/pull/8301
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/8301
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 997 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
atstoyanovhttps://github.com/atstoyanov
nodejs:masterhttps://github.com/nodejs/node/tree/master
atstoyanov:cryptofixhttps://github.com/atstoyanov/node/tree/cryptofix
Conversationhttps://github.com/nodejs/node/pull/8301
Commits1 (1)https://github.com/nodejs/node/pull/8301/commits
Checkshttps://github.com/nodejs/node/pull/8301/checks
Files changedhttps://github.com/nodejs/node/pull/8301/files
crypto: fix ucs2/ucs-2/utf16le/utf-16le encoding checkhttps://github.com/nodejs/node/pull/8301#top
atstoyanovhttps://github.com/atstoyanov
nodejs:masterhttps://github.com/nodejs/node/tree/master
atstoyanov:cryptofixhttps://github.com/atstoyanov/node/tree/cryptofix
https://github.com/atstoyanov
atstoyanovhttps://github.com/atstoyanov
Aug 27, 2016https://github.com/nodejs/node/pull/8301#issue-173604477
Please reload this pagehttps://github.com/nodejs/node/pull/8301
#8236https://github.com/nodejs/node/issues/8236
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Aug 27, 2016https://github.com/nodejs/node/pull/8301#event-769780560
addaleaxhttps://github.com/addaleax
Aug 27, 2016 https://github.com/nodejs/node/pull/8301#discussion-diff-76519144
View reviewed changes https://github.com/nodejs/node/pull/8301/files#diff-553dfdec542c8a82c02a3b192cc8b53de78c2e528be8640d52543d7715260afa
test/parallel/test-crypto-cipher-decipher.jshttps://github.com/nodejs/node/pull/8301/files#diff-553dfdec542c8a82c02a3b192cc8b53de78c2e528be8640d52543d7715260afa
addaleaxhttps://github.com/addaleax
Aug 27, 2016https://github.com/nodejs/node/pull/8301#discussion_r76519144
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node-v0.x-archivehttps://github.com/nodejs/node-v0.x-archive
Please reload this pagehttps://github.com/nodejs/node/pull/8301
mscdexhttps://github.com/mscdex
Aug 27, 2016https://github.com/nodejs/node/pull/8301#discussion_r76520756
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8301
cjihrighttps://github.com/cjihrig
Aug 28, 2016https://github.com/nodejs/node/pull/8301#discussion_r76524750
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 27, 2016https://github.com/nodejs/node/pull/8301#issuecomment-242928217
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/atstoyanov
atstoyanovhttps://github.com/atstoyanov
force-pushedhttps://github.com/nodejs/node/compare/5cab2e84fbfb547d5bc32b463eb400389d91fa20..b2f6b787510f90c7bce7549bb897c71f14c203af
5cab2e8https://github.com/nodejs/node/commit/5cab2e84fbfb547d5bc32b463eb400389d91fa20
b2f6b78https://github.com/nodejs/node/commit/b2f6b787510f90c7bce7549bb897c71f14c203af
Compare https://github.com/nodejs/node/compare/5cab2e84fbfb547d5bc32b463eb400389d91fa20..b2f6b787510f90c7bce7549bb897c71f14c203af
August 27, 2016 17:29https://github.com/nodejs/node/pull/8301#event-769789049
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 27, 2016https://github.com/nodejs/node/pull/8301#issuecomment-242931189
https://ci.nodejs.org/job/node-test-commit/4798/https://ci.nodejs.org/job/node-test-commit/4798/
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Aug 27, 2016https://github.com/nodejs/node/pull/8301#issuecomment-242934403
Please reload this pagehttps://github.com/nodejs/node/pull/8301
cjihrighttps://github.com/cjihrig
Aug 28, 2016 https://github.com/nodejs/node/pull/8301#discussion-diff-76524754
View reviewed changes https://github.com/nodejs/node/pull/8301/files#diff-553dfdec542c8a82c02a3b192cc8b53de78c2e528be8640d52543d7715260afa
test/parallel/test-crypto-cipher-decipher.jshttps://github.com/nodejs/node/pull/8301/files#diff-553dfdec542c8a82c02a3b192cc8b53de78c2e528be8640d52543d7715260afa
cjihrighttps://github.com/cjihrig
Aug 28, 2016https://github.com/nodejs/node/pull/8301#discussion_r76524754
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 29, 2016https://github.com/nodejs/node/pull/8301#issuecomment-243182007
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/atstoyanov
atstoyanovhttps://github.com/atstoyanov
Aug 29, 2016https://github.com/nodejs/node/pull/8301#issuecomment-243190804
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 29, 2016https://github.com/nodejs/node/pull/8301#issuecomment-243191664
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/atstoyanov
atstoyanovhttps://github.com/atstoyanov
force-pushedhttps://github.com/nodejs/node/compare/b2f6b787510f90c7bce7549bb897c71f14c203af..039003a016504daed1ce46fce9b6ed48c5cbe166
b2f6b78https://github.com/nodejs/node/commit/b2f6b787510f90c7bce7549bb897c71f14c203af
039003ahttps://github.com/nodejs/node/commit/039003a016504daed1ce46fce9b6ed48c5cbe166
Compare https://github.com/nodejs/node/compare/b2f6b787510f90c7bce7549bb897c71f14c203af..039003a016504daed1ce46fce9b6ed48c5cbe166
August 30, 2016 07:43https://github.com/nodejs/node/pull/8301#event-771752739
jasnellhttps://github.com/jasnell
Aug 30, 2016 https://github.com/nodejs/node/pull/8301#discussion-diff-76876348
View reviewed changes https://github.com/nodejs/node/pull/8301/files#diff-553dfdec542c8a82c02a3b192cc8b53de78c2e528be8640d52543d7715260afa
test/parallel/test-crypto-cipher-decipher.jshttps://github.com/nodejs/node/pull/8301/files#diff-553dfdec542c8a82c02a3b192cc8b53de78c2e528be8640d52543d7715260afa
jasnellhttps://github.com/jasnell
Aug 30, 2016https://github.com/nodejs/node/pull/8301#discussion_r76876348
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/atstoyanov
crypto: fix getDecoder() encoding checkhttps://github.com/nodejs/node/pull/8301/commits/1ecd0921329436d50912b331dc588c811ef28043
1ecd092https://github.com/nodejs/node/pull/8301/commits/1ecd0921329436d50912b331dc588c811ef28043
nodejs#8236https://github.com/nodejs/node/issues/8236
https://github.com/atstoyanov
atstoyanovhttps://github.com/atstoyanov
force-pushedhttps://github.com/nodejs/node/compare/039003a016504daed1ce46fce9b6ed48c5cbe166..1ecd0921329436d50912b331dc588c811ef28043
039003ahttps://github.com/nodejs/node/commit/039003a016504daed1ce46fce9b6ed48c5cbe166
1ecd092https://github.com/nodejs/node/commit/1ecd0921329436d50912b331dc588c811ef28043
Compare https://github.com/nodejs/node/compare/039003a016504daed1ce46fce9b6ed48c5cbe166..1ecd0921329436d50912b331dc588c811ef28043
September 1, 2016 13:00https://github.com/nodejs/node/pull/8301#event-775108982
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2016https://github.com/nodejs/node/pull/8301#issuecomment-244497144
https://ci.nodejs.org/job/node-test-commit/4891/https://ci.nodejs.org/job/node-test-commit/4891/
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 4, 2016https://github.com/nodejs/node/pull/8301#issuecomment-244614157
a6f7b13https://github.com/nodejs/node/commit/a6f7b13d02c20ffad48840832fcff2e23a72a7fb
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 4, 2016https://github.com/nodejs/node/pull/8301#event-777686122
addaleaxhttps://github.com/addaleax
Sep 4, 2016 https://github.com/nodejs/node/pull/8301#ref-commit-a6f7b13
https://github.com/atstoyanov
https://github.com/addaleax
crypto: fix getDecoder() encoding checkhttps://github.com/nodejs/node/commit/a6f7b13d02c20ffad48840832fcff2e23a72a7fb
a6f7b13https://github.com/nodejs/node/commit/a6f7b13d02c20ffad48840832fcff2e23a72a7fb
#8236https://github.com/nodejs/node/issues/8236
#8301https://github.com/nodejs/node/pull/8301
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 6, 2016 https://github.com/nodejs/node/pull/8301#ref-issue-175360000
v6.6.0 pre-proposal #8428 https://github.com/nodejs/node/issues/8428
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 8, 2016https://github.com/nodejs/node/pull/8301#issuecomment-245771961
#7207https://github.com/nodejs/node/pull/7207
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Sep 8, 2016https://github.com/nodejs/node/pull/8301#event-783232986
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 8, 2016https://github.com/nodejs/node/pull/8301#issuecomment-245772360
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 9, 2016https://github.com/nodejs/node/pull/8301#issuecomment-246003942
#8463https://github.com/nodejs/node/pull/8463
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Sep 9, 2016https://github.com/nodejs/node/pull/8301#event-784361989
Fishrock123https://github.com/Fishrock123
Sep 14, 2016 https://github.com/nodejs/node/pull/8301#ref-commit-1640e7a
https://github.com/atstoyanov
https://github.com/Fishrock123
crypto: fix getDecoder() encoding checkhttps://github.com/nodejs/node/commit/1640e7a4da9ecb202d7439a622daaf698987ae05
1640e7ahttps://github.com/nodejs/node/commit/1640e7a4da9ecb202d7439a622daaf698987ae05
#8236https://github.com/nodejs/node/issues/8236
#8301https://github.com/nodejs/node/pull/8301
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Sep 30, 2016https://github.com/nodejs/node/pull/8301#issuecomment-250863910
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Sep 30, 2016https://github.com/nodejs/node/pull/8301#event-809093107
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8301
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
crypto: getDecoder throws "AssertionError: Cannot change encoding" when encoding is "ucs2", "ucs-2" or "utf-16le". https://github.com/nodejs/node/issues/8236
Please reload this pagehttps://github.com/nodejs/node/pull/8301
https://github.com/atstoyanov
https://github.com/addaleax
https://github.com/mscdex
https://github.com/jasnell
https://github.com/Fishrock123
https://github.com/MylesBorins
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.