| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5ab3df80-4df1-ec11-dd22-96d5131d34ec |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 923A:1B02A6:987FD:CD841:6A525304 |
| html-safe-nonce | 26edbe078a061d689eb0a2d2d87fcfc93b6d40d6a71a00c143a23c359058985c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjNBOjFCMDJBNjo5ODdGRDpDRDg0MTo2QTUyNTMwNCIsInZpc2l0b3JfaWQiOiI1NzUxNTk1NTQ3NzMyNjI4MjI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7bab379d8975fa51992db0654af0d8dcf6c25f4905d20ec77b28e316651dde89 |
| hovercard-subject-tag | pull_request:82955379 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8285/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/36d50ecba081dde702b988536444ae473be13e9de0878dcad3920f6addd04c22/nodejs/node/pull/8285 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/36d50ecba081dde702b988536444ae473be13e9de0878dcad3920f6addd04c22/nodejs/node/pull/8285 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
addons test
Description of change
addon tests were st... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mhdawson |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8285#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8285 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8285 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8285 |
| Reload | https://github.com/nodejs/node/pull/8285 |
| Reload | https://github.com/nodejs/node/pull/8285 |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
984
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mhdawson:aixaddon2 | https://github.com/mhdawson/io.js/tree/aixaddon2 |
| Conversation | https://github.com/nodejs/node/pull/8285 |
| Commits3 (3) | https://github.com/nodejs/node/pull/8285/commits |
| Checks | https://github.com/nodejs/node/pull/8285/checks |
| Files changed | https://github.com/nodejs/node/pull/8285/files |
| build: fix dependencies on AIX | https://github.com/nodejs/node/pull/8285#top |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mhdawson:aixaddon2 | https://github.com/mhdawson/io.js/tree/aixaddon2 |
|
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 26, 2016 | https://github.com/nodejs/node/pull/8285#issue-173545249 |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| #8285 | https://github.com/nodejs/node/pull/8285 |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
|
| https://github.com/mhdawson |
| build: fix dependencies on AIX | https://github.com/nodejs/node/pull/8285/commits/57aec9bd5ce79fe937fe7e1cfdd436344a90a41a |
| 57aec9b | https://github.com/nodejs/node/pull/8285/commits/57aec9bd5ce79fe937fe7e1cfdd436344a90a41a |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Aug 26, 2016 | https://github.com/nodejs/node/pull/8285#event-769461314 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 26, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-242853918 |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Aug 26, 2016
| https://github.com/nodejs/node/pull/8285#ref-issue-172765767 |
|
test: intermittent failure running add-on tests on AIX
#8239
| https://github.com/nodejs/node/issues/8239 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 26, 2016 | https://github.com/nodejs/node/pull/8285#event-769471085 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 26, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-242855571 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 26, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-242857729 |
| https://ci.nodejs.org/job/node-test-pull-request/3848/ | https://ci.nodejs.org/job/node-test-pull-request/3848/ |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 26, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-242865290 |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Aug 27, 2016
| https://github.com/nodejs/node/pull/8285#discussion-diff-76513784 |
| View reviewed changes
| https://github.com/nodejs/node/pull/8285/files/57aec9bd5ce79fe937fe7e1cfdd436344a90a41a#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 |
| Makefile | https://github.com/nodejs/node/pull/8285/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 |
| bnoordhuis | https://github.com/bnoordhuis |
| Aug 27, 2016 | https://github.com/nodejs/node/pull/8285#discussion_r76513784 |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
|
| https://github.com/mhdawson |
| fix first set of comments | https://github.com/nodejs/node/pull/8285/commits/1e6b0142ab8986db482e100109f58601f84f3d3f |
| 1e6b014 | https://github.com/nodejs/node/pull/8285/commits/1e6b0142ab8986db482e100109f58601f84f3d3f |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 29, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-243127061 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 29, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-243139232 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
|
| https://github.com/mhdawson |
| fixup, avoid recursive expansion | https://github.com/nodejs/node/pull/8285/commits/7d118ff7a42f7849c52e13e0e0d553cb30002bb7 |
| 7d118ff | https://github.com/nodejs/node/pull/8285/commits/7d118ff7a42f7849c52e13e0e0d553cb30002bb7 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 29, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-243150622 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Aug 29, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-243172711 |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 29, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-243174264 |
| https://ci.nodejs.org/job/node-test-pull-request/3871/ | https://ci.nodejs.org/job/node-test-pull-request/3871/ |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 29, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-243239482 |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Aug 29, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-243242630 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 29, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-243244340 |
| 1657f12 | https://github.com/nodejs/node/commit/1657f12f75879fdc0cb0555d7b8af39a3b3bbec7 |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| mhdawson | https://github.com/mhdawson |
|
Aug 29, 2016
| https://github.com/nodejs/node/pull/8285#ref-commit-1657f12 |
|
| https://github.com/mhdawson |
| build: fix dependencies on AIX | https://github.com/nodejs/node/commit/1657f12f75879fdc0cb0555d7b8af39a3b3bbec7 |
| 1657f12 | https://github.com/nodejs/node/commit/1657f12f75879fdc0cb0555d7b8af39a3b3bbec7 |
| #8285 | https://github.com/nodejs/node/pull/8285 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 29, 2016 | https://github.com/nodejs/node/pull/8285#event-771281798 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Sep 6, 2016
| https://github.com/nodejs/node/pull/8285#ref-issue-175360000 |
|
v6.6.0 pre-proposal
#8428
| https://github.com/nodejs/node/issues/8428 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Sep 8, 2016
| https://github.com/nodejs/node/pull/8285#ref-commit-faa7700 |
|
| https://github.com/mhdawson |
|
| https://github.com/Fishrock123 |
| build: fix dependencies on AIX | https://github.com/Fishrock123/node/commit/faa77009e9ff38d075d9ed34cc13815d10d82320 |
| faa7700 | https://github.com/Fishrock123/node/commit/faa77009e9ff38d075d9ed34cc13815d10d82320 |
| nodejs#8285 | https://github.com/nodejs/node/pull/8285 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Sep 9, 2016
| https://github.com/nodejs/node/pull/8285#ref-commit-836bfc1 |
|
| https://github.com/mhdawson |
|
| https://github.com/Fishrock123 |
| build: fix dependencies on AIX | https://github.com/nodejs/node/commit/836bfc188be529f65f26f685cb6589542c9942ef |
| 836bfc1 | https://github.com/nodejs/node/commit/836bfc188be529f65f26f685cb6589542c9942ef |
| #8285 | https://github.com/nodejs/node/pull/8285 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/8285#event-809078056 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/8285#issuecomment-250861142 |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 30, 2016
| https://github.com/nodejs/node/pull/8285#ref-commit-ecbd079 |
|
| https://github.com/mhdawson |
| build: fix dependencies on AIX | https://github.com/nodejs/node/commit/ecbd07951d29f11c40599160c07adcca559098cc |
| ecbd079 | https://github.com/nodejs/node/commit/ecbd07951d29f11c40599160c07adcca559098cc |
| #8285 | https://github.com/nodejs/node/pull/8285 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/8285#ref-commit-3a50f84 |
|
| https://github.com/mhdawson |
| build: fix dependencies on AIX | https://github.com/nodejs/node/commit/3a50f84398ddf86bdfe72eed3128fe68f8d238e8 |
| 3a50f84 | https://github.com/nodejs/node/commit/3a50f84398ddf86bdfe72eed3128fe68f8d238e8 |
| #8285 | https://github.com/nodejs/node/pull/8285 |
| rvagg | https://github.com/rvagg |
|
Oct 18, 2016
| https://github.com/nodejs/node/pull/8285#ref-commit-8b364f2 |
|
| https://github.com/mhdawson |
|
| https://github.com/rvagg |
| build: fix dependencies on AIX | https://github.com/nodejs/node/commit/8b364f236b8a29d23434d8952b0d890e3e60dc2f |
| 8b364f2 | https://github.com/nodejs/node/commit/8b364f236b8a29d23434d8952b0d890e3e60dc2f |
| #8285 | https://github.com/nodejs/node/pull/8285 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/8285#ref-commit-00ea738 |
|
| https://github.com/mhdawson |
|
| https://github.com/MylesBorins |
| build: fix dependencies on AIX | https://github.com/nodejs/node/commit/00ea7388cb6771006a88e59ff95a6840ac38a77e |
| 00ea738 | https://github.com/nodejs/node/commit/00ea7388cb6771006a88e59ff95a6840ac38a77e |
| #8285 | https://github.com/nodejs/node/pull/8285 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/8285#ref-pullrequest-185475513 |
|
V4.6.2 proposal
#9298
| https://github.com/nodejs/node/pull/9298 |
| https://github.com/sxa |
| sxa | https://github.com/sxa |
|
Nov 28, 2016
| https://github.com/nodejs/node/pull/8285#ref-issue-192026384 |
|
AIX: v4x-staging - object factory test failures
#9825
| https://github.com/nodejs/node/issues/9825 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| March 15, 2017 21:57 | https://github.com/nodejs/node/pull/8285#event-1001765223 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8285 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Please reload this page | https://github.com/nodejs/node/pull/8285 |
|
| https://github.com/mhdawson |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |