René's URL Explorer Experiment


Title: test: refactor buffer tests by jasnell · Pull Request #8256 · nodejs/node · GitHub

Open Graph Title: test: refactor buffer tests by jasnell · Pull Request #8256 · nodejs/node

X Title: test: refactor buffer tests by jasnell · Pull Request #8256 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included Affected core subsystem(s) buffer,test Description of change Refactor the Buffer tes...

X Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included Affected core subsystem(s) buffer,test Description of change Refactor the Buffer tes...

Opengraph URL: https://github.com/nodejs/node/pull/8256

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:96b48b6f-c305-4661-c7d0-6e37945a9c71
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2BC:1C38BA:1FB97D3:2A3462B:6A51EB2C
html-safe-nonce2ac78aa48a70521565db7507844434d5cb28d428f9fb587cfccca8b12176c292
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkJDOjFDMzhCQToxRkI5N0QzOjJBMzQ2MkI6NkE1MUVCMkMiLCJ2aXNpdG9yX2lkIjoiMTUyMDE5NTM2MTE0NjI2ODQ2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac86f296a2bffdbe1ddaff9d84cb888d21310f4b43546a806d13416e1ba8c34d92
hovercard-subject-tagpull_request:82584029
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8256/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/72b16512aae5baebcb0e57e01cb31794252684c61646494cb1c9fde7225ad601/nodejs/node/pull/8256
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/72b16512aae5baebcb0e57e01cb31794252684c61646494cb1c9fde7225ad601/nodejs/node/pull/8256
og:image:altChecklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included Affected core subsystem(s) buffer,test Description of change Refactor the Buffer tes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8256#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8256
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8256
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8256
Reloadhttps://github.com/nodejs/node/pull/8256
Reloadhttps://github.com/nodejs/node/pull/8256
Please reload this pagehttps://github.com/nodejs/node/pull/8256
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/8256
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 983 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:refactor-test-bufferhttps://github.com/jasnell/node/tree/refactor-test-buffer
Conversationhttps://github.com/nodejs/node/pull/8256
Commits12 (12)https://github.com/nodejs/node/pull/8256/commits
Checkshttps://github.com/nodejs/node/pull/8256/checks
Files changedhttps://github.com/nodejs/node/pull/8256/files
test: refactor buffer testshttps://github.com/nodejs/node/pull/8256#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:refactor-test-bufferhttps://github.com/jasnell/node/tree/refactor-test-buffer
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 24, 2016https://github.com/nodejs/node/pull/8256#issue-173011817
Please reload this pagehttps://github.com/nodejs/node/pull/8256
https://github.com/jasnell
test: separate negative buffer length testshttps://github.com/nodejs/node/pull/8256/commits/afe56a2216dff8e7cdbaa8e7b2c88935414f741b
afe56a2https://github.com/nodejs/node/pull/8256/commits/afe56a2216dff8e7cdbaa8e7b2c88935414f741b
https://github.com/jasnell
jasnellhttps://github.com/jasnell
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Aug 24, 2016https://github.com/nodejs/node/pull/8256#event-766326959
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 24, 2016https://github.com/nodejs/node/pull/8256#issuecomment-242145198
https://ci.nodejs.org/job/node-test-pull-request/3821/https://ci.nodejs.org/job/node-test-pull-request/3821/
Please reload this pagehttps://github.com/nodejs/node/pull/8256
targoshttps://github.com/targos
Aug 24, 2016 https://github.com/nodejs/node/pull/8256#discussion-diff-76102274
View reviewed changes https://github.com/nodejs/node/pull/8256/files#diff-06f3b55f7c5fc7998ad51873914d3776aa94796c064fa2563ad67c914b191f06
test/parallel/test-buffer-failed-alloc-typed-arrays.jshttps://github.com/nodejs/node/pull/8256/files#diff-06f3b55f7c5fc7998ad51873914d3776aa94796c064fa2563ad67c914b191f06
targoshttps://github.com/targos
Aug 24, 2016https://github.com/nodejs/node/pull/8256#discussion_r76102274
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8256
jasnellhttps://github.com/jasnell
Aug 24, 2016https://github.com/nodejs/node/pull/8256#discussion_r76106316
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8256
jasnellhttps://github.com/jasnell
August 24, 2016 10:53https://github.com/nodejs/node/pull/8256#commits-pushed-7e9e884
https://github.com/jasnell
test: separate failed buffer allocation uint32array checkhttps://github.com/nodejs/node/pull/8256/commits/7e9e884a03d9c5f738a76e3c4dd374ba7b248906
7e9e884https://github.com/nodejs/node/pull/8256/commits/7e9e884a03d9c5f738a76e3c4dd374ba7b248906
https://github.com/jasnell
test: separate out buffer regression 649 testhttps://github.com/nodejs/node/pull/8256/commits/f58f6ecd1f28d54889184f4d9aa3bdd7872f91f7
f58f6echttps://github.com/nodejs/node/pull/8256/commits/f58f6ecd1f28d54889184f4d9aa3bdd7872f91f7
https://github.com/jasnell
test: separate buffer compare testshttps://github.com/nodejs/node/pull/8256/commits/435b7c72a2cae644bdc3541cc0bba2b7a4c13f59
435b7c7https://github.com/nodejs/node/pull/8256/commits/435b7c72a2cae644bdc3541cc0bba2b7a4c13f59
https://github.com/jasnell
test: separate buffer equal testshttps://github.com/nodejs/node/pull/8256/commits/c82a8be2c81ee7fd71b55dc58354af3189fddaae
c82a8behttps://github.com/nodejs/node/pull/8256/commits/c82a8be2c81ee7fd71b55dc58354af3189fddaae
https://github.com/jasnell
test: separate buffer toString range testshttps://github.com/nodejs/node/pull/8256/commits/1930c73df9c3f430ccaec4d700a51c71ff22dbd0
1930c73https://github.com/nodejs/node/pull/8256/commits/1930c73df9c3f430ccaec4d700a51c71ff22dbd0
https://github.com/jasnell
test: separate buffer fill testshttps://github.com/nodejs/node/pull/8256/commits/89d8e87ca8b01be07186aef177d63d3026420b0a
89d8e87https://github.com/nodejs/node/pull/8256/commits/89d8e87ca8b01be07186aef177d63d3026420b0a
https://github.com/jasnell
test: separate out buffer copy testshttps://github.com/nodejs/node/pull/8256/commits/253e77c660c20674f57db30fb901ba09b46809fb
253e77chttps://github.com/nodejs/node/pull/8256/commits/253e77c660c20674f57db30fb901ba09b46809fb
https://github.com/jasnell
test: favor use of strictEqual where possible in buffer testhttps://github.com/nodejs/node/pull/8256/commits/a5d4501340f21aaaeb77dd6b91b02d801335d7ac
a5d4501https://github.com/nodejs/node/pull/8256/commits/a5d4501340f21aaaeb77dd6b91b02d801335d7ac
https://github.com/jasnell
test: separate out buffer slice testshttps://github.com/nodejs/node/pull/8256/commits/0f76db67071fc7916b5c61644b010af7b7fc92c8
0f76db6https://github.com/nodejs/node/pull/8256/commits/0f76db67071fc7916b5c61644b010af7b7fc92c8
https://github.com/jasnell
test: separate out buffer isencoding testhttps://github.com/nodejs/node/pull/8256/commits/add7ecc55aa61b432f460a5a99869a2292a0f61f
add7ecchttps://github.com/nodejs/node/pull/8256/commits/add7ecc55aa61b432f460a5a99869a2292a0f61f
https://github.com/jasnell
test: clean up / refactor buffer tests, remove duplicationhttps://github.com/nodejs/node/pull/8256/commits/d67bd342f09d90bb729b893f4c050e6dd0a3f014
d67bd34https://github.com/nodejs/node/pull/8256/commits/d67bd342f09d90bb729b893f4c050e6dd0a3f014
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/a9e1407f60334da4e4297e1315a0ebc678073833..d67bd342f09d90bb729b893f4c050e6dd0a3f014
a9e1407https://github.com/nodejs/node/commit/a9e1407f60334da4e4297e1315a0ebc678073833
d67bd34https://github.com/nodejs/node/commit/d67bd342f09d90bb729b893f4c050e6dd0a3f014
Compare https://github.com/nodejs/node/compare/a9e1407f60334da4e4297e1315a0ebc678073833..d67bd342f09d90bb729b893f4c050e6dd0a3f014
August 24, 2016 17:54https://github.com/nodejs/node/pull/8256#event-766362303
https://github.com/targos
targoshttps://github.com/targos
Aug 24, 2016https://github.com/nodejs/node/pull/8256#issuecomment-242157652
Please reload this pagehttps://github.com/nodejs/node/pull/8256
Trotthttps://github.com/Trott
Aug 24, 2016 https://github.com/nodejs/node/pull/8256#discussion-diff-76146451
View reviewed changes https://github.com/nodejs/node/pull/8256/files/d67bd342f09d90bb729b893f4c050e6dd0a3f014#diff-a265cfa759473351948564aded4d796e5ae4d558ad4b51831300c319dadf80f4
test/parallel/test-buffer-alloc.jshttps://github.com/nodejs/node/pull/8256/files#diff-a265cfa759473351948564aded4d796e5ae4d558ad4b51831300c319dadf80f4
Trotthttps://github.com/Trott
Aug 24, 2016https://github.com/nodejs/node/pull/8256#discussion_r76146451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8256
Trotthttps://github.com/Trott
Aug 24, 2016https://github.com/nodejs/node/pull/8256#discussion_r76146695
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8256
jasnellhttps://github.com/jasnell
Aug 26, 2016https://github.com/nodejs/node/pull/8256#discussion_r76424939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8256
jasnellhttps://github.com/jasnell
Aug 26, 2016 https://github.com/nodejs/node/pull/8256#ref-commit-7053922
https://github.com/jasnell
test: clean up / refactor buffer tests, remove duplicationhttps://github.com/nodejs/node/commit/7053922c1a76ac56ef245923ec171b01cd90d2f4
7053922https://github.com/nodejs/node/commit/7053922c1a76ac56ef245923ec171b01cd90d2f4
#8256https://github.com/nodejs/node/pull/8256
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 26, 2016https://github.com/nodejs/node/pull/8256#issuecomment-242747960
7053922https://github.com/nodejs/node/commit/7053922c1a76ac56ef245923ec171b01cd90d2f4
Please reload this pagehttps://github.com/nodejs/node/pull/8256
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 26, 2016https://github.com/nodejs/node/pull/8256#event-768970610
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 6, 2016 https://github.com/nodejs/node/pull/8256#ref-issue-175360000
v6.6.0 pre-proposal #8428 https://github.com/nodejs/node/issues/8428
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 7, 2016https://github.com/nodejs/node/pull/8256#issuecomment-245327768
Please reload this pagehttps://github.com/nodejs/node/pull/8256
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Sep 7, 2016https://github.com/nodejs/node/pull/8256#event-781129519
Fishrock123https://github.com/Fishrock123
Sep 8, 2016 https://github.com/nodejs/node/pull/8256#ref-commit-fdb81a0
https://github.com/jasnell
https://github.com/Fishrock123
test: clean up / refactor buffer tests, remove duplicationhttps://github.com/Fishrock123/node/commit/fdb81a0d195169c2996c7acd56622b385991ba78
fdb81a0https://github.com/Fishrock123/node/commit/fdb81a0d195169c2996c7acd56622b385991ba78
nodejs#8256https://github.com/nodejs/node/pull/8256
Fishrock123https://github.com/Fishrock123
Sep 9, 2016 https://github.com/nodejs/node/pull/8256#ref-commit-0b0a1ce
https://github.com/jasnell
https://github.com/Fishrock123
test: clean up / refactor buffer tests, remove duplicationhttps://github.com/nodejs/node/commit/0b0a1ceac3c6da19b10d24a8bf195cc2b9b106ec
0b0a1cehttps://github.com/nodejs/node/commit/0b0a1ceac3c6da19b10d24a8bf195cc2b9b106ec
#8256https://github.com/nodejs/node/pull/8256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Sep 30, 2016https://github.com/nodejs/node/pull/8256#event-809074940
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Sep 30, 2016https://github.com/nodejs/node/pull/8256#event-809075081
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Sep 30, 2016https://github.com/nodejs/node/pull/8256#issuecomment-250860583
Please reload this pagehttps://github.com/nodejs/node/pull/8256
https://github.com/targos
targoshttps://github.com/targos
Oct 7, 2016 https://github.com/nodejs/node/pull/8256#ref-pullrequest-177266996
Improve buffer test coverage #8552 https://github.com/nodejs/node/pull/8552
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8256
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/8256
https://github.com/jasnell
https://github.com/targos
https://github.com/Fishrock123
https://github.com/MylesBorins
https://github.com/Trott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.