René's URL Explorer Experiment


Title: net: make holding the buffer in memory more robust by addaleax · Pull Request #8252 · nodejs/node · GitHub

Open Graph Title: net: make holding the buffer in memory more robust by addaleax · Pull Request #8252 · nodejs/node

X Title: net: make holding the buffer in memory more robust by addaleax · Pull Request #8252 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) net/src? Descri...

X Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) net/src? Descri...

Opengraph URL: https://github.com/nodejs/node/pull/8252

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b69ce188-ae02-1a9b-9432-58853057e2e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9118:1480EB:D0FDF7:1175661:6A52A2D8
html-safe-nonce96beedc4058c1d1af1eb8da92117eec5516b5fbe5fb9610aa2bc8de372429d46
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTE4OjE0ODBFQjpEMEZERjc6MTE3NTY2MTo2QTUyQTJEOCIsInZpc2l0b3JfaWQiOiIzNDg3Mzg3MjI5OTMxODcyOTg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2cee6d0abc76066d1c14266a237c519f0fdf36a9e69f99b885583c3f19831819
hovercard-subject-tagpull_request:82540736
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8252/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e0c4e4184e91f9f78f579f1e79cc8922bbda3ec888303a92de5d8ee4fe9f3d3a/nodejs/node/pull/8252
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e0c4e4184e91f9f78f579f1e79cc8922bbda3ec888303a92de5d8ee4fe9f3d3a/nodejs/node/pull/8252
og:image:altChecklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) net/src? Descri...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8252#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8252
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8252
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8252
Reloadhttps://github.com/nodejs/node/pull/8252
Reloadhttps://github.com/nodejs/node/pull/8252
Please reload this pagehttps://github.com/nodejs/node/pull/8252
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/8252
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 988 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:fix-efault-8251https://github.com/addaleax/node/tree/fix-efault-8251
Conversationhttps://github.com/nodejs/node/pull/8252
Commits2 (2)https://github.com/nodejs/node/pull/8252/commits
Checkshttps://github.com/nodejs/node/pull/8252/checks
Files changedhttps://github.com/nodejs/node/pull/8252/files
net: make holding the buffer in memory more robusthttps://github.com/nodejs/node/pull/8252#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:fix-efault-8251https://github.com/addaleax/node/tree/fix-efault-8251
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 24, 2016https://github.com/nodejs/node/pull/8252#issue-172950223
Please reload this pagehttps://github.com/nodejs/node/pull/8252
#8251https://github.com/nodejs/node/issues/8251
https://ci.nodejs.org/job/node-test-commit/4749/https://ci.nodejs.org/job/node-test-commit/4749/
Please reload this pagehttps://github.com/nodejs/node/pull/8252
https://github.com/addaleax
net: make holding the buffer in memory more robusthttps://github.com/nodejs/node/pull/8252/commits/a89b6535433d72636d7a9888358975c588a89935
a89b653https://github.com/nodejs/node/pull/8252/commits/a89b6535433d72636d7a9888358975c588a89935
nodejs#8251https://github.com/nodejs/node/issues/8251
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Aug 24, 2016https://github.com/nodejs/node/pull/8252#event-765963393
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 24, 2016 https://github.com/nodejs/node/pull/8252#ref-issue-172930089
EFAULT error in process.stdout.write(data, 'hex') #8251 https://github.com/nodejs/node/issues/8251
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 24, 2016https://github.com/nodejs/node/pull/8252#issuecomment-242149652
Please reload this pagehttps://github.com/nodejs/node/pull/8252
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 24, 2016https://github.com/nodejs/node/pull/8252#issuecomment-242149724
Please reload this pagehttps://github.com/nodejs/node/pull/8252
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Aug 24, 2016https://github.com/nodejs/node/pull/8252#issuecomment-242166199
Please reload this pagehttps://github.com/nodejs/node/pull/8252
bnoordhuishttps://github.com/bnoordhuis
Aug 24, 2016 https://github.com/nodejs/node/pull/8252#discussion-diff-76114408
View reviewed changes https://github.com/nodejs/node/pull/8252/files/a89b6535433d72636d7a9888358975c588a89935#diff-b500913fb0472212f8f06d43f870225c1717d6c9939b19ebfb0fc9b02debaa78
test/parallel/test-net-write-fully-async-buffer.jshttps://github.com/nodejs/node/pull/8252/files#diff-b500913fb0472212f8f06d43f870225c1717d6c9939b19ebfb0fc9b02debaa78
bnoordhuishttps://github.com/bnoordhuis
Aug 24, 2016https://github.com/nodejs/node/pull/8252#discussion_r76114408
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8252
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 24, 2016https://github.com/nodejs/node/pull/8252#issuecomment-242167398
Please reload this pagehttps://github.com/nodejs/node/pull/8252
https://github.com/addaleax
[squash] address nitshttps://github.com/nodejs/node/pull/8252/commits/332b6a00cf599e9dfbaed84d5412f9881dbb4075
332b6a0https://github.com/nodejs/node/pull/8252/commits/332b6a00cf599e9dfbaed84d5412f9881dbb4075
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 25, 2016https://github.com/nodejs/node/pull/8252#issuecomment-242280280
Please reload this pagehttps://github.com/nodejs/node/pull/8252
https://ci.nodejs.org/job/node-test-commit/4758/https://ci.nodejs.org/job/node-test-commit/4758/
Please reload this pagehttps://github.com/nodejs/node/pull/8252
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 27, 2016https://github.com/nodejs/node/pull/8252#issuecomment-242919681
4863f6ahttps://github.com/nodejs/node/commit/4863f6a1217d1805c4f1a98a32e7774a6379bf5a
Please reload this pagehttps://github.com/nodejs/node/pull/8252
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 27, 2016https://github.com/nodejs/node/pull/8252#event-769748771
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
August 27, 2016 14:17https://github.com/nodejs/node/pull/8252#event-769748790
addaleaxhttps://github.com/addaleax
Aug 27, 2016 https://github.com/nodejs/node/pull/8252#ref-commit-4863f6a
https://github.com/addaleax
net: make holding the buffer in memory more robusthttps://github.com/nodejs/node/commit/4863f6a1217d1805c4f1a98a32e7774a6379bf5a
4863f6ahttps://github.com/nodejs/node/commit/4863f6a1217d1805c4f1a98a32e7774a6379bf5a
#8251https://github.com/nodejs/node/issues/8251
#8252https://github.com/nodejs/node/pull/8252
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Aug 27, 2016https://github.com/nodejs/node/pull/8252#event-769749117
addaleaxhttps://github.com/addaleax
Aug 27, 2016 https://github.com/nodejs/node/pull/8252#ref-commit-6b6ae89
https://github.com/addaleax
net: make holding the buffer in memory more robusthttps://github.com/addaleax/node/commit/6b6ae897245a25aeaaa28fb9f0e8e3e3868de714
6b6ae89https://github.com/addaleax/node/commit/6b6ae897245a25aeaaa28fb9f0e8e3e3868de714
nodejs#8251https://github.com/nodejs/node/issues/8251
nodejs#8252https://github.com/nodejs/node/pull/8252
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 27, 2016 https://github.com/nodejs/node/pull/8252#ref-pullrequest-173599387
net: make holding the buffer in memory more robust (v4.x backport) #8300 https://github.com/nodejs/node/pull/8300
MylesBorinshttps://github.com/MylesBorins
Sep 4, 2016 https://github.com/nodejs/node/pull/8252#ref-commit-bceac33
https://github.com/addaleax
https://github.com/MylesBorins
net: make holding the buffer in memory more robusthttps://github.com/nodejs/node/commit/bceac33ded7a6b5d104e2b796eed436d27beb016
bceac33https://github.com/nodejs/node/commit/bceac33ded7a6b5d104e2b796eed436d27beb016
#8251https://github.com/nodejs/node/issues/8251
#8252https://github.com/nodejs/node/pull/8252
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 6, 2016 https://github.com/nodejs/node/pull/8252#ref-issue-175360000
v6.6.0 pre-proposal #8428 https://github.com/nodejs/node/issues/8428
Fishrock123https://github.com/Fishrock123
Sep 8, 2016 https://github.com/nodejs/node/pull/8252#ref-commit-ca9c1b9
https://github.com/addaleax
https://github.com/Fishrock123
net: make holding the buffer in memory more robusthttps://github.com/Fishrock123/node/commit/ca9c1b94ea7556e22304a8e2a9b9bb4c52c904b5
ca9c1b9https://github.com/Fishrock123/node/commit/ca9c1b94ea7556e22304a8e2a9b9bb4c52c904b5
nodejs#8251https://github.com/nodejs/node/issues/8251
nodejs#8252https://github.com/nodejs/node/pull/8252
Fishrock123https://github.com/Fishrock123
Sep 9, 2016 https://github.com/nodejs/node/pull/8252#ref-commit-3ef8ba8
https://github.com/addaleax
https://github.com/Fishrock123
net: make holding the buffer in memory more robusthttps://github.com/nodejs/node/commit/3ef8ba8bdc8426518e500187e5d5ff7707ed31d6
3ef8ba8https://github.com/nodejs/node/commit/3ef8ba8bdc8426518e500187e5d5ff7707ed31d6
#8251https://github.com/nodejs/node/issues/8251
#8252https://github.com/nodejs/node/pull/8252
MylesBorinshttps://github.com/MylesBorins
Sep 28, 2016 https://github.com/nodejs/node/pull/8252#ref-commit-9ffc808
https://github.com/addaleax
net: make holding the buffer in memory more robusthttps://github.com/nodejs/node/commit/9ffc80849d377178061e0e75c900edf9b641480e
9ffc808https://github.com/nodejs/node/commit/9ffc80849d377178061e0e75c900edf9b641480e
#8251https://github.com/nodejs/node/issues/8251
#8252https://github.com/nodejs/node/pull/8252
rvagghttps://github.com/rvagg
Oct 18, 2016 https://github.com/nodejs/node/pull/8252#ref-commit-0808f3b
https://github.com/addaleax
https://github.com/rvagg
net: make holding the buffer in memory more robusthttps://github.com/nodejs/node/commit/0808f3bbc771220b2999c44cbc9ef75b26cc6180
0808f3bhttps://github.com/nodejs/node/commit/0808f3bbc771220b2999c44cbc9ef75b26cc6180
#8251https://github.com/nodejs/node/issues/8251
#8252https://github.com/nodejs/node/pull/8252
MylesBorinshttps://github.com/MylesBorins
Oct 26, 2016 https://github.com/nodejs/node/pull/8252#ref-commit-9f1b790
https://github.com/addaleax
https://github.com/MylesBorins
net: make holding the buffer in memory more robusthttps://github.com/nodejs/node/commit/9f1b790f798cd0ccc602f68442f32c15b5e3a3be
9f1b790https://github.com/nodejs/node/commit/9f1b790f798cd0ccc602f68442f32c15b5e3a3be
#8251https://github.com/nodejs/node/issues/8251
#8252https://github.com/nodejs/node/pull/8252
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 26, 2016 https://github.com/nodejs/node/pull/8252#ref-pullrequest-185475513
V4.6.2 proposal #9298 https://github.com/nodejs/node/pull/9298
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8252
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
EFAULT error in process.stdout.write(data, 'hex') https://github.com/nodejs/node/issues/8251
Please reload this pagehttps://github.com/nodejs/node/pull/8252
https://github.com/addaleax
https://github.com/jasnell
https://github.com/trevnorris
https://github.com/bnoordhuis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.