René's URL Explorer Experiment


Title: url: keep auth in `url.resolve()` if host matches by imyller · Pull Request #8215 · nodejs/node · GitHub

Open Graph Title: url: keep auth in `url.resolve()` if host matches by imyller · Pull Request #8215 · nodejs/node

X Title: url: keep auth in `url.resolve()` if host matches by imyller · Pull Request #8215 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) url Descripti...

X Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) url Descripti...

Opengraph URL: https://github.com/nodejs/node/pull/8215

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:15544659-7441-eb49-58e5-5b4c43c304d4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE326:17E18C:53C19:704B8:6A5253A5
html-safe-nonce0d0b221c6b833af8f39a2c4fdf08047992c21588fcda6321c163e170712da7cc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzI2OjE3RTE4Qzo1M0MxOTo3MDRCODo2QTUyNTNBNSIsInZpc2l0b3JfaWQiOiI4MTc4NDg4MzQ5MDA4NDgzMjM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd00ca47e7571306a6aa22e90a2dd5337cedca0db600b5a3b31432364be3efc05
hovercard-subject-tagpull_request:82116751
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8215/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3658868fda5a4f0311d44192b7776806fe5f6b5de98e63d59db3af34cc115e46/nodejs/node/pull/8215
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3658868fda5a4f0311d44192b7776806fe5f6b5de98e63d59db3af34cc115e46/nodejs/node/pull/8215
og:image:altChecklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) url Descripti...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameimyller
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8215#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8215
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8215
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8215
Reloadhttps://github.com/nodejs/node/pull/8215
Reloadhttps://github.com/nodejs/node/pull/8215
Please reload this pagehttps://github.com/nodejs/node/pull/8215
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/8215
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 984 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
imyllerhttps://github.com/imyller
nodejs:masterhttps://github.com/nodejs/node/tree/master
imyller:url-resolve-authhttps://github.com/imyller/node/tree/url-resolve-auth
Conversationhttps://github.com/nodejs/node/pull/8215
Commits1 (1)https://github.com/nodejs/node/pull/8215/commits
Checkshttps://github.com/nodejs/node/pull/8215/checks
Files changedhttps://github.com/nodejs/node/pull/8215/files
url: keep auth in url.resolve() if host matcheshttps://github.com/nodejs/node/pull/8215#top
imyllerhttps://github.com/imyller
nodejs:masterhttps://github.com/nodejs/node/tree/master
imyller:url-resolve-authhttps://github.com/imyller/node/tree/url-resolve-auth
https://github.com/imyller
imyllerhttps://github.com/imyller
Aug 21, 2016https://github.com/nodejs/node/pull/8215#issue-172340708
#1480https://github.com/nodejs/node/pull/1480
#8165https://github.com/nodejs/node/issues/8165
Please reload this pagehttps://github.com/nodejs/node/pull/8215
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
Aug 21, 2016https://github.com/nodejs/node/pull/8215#event-762376306
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 22, 2016https://github.com/nodejs/node/pull/8215#issuecomment-241515604
https://ci.nodejs.org/job/node-test-pull-request/3791/https://ci.nodejs.org/job/node-test-pull-request/3791/
Please reload this pagehttps://github.com/nodejs/node/pull/8215
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 22, 2016https://github.com/nodejs/node/pull/8215#issuecomment-241515711
Please reload this pagehttps://github.com/nodejs/node/pull/8215
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 23, 2016https://github.com/nodejs/node/pull/8215#issuecomment-241831600
https://ci.nodejs.org/job/node-test-pull-request/3805/https://ci.nodejs.org/job/node-test-pull-request/3805/
Please reload this pagehttps://github.com/nodejs/node/pull/8215
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 23, 2016https://github.com/nodejs/node/pull/8215#issuecomment-241854014
Please reload this pagehttps://github.com/nodejs/node/pull/8215
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 23, 2016https://github.com/nodejs/node/pull/8215#issuecomment-241854306
@imyllerhttps://github.com/imyller
Please reload this pagehttps://github.com/nodejs/node/pull/8215
https://github.com/imyller
url: keep auth in url.resolve() if host matcheshttps://github.com/nodejs/node/pull/8215/commits/aaae94ea7ebf1bff8e79eb013cc78a6c323a9c09
aaae94ehttps://github.com/nodejs/node/pull/8215/commits/aaae94ea7ebf1bff8e79eb013cc78a6c323a9c09
nodejs#8165https://github.com/nodejs/node/issues/8165
https://github.com/imyller
imyllerhttps://github.com/imyller
force-pushedhttps://github.com/nodejs/node/compare/5cbab64a168a8ec8f0f3a63d0b226ef64d45e361..aaae94ea7ebf1bff8e79eb013cc78a6c323a9c09
5cbab64https://github.com/nodejs/node/commit/5cbab64a168a8ec8f0f3a63d0b226ef64d45e361
aaae94ehttps://github.com/nodejs/node/commit/aaae94ea7ebf1bff8e79eb013cc78a6c323a9c09
Compare https://github.com/nodejs/node/compare/5cbab64a168a8ec8f0f3a63d0b226ef64d45e361..aaae94ea7ebf1bff8e79eb013cc78a6c323a9c09
August 24, 2016 05:50https://github.com/nodejs/node/pull/8215#event-765499480
https://github.com/imyller
imyllerhttps://github.com/imyller
Aug 24, 2016https://github.com/nodejs/node/pull/8215#issuecomment-241964321
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/8215
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 24, 2016https://github.com/nodejs/node/pull/8215#issuecomment-242146160
https://ci.nodejs.org/job/node-test-pull-request/3822/https://ci.nodejs.org/job/node-test-pull-request/3822/
Please reload this pagehttps://github.com/nodejs/node/pull/8215
jasnellhttps://github.com/jasnell
Aug 24, 2016 https://github.com/nodejs/node/pull/8215#ref-commit-51f96df
https://github.com/imyller
https://github.com/jasnell
url: keep auth in url.resolve() if host matcheshttps://github.com/nodejs/node/commit/51f96dfcfc7e596866ac2a65f2984b55e760bff5
51f96dfhttps://github.com/nodejs/node/commit/51f96dfcfc7e596866ac2a65f2984b55e760bff5
#8165https://github.com/nodejs/node/issues/8165
#8215https://github.com/nodejs/node/pull/8215
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 24, 2016https://github.com/nodejs/node/pull/8215#issuecomment-242167787
51f96dfhttps://github.com/nodejs/node/commit/51f96dfcfc7e596866ac2a65f2984b55e760bff5
Please reload this pagehttps://github.com/nodejs/node/pull/8215
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 24, 2016https://github.com/nodejs/node/pull/8215#event-766427343
https://github.com/msakrejda
msakrejdahttps://github.com/msakrejda
Aug 31, 2016 https://github.com/nodejs/node/pull/8215#ref-issue-171797418
Auth lost on redirect to same host in node 6.3.1 follow-redirects/follow-redirects#42 https://github.com/follow-redirects/follow-redirects/issues/42
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 6, 2016 https://github.com/nodejs/node/pull/8215#ref-issue-175360000
v6.6.0 pre-proposal #8428 https://github.com/nodejs/node/issues/8428
Fishrock123https://github.com/Fishrock123
Sep 8, 2016 https://github.com/nodejs/node/pull/8215#ref-commit-7307367
https://github.com/imyller
https://github.com/Fishrock123
url: keep auth in url.resolve() if host matcheshttps://github.com/Fishrock123/node/commit/73073672b8e56b87e3e63abbf9b8ac975df8e5b1
7307367https://github.com/Fishrock123/node/commit/73073672b8e56b87e3e63abbf9b8ac975df8e5b1
nodejs#8165https://github.com/nodejs/node/issues/8165
nodejs#8215https://github.com/nodejs/node/pull/8215
Fishrock123https://github.com/Fishrock123
Sep 9, 2016 https://github.com/nodejs/node/pull/8215#ref-commit-6ae7af0
https://github.com/imyller
https://github.com/Fishrock123
url: keep auth in url.resolve() if host matcheshttps://github.com/nodejs/node/commit/6ae7af0fa3e91681bc1dfb05a9b651a5ce5e12da
6ae7af0https://github.com/nodejs/node/commit/6ae7af0fa3e91681bc1dfb05a9b651a5ce5e12da
#8165https://github.com/nodejs/node/issues/8165
#8215https://github.com/nodejs/node/pull/8215
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Sep 30, 2016https://github.com/nodejs/node/pull/8215#event-809063201
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Sep 30, 2016https://github.com/nodejs/node/pull/8215#issuecomment-250858239
Please reload this pagehttps://github.com/nodejs/node/pull/8215
Please reload this pagehttps://github.com/nodejs/node/pull/8215
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8215
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
url.resolve auth behavior if host does *not* change https://github.com/nodejs/node/issues/8165
Please reload this pagehttps://github.com/nodejs/node/pull/8215
https://github.com/imyller
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.