| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:48e7c64c-811f-d87a-2ed5-e368f71e229c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BE3E:203A29:51D79C:6E3254:6A51CA0E |
| html-safe-nonce | df64a869126c4460a342773f610499c87a36d617e9465dc22fa154827c2f35df |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTNFOjIwM0EyOTo1MUQ3OUM6NkUzMjU0OjZBNTFDQTBFIiwidmlzaXRvcl9pZCI6IjQ3OTQzMTgwMzI2MTU4ODUzMjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ec0d54012868df59a4a9d543cb5d21ebb9e68b894e5424e53cd81edc950fd3f6 |
| hovercard-subject-tag | pull_request:82079067 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8198/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c10a3bd3e087b816665a812423a4c0e5361a70f92dcde854fbb45393d0212981/nodejs/node/pull/8198 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c10a3bd3e087b816665a812423a4c0e5361a70f92dcde854fbb45393d0212981/nodejs/node/pull/8198 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines
Affect... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | yorkie |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8198#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8198 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8198 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8198 |
| Reload | https://github.com/nodejs/node/pull/8198 |
| Reload | https://github.com/nodejs/node/pull/8198 |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
983
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| yorkie | https://github.com/yorkie |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| yorkie:test-async-wrap-throw-no-init | https://github.com/yorkie/node/tree/test-async-wrap-throw-no-init |
| Conversation | https://github.com/nodejs/node/pull/8198 |
| Commits1 (1) | https://github.com/nodejs/node/pull/8198/commits |
| Checks | https://github.com/nodejs/node/pull/8198/checks |
| Files changed | https://github.com/nodejs/node/pull/8198/files |
| async_wrap: add a missing case to test-async-wrap-throw-no-init | https://github.com/nodejs/node/pull/8198#top |
| yorkie | https://github.com/yorkie |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| yorkie:test-async-wrap-throw-no-init | https://github.com/yorkie/node/tree/test-async-wrap-throw-no-init |
|
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
| Aug 20, 2016 | https://github.com/nodejs/node/pull/8198#issue-172271775 |
| this line | https://github.com/nodejs/node/blob/master/src/async-wrap.cc#L145 |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Aug 20, 2016 | https://github.com/nodejs/node/pull/8198#event-762065975 |
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
|
async_wrap
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_wrap |
| Aug 20, 2016 | https://github.com/nodejs/node/pull/8198#event-762065998 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 21, 2016 | https://github.com/nodejs/node/pull/8198#issuecomment-241284759 |
| https://ci.nodejs.org/job/node-test-pull-request/3779/ | https://ci.nodejs.org/job/node-test-pull-request/3779/ |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 21, 2016 | https://github.com/nodejs/node/pull/8198#issuecomment-241284764 |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
| Aug 22, 2016 | https://github.com/nodejs/node/pull/8198#issuecomment-241333069 |
| https://ci.nodejs.org/job/node-test-binary-arm/3435/RUN_SUBSET=3,label=pi1-raspbian-wheezy/console | https://ci.nodejs.org/job/node-test-binary-arm/3435/RUN_SUBSET=3,label=pi1-raspbian-wheezy/console |
| https://ci.nodejs.org/job/node-test-commit-smartos/3842/nodes=smartos14-32/tapTestReport/test.tap-1189/ | https://ci.nodejs.org/job/node-test-commit-smartos/3842/nodes=smartos14-32/tapTestReport/test.tap-1189/ |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
|
Aug 22, 2016
| https://github.com/nodejs/node/pull/8198#ref-issue-172385849 |
|
test: failed on sequential/test-child-process-pass-fd
#8219
| https://github.com/nodejs/node/issues/8219 |
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
| Aug 22, 2016 | https://github.com/nodejs/node/pull/8198#issuecomment-241334986 |
| @jasnell | https://github.com/jasnell |
| #8203 | https://github.com/nodejs/node/pull/8203 |
| #8219 | https://github.com/nodejs/node/issues/8219 |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Aug 22, 2016 | https://github.com/nodejs/node/pull/8198#issuecomment-241541937 |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
| Aug 23, 2016 | https://github.com/nodejs/node/pull/8198#issuecomment-241912894 |
| https://ci.nodejs.org/job/node-test-pull-request/3815/ | https://ci.nodejs.org/job/node-test-pull-request/3815/ |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
|
| https://github.com/yorkie |
| async_wrap: add a missing case to test-async-wrap-throw-no-init | https://github.com/nodejs/node/pull/8198/commits/10b3f131c2fc8a6d42e53105287d9e652937242d |
| 10b3f13 | https://github.com/nodejs/node/pull/8198/commits/10b3f131c2fc8a6d42e53105287d9e652937242d |
| nodejs#8198 | https://github.com/nodejs/node/pull/8198 |
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
| force-pushed | https://github.com/nodejs/node/compare/c49a07026a65dbf0b9485c8a5189f8ebcafaa0de..10b3f131c2fc8a6d42e53105287d9e652937242d |
| c49a070 | https://github.com/nodejs/node/commit/c49a07026a65dbf0b9485c8a5189f8ebcafaa0de |
| 10b3f13 | https://github.com/nodejs/node/commit/10b3f131c2fc8a6d42e53105287d9e652937242d |
|
Compare
| https://github.com/nodejs/node/compare/c49a07026a65dbf0b9485c8a5189f8ebcafaa0de..10b3f131c2fc8a6d42e53105287d9e652937242d |
| August 25, 2016 19:54 | https://github.com/nodejs/node/pull/8198#event-767980673 |
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
| 10b3f13 | https://github.com/nodejs/node/commit/10b3f131c2fc8a6d42e53105287d9e652937242d |
| Aug 25, 2016 | https://github.com/nodejs/node/pull/8198#event-767982847 |
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
| August 25, 2016 19:56 | https://github.com/nodejs/node/pull/8198#event-767982993 |
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
| Aug 25, 2016 | https://github.com/nodejs/node/pull/8198#issuecomment-242515968 |
| 10b3f13 | https://github.com/nodejs/node/commit/10b3f131c2fc8a6d42e53105287d9e652937242d |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
| Aug 25, 2016 | https://github.com/nodejs/node/pull/8198#issuecomment-242518231 |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
| failure | https://ci.nodejs.org/job/node-test-pull-request/3815/ |
| here | https://ci.nodejs.org/job/node-test-commit-aix/447/nodes=aix61-ppc64/console |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Sep 6, 2016
| https://github.com/nodejs/node/pull/8198#ref-issue-175360000 |
|
v6.6.0 pre-proposal
#8428
| https://github.com/nodejs/node/issues/8428 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Sep 8, 2016
| https://github.com/nodejs/node/pull/8198#ref-commit-60cc9cb |
|
| https://github.com/yorkie |
|
| https://github.com/Fishrock123 |
| async_wrap: add a missing case to test-async-wrap-throw-no-init | https://github.com/Fishrock123/node/commit/60cc9cbd646d4401e3bb9384bd46fff871730f1d |
| 60cc9cb | https://github.com/Fishrock123/node/commit/60cc9cbd646d4401e3bb9384bd46fff871730f1d |
| nodejs#8198 | https://github.com/nodejs/node/pull/8198 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Sep 9, 2016
| https://github.com/nodejs/node/pull/8198#ref-commit-2ecc8c4 |
|
| https://github.com/yorkie |
|
| https://github.com/Fishrock123 |
| async_wrap: add a missing case to test-async-wrap-throw-no-init | https://github.com/nodejs/node/commit/2ecc8c4c23baadd79bf465a10d126a8544ca1117 |
| 2ecc8c4 | https://github.com/nodejs/node/commit/2ecc8c4c23baadd79bf465a10d126a8544ca1117 |
| #8198 | https://github.com/nodejs/node/pull/8198 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 30, 2016
| https://github.com/nodejs/node/pull/8198#ref-commit-83776f1 |
|
| https://github.com/yorkie |
| async_wrap: add a missing case to test-async-wrap-throw-no-init | https://github.com/nodejs/node/commit/83776f1ecfc1d87438d125161cb01c0af9ba10cc |
| 83776f1 | https://github.com/nodejs/node/commit/83776f1ecfc1d87438d125161cb01c0af9ba10cc |
| #8198 | https://github.com/nodejs/node/pull/8198 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/8198#issuecomment-250860189 |
| @trevnorris | https://github.com/trevnorris |
| @yorkie | https://github.com/yorkie |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/8198#ref-commit-0e94765 |
|
| https://github.com/yorkie |
| async_wrap: add a missing case to test-async-wrap-throw-no-init | https://github.com/nodejs/node/commit/0e94765c69783e0c398091f39b1d1c0610209626 |
| 0e94765 | https://github.com/nodejs/node/commit/0e94765c69783e0c398091f39b1d1c0610209626 |
| #8198 | https://github.com/nodejs/node/pull/8198 |
| rvagg | https://github.com/rvagg |
|
Oct 18, 2016
| https://github.com/nodejs/node/pull/8198#ref-commit-fbd31b7 |
|
| https://github.com/yorkie |
|
| https://github.com/rvagg |
| async_wrap: add a missing case to test-async-wrap-throw-no-init | https://github.com/nodejs/node/commit/fbd31b7af7ce6f1acd42739f148eea6fee91f0f5 |
| fbd31b7 | https://github.com/nodejs/node/commit/fbd31b7af7ce6f1acd42739f148eea6fee91f0f5 |
| #8198 | https://github.com/nodejs/node/pull/8198 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/8198#ref-commit-861e584 |
|
| https://github.com/yorkie |
|
| https://github.com/MylesBorins |
| async_wrap: add a missing case to test-async-wrap-throw-no-init | https://github.com/nodejs/node/commit/861e584d466035462f3c7693b8381101f1f4cb6f |
| 861e584 | https://github.com/nodejs/node/commit/861e584d466035462f3c7693b8381101f1f4cb6f |
| #8198 | https://github.com/nodejs/node/pull/8198 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/8198#ref-pullrequest-185475513 |
|
V4.6.2 proposal
#9298
| https://github.com/nodejs/node/pull/9298 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8198 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/8198 |
|
| https://github.com/yorkie |
|
| https://github.com/jasnell |
|
| https://github.com/trevnorris |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |