René's URL Explorer Experiment


Title: dns: lookupService() callback must be a function by cjihrig · Pull Request #8170 · nodejs/node · GitHub

Open Graph Title: dns: lookupService() callback must be a function by cjihrig · Pull Request #8170 · nodejs/node

X Title: dns: lookupService() callback must be a function by cjihrig · Pull Request #8170 · nodejs/node

Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) dns Description...

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) dns Description...

X Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) dns Description...

Opengraph URL: https://github.com/nodejs/node/pull/8170

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:64c4c48d-2d41-b17f-9030-4a6f8959f76d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDC4:2DD042:2EA347:3CDB18:696B3C60
html-safe-nonce8df5d13790818904a467b2081ae7bd811b6e7aec9568866c413461d831c7ffab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREM0OjJERDA0MjoyRUEzNDc6M0NEQjE4OjY5NkIzQzYwIiwidmlzaXRvcl9pZCI6IjQ3MjY0MjE2Nzc3NTcxMTk1ODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4b9bbaa7602c2b75fc00c647cd9e6e6536f52d4ed2d69cf25593964eeb5af521
hovercard-subject-tagpull_request:81891830
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8170/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0595ea3d0309a9ef3c56c653ac5fd699a648bcefdaabee0b0d719fa6c052b426/nodejs/node/pull/8170
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0595ea3d0309a9ef3c56c653ac5fd699a648bcefdaabee0b0d719fa6c052b426/nodejs/node/pull/8170
og:image:altChecklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) dns Description...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8170#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8170
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8170
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8170
Reloadhttps://github.com/nodejs/node/pull/8170
Reloadhttps://github.com/nodejs/node/pull/8170
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/8170
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/8170
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/8170#issue-comment-box
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:lookupservicehttps://github.com/cjihrig/node/tree/lookupservice
dns: lookupService() callback must be a function https://github.com/nodejs/node/pull/8170#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:lookupservicehttps://github.com/cjihrig/node/tree/lookupservice
Conversation 6 https://github.com/nodejs/node/pull/8170
Commits 2 https://github.com/nodejs/node/pull/8170/commits
Checks 0 https://github.com/nodejs/node/pull/8170/checks
Files changed 2 https://github.com/nodejs/node/pull/8170/files
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 18, 2016https://github.com/nodejs/node/pull/8170#issue-172005834
Please reload this pagehttps://github.com/nodejs/node/pull/8170
cjihrighttps://github.com/cjihrig
August 18, 2016 17:09https://github.com/nodejs/node/pull/8170#commits-pushed-39ba118
https://github.com/cjihrig
dns: lookupService() callback must be a functionhttps://github.com/nodejs/node/pull/8170/commits/39ba118a15c7e29f4764f8ee37072a4d0612b0ba
39ba118https://github.com/nodejs/node/pull/8170/commits/39ba118a15c7e29f4764f8ee37072a4d0612b0ba
https://github.com/cjihrig
dns: remove makeAsync() function checkhttps://github.com/nodejs/node/pull/8170/commits/2bebeb1bd5c2bf95dd9cd9712fd684719487ab91
2bebeb1https://github.com/nodejs/node/pull/8170/commits/2bebeb1bd5c2bf95dd9cd9712fd684719487ab91
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
Aug 18, 2016https://github.com/nodejs/node/pull/8170#event-760538102
https://github.com/jasnell
jasnellhttps://github.com/jasnell
error-handling https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerror-handling
Aug 18, 2016https://github.com/nodejs/node/pull/8170#event-760564096
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 18, 2016https://github.com/nodejs/node/pull/8170#issuecomment-240869193
Please reload this pagehttps://github.com/nodejs/node/pull/8170
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 18, 2016https://github.com/nodejs/node/pull/8170#issuecomment-240869250
Please reload this pagehttps://github.com/nodejs/node/pull/8170
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Aug 19, 2016https://github.com/nodejs/node/pull/8170#issuecomment-241001923
Please reload this pagehttps://github.com/nodejs/node/pull/8170
https://github.com/yorkie
yorkiehttps://github.com/yorkie
Aug 19, 2016https://github.com/nodejs/node/pull/8170#issuecomment-241050568
https://ci.nodejs.org/job/node-test-pull-request/3751https://ci.nodejs.org/job/node-test-pull-request/3751
Please reload this pagehttps://github.com/nodejs/node/pull/8170
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 20, 2016https://github.com/nodejs/node/pull/8170#issuecomment-241222216
https://ci.nodejs.org/job/node-test-pull-request/3767/https://ci.nodejs.org/job/node-test-pull-request/3767/
Please reload this pagehttps://github.com/nodejs/node/pull/8170
jasnellhttps://github.com/jasnell
Aug 22, 2016 https://github.com/nodejs/node/pull/8170#ref-commit-3a43568
https://github.com/cjihrig
https://github.com/jasnell
dns: lookupService() callback must be a functionhttps://github.com/nodejs/node/commit/3a43568020db762dea915122ed662e712a4a5781
3a43568https://github.com/nodejs/node/commit/3a43568020db762dea915122ed662e712a4a5781
#8170https://github.com/nodejs/node/pull/8170
jasnellhttps://github.com/jasnell
Aug 22, 2016 https://github.com/nodejs/node/pull/8170#ref-commit-013d76c
https://github.com/cjihrig
https://github.com/jasnell
dns: remove makeAsync() function checkhttps://github.com/nodejs/node/commit/013d76cb734aa6deb4f468395960fb9d985cd8f5
013d76chttps://github.com/nodejs/node/commit/013d76cb734aa6deb4f468395960fb9d985cd8f5
#8170https://github.com/nodejs/node/pull/8170
https://github.com/jasnell
jasnellhttps://github.com/jasnell
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Aug 22, 2016https://github.com/nodejs/node/pull/8170#event-763407648
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 22, 2016https://github.com/nodejs/node/pull/8170#issuecomment-241499494
013d76chttps://github.com/nodejs/node/commit/013d76cb734aa6deb4f468395960fb9d985cd8f5
Please reload this pagehttps://github.com/nodejs/node/pull/8170
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 22, 2016https://github.com/nodejs/node/pull/8170#event-763409140
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
August 23, 2016 01:21https://github.com/nodejs/node/pull/8170#event-763849403
evanlucashttps://github.com/evanlucas
Aug 24, 2016 https://github.com/nodejs/node/pull/8170#ref-commit-70648f4
https://github.com/cjihrig
https://github.com/evanlucas
dns: lookupService() callback must be a functionhttps://github.com/nodejs/node/commit/70648f47ca65b75e8c31474ee7c0b1b832ea558d
70648f4https://github.com/nodejs/node/commit/70648f47ca65b75e8c31474ee7c0b1b832ea558d
#8170https://github.com/nodejs/node/pull/8170
evanlucashttps://github.com/evanlucas
Aug 24, 2016 https://github.com/nodejs/node/pull/8170#ref-commit-d0cb52b
https://github.com/cjihrig
https://github.com/evanlucas
dns: remove makeAsync() function checkhttps://github.com/nodejs/node/commit/d0cb52b9678a1588e71a882189d70ac95e067814
d0cb52bhttps://github.com/nodejs/node/commit/d0cb52b9678a1588e71a882189d70ac95e067814
#8170https://github.com/nodejs/node/pull/8170
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Aug 24, 2016 https://github.com/nodejs/node/pull/8170#ref-pullrequest-172960911
2016-08-26, Version 6.5.0 (Current) #8253 https://github.com/nodejs/node/pull/8253
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8170
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
Please reload this pagehttps://github.com/nodejs/node/pull/8170
https://github.com/cjihrig
https://github.com/jasnell
https://github.com/evanlucas
https://github.com/yorkie
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.