| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9020cf06-a025-4ce3-a0a4-2e6b152d04d6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 83DE:2C3E22:13F2C23:19CEAEB:696B1AD9 |
| html-safe-nonce | 8ab6fbda1b742540769d8543a4c6a28b65728cc4ec77105dfe2e158c5c9a4f9c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0RFOjJDM0UyMjoxM0YyQzIzOjE5Q0VBRUI6Njk2QjFBRDkiLCJ2aXNpdG9yX2lkIjoiMzI0MzY1Nzk1MDUxNjY4MTQzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 94dde6a74eb01ff27a53432ce29e9411434cfc9cb557d716901d8b3661f6d255 |
| hovercard-subject-tag | pull_request:81508598 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8124/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2300209e1befeff6450f5c4620d28ca0653178f1f21ac3cff84033462172d3cd/nodejs/node/pull/8124 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2300209e1befeff6450f5c4620d28ca0653178f1f21ac3cff84033462172d3cd/nodejs/node/pull/8124 |
| og:image:alt | Checklist
documentation is changed or added
commit message follows commit guidelines
Description of change
Const is block-scoped.
Stream HTTP server example code is broken since const was intro... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lazlojuly |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8124#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8124 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8124 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8124 |
| Reload | https://github.com/nodejs/node/pull/8124 |
| Reload | https://github.com/nodejs/node/pull/8124 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8124 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/8124 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/8124#issue-comment-box |
| lazlojuly | https://github.com/lazlojuly |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lazlojuly:doc-stream-http-example-fix | https://github.com/lazlojuly/node/tree/doc-stream-http-example-fix |
|
doc: fix variable scoping bug in Stream HTTP server example code
| https://github.com/nodejs/node/pull/8124#top |
| lazlojuly | https://github.com/lazlojuly |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lazlojuly:doc-stream-http-example-fix | https://github.com/lazlojuly/node/tree/doc-stream-http-example-fix |
|
Conversation
5
| https://github.com/nodejs/node/pull/8124 |
|
Commits
1
| https://github.com/nodejs/node/pull/8124/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/8124/checks |
|
Files changed
| https://github.com/nodejs/node/pull/8124/files |
| Please reload this page | https://github.com/nodejs/node/pull/8124 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/lazlojuly |
| lazlojuly | https://github.com/lazlojuly |
| Aug 16, 2016 | https://github.com/nodejs/node/pull/8124#issue-171467828 |
| Please reload this page | https://github.com/nodejs/node/pull/8124 |
| Please reload this page | https://github.com/nodejs/node/pull/8124 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Aug 16, 2016 | https://github.com/nodejs/node/pull/8124#event-757358170 |
| jasnell | https://github.com/jasnell |
|
Aug 16, 2016
| https://github.com/nodejs/node/pull/8124#discussion-diff-74979881 |
| View reviewed changes
| https://github.com/nodejs/node/pull/8124/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/8124/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| jasnell | https://github.com/jasnell |
| Aug 16, 2016 | https://github.com/nodejs/node/pull/8124#discussion_r74979881 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8124 |
| lazlojuly | https://github.com/lazlojuly |
| Aug 16, 2016 | https://github.com/nodejs/node/pull/8124#discussion_r74982568 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8124 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 16, 2016 | https://github.com/nodejs/node/pull/8124#issuecomment-240173970 |
| Please reload this page | https://github.com/nodejs/node/pull/8124 |
|
| https://github.com/lazlojuly |
| doc: fix variable scoping bug in Stream HTTP server example code | https://github.com/nodejs/node/pull/8124/commits/061880fa52a1bd74f44e7eb337b0197302856ae6 |
| 061880f | https://github.com/nodejs/node/pull/8124/commits/061880fa52a1bd74f44e7eb337b0197302856ae6 |
| https://github.com/lazlojuly |
| lazlojuly | https://github.com/lazlojuly |
| force-pushed | https://github.com/nodejs/node/compare/6b076641db9a8dfdcd29d168a1424c7bf6b5a553..061880fa52a1bd74f44e7eb337b0197302856ae6 |
| 6b07664 | https://github.com/nodejs/node/commit/6b076641db9a8dfdcd29d168a1424c7bf6b5a553 |
| 061880f | https://github.com/nodejs/node/commit/061880fa52a1bd74f44e7eb337b0197302856ae6 |
|
Compare
| https://github.com/nodejs/node/compare/6b076641db9a8dfdcd29d168a1424c7bf6b5a553..061880fa52a1bd74f44e7eb337b0197302856ae6 |
| August 16, 2016 17:34 | https://github.com/nodejs/node/pull/8124#event-757396901 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Aug 16, 2016 | https://github.com/nodejs/node/pull/8124#issuecomment-240180259 |
| Please reload this page | https://github.com/nodejs/node/pull/8124 |
| jasnell | https://github.com/jasnell |
|
Aug 18, 2016
| https://github.com/nodejs/node/pull/8124#ref-commit-66d697c |
|
| https://github.com/lazlojuly |
|
| https://github.com/jasnell |
| doc: fix variable scoping bug in server example code | https://github.com/nodejs/node/commit/66d697cb5c32461cf65fe44d797c8648ab2f0fca |
| 66d697c | https://github.com/nodejs/node/commit/66d697cb5c32461cf65fe44d797c8648ab2f0fca |
| #8124 | https://github.com/nodejs/node/pull/8124 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 18, 2016 | https://github.com/nodejs/node/pull/8124#issuecomment-240785599 |
| 66d697c | https://github.com/nodejs/node/commit/66d697cb5c32461cf65fe44d797c8648ab2f0fca |
| @lazlojuly | https://github.com/lazlojuly |
| Please reload this page | https://github.com/nodejs/node/pull/8124 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 18, 2016 | https://github.com/nodejs/node/pull/8124#event-760190317 |
| evanlucas | https://github.com/evanlucas |
|
Aug 24, 2016
| https://github.com/nodejs/node/pull/8124#ref-commit-82329b6 |
|
| https://github.com/lazlojuly |
|
| https://github.com/evanlucas |
| doc: fix variable scoping bug in server example code | https://github.com/nodejs/node/commit/82329b6e8fe3fd364e13869cc3387eb4e68a7ecc |
| 82329b6 | https://github.com/nodejs/node/commit/82329b6e8fe3fd364e13869cc3387eb4e68a7ecc |
| #8124 | https://github.com/nodejs/node/pull/8124 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Aug 24, 2016
| https://github.com/nodejs/node/pull/8124#ref-pullrequest-172960911 |
|
2016-08-26, Version 6.5.0 (Current)
#8253
| https://github.com/nodejs/node/pull/8253 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 30, 2016
| https://github.com/nodejs/node/pull/8124#ref-commit-c947929 |
|
| https://github.com/lazlojuly |
| doc: fix variable scoping bug in server example code | https://github.com/nodejs/node/commit/c9479299c19576cf6e96cfee26e0def28eb170a3 |
| c947929 | https://github.com/nodejs/node/commit/c9479299c19576cf6e96cfee26e0def28eb170a3 |
| #8124 | https://github.com/nodejs/node/pull/8124 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/8124#event-808873414 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/8124#ref-commit-5febcca |
|
| https://github.com/lazlojuly |
| doc: fix variable scoping bug in server example code | https://github.com/nodejs/node/commit/5febcca27b73ba21f51144d620b519d72a3c586b |
| 5febcca | https://github.com/nodejs/node/commit/5febcca27b73ba21f51144d620b519d72a3c586b |
| #8124 | https://github.com/nodejs/node/pull/8124 |
| rvagg | https://github.com/rvagg |
|
Oct 18, 2016
| https://github.com/nodejs/node/pull/8124#ref-commit-7590ade |
|
| https://github.com/lazlojuly |
|
| https://github.com/rvagg |
| doc: fix variable scoping bug in server example code | https://github.com/nodejs/node/commit/7590aded30a7faebc9f59e5ac4d3d1616ad51d2e |
| 7590ade | https://github.com/nodejs/node/commit/7590aded30a7faebc9f59e5ac4d3d1616ad51d2e |
| #8124 | https://github.com/nodejs/node/pull/8124 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/8124#ref-commit-3a3fde6 |
|
| https://github.com/lazlojuly |
|
| https://github.com/MylesBorins |
| doc: fix variable scoping bug in server example code | https://github.com/nodejs/node/commit/3a3fde69c7050e505836d7ceb0b52fbc44592f9e |
| 3a3fde6 | https://github.com/nodejs/node/commit/3a3fde69c7050e505836d7ceb0b52fbc44592f9e |
| #8124 | https://github.com/nodejs/node/pull/8124 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/8124#ref-pullrequest-185475513 |
|
V4.6.2 proposal
#9298
| https://github.com/nodejs/node/pull/9298 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8124 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/8124 |
|
| https://github.com/lazlojuly |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |