René's URL Explorer Experiment


Title: tls: copy the Buffer object before using by thefourtheye · Pull Request #8055 · nodejs/node · GitHub

Open Graph Title: tls: copy the Buffer object before using by thefourtheye · Pull Request #8055 · nodejs/node

X Title: tls: copy the Buffer object before using by thefourtheye · Pull Request #8055 · nodejs/node

Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) tls Description of ...

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) tls Description of ...

X Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) tls Description of ...

Opengraph URL: https://github.com/nodejs/node/pull/8055

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ca875218-fc4f-6703-5ab2-b349a96a3b31
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8130:4D95E:28C992:39B320:696A0726
html-safe-noncee7787993eb0f46d9a9fdef4eebfb4f26364ff84997977accc6dfc0fc723178d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTMwOjREOTVFOjI4Qzk5MjozOUIzMjA6Njk2QTA3MjYiLCJ2aXNpdG9yX2lkIjoiMTA1NDc1NjU0MTMxMTg3ODk1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4b265f96624a645edd37d37f911f5c74c65f4302c927f626a6e522cc5761f92f
hovercard-subject-tagpull_request:80851916
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8055/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/58da4def46f90da25cff9698c020ddf9bc30d8a568efcb37a22da44842f79315/nodejs/node/pull/8055
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/58da4def46f90da25cff9698c020ddf9bc30d8a568efcb37a22da44842f79315/nodejs/node/pull/8055
og:image:altChecklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) tls Description of ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamethefourtheye
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/8055#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8055
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8055
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/8055
Reloadhttps://github.com/nodejs/node/pull/8055
Reloadhttps://github.com/nodejs/node/pull/8055
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/8055
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/8055
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/8055#issue-comment-box
thefourtheyehttps://github.com/thefourtheye
nodejs:masterhttps://github.com/nodejs/node/tree/master
thefourtheye:tls-buffers-copiedhttps://github.com/thefourtheye/io.js/tree/tls-buffers-copied
tls: copy the Buffer object before using https://github.com/nodejs/node/pull/8055#top
thefourtheyehttps://github.com/thefourtheye
nodejs:masterhttps://github.com/nodejs/node/tree/master
thefourtheye:tls-buffers-copiedhttps://github.com/thefourtheye/io.js/tree/tls-buffers-copied
Conversation 14 https://github.com/nodejs/node/pull/8055
Commits 2 https://github.com/nodejs/node/pull/8055/commits
Checks 0 https://github.com/nodejs/node/pull/8055/checks
Files changed https://github.com/nodejs/node/pull/8055/files
Please reload this pagehttps://github.com/nodejs/node/pull/8055
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Aug 10, 2016https://github.com/nodejs/node/pull/8055#issue-170497323
Please reload this pagehttps://github.com/nodejs/node/pull/8055
https://github.com/thefourtheye
tls: copy the Buffer object before usinghttps://github.com/nodejs/node/pull/8055/commits/2ea085595a946bc91a8eed426d25773429b623f1
2ea0855https://github.com/nodejs/node/pull/8055/commits/2ea085595a946bc91a8eed426d25773429b623f1
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Aug 10, 2016https://github.com/nodejs/node/pull/8055#event-751801772
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 10, 2016https://github.com/nodejs/node/pull/8055#issuecomment-238980570
Please reload this pagehttps://github.com/nodejs/node/pull/8055
bnoordhuishttps://github.com/bnoordhuis
Aug 10, 2016 https://github.com/nodejs/node/pull/8055#discussion-diff-74338373
View reviewed changes https://github.com/nodejs/node/pull/8055/files/2ea085595a946bc91a8eed426d25773429b623f1#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
lib/tls.jshttps://github.com/nodejs/node/pull/8055/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
bnoordhuishttps://github.com/bnoordhuis
Aug 10, 2016https://github.com/nodejs/node/pull/8055#discussion_r74338373
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8055
thefourtheyehttps://github.com/thefourtheye
Aug 11, 2016https://github.com/nodejs/node/pull/8055#discussion_r74362665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/8055
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 10, 2016https://github.com/nodejs/node/pull/8055#issuecomment-239017726
Please reload this pagehttps://github.com/nodejs/node/pull/8055
https://github.com/thefourtheye
fix review commentshttps://github.com/nodejs/node/pull/8055/commits/2ee392b0ee4e104d661924b09de48aae3c9dee04
2ee392bhttps://github.com/nodejs/node/pull/8055/commits/2ee392b0ee4e104d661924b09de48aae3c9dee04
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 11, 2016https://github.com/nodejs/node/pull/8055#issuecomment-239238413
Please reload this pagehttps://github.com/nodejs/node/pull/8055
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 11, 2016https://github.com/nodejs/node/pull/8055#issuecomment-239238558
Please reload this pagehttps://github.com/nodejs/node/pull/8055
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Aug 12, 2016https://github.com/nodejs/node/pull/8055#issuecomment-239388705
Please reload this pagehttps://github.com/nodejs/node/pull/8055
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 12, 2016https://github.com/nodejs/node/pull/8055#issuecomment-239513721
https://ci.nodejs.org/job/node-test-pull-request/3644/https://ci.nodejs.org/job/node-test-pull-request/3644/
Please reload this pagehttps://github.com/nodejs/node/pull/8055
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 18, 2016https://github.com/nodejs/node/pull/8055#issuecomment-240600662
Please reload this pagehttps://github.com/nodejs/node/pull/8055
jasnellhttps://github.com/jasnell
Aug 18, 2016 https://github.com/nodejs/node/pull/8055#ref-commit-60dcd73
https://github.com/thefourtheye
https://github.com/jasnell
tls: copy the Buffer object before usinghttps://github.com/nodejs/node/commit/60dcd7323f6a62d9539c4de70756a1081a123281
60dcd73https://github.com/nodejs/node/commit/60dcd7323f6a62d9539c4de70756a1081a123281
#8055https://github.com/nodejs/node/pull/8055
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 18, 2016https://github.com/nodejs/node/pull/8055#issuecomment-240600694
60dcd73https://github.com/nodejs/node/commit/60dcd7323f6a62d9539c4de70756a1081a123281
Please reload this pagehttps://github.com/nodejs/node/pull/8055
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 18, 2016https://github.com/nodejs/node/pull/8055#event-759326627
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
August 18, 2016 04:09https://github.com/nodejs/node/pull/8055#event-759406122
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Aug 18, 2016https://github.com/nodejs/node/pull/8055#issuecomment-240619084
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/8055
evanlucashttps://github.com/evanlucas
Aug 24, 2016 https://github.com/nodejs/node/pull/8055#ref-commit-c26b9af
https://github.com/thefourtheye
https://github.com/evanlucas
tls: copy the Buffer object before usinghttps://github.com/nodejs/node/commit/c26b9af1e277ef94b9bb33d93e1779b0a35f41e2
c26b9afhttps://github.com/nodejs/node/commit/c26b9af1e277ef94b9bb33d93e1779b0a35f41e2
#8055https://github.com/nodejs/node/pull/8055
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Aug 24, 2016 https://github.com/nodejs/node/pull/8055#ref-pullrequest-172960911
2016-08-26, Version 6.5.0 (Current) #8253 https://github.com/nodejs/node/pull/8253
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Sep 30, 2016https://github.com/nodejs/node/pull/8055#event-808866400
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Sep 30, 2016https://github.com/nodejs/node/pull/8055#issuecomment-250821200
Please reload this pagehttps://github.com/nodejs/node/pull/8055
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 10, 2016 https://github.com/nodejs/node/pull/8055#ref-pullrequest-182134708
tls: copy the Buffer object before using (backport to v4.x) #9016 https://github.com/nodejs/node/pull/9016
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Oct 10, 2016https://github.com/nodejs/node/pull/8055#event-818732521
MylesBorinshttps://github.com/MylesBorins
Oct 11, 2016 https://github.com/nodejs/node/pull/8055#ref-commit-2847490
https://github.com/thefourtheye
tls: copy the Buffer object before usinghttps://github.com/MylesBorins/node/commit/28474903e7343cab767029dc88e8c97769aaecf2
2847490https://github.com/MylesBorins/node/commit/28474903e7343cab767029dc88e8c97769aaecf2
nodejs#8055https://github.com/nodejs/node/pull/8055
rvagghttps://github.com/rvagg
Oct 18, 2016 https://github.com/nodejs/node/pull/8055#ref-commit-65b2421
https://github.com/thefourtheye
https://github.com/rvagg
tls: copy the Buffer object before usinghttps://github.com/nodejs/node/commit/65b2421988d495982fd569f55eb35b761b13c80a
65b2421https://github.com/nodejs/node/commit/65b2421988d495982fd569f55eb35b761b13c80a
#8055https://github.com/nodejs/node/pull/8055
MylesBorinshttps://github.com/MylesBorins
Oct 26, 2016 https://github.com/nodejs/node/pull/8055#ref-commit-c841b5a
https://github.com/thefourtheye
https://github.com/MylesBorins
tls: copy the Buffer object before usinghttps://github.com/nodejs/node/commit/c841b5a6b9546d24a41bd3d400c2b13c37eb0b17
c841b5ahttps://github.com/nodejs/node/commit/c841b5a6b9546d24a41bd3d400c2b13c37eb0b17
#8055https://github.com/nodejs/node/pull/8055
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 26, 2016 https://github.com/nodejs/node/pull/8055#ref-pullrequest-185475513
V4.6.2 proposal #9298 https://github.com/nodejs/node/pull/9298
MylesBorinshttps://github.com/MylesBorins
Jan 19, 2017 https://github.com/nodejs/node/pull/8055#ref-commit-15462eb
https://github.com/thefourtheye
https://github.com/MylesBorins
tls: copy the Buffer object before usinghttps://github.com/nodejs/node/commit/15462eb4d7eeec78fef817b42f8b28237f58a03e
15462ebhttps://github.com/nodejs/node/commit/15462eb4d7eeec78fef817b42f8b28237f58a03e
c26b9afhttps://github.com/nodejs/node/commit/c26b9af1e277ef94b9bb33d93e1779b0a35f41e2
#8055https://github.com/nodejs/node/pull/8055
MylesBorinshttps://github.com/MylesBorins
Jan 24, 2017 https://github.com/nodejs/node/pull/8055#ref-commit-8c7391b
https://github.com/thefourtheye
https://github.com/MylesBorins
tls: copy the Buffer object before usinghttps://github.com/nodejs/node/commit/8c7391b9ce593b7e946322ec875e5c01690b1d86
8c7391bhttps://github.com/nodejs/node/commit/8c7391b9ce593b7e946322ec875e5c01690b1d86
c26b9afhttps://github.com/nodejs/node/commit/c26b9af1e277ef94b9bb33d93e1779b0a35f41e2
#8055https://github.com/nodejs/node/pull/8055
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 24, 2017 https://github.com/nodejs/node/pull/8055#ref-pullrequest-202753055
v4.8.0 proposal #10973 https://github.com/nodejs/node/pull/10973
MylesBorinshttps://github.com/MylesBorins
Feb 1, 2017 https://github.com/nodejs/node/pull/8055#ref-commit-a67ada7
https://github.com/thefourtheye
https://github.com/MylesBorins
tls: copy the Buffer object before usinghttps://github.com/nodejs/node/commit/a67ada7d32b18029dc324e37e87065887fbd188d
a67ada7https://github.com/nodejs/node/commit/a67ada7d32b18029dc324e37e87065887fbd188d
c26b9afhttps://github.com/nodejs/node/commit/c26b9af1e277ef94b9bb33d93e1779b0a35f41e2
#8055https://github.com/nodejs/node/pull/8055
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
May 27, 2022 https://github.com/nodejs/node/pull/8055#ref-pullrequest-1249279941
tls: fix convertALPNProtocols accepting ArrayBufferViews #43211 https://github.com/nodejs/node/pull/43211
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8055
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/8055
https://github.com/thefourtheye
https://github.com/jasnell
https://github.com/bnoordhuis
https://github.com/fhinkel
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.