| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f53877c9-b6c3-8df4-fdff-38d08f12e909 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB80:21AC08:191605:22F2B9:696A6CD5 |
| html-safe-nonce | 273d2a81358cef76625773ba401f04c11839a6eea16d7c58c9c854e9e5ede1eb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjgwOjIxQUMwODoxOTE2MDU6MjJGMkI5OjY5NkE2Q0Q1IiwidmlzaXRvcl9pZCI6IjgyNDUwNTAzNjA1NzcyODk0MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2c5ac2bc082081b03c10b56bac753f2da509f382ec92ca23c240f236824ba982 |
| hovercard-subject-tag | pull_request:80498988 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/8019/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1491fdf95db51162efed3580794344873b57c94b5790ac0112514c489371952e/nodejs/node/pull/8019 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1491fdf95db51162efed3580794344873b57c94b5790ac0112514c489371952e/nodejs/node/pull/8019 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines
Affected core subsystem(s)
This change on... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | eugeneo |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/8019#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8019 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8019 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/8019 |
| Reload | https://github.com/nodejs/node/pull/8019 |
| Reload | https://github.com/nodejs/node/pull/8019 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/8019#issue-comment-box |
| eugeneo | https://github.com/eugeneo |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
inspector: Fix failing test
| https://github.com/nodejs/node/pull/8019#top |
| eugeneo | https://github.com/eugeneo |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
7
| https://github.com/nodejs/node/pull/8019 |
|
Commits
1
| https://github.com/nodejs/node/pull/8019/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/8019/checks |
|
Files changed
| https://github.com/nodejs/node/pull/8019/files |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/eugeneo |
| eugeneo | https://github.com/eugeneo |
| Aug 8, 2016 | https://github.com/nodejs/node/pull/8019#issue-169992672 |
| @ofrobots | https://github.com/ofrobots |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Aug 8, 2016 | https://github.com/nodejs/node/pull/8019#event-748811458 |
| addaleax | https://github.com/addaleax |
|
Aug 8, 2016
| https://github.com/nodejs/node/pull/8019#discussion-diff-73929106 |
| View reviewed changes
| https://github.com/nodejs/node/pull/8019/files#diff-d0e04008ea5835c3266e08e258725c1055d093b45afdae7fbaea6d80375da6b9 |
| test/cctest/test_inspector_socket.cc | https://github.com/nodejs/node/pull/8019/files#diff-d0e04008ea5835c3266e08e258725c1055d093b45afdae7fbaea6d80375da6b9 |
| addaleax | https://github.com/addaleax |
| Aug 8, 2016 | https://github.com/nodejs/node/pull/8019#discussion_r73929106 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
| eugeneo | https://github.com/eugeneo |
| Aug 8, 2016 | https://github.com/nodejs/node/pull/8019#discussion_r73929710 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
inspector
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector |
| Aug 8, 2016 | https://github.com/nodejs/node/pull/8019#event-748818108 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Aug 8, 2016 | https://github.com/nodejs/node/pull/8019#issuecomment-238410493 |
| https://ci.nodejs.org/job/node-test-pull-request/3582/ | https://ci.nodejs.org/job/node-test-pull-request/3582/ |
| #8006 | https://github.com/nodejs/node/issues/8006 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
| https://github.com/eugeneo |
| eugeneo | https://github.com/eugeneo |
| Aug 9, 2016 | https://github.com/nodejs/node/pull/8019#issuecomment-238420813 |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Aug 9, 2016 | https://github.com/nodejs/node/pull/8019#issuecomment-238515319 |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
| test: Fix failing inspector cctest | https://github.com/nodejs/node/pull/8019/commits/4488a4f0d30e880342b1bc0b21991d30eab464bb |
| 4488a4f | https://github.com/nodejs/node/pull/8019/commits/4488a4f0d30e880342b1bc0b21991d30eab464bb |
| #8006 | https://github.com/nodejs/node/issues/8006 |
| https://github.com/eugeneo |
| eugeneo | https://github.com/eugeneo |
| Aug 9, 2016 | https://github.com/nodejs/node/pull/8019#issuecomment-238599910 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
| ofrobots | https://github.com/ofrobots |
|
Aug 10, 2016
| https://github.com/nodejs/node/pull/8019#ref-commit-49e473a |
|
| https://github.com/ofrobots |
| test: fix failing inspector cctest | https://github.com/nodejs/node/commit/49e473a45fb3e13fdd4588c6241b71bbac4fe5ab |
| 49e473a | https://github.com/nodejs/node/commit/49e473a45fb3e13fdd4588c6241b71bbac4fe5ab |
| #8006 | https://github.com/nodejs/node/issues/8006 |
| #8019 | https://github.com/nodejs/node/pull/8019 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Aug 10, 2016 | https://github.com/nodejs/node/pull/8019#issuecomment-238733388 |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Aug 10, 2016 | https://github.com/nodejs/node/pull/8019#event-750654079 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 10, 2016
| https://github.com/nodejs/node/pull/8019#ref-issue-170001504 |
|
v6.4.0 Release Proposal
#8020
| https://github.com/nodejs/node/issues/8020 |
| cjihrig | https://github.com/cjihrig |
|
Aug 10, 2016
| https://github.com/nodejs/node/pull/8019#ref-commit-554b0f9 |
|
| https://github.com/cjihrig |
| test: fix failing inspector cctest | https://github.com/nodejs/node/commit/554b0f9d910dcc105f274c04a73383e8976e0279 |
| 554b0f9 | https://github.com/nodejs/node/commit/554b0f9d910dcc105f274c04a73383e8976e0279 |
| #8006 | https://github.com/nodejs/node/issues/8006 |
| #8019 | https://github.com/nodejs/node/pull/8019 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 11, 2016
| https://github.com/nodejs/node/pull/8019#ref-pullrequest-170733186 |
|
v6.4.0 Proposal
#8070
| https://github.com/nodejs/node/pull/8070 |
| https://github.com/eugeneo |
| eugeneo | https://github.com/eugeneo |
| August 16, 2016 00:04 | https://github.com/nodejs/node/pull/8019#event-756372358 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Sep 9, 2016 | https://github.com/nodejs/node/pull/8019#event-783439485 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F8019 |
|
inspector
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/8019 |
|
| https://github.com/eugeneo |
|
| https://github.com/ofrobots |
|
| https://github.com/bnoordhuis |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |